16061 2007-11-20 00:03:05 -0800 no-svg build broken after r27278 2007-11-20 06:52:59 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED http://trac.webkit.org/projects/webkit/changeset/27278 P2 Normal --- 1 ddkilzer ddkilzer sam timothy oldest_to_newest 61758 0 ddkilzer 2007-11-20 00:03:05 -0800 I broke the no-svg build after r27278 because neither DOMHTMLEmbedElementPrivate.h nor DOMHTMLObjectElementPrivate.h are created when SVG is disabled. I'm not sure how to best fix this. At first glance, either both header files always need to be generated (even with empty categories), or else Xcode needs to conditionalize them. (Or I just need to remove them from Xcode.) Note that they also need to be conditionalized in WebKit/MigrateHeaders.make. It's sad that this wasn't noticed (probably because the no-svg buildbot is always red--Bug 12402 was filed to address that). 61759 1 17412 ddkilzer 2007-11-20 00:18:30 -0800 Created attachment 17412 Patch v1 Possible solution (always generate these two files so that they exist on the no-svg build). 61783 2 17412 eric 2007-11-20 05:44:23 -0800 Comment on attachment 17412 Patch v1 I think this hack is fine if you add a comment explaining what you're doing in CodeGeneratorObjC.pm. 61787 3 ddkilzer 2007-11-20 06:50:49 -0800 (In reply to comment #2) > (From update of attachment 17412 [edit]) > I think this hack is fine if you add a comment explaining what you're doing in > CodeGeneratorObjC.pm. Thanks, Eric! I changed the code to be the comment. Committed r27923 http://trac.webkit.org/projects/webkit/changeset/27923 61789 4 ddkilzer 2007-11-20 06:52:59 -0800 And fixed a typo: Committed r27924 17412 2007-11-20 00:18:30 -0800 2007-11-20 05:44:23 -0800 Patch v1 bug-16061-v1.diff text/plain 1305 ddkilzer ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODU5M2EwYi4uMTliM2UxYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwNy0xMS0yMCAgRGF2aWQgRC4gS2ls emVyICA8ZGRraWx6ZXJAd2Via2l0Lm9yZz4KKworICAgICAgICBuby1zdmcgYnVpbGQgYnJva2Vu IGFmdGVyIHIyNzI3OAorICAgICAgICA8aHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTYwNjE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JPYmpDLnBtOiBBbHdheXMgZ2Vu ZXJhdGUgRE9NSFRNTEVtYmVkRWxlbWVudFByaXZhdGUuaAorICAgICAgICBhbmQgRE9NSFRNTE9i amVjdEVsZW1lbnRQcml2YXRlLmggZm9yIG5vLXN2ZyBidWlsZC4KKwogMjAwNy0xMS0xOCAgQWxl eGV5IFByb3NrdXJ5YWtvdiAgPGFwQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg TWFjaWVqLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0 b3JPYmpDLnBtIGIvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JPYmpDLnBt CmluZGV4IDJiOTExM2QuLmJlZDgzZDYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy9Db2RlR2VuZXJhdG9yT2JqQy5wbQorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMv Q29kZUdlbmVyYXRvck9iakMucG0KQEAgLTg4Nyw3ICs4ODcsOCBAQCBzdWIgR2VuZXJhdGVIZWFk ZXIKICAgICAgICAgcHVzaChAaGVhZGVyQ29udGVudCwgIlxAZW5kXG4iKTsKICAgICB9CiAKLSAg ICBpZiAoQHByaXZhdGVIZWFkZXJBdHRyaWJ1dGVzID4gMCBvciBAcHJpdmF0ZUhlYWRlckZ1bmN0 aW9ucyA+IDApIHsKKyAgICBpZiAoQHByaXZhdGVIZWFkZXJBdHRyaWJ1dGVzID4gMCBvciBAcHJp dmF0ZUhlYWRlckZ1bmN0aW9ucyA+IDAKKyAgICAgICAgICAgIG9yICRjbGFzc05hbWUgZXEgIkRP TUhUTUxFbWJlZEVsZW1lbnQiIG9yICRjbGFzc05hbWUgZXEgIkRPTUhUTUxPYmplY3RFbGVtZW50 IikgewogICAgICAgICAjIC0gUHJpdmF0ZSBjYXRlZ29yeSBAaW50ZXJmYWNlCiAgICAgICAgIEBw cml2YXRlSGVhZGVyQ29udGVudEhlYWRlciA9IHNwbGl0KCJcciIsICRoZWFkZXJMaWNlbmNlVGVt cGxhdGUpOwogICAgICAgICBwdXNoKEBoZWFkZXJDb250ZW50SGVhZGVyLCAiXG4iKTsK