160604 2016-08-05 11:54:36 -0700 REGRESSION (r201245): switching between Computed and Visual Styles panels causes internal error 2016-08-07 12:42:28 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1218000 0 mattbaker 2016-08-05 11:54:36 -0700 Summary: Switching between Computed and Visual Styles panels causes internal error. Steps to Reproduce: 1. Open Inspector > Elements 2. Show Styles sidebar if necessary 3. Switch from Computed panel to Visual panel => [Error] TypeError: undefined is not an object (evaluating 'this._selectorSection.update') refresh — VisualStyleDetailsPanel.js:64 _refreshPreservingScrollPosition — StyleDetailsPanel.js:143 nodeStylesRefreshed — StyleDetailsPanel.js:114 dispatch — Object.js:162 dispatchEventToListeners — Object.js:169 fetchedComputedStyle — DOMNodeStyles.js:228 ... 4. When switching from Visual to Computed => [Error] TypeError: undefined is not an object (evaluating 'this._propertiesTextEditor.style = this.nodeStyles.computedStyle') refresh — ComputedStyleDetailsPanel.js:130 _refreshPreservingScrollPosition — StyleDetailsPanel.js:143 nodeStylesRefreshed — StyleDetailsPanel.js:114 dispatch — Object.js:162 dispatchEventToListeners — Object.js:169 fetchedComputedStyle — DOMNodeStyles.js:228 ... Note: I expected this to be a regression caused by https://trac.webkit.org/changeset/203253, but it looks like it was broken earlier. 1218001 1 webkit-bug-importer 2016-08-05 11:54:57 -0700 <rdar://problem/27723416> 1218010 2 mattbaker 2016-08-05 12:46:26 -0700 Regressed in https://trac.webkit.org/changeset/201245. 1218011 3 webkit-bug-importer 2016-08-05 12:46:53 -0700 <rdar://problem/27724305> 1218383 4 285530 mattbaker 2016-08-07 12:11:20 -0700 Created attachment 285530 [Patch] Proposed Fix 1218384 5 285530 commit-queue 2016-08-07 12:42:24 -0700 Comment on attachment 285530 [Patch] Proposed Fix Clearing flags on attachment: 285530 Committed r204244: <http://trac.webkit.org/changeset/204244> 1218385 6 commit-queue 2016-08-07 12:42:28 -0700 All reviewed patches have been landed. Closing bug. 285530 2016-08-07 12:11:20 -0700 2016-08-07 12:42:24 -0700 [Patch] Proposed Fix bug-160604-20160807120951.patch text/plain 1619 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0MjQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA2 ZDUwNmZiMjlhYThiMTVhNGQxNDkyMjFlODkzZGJkNGQzZWVlMzliLi5lNzMzNDhjNjE3MTEyYWEw Y2I2YTc1OGJmZDQ0ODY0OThkZmM0YjY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNi0wOC0wNyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjIwMTI0NSk6IHN3aXRjaGluZyBiZXR3ZWVuIENvbXB1 dGVkIGFuZCBWaXN1YWwgU3R5bGVzIHBhbmVscyBjYXVzZXMgaW50ZXJuYWwgZXJyb3IKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDYwNAorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMjc3MjM0MTY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1N0eWxlRGV0YWlsc1Bh bmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlN0eWxlRGV0YWlsc1BhbmVsLnByb3RvdHlw ZS5zaG93bik6CisgICAgICAgIE9ubHkgcGVyZm9ybSBhIGxheW91dCBpZiBuZWVkZWQuIFN1YmNs YXNzZXMgYWNjZXNzIG5vZGUgc3R5bGUKKyAgICAgICAgZGF0YSBkdXJpbmcgbGF5b3V0LCB3aGlj aCBtYXkgbm90IGV4aXN0IHlldC4KKwogMjAxNi0wOC0wNiAgTWF0dCBCYWtlciAgPG1hdHRiYWtl ckBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjIwMzI1Myk6IE5vZGUgZGV0YWls cyBzaWRlYmFyIGZsaWNrZXJzIHdoaWxlIHJlc2l6aW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TdHlsZURldGFpbHNQYW5lbC5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1N0eWxlRGV0YWlsc1BhbmVs LmpzCmluZGV4IDQ0ZDg3YWU0NTQwMDExZWZlYWY2NzExNTY3ZjkyYTlmYWE0NWZiMGQuLjA3MTUz MzM5NTc2YzY4MWRhNmRmNDU5ZTIzZjY4MTE0YmE2N2M3OWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1N0eWxlRGV0YWlsc1BhbmVsLmpzCisr KyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1N0eWxlRGV0YWls c1BhbmVsLmpzCkBAIC02Miw3ICs2Miw3IEBAIFdlYkluc3BlY3Rvci5TdHlsZURldGFpbHNQYW5l bCA9IGNsYXNzIFN0eWxlRGV0YWlsc1BhbmVsIGV4dGVuZHMgV2ViSW5zcGVjdG9yLlZpCiAgICAg ICAgIHRoaXMuX3JlZnJlc2hOb2RlU3R5bGVzKCk7CiAKICAgICAgICAgLy8gRklYTUU6IHJlbW92 ZSBvbmNlIDxodHRwczovL3dlYmtpdC5vcmcvYi8xNTA3NDE+IGlzIGZpeGVkLgotICAgICAgICB0 aGlzLm5lZWRzTGF5b3V0KCk7CisgICAgICAgIHRoaXMudXBkYXRlTGF5b3V0SWZOZWVkZWQoKTsK ICAgICB9CiAKICAgICBoaWRkZW4oKQo=