160601 2016-08-05 10:15:49 -0700 Disk cache tests produce many undefined value warnings 2016-08-05 16:59:21 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap cdumez commit-queue koivisto lforschler ryanhaddad oldest_to_newest 1217949 0 ap 2016-08-05 10:15:49 -0700 There are dozens of warnings of this kind, making it hard to spot relevant logs: [Fri Aug 05 05:47:00.914705 2016] [cgi:error] [pid 97021] [client 127.0.0.1:62254] AH01215: Use of uninitialized value in string eq at LayoutTests/http/tests/cache/disk-cache/resources/generate-response.cgi line 30.: /LayoutTests/http/tests/cache/disk-cache/resources/generate-response.cgi, referer: http://127.0.0.1:8000/cache/disk-cache/disk-cache-vary.html 1217958 1 285430 ap 2016-08-05 10:25:20 -0700 Created attachment 285430 proposed fix 1218116 2 285430 commit-queue 2016-08-05 16:59:15 -0700 Comment on attachment 285430 proposed fix Clearing flags on attachment: 285430 Committed r204202: <http://trac.webkit.org/changeset/204202> 1218117 3 commit-queue 2016-08-05 16:59:21 -0700 All reviewed patches have been landed. Closing bug. 285430 2016-08-05 10:25:20 -0700 2016-08-05 16:59:15 -0700 proposed fix UndefinedValueWarnings.txt text/plain 2728 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIwNDE3NikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE2LTA4LTA1ICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIERpc2sgY2FjaGUgdGVzdHMgcHJvZHVjZSBt YW55IHVuZGVmaW5lZCB2YWx1ZSB3YXJuaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwNjAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL2NhY2hlL2Rpc2stY2FjaGUvcmVzb3Vy Y2VzL2dlbmVyYXRlLXJlc3BvbnNlLmNnaTogQ2xlYW5lZCB1cCBoZWFkZXIKKyAgICAgICAgYW5k IHBhcmFtZXRlciBoYW5kbGluZy4gUmVtb3ZlZCBhIGNvdXBsZSB1bm5lY2Vzc2FyeSBjaGVja3Mg Zm9yICRjZ2ktPmh0dHAuCisKIDIwMTYtMDgtMDUgIEpvaG4gV2lsYW5kZXIgIDx3aWxhbmRlckBh cHBsZS5jb20+CiAKICAgICAgICAgUG9wdXBzIG9wZW5lZCBmcm9tIGEgc2FuZGJveGVkIGlmcmFt ZSBzaG91bGQgdGhlbXNlbHZlcyBiZSBzYW5kYm94ZWQKSW5kZXg6IExheW91dFRlc3RzL2h0dHAv dGVzdHMvY2FjaGUvZGlzay1jYWNoZS9yZXNvdXJjZXMvZ2VuZXJhdGUtcmVzcG9uc2UuY2dpCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvY2FjaGUvZGlzay1jYWNoZS9yZXNv dXJjZXMvZ2VuZXJhdGUtcmVzcG9uc2UuY2dpCShyZXZpc2lvbiAyMDQxNjgpCisrKyBMYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL2NhY2hlL2Rpc2stY2FjaGUvcmVzb3VyY2VzL2dlbmVyYXRlLXJlc3Bv bnNlLmNnaQkod29ya2luZyBjb3B5KQpAQCAtOSw2ICs5LDggQEAgbXkgJGV4cGlyZXNJbkZ1dHVy ZUluMzA0ID0gJHF1ZXJ5LT5wYXJhbQogbXkgJGRlbGF5ID0gJHF1ZXJ5LT5wYXJhbSgnZGVsYXkn KSB8fCAwOwogbXkgJGJvZHkgPSAkcXVlcnktPnBhcmFtKCdib2R5JykgfHwgMDsKIG15ICRzdGF0 dXMgPSAkcXVlcnktPnBhcmFtKCdTdGF0dXMnKSB8fCAwOworbXkgJHJhbmdlID0gJHF1ZXJ5LT5w YXJhbSgnUmFuZ2UnKSB8fCAnJzsKK215ICRsb2NhdGlvbiA9ICRxdWVyeS0+cGFyYW0oJ0xvY2F0 aW9uJykgfHwgJyc7CiAKIGlmICgkYm9keSBlcSAidW5pcXVlIikgewogICAgICRib2R5ID0gc3By aW50ZiAiJTA4WFxuIiwgcmFuZCgweGZmZmZmZmZmKQpAQCAtMTcsMTcgKzE5LDE5IEBAIGlmICgk Ym9keSBlcSAidW5pcXVlIikgewogbXkgJGhhc1N0YXR1c0NvZGUgPSAwOwogbXkgJGhhc0xvY2F0 aW9uID0gMDsKIGlmICgkc3RhdHVzID09IDMwMSB8fCAkc3RhdHVzID09IDMwMiB8fCAkc3RhdHVz ID09IDMwMyB8fCAkc3RhdHVzID09IDMwNykgewotICAgIGlmICgkcXVlcnktPnBhcmFtKCdMb2Nh dGlvbicpIGVxICJ1bmlxdWUtY2FjaGVhYmxlIikgeworICAgIGlmICgkbG9jYXRpb24gZXEgInVu aXF1ZS1jYWNoZWFibGUiKSB7CiAgICAgICAgIG15ICRyZWRpcmVjdEJvZHkgPSBzcHJpbnRmICIl MDhYIiwgcmFuZCgweGZmZmZmZmZmKTsKICAgICAgICAgcHJpbnQgIlN0YXR1czogIi4gJHN0YXR1 cyAuICJcbiI7Ci0gICAgICAgIHByaW50ICJMb2NhdGlvbjogZ2VuZXJhdGUtcmVzcG9uc2UuY2dp P2JvZHk9IiAuICRyZWRpcmVjdEJvZHkgLiAiJkNhY2hlLWNvbnRyb2w9bWF4LWFnZSUzRDEwMDAm dW5pcXVlSWQ9IiAuICRxdWVyeS0+cGFyYW0oJ3VuaXF1ZUlkJykgLiAiXG4iOworICAgICAgICBt eSAkdW5pcXVlSWQgPSAkcXVlcnktPnBhcmFtKCd1bmlxdWVJZCcpOworICAgICAgICBwcmludCAi TG9jYXRpb246IGdlbmVyYXRlLXJlc3BvbnNlLmNnaT9ib2R5PSIgLiAkcmVkaXJlY3RCb2R5IC4g IiZDYWNoZS1jb250cm9sPW1heC1hZ2UlM0QxMDAwJnVuaXF1ZUlkPSIgLiAkdW5pcXVlSWQgLiAi XG4iOwogICAgICAgICAkaGFzTG9jYXRpb24gPSAxOwogICAgICAgICAkaGFzU3RhdHVzQ29kZSA9 IDE7CiAgICAgfQogfQogCiBteSAkaGFzRXhwaXJlc0hlYWRlciA9IDA7Ci1pZiAoJHF1ZXJ5LT5o dHRwICYmICRxdWVyeS0+aHR0cCgiSWYtTm9uZS1NYXRjaCIpIGVxICJtYXRjaCIpIHsKK215ICRp Zk5vbmVNYXRjaEhlYWRlciA9ICRxdWVyeS0+aHR0cCgiSWYtTm9uZS1NYXRjaCIpOworaWYgKGRl ZmluZWQgJGlmTm9uZU1hdGNoSGVhZGVyIGFuZCAkaWZOb25lTWF0Y2hIZWFkZXIgZXEgIm1hdGNo IikgewogICAgIHByaW50ICJTdGF0dXM6IDMwNFxuIjsKICAgICAkaGFzU3RhdHVzQ29kZSA9IDE7 CiAgICAgaWYgKCRleHBpcmVzSW5GdXR1cmVJbjMwNCkgewpAQCAtMzYsNyArNDAsNyBAQCBpZiAo JHF1ZXJ5LT5odHRwICYmICRxdWVyeS0+aHR0cCgiSWYtTm9uCiAgICAgfQogfQogCi1pZiAoJHF1 ZXJ5LT5odHRwICYmICRxdWVyeS0+cGFyYW0oIlJhbmdlIikgPX4gL2J5dGVzPShcZCspLShcZCsp LykgeworaWYgKCRyYW5nZSA9fiAvYnl0ZXM9KFxkKyktKFxkKykvKSB7CiAKICAgICBpZiAoJDEg PCA2ICYmICQyIDwgNikgewogICAgICAgICBwcmludCAiU3RhdHVzOiAyMDZcbiI7Cg==