160530 2016-08-03 15:52:27 -0700 Drop DocumentType.internalSubset attribute 2016-08-04 09:03:12 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://dom.spec.whatwg.org/#documenttype WebExposed P2 Normal --- 1 cdumez cdumez cdumez commit-queue darin dbates rniwa sam oldest_to_newest 1217246 0 cdumez 2016-08-03 15:52:27 -0700 Drop DocumentType.internalSubset attribute. It is no longer in the DOM specification, and other browsers have already dropped it. In WebKit, it is always null anyway. 1217256 1 285288 cdumez 2016-08-03 16:11:35 -0700 Created attachment 285288 Patch 1217313 2 285288 achristensen 2016-08-03 21:51:49 -0700 Comment on attachment 285288 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285288&action=review > Source/WebCore/bindings/objc/DOMDocumentType.mm:77 > - return IMPL->internalSubset(); > + return IMPL->internalSubsetForBindings(); What are the implications of keeping the objc bindings when the javascript bindings are gone? Before we started freezing the objc bindings, wouldn't we have removed the whole method? 1217321 3 285288 commit-queue 2016-08-03 22:12:46 -0700 Comment on attachment 285288 Patch Clearing flags on attachment: 285288 Committed r204114: <http://trac.webkit.org/changeset/204114> 1217322 4 commit-queue 2016-08-03 22:12:51 -0700 All reviewed patches have been landed. Closing bug. 1217418 5 cdumez 2016-08-04 09:03:12 -0700 (In reply to comment #2) > Comment on attachment 285288 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=285288&action=review > > > Source/WebCore/bindings/objc/DOMDocumentType.mm:77 > > - return IMPL->internalSubset(); > > + return IMPL->internalSubsetForBindings(); > > What are the implications of keeping the objc bindings when the javascript > bindings are gone? Before we started freezing the objc bindings, wouldn't > we have removed the whole method? No, before the freeze, we wouldn't have been able to remove the whole method. After the freeze though we would in theory be able to remove the internalSubsetForBindings() method and hack the ObjC bindings to stop calling it. However, this is usually not possible because of GObject bindings. 285288 2016-08-03 16:11:35 -0700 2016-08-03 22:12:46 -0700 Patch bug-160530-20160803161011.patch text/plain 13079 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0MTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 ODg2YmVhMGRiZjA4YTk1OTk2NWMxZTYzNDRlNmRlYjYyNmU0NTJkLi4wNzBiYWFhZjljZDUwMzUy ZGNiZjU0OGM0NGZkNDgxYjUwYzFkZDc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNi0wOC0wMyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgor CisgICAgICAgIERyb3AgRG9jdW1lbnRUeXBlLmludGVybmFsU3Vic2V0IGF0dHJpYnV0ZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwNTMwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRHJvcCBEb2N1bWVu dFR5cGUuaW50ZXJuYWxTdWJzZXQgYXR0cmlidXRlLgorCisgICAgICAgICogaW5zcGVjdG9yL3By b3RvY29sL0RPTS5qc29uOgorCiAyMDE2LTA4LTAzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBs ZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMjAzMzY4KTogYnJva2Ugc29tZSB0ZXN0MjYy IHRlc3RzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKaW5kZXggOTUxYjc4NjFhZGEzYmFkZjgxNjU4MDgyNzM1MjY5OWEwYjM4 MTg5My4uYjA1MjY2ZjAzYzZhY2RjYjUwMjY4MDA1N2I1MDA4YjkyMTVhYjhlZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDMyIEBACisyMDE2LTA4LTAzICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBs ZS5jb20+CisKKyAgICAgICAgRHJvcCBEb2N1bWVudFR5cGUuaW50ZXJuYWxTdWJzZXQgYXR0cmli dXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjA1 MzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEcm9w IERvY3VtZW50VHlwZS5pbnRlcm5hbFN1YnNldCBhdHRyaWJ1dGUuCisKKyAgICAgICAgSXQgaXMg bm8gbG9uZ2VyIGluIHRoZSBET00gc3BlY2lmaWNhdGlvbjoKKyAgICAgICAgLSBodHRwczovL2Rv bS5zcGVjLndoYXR3Zy5vcmcvI2RvY3VtZW50dHlwZQorICAgICAgICAtIGh0dHBzOi8vdzNjLmdp dGh1Yi5pby9ET00tUGFyc2luZy8jeG1sLXNlcmlhbGl6aW5nLWEtZG9jdW1lbnR0eXBlLW5vZGUK KworICAgICAgICBPdGhlciBicm93c2VycyBoYXZlIGFscmVhZHkgZHJvcHBlZCBpdC4gSW4gV2Vi S2l0LCBpdCB3YXMgYWx3YXlzIG51bGwKKyAgICAgICAgYW55d2F5LgorCisgICAgICAgIE5vIG5l dyB0ZXN0cywgcmViYXNlbGluZWQgZXhpc3RpbmcgdGVzdC4KKworICAgICAgICAqIGJpbmRpbmdz L29iamMvRE9NRG9jdW1lbnRUeXBlLm1tOgorICAgICAgICAoLVtET01Eb2N1bWVudFR5cGUgaW50 ZXJuYWxTdWJzZXRdKToKKyAgICAgICAgKiBkb20vRG9jdW1lbnRUeXBlLmg6CisgICAgICAgICog ZG9tL0RvY3VtZW50VHlwZS5pZGw6CisgICAgICAgICogZG9tL05vZGUuY3BwOgorICAgICAgICAo V2ViQ29yZTo6Tm9kZTo6aXNFcXVhbE5vZGUpOiBEZWxldGVkLgorICAgICAgICAqIGVkaXRpbmcv TWFya3VwQWNjdW11bGF0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWFya3VwQWNjdW11bGF0 b3I6OmFwcGVuZERvY3VtZW50VHlwZSk6IERlbGV0ZWQuCisgICAgICAgICogaW5zcGVjdG9yL0lu c3BlY3RvckRPTUFnZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckRPTUFnZW50 OjpidWlsZE9iamVjdEZvck5vZGUpOiBEZWxldGVkLgorCiAyMDE2LTA4LTAzICBBbmRlcnMgQ2Fy bHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGRlYWQgYmluZGlu Z3MgY29kZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKaW5kZXggNmY0ZWYyOTliMTkxZGQyNmE0MjI5 NGY4ZDkzYmU3NmVkZGU1Zjk0NC4uYmI2MjMzYTkxYzBmNzMwYTk4ZGZjYjg3ZGI1MzQ2MWE1Zjcw M2I4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTYtMDgt MDMgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBEcm9wIERvY3Vt ZW50VHlwZS5pbnRlcm5hbFN1YnNldCBhdHRyaWJ1dGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDUzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIERyb3AgRG9jdW1lbnRUeXBlLmludGVybmFsU3Vic2V0 IGF0dHJpYnV0ZS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL0RPTU5vZGUuanM6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NTm9kZSk6IERlbGV0ZWQuCisgICAgICAgICogVXNl ckludGVyZmFjZS9Nb2RlbHMvRE9NU2VhcmNoTWF0Y2hPYmplY3QuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuRE9NU2VhcmNoTWF0Y2hPYmplY3QudGl0bGVGb3JET01Ob2RlKTogRGVsZXRlZC4K KyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVFbGVtZW50LmpzOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLkRPTVRyZWVFbGVtZW50LnByb3RvdHlwZS5fbm9kZVRpdGxlSW5mbyk6 IERlbGV0ZWQuCisKIDIwMTYtMDgtMDMgIE1hdHQgQmFrZXIgIDxtYXR0YmFrZXJAYXBwbGUuY29t PgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENtZC1MIHNob3J0Y3V0IGZvciBKdW1wIHRvIExp bmUgY29uZmxpY3RzIHdpdGggc2VsZWN0aW5nIFVSTCBvZiBpbnNwZWN0ZWQgcGFnZQpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9wcm90b2NvbC9ET00uanNvbiBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcHJvdG9jb2wvRE9NLmpzb24KaW5kZXgg MGRkOGUxNTA3ODZhNTI5NTcyYjVmYTk3ZTYxYzRhNjZiNjgxYzQyMy4uYjAwMTM5Mzg4MzE2ODJj YzkyOWU1N2IxZjlhN2E0ZmNkY2YzNjA1MCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2luc3BlY3Rvci9wcm90b2NvbC9ET00uanNvbgorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvaW5zcGVjdG9yL3Byb3RvY29sL0RPTS5qc29uCkBAIC00Nyw3ICs0Nyw2IEBACiAgICAgICAg ICAgICAgICAgeyAibmFtZSI6ICJiYXNlVVJMIiwgInR5cGUiOiAic3RyaW5nIiwgIm9wdGlvbmFs IjogdHJ1ZSwgImRlc2NyaXB0aW9uIjogIkJhc2UgVVJMIHRoYXQgPGNvZGU+RG9jdW1lbnQ8L2Nv ZGU+IG9yIDxjb2RlPkZyYW1lT3duZXI8L2NvZGU+IG5vZGUgdXNlcyBmb3IgVVJMIGNvbXBsZXRp b24uIiB9LAogICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAicHVibGljSWQiLCAidHlwZSI6ICJz dHJpbmciLCAib3B0aW9uYWwiOiB0cnVlLCAiZGVzY3JpcHRpb24iOiAiPGNvZGU+RG9jdW1lbnRU eXBlPC9jb2RlPidzIHB1YmxpY0lkLiIgfSwKICAgICAgICAgICAgICAgICB7ICJuYW1lIjogInN5 c3RlbUlkIiwgInR5cGUiOiAic3RyaW5nIiwgIm9wdGlvbmFsIjogdHJ1ZSwgImRlc2NyaXB0aW9u IjogIjxjb2RlPkRvY3VtZW50VHlwZTwvY29kZT4ncyBzeXN0ZW1JZC4iIH0sCi0gICAgICAgICAg ICAgICAgeyAibmFtZSI6ICJpbnRlcm5hbFN1YnNldCIsICJ0eXBlIjogInN0cmluZyIsICJvcHRp b25hbCI6IHRydWUsICJkZXNjcmlwdGlvbiI6ICI8Y29kZT5Eb2N1bWVudFR5cGU8L2NvZGU+J3Mg aW50ZXJuYWxTdWJzZXQuIiB9LAogICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAieG1sVmVyc2lv biIsICJ0eXBlIjogInN0cmluZyIsICJvcHRpb25hbCI6IHRydWUsICJkZXNjcmlwdGlvbiI6ICI8 Y29kZT5Eb2N1bWVudDwvY29kZT4ncyBYTUwgdmVyc2lvbiBpbiBjYXNlIG9mIFhNTCBkb2N1bWVu dHMuIiB9LAogICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAibmFtZSIsICJ0eXBlIjogInN0cmlu ZyIsICJvcHRpb25hbCI6IHRydWUsICJkZXNjcmlwdGlvbiI6ICI8Y29kZT5BdHRyPC9jb2RlPidz IG5hbWUuIiB9LAogICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAidmFsdWUiLCAidHlwZSI6ICJz dHJpbmciLCAib3B0aW9uYWwiOiB0cnVlLCAiZGVzY3JpcHRpb24iOiAiPGNvZGU+QXR0cjwvY29k ZT4ncyB2YWx1ZS4iIH0sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9vYmpj L0RPTURvY3VtZW50VHlwZS5tbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL29iamMvRE9NRG9j dW1lbnRUeXBlLm1tCmluZGV4IGNkMmJmM2ZkMTFjNTI0ZWU2OGE4NmIwMWY5N2FkZjBmYjE5ZDQy ZjEuLjE0M2MwNTY2OWIwYTE3OGUwODcxOTk3MGI3YjNkY2YxNWE5ODNmZWEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL29iamMvRE9NRG9jdW1lbnRUeXBlLm1tCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL29iamMvRE9NRG9jdW1lbnRUeXBlLm1tCkBAIC03NCw3ICs3 NCw3IEBAIC0gKE5TU3RyaW5nICopc3lzdGVtSWQKIC0gKE5TU3RyaW5nICopaW50ZXJuYWxTdWJz ZXQKIHsKICAgICBXZWJDb3JlOjpKU01haW5UaHJlYWROdWxsU3RhdGUgc3RhdGU7Ci0gICAgcmV0 dXJuIElNUEwtPmludGVybmFsU3Vic2V0KCk7CisgICAgcmV0dXJuIElNUEwtPmludGVybmFsU3Vi c2V0Rm9yQmluZGluZ3MoKTsKIH0KIAogLSAodm9pZClyZW1vdmUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2RvbS9Eb2N1bWVudFR5cGUuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVu dFR5cGUuaAppbmRleCA1MzUyZjRiYTM1ZTYyN2M1MWU3Mzk0N2U2Y2U3MWIyMzBlOGQ3ZDkzLi4x MTFhYzk0MWIwNDI0ZTU2NjZjNzdmMGI1MjFjOWI3NzY3ZjczNjkxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9kb20vRG9jdW1lbnRUeXBlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0Rv Y3VtZW50VHlwZS5oCkBAIC00MCwxMSArNDAsMTEgQEAgcHVibGljOgogICAgIC8vIFRoZXNlIGFy ZSBuZWVkZWQgYnkgT2JqQyAvIEdPYmplY3QgYmluZGluZ3MgZm9yIGJhY2t3YXJkIGNvbXBhdGli aWxpdHkuCiAgICAgTmFtZWROb2RlTWFwKiBlbnRpdGllc0ZvckJpbmRpbmdzKCkgY29uc3QgeyBy ZXR1cm4gbnVsbHB0cjsgfQogICAgIE5hbWVkTm9kZU1hcCogbm90YXRpb25zRm9yQmluZGluZ3Mo KSBjb25zdCB7IHJldHVybiBudWxscHRyOyB9CisgICAgU3RyaW5nIGludGVybmFsU3Vic2V0Rm9y QmluZGluZ3MoKSBjb25zdCB7IHJldHVybiBTdHJpbmcoKTsgfQogCiAgICAgY29uc3QgU3RyaW5n JiBuYW1lKCkgY29uc3QgeyByZXR1cm4gbV9uYW1lOyB9CiAgICAgY29uc3QgU3RyaW5nJiBwdWJs aWNJZCgpIGNvbnN0IHsgcmV0dXJuIG1fcHVibGljSWQ7IH0KICAgICBjb25zdCBTdHJpbmcmIHN5 c3RlbUlkKCkgY29uc3QgeyByZXR1cm4gbV9zeXN0ZW1JZDsgfQotICAgIGNvbnN0IFN0cmluZyYg aW50ZXJuYWxTdWJzZXQoKSBjb25zdCB7IHJldHVybiBtX3N1YnNldDsgfQogCiBwcml2YXRlOgog ICAgIERvY3VtZW50VHlwZShEb2N1bWVudCYsIGNvbnN0IFN0cmluZyYgbmFtZSwgY29uc3QgU3Ry aW5nJiBwdWJsaWNJZCwgY29uc3QgU3RyaW5nJiBzeXN0ZW1JZCk7CkBAIC01Niw3ICs1Niw2IEBA IHByaXZhdGU6CiAgICAgU3RyaW5nIG1fbmFtZTsKICAgICBTdHJpbmcgbV9wdWJsaWNJZDsKICAg ICBTdHJpbmcgbV9zeXN0ZW1JZDsKLSAgICBTdHJpbmcgbV9zdWJzZXQ7CiB9OwogCiB9IC8vIG5h bWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnRU eXBlLmlkbCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudFR5cGUuaWRsCmluZGV4IDEyZThi MGUzYzVhZjQxZTAxNzA4MDg3M2UwNzhmZmU3NWY5ZGEzNjQuLjcxYzU3NjllNjZiYzNlMzdjMGFm MjNhMDNmNzcxNGJmYTI4Y2JkYjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1 bWVudFR5cGUuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudFR5cGUuaWRsCkBA IC0yOSwxMyArMjksMTMgQEAKICNpZiAhZGVmaW5lZChMQU5HVUFHRV9KQVZBU0NSSVBUKSB8fCAh TEFOR1VBR0VfSkFWQVNDUklQVAogICAgIFtJbXBsZW1lbnRlZEFzPWVudGl0aWVzRm9yQmluZGlu Z3NdIHJlYWRvbmx5IGF0dHJpYnV0ZSBOYW1lZE5vZGVNYXAgZW50aXRpZXM7CiAgICAgW0ltcGxl bWVudGVkQXM9bm90YXRpb25zRm9yQmluZGluZ3NdIHJlYWRvbmx5IGF0dHJpYnV0ZSBOYW1lZE5v ZGVNYXAgbm90YXRpb25zOworICAgIFtJbXBsZW1lbnRlZEFzPWludGVybmFsU3Vic2V0Rm9yQmlu ZGluZ3NdIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmc/IGludGVybmFsU3Vic2V0OwogI2Vu ZGlmCiAKICAgICAvLyBET00gTGV2ZWwgMgogCiAgICAgcmVhZG9ubHkgYXR0cmlidXRlIERPTVN0 cmluZyBwdWJsaWNJZDsKICAgICByZWFkb25seSBhdHRyaWJ1dGUgRE9NU3RyaW5nIHN5c3RlbUlk OwotICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmc/IGludGVybmFsU3Vic2V0OwogfTsK IAogRG9jdW1lbnRUeXBlIGltcGxlbWVudHMgQ2hpbGROb2RlOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvZG9tL05vZGUuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCmluZGV4 IGQ3MTc0NGVmOWQwMzdiNmI3Njk5YjVkMGM1ZmY1Mzk2NTQ1NWQ0YjYuLjhlNTAyODMwODUwMGI5 ZDVmYmU2NGQ2YmQ3YzI4MTNkMmI3MDVjYzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9Ob2RlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAKQEAgLTEyMjYsOCAr MTIyNiw2IEBAIGJvb2wgTm9kZTo6aXNFcXVhbE5vZGUoTm9kZSogb3RoZXIpIGNvbnN0CiAgICAg ICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgIGlmICh0aGlzRG9jVHlwZS5zeXN0ZW1JZCgp ICE9IG90aGVyRG9jVHlwZS5zeXN0ZW1JZCgpKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwot ICAgICAgICBpZiAodGhpc0RvY1R5cGUuaW50ZXJuYWxTdWJzZXQoKSAhPSBvdGhlckRvY1R5cGUu aW50ZXJuYWxTdWJzZXQoKSkKLSAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgYnJl YWs7CiAgICAgICAgIH0KICAgICBjYXNlIE5vZGU6OkVMRU1FTlRfTk9ERTogewpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9NYXJrdXBBY2N1bXVsYXRvci5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9lZGl0aW5nL01hcmt1cEFjY3VtdWxhdG9yLmNwcAppbmRleCA4NmQ0Nzg1NzA0ZTVi NmRmOGY5OTllNWQxMWZjMTE1ZDU3YmExODg0Li4xYWI4NDc4NDg2OGIwYWQyOTMxMzZjZTgzMGJm YWU1ZWMzZjA5MzBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL01hcmt1cEFj Y3VtdWxhdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL01hcmt1cEFjY3VtdWxh dG9yLmNwcApAQCAtNDA0LDEyICs0MDQsNiBAQCB2b2lkIE1hcmt1cEFjY3VtdWxhdG9yOjphcHBl bmREb2N1bWVudFR5cGUoU3RyaW5nQnVpbGRlciYgcmVzdWx0LCBjb25zdCBEb2N1bWVudAogICAg ICAgICByZXN1bHQuYXBwZW5kKGRvY3VtZW50VHlwZS5zeXN0ZW1JZCgpKTsKICAgICAgICAgcmVz dWx0LmFwcGVuZCgnIicpOwogICAgIH0KLSAgICBpZiAoIWRvY3VtZW50VHlwZS5pbnRlcm5hbFN1 YnNldCgpLmlzTnVsbCgpKSB7Ci0gICAgICAgIHJlc3VsdC5hcHBlbmQoJyAnKTsKLSAgICAgICAg cmVzdWx0LmFwcGVuZCgnWycpOwotICAgICAgICByZXN1bHQuYXBwZW5kKGRvY3VtZW50VHlwZS5p bnRlcm5hbFN1YnNldCgpKTsKLSAgICAgICAgcmVzdWx0LmFwcGVuZCgnXScpOwotICAgIH0KICAg ICByZXN1bHQuYXBwZW5kKCc+Jyk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yRE9NQWdlbnQuY3BwCmluZGV4IDg2ZTY3ZTJmNmE2ODEyYTYwMzdjYzM3ODlmMGY0 N2MwZDI3NTI3NDUuLjZlOTQ3NTRjY2IxOTFhNmEyZjc5OGViZDNjZWQ0NWQ1YjBlOWVhOWQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcApAQCAt MTQwMSw3ICsxNDAxLDYgQEAgUmVmPEluc3BlY3Rvcjo6UHJvdG9jb2w6OkRPTTo6Tm9kZT4gSW5z cGVjdG9yRE9NQWdlbnQ6OmJ1aWxkT2JqZWN0Rm9yTm9kZShOb2RlKgogICAgICAgICBEb2N1bWVu dFR5cGUmIGRvY1R5cGUgPSBkb3duY2FzdDxEb2N1bWVudFR5cGU+KCpub2RlKTsKICAgICAgICAg dmFsdWUtPnNldFB1YmxpY0lkKGRvY1R5cGUucHVibGljSWQoKSk7CiAgICAgICAgIHZhbHVlLT5z ZXRTeXN0ZW1JZChkb2NUeXBlLnN5c3RlbUlkKCkpOwotICAgICAgICB2YWx1ZS0+c2V0SW50ZXJu YWxTdWJzZXQoZG9jVHlwZS5pbnRlcm5hbFN1YnNldCgpKTsKICAgICB9IGVsc2UgaWYgKGlzPEF0 dHI+KCpub2RlKSkgewogICAgICAgICBBdHRyJiBhdHRyaWJ1dGUgPSBkb3duY2FzdDxBdHRyPigq bm9kZSk7CiAgICAgICAgIHZhbHVlLT5zZXROYW1lKGF0dHJpYnV0ZS5uYW1lKCkpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0RPTU5vZGUu anMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRE9NTm9kZS5q cwppbmRleCBkNzU2YzZiMWIyMDE5ZmYwNWRkYzg4ZDI5NzQ2M2YyMmZhZTI5Y2UzLi45YzM0NjMz MTlkNjczYTdjNWI1NmU2MDhkMzUyOWRkOTJiZGI3YjNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRE9NTm9kZS5qcworKysgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRE9NTm9kZS5qcwpAQCAtMTIyLDcg KzEyMiw2IEBAIFdlYkluc3BlY3Rvci5ET01Ob2RlID0gY2xhc3MgRE9NTm9kZSBleHRlbmRzIFdl Ykluc3BlY3Rvci5PYmplY3QKICAgICAgICAgfSBlbHNlIGlmICh0aGlzLl9ub2RlVHlwZSA9PT0g Tm9kZS5ET0NVTUVOVF9UWVBFX05PREUpIHsKICAgICAgICAgICAgIHRoaXMucHVibGljSWQgPSBw YXlsb2FkLnB1YmxpY0lkOwogICAgICAgICAgICAgdGhpcy5zeXN0ZW1JZCA9IHBheWxvYWQuc3lz dGVtSWQ7Ci0gICAgICAgICAgICB0aGlzLmludGVybmFsU3Vic2V0ID0gcGF5bG9hZC5pbnRlcm5h bFN1YnNldDsKICAgICAgICAgfSBlbHNlIGlmICh0aGlzLl9ub2RlVHlwZSA9PT0gTm9kZS5ET0NV TUVOVF9OT0RFKSB7CiAgICAgICAgICAgICB0aGlzLmRvY3VtZW50VVJMID0gcGF5bG9hZC5kb2N1 bWVudFVSTDsKICAgICAgICAgICAgIHRoaXMueG1sVmVyc2lvbiA9IHBheWxvYWQueG1sVmVyc2lv bjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVs cy9ET01TZWFyY2hNYXRjaE9iamVjdC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL01vZGVscy9ET01TZWFyY2hNYXRjaE9iamVjdC5qcwppbmRleCA5NmUyYmRjMzA3Nzll M2M3Y2NhNmQ2M2MzMmExZGRkMzBlYzZhZTc1Li5iZjhiOTMwOGMxOGQxZmRmMDlmM2Y3MTYxNjhh YTRkZTY1MDQzY2EzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9Nb2RlbHMvRE9NU2VhcmNoTWF0Y2hPYmplY3QuanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0RPTVNlYXJjaE1hdGNoT2JqZWN0LmpzCkBAIC02 OCw5ICs2OCw2IEBAIFdlYkluc3BlY3Rvci5ET01TZWFyY2hNYXRjaE9iamVjdCA9IGNsYXNzIERP TVNlYXJjaE1hdGNoT2JqZWN0IGV4dGVuZHMgV2ViSW5zcGVjCiAgICAgICAgICAgICB9IGVsc2Ug aWYgKGRvbU5vZGUuc3lzdGVtSWQpCiAgICAgICAgICAgICAgICAgdGl0bGUgKz0gIiBTWVNURU0g XCIiICsgZG9tTm9kZS5zeXN0ZW1JZCArICJcIiI7CiAKLSAgICAgICAgICAgIGlmIChkb21Ob2Rl LmludGVybmFsU3Vic2V0KQotICAgICAgICAgICAgICAgIHRpdGxlICs9ICIgWyIgKyBkb21Ob2Rl LmludGVybmFsU3Vic2V0ICsgIl0iOwotCiAgICAgICAgICAgICByZXR1cm4gdGl0bGUgKyAiPiI7 CiAKICAgICAgICAgY2FzZSBOb2RlLkNEQVRBX1NFQ1RJT05fTk9ERToKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVFbGVtZW50Lmpz IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUVsZW1l bnQuanMKaW5kZXggNTZkMWQ0ZWRlMTk4YzhlODYzOGZkNzEyODU0M2Q3ZDg5Y2Q1MjQ2Yi4uNTRk MzU1YWVlYjg5N2Y2YWYwOWEwMTIzNDMxY2RiYjk0YWE1YmNhZCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUVsZW1lbnQuanMKKysr IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUVsZW1l bnQuanMKQEAgLTEzMDYsOSArMTMwNiw2IEBAIFdlYkluc3BlY3Rvci5ET01UcmVlRWxlbWVudCA9 IGNsYXNzIERPTVRyZWVFbGVtZW50IGV4dGVuZHMgV2ViSW5zcGVjdG9yLlRyZWVFbGVtCiAgICAg ICAgICAgICAgICAgfSBlbHNlIGlmIChub2RlLnN5c3RlbUlkKQogICAgICAgICAgICAgICAgICAg ICBkb2NUeXBlRWxlbWVudC5hcHBlbmQoIiBTWVNURU0gXCIiICsgbm9kZS5zeXN0ZW1JZCArICJc IiIpOwogCi0gICAgICAgICAgICAgICAgaWYgKG5vZGUuaW50ZXJuYWxTdWJzZXQpCi0gICAgICAg ICAgICAgICAgICAgIGRvY1R5cGVFbGVtZW50LmFwcGVuZCgiIFsiICsgbm9kZS5pbnRlcm5hbFN1 YnNldCArICJdIik7Ci0KICAgICAgICAgICAgICAgICBkb2NUeXBlRWxlbWVudC5hcHBlbmQoIj4i KTsKICAgICAgICAgICAgICAgICBicmVhazsKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1w b3J0ZWQvdzNjL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cK aW5kZXggYTEzNGRjNWU4YzkxMmVkZTUyNmY3YTEzMzlhZmQ3YjU0OTQ5MWU3ZS4uZWJlMDE5ZTBj ODJmNzMwNzFkNzI2NGEwZjIzNjU5NzM1YTU5ZTc4YSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv aW1wb3J0ZWQvdzNjL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTYtMDgtMDMgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KIAorICAgICAgICBEcm9wIERvY3VtZW50VHlwZS5pbnRlcm5hbFN1YnNldCBh dHRyaWJ1dGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE2MDUzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJlYmFzZWxpbmUgVzNDIHRlc3Qgbm93IHRoYXQgb25lIG1vcmUgY2hlY2sgaXMgcGFzc2luZy4K KworICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9kb20vaGlzdG9yaWNhbC1leHBlY3RlZC50 eHQ6CisKKzIwMTYtMDgtMDMgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKwogICAg ICAgICBGaXggbG9nZ2luZyBpbiBXM0MgdGVzdHMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDUxMwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9p bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9oaXN0b3JpY2FsLWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZG9tL2hpc3Rv cmljYWwtZXhwZWN0ZWQudHh0CmluZGV4IGM5YjgwMTI4MzQ0MjZmZjk1NjYzZjJlNmJlM2JlNWIw ZDQ3ZjQ3YTEuLjQxMTE3MzgyYjYxMzNhYTBhODNjZjVjZDFlMmQ2YTk0Y2NlYzJhNzcgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZG9tL2hp c3RvcmljYWwtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWIt cGxhdGZvcm0tdGVzdHMvZG9tL2hpc3RvcmljYWwtZXhwZWN0ZWQudHh0CkBAIC00Miw3ICs0Miw3 IEBAIFBBU1MgSGlzdG9yaWNhbCBET00gZmVhdHVyZXMgbXVzdCBiZSByZW1vdmVkOiBzZXRJZEF0 dHJpYnV0ZU5TCiBQQVNTIEhpc3RvcmljYWwgRE9NIGZlYXR1cmVzIG11c3QgYmUgcmVtb3ZlZDog c2V0SWRBdHRyaWJ1dGVOb2RlIAogUEFTUyBEb2N1bWVudFR5cGUgbWVtYmVyIG11c3QgYmUgbnVr ZWQ6IGVudGl0aWVzIAogUEFTUyBEb2N1bWVudFR5cGUgbWVtYmVyIG11c3QgYmUgbnVrZWQ6IG5v dGF0aW9ucyAKLUZBSUwgRG9jdW1lbnRUeXBlIG1lbWJlciBtdXN0IGJlIG51a2VkOiBpbnRlcm5h bFN1YnNldCBhc3NlcnRfZXF1YWxzOiBleHBlY3RlZCAodW5kZWZpbmVkKSB1bmRlZmluZWQgYnV0 IGdvdCAob2JqZWN0KSBudWxsCitQQVNTIERvY3VtZW50VHlwZSBtZW1iZXIgbXVzdCBiZSBudWtl ZDogaW50ZXJuYWxTdWJzZXQgCiBQQVNTIFRleHQgbWVtYmVyIG11c3QgYmUgbnVrZWQ6IGlzRWxl bWVudENvbnRlbnRXaGl0ZXNwYWNlIAogRkFJTCBUZXh0IG1lbWJlciBtdXN0IGJlIG51a2VkOiBy ZXBsYWNlV2hvbGVUZXh0IGFzc2VydF9lcXVhbHM6IGV4cGVjdGVkICh1bmRlZmluZWQpIHVuZGVm aW5lZCBidXQgZ290IChmdW5jdGlvbikgZnVuY3Rpb24gImZ1bmN0aW9uIHJlcGxhY2VXaG9sZVRl eHQoKSB7CiAgICAgW25hdGl2ZSBjb2RlXQo=