16050 2007-11-19 09:02:40 -0800 sqlite3_prepare16_v2 build bustage. 2007-11-19 10:02:44 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 0 dougt webkit-unassigned oldest_to_newest 61686 0 dougt 2007-11-19 09:02:40 -0800 in WebCore/platform/sql/SQLiteStatement.cpp, use of the function |sqlite3_prepare16_v2| is dependent on the SQLITE_VERSION_NUMBER being greater than 3.3.0. (line 53). |sqlite3_prepare16_v2| was introduced in SQLITE_VERSION_NUMBER 3.3.9 (according to http://www.sqlite.org/cvstrac/wiki?p=WhenPreparedStatementExpire). Anyone using sqlite version between 3.3.1 and 3.3.9 will not be able to build WebCore/platform/sql/SQLiteStatement.cpp. According to the SQLite headers ** The SQLITE_VERSION_NUMBER is an integer with the value ** (X*1000000 + Y*1000 + Z). For example, for version "3.1.1beta", ** SQLITE_VERSION_NUMBER is set to 3001001. To detect if they are using ** version 3.1.1 or greater at compile time, programs may use the test ** (SQLITE_VERSION_NUMBER>=3001001). Patch coming up. 61687 1 17399 dougt 2007-11-19 09:17:33 -0800 Created attachment 17399 Patch 1. 61688 2 alp 2007-11-19 10:02:44 -0800 Landed in r27910. 17399 2007-11-19 09:17:33 -0800 2007-11-19 09:21:51 -0800 Patch 1. x text/plain 1229 dougt SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vc3FsL1NRTGl0ZVN0YXRlbWVudC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9zcWwvU1FMaXRlU3RhdGVtZW50LmNwcCAgICAocmV2aXNp b24gMjc4NjApCisrKyBXZWJDb3JlL3BsYXRmb3JtL3NxbC9TUUxpdGVTdGF0ZW1lbnQuY3BwICAg ICh3b3JraW5nIGNvcHkpCkBAIC01MCw3ICs1MCw3IEBACiB7ICAgIAogICAgIGNvbnN0IHZvaWQq IHRhaWw7CiAgICAgTE9HKFNRTERhdGFiYXNlLCAiU1FMIC0gcHJlcGFyZSAtICVzIiwgbV9xdWVy eS5hc2NpaSgpLmRhdGEoKSk7Ci0jaWYgU1FMSVRFX1ZFUlNJT05fTlVNQkVSID4gMzAwMzAwMCAK KyNpZiBTUUxJVEVfVkVSU0lPTl9OVU1CRVIgPj0gMzAwMzAwOSAKICAgICBpZiAoc3FsaXRlM19w cmVwYXJlMTZfdjIobV9kYXRhYmFzZS5zcWxpdGUzSGFuZGxlKCksIG1fcXVlcnkuY2hhcmFjdGVy cygpLCAtMSwgJm1fc3RhdGVtZW50LCAmdGFpbCkgIT0gU1FMSVRFX09LKSB7CiAjZWxzZQogICAg IGlmIChzcWxpdGUzX3ByZXBhcmUxNihtX2RhdGFiYXNlLnNxbGl0ZTNIYW5kbGUoKSwgbV9xdWVy eS5jaGFyYWN0ZXJzKCksIC0xLCAmbV9zdGF0ZW1lbnQsICZ0YWlsKSAhPSBTUUxJVEVfT0spIHsK SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n ICAgKHJldmlzaW9uIDI3OTA2KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cgICAod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDEzIEBACisyMDA3LTExLTE5ICBkb3VndCAgPGRvdWd0QG1lZXIubmV0Pgor CisgICAgICAgIFJldmlld2VkIGJ5IFhYWC4KKworICAgICAgICBVc2luZyB0aGUgY29ycmVjdCBT UUxJVEVfVkVSU0lPTl9OVU1CRVIgYXJvdW5kIHNxbGl0ZV9wcmVwYXJlMTZfdjIKKyAgICAgICAg dG8gZml4IGJ1aWxkIGJ1c3RhZ2UuIEJ1ZyAxNjA1MC4KKworICAgICAgICAqIHBsYXRmb3JtL3Nx bC9TUUxpdGVTdGF0ZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1FMaXRlU3RhdGVtZW50 OjpwcmVwYXJlKToKKwogMjAwNy0xMS0xOSAgQWxwIFRva2VyICA8YWxwQGF0b2tlci5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgTWFyayBSb3dlLgo=