16049 2007-11-19 07:24:58 -0800 execCommand('backColor') fails on collapsed selections 2008-06-19 18:16:35 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All OS X 10.4 RESOLVED FIXED http://nick-santos.com/tests/background_color.html P2 Normal --- 1 nicksantos webkit-unassigned ap jparent justin.garcia mrowe oldest_to_newest 61674 0 nicksantos 2007-11-19 07:24:58 -0800 Repro Steps: 1) Place the cursor in a contentEditable element. 2) Execute document.execCommand('backColor', false, '#f00') in JavaScript. 3) Type some text. Expected Result: The new text should have a red background. Actual Result: The new text keeps the same background. Notes: 'backColor' works ok when text is actually selected. If we replace 'backColor' with 'foreColor' in step #2, the new text is red as expected. Verified on Safari3/Win and Webkit-Nightly/OSX. 61682 1 mrowe 2007-11-19 08:11:45 -0800 JSEditor.cpp shows that BackColor and ForeColor have different values for the enabledFn member of their CommandImp: WebCore/editing/JSEditor.cpp: { "BackColor", { execBackColor, enabledAnyRichlyEditableRangeSelection, stateNone, valueBackColor } }, WebCore/editing/JSEditor.cpp: { "ForeColor", { execForeColor, enabledAnySelection, stateNone, valueForeColor } }, BackColor requires a range selection which would cause the command to be disabled for collapsed selections. The fix here may be as simple as changing the enabledFn to enabledAnyRichlyEditableSelection. A quick test suggests that this gives the same behaviour as IE on the test case. 66782 2 eric 2008-01-10 12:58:33 -0800 So it sounds like all this bug needs is some understanding of what a change to enabledAnyRichlyEditableSelection would mean for the rest of the web. :) I guess we solve that with a test case. 83928 3 jparent 2008-06-19 15:54:40 -0700 +1 on fixing this. We have horrible, horrible hacks in place to get this working in the Google editor. I'd love to get rid of them! 83929 4 justin.garcia 2008-06-19 16:11:14 -0700 (In reply to comment #1) > JSEditor.cpp shows that BackColor and ForeColor have different values for the > enabledFn member of their CommandImp: > > WebCore/editing/JSEditor.cpp: { "BackColor", { execBackColor, > enabledAnyRichlyEditableRangeSelection, stateNone, valueBackColor } }, > WebCore/editing/JSEditor.cpp: { "ForeColor", { execForeColor, > enabledAnySelection, stateNone, valueForeColor } }, Yikes that's completely wrong, BackColor should have enabledAnyRichlyEditableRangeSelection, and I don't know why ForeColor has enabledAnySelection, it should be disabled in a plain text region too. 83930 5 justin.garcia 2008-06-19 16:12:04 -0700 > BackColor should have enabledAnyRichlyEditableRangeSelection that should read "enabledAnyRichlyEditableSelection". 83944 6 justin.garcia 2008-06-19 18:16:35 -0700 http://trac.webkit.org/changeset/34682