<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>160486</bug_id>
          
          <creation_ts>2016-08-02 18:41:06 -0700</creation_ts>
          <short_desc>run-javascriptcore-tests should accept multiple --extra-tests</short_desc>
          <delta_ts>2016-08-02 19:39:35 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Filip Pizlo">fpizlo</reporter>
          <assigned_to name="Filip Pizlo">fpizlo</assigned_to>
          <cc>lforschler</cc>
    
    <cc>saam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1216739</commentid>
    <comment_count>0</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2016-08-02 18:41:06 -0700</bug_when>
    <thetext>Patch forthcoming.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1216740</commentid>
    <comment_count>1</comment_count>
      <attachid>285182</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2016-08-02 18:42:29 -0700</bug_when>
    <thetext>Created attachment 285182
the patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1216745</commentid>
    <comment_count>2</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2016-08-02 18:59:31 -0700</bug_when>
    <thetext>Landed in https://trac.webkit.org/changeset/204060</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1216753</commentid>
    <comment_count>3</comment_count>
    <who name="Saam Barati">saam</who>
    <bug_when>2016-08-02 19:38:48 -0700</bug_when>
    <thetext>I forgot to ask but does this work with the extra tests environment variable?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1216754</commentid>
    <comment_count>4</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2016-08-02 19:39:35 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; I forgot to ask but does this work with the extra tests environment variable?

Yes.  It&apos;s now additive.  Previously it was destructive: --extra-tests would override the environment variable.  Now you get the sum of the two.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>285182</attachid>
            <date>2016-08-02 18:42:29 -0700</date>
            <delta_ts>2016-08-02 18:43:44 -0700</delta_ts>
            <desc>the patch</desc>
            <filename>blah.patch</filename>
            <type>text/plain</type>
            <size>2186</size>
            <attacher name="Filip Pizlo">fpizlo</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDIwNDA1OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE2IEBACisyMDE2LTA4LTAyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisK
KyAgICAgICAgcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzIHNob3VsZCBhY2NlcHQgbXVsdGlwbGUg
LS1leHRyYS10ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTYwNDg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAg
ICAgIAorICAgICAgICBXZSB3YW50IHRvIGJlIGFibGUgdG8gcGFzcyAtLWV4dHJhLXRlc3RzIG11
bHRpcGxlIHRpbWVzLCB0byBzdXBwbHkgYW4gYXJiaXRyYXJ5IG51bWJlciBvZiBleHRyYQorICAg
ICAgICB0ZXN0IHN1aXRlcy4gVGhpcyBkb2VzIGl0IGJ5IHVzaW5nIEdldE9wdDo6TG9uZydzIGFy
cmF5IHN1cHBvcnQuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0
czoKKyAgICAgICAgKHJ1bkpTQ1N0cmVzc1Rlc3RzKToKKwogMjAxNi0wOC0wMiAgRW5yaWNhIENh
c3VjY2kgIDxlbnJpY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEFsbG93IGJ1aWxkaW5nIHdpdGgg
Y29udGVudCBmaWx0ZXJpbmcgZGlzYWJsZWQuCkluZGV4OiBUb29scy9TY3JpcHRzL3J1bi1qYXZh
c2NyaXB0Y29yZS10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3J1bi1qYXZhc2Ny
aXB0Y29yZS10ZXN0cwkocmV2aXNpb24gMjA0MDU4KQorKysgVG9vbHMvU2NyaXB0cy9ydW4tamF2
YXNjcmlwdGNvcmUtdGVzdHMJKHdvcmtpbmcgY29weSkKQEAgLTQ3LDcgKzQ3LDcgQEAgbXkgJGNv
bmZpZ3VyYXRpb24gPSBjb25maWd1cmF0aW9uKCk7CiAjIFRoZXNlIHZhcmlhYmxlcyBhcmUgaW50
ZW50aW9uYWxseSBsZWZ0IHVuZGVmaW5lZC4KIG15ICRyb290OwogbXkgJHNob3dIZWxwOwotbXkg
JGV4dHJhVGVzdHM7CitteSBAZXh0cmFUZXN0cyA9ICgpOwogbXkgJGpzRHJpdmVyQXJnczsKIG15
ICRjaGlsZFByb2Nlc3NlczsKIG15ICRzaGVsbFJ1bm5lcjsKQEAgLTk1LDcgKzk1LDcgQEAgaWYg
KCRFTlZ7UlVOX0pBVkFTQ1JJUFRDT1JFX1RFU1RTX0JVSUxEfQogfQogCiBpZiAoJEVOVntSVU5f
SkFWQVNDUklQVENPUkVfVEVTVFNfRVhUUkFfVEVTVFN9KSB7Ci0gICAgJGV4dHJhVGVzdHMgPSAk
RU5We1JVTl9KQVZBU0NSSVBUQ09SRV9URVNUU19FWFRSQV9URVNUU307CisgICAgcHVzaCBAZXh0
cmFUZXN0cywgJEVOVntSVU5fSkFWQVNDUklQVENPUkVfVEVTVFNfRVhUUkFfVEVTVFN9OwogfQog
CiBteSAkcHJvZ3JhbU5hbWUgPSBiYXNlbmFtZSgkMCk7CkBAIC0xNDUsNyArMTQ1LDcgQEAgRU9G
CiAKIEdldE9wdGlvbnMoCiAgICAgJ3Jvb3Q9cycgPT4gXCRyb290LAotICAgICdleHRyYS10ZXN0
cz1zJyA9PiBcJGV4dHJhVGVzdHMsCisgICAgJ2V4dHJhLXRlc3RzPXMnID0+IFxAZXh0cmFUZXN0
cywKICAgICAnYnVpbGQhJyA9PiBcJGJ1aWxkSlNDLAogICAgICd0ZXN0YXBpIScgPT4gXCRydW5U
ZXN0QVBJLAogICAgICdqc2Mtc3RyZXNzIScgPT4gXCRydW5KU0NTdHJlc3MsCkBAIC0zNDUsOCAr
MzQ1LDggQEAgc3ViIHJ1bkpTQ1N0cmVzc1Rlc3RzCiAgICAgIyBFbmQgb3B0aW9uIHByb2Nlc3Np
bmcsIHRoZSByZXN0IG9mIHRoZSBhcmd1bWVudHMgYXJlIHRlc3RzCiAgICAgcHVzaChAanNjU3Ry
ZXNzRHJpdmVyQ21kLCAiLS0iKTsKIAotICAgIGlmIChkZWZpbmVkKCRleHRyYVRlc3RzKSkgewot
ICAgICAgICBwdXNoKEBqc2NTdHJlc3NEcml2ZXJDbWQsICRleHRyYVRlc3RzKTsKKyAgICBmb3Ig
bXkgJHRlc3RTdWl0ZSAoQGV4dHJhVGVzdHMpIHsKKyAgICAgICAgcHVzaChAanNjU3RyZXNzRHJp
dmVyQ21kLCAkdGVzdFN1aXRlKTsKICAgICB9CiAgICAgaWYgKGRlZmluZWQoJEVOVnsiRVhUUkFf
SlNDX1RFU1RTIn0pKSB7CiAgICAgICAgIHB1c2goQGpzY1N0cmVzc0RyaXZlckNtZCwgJEVOVnsi
RVhUUkFfSlNDX1RFU1RTIn0pOwo=
</data>
<flag name="review"
          id="308819"
          type_id="1"
          status="+"
          setter="saam"
    />
          </attachment>
      

    </bug>

</bugzilla>