160479 2016-08-02 17:01:14 -0700 REGRESSION(r203368): broke some test262 tests 2016-08-03 11:52:37 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 143247 1 fpizlo fpizlo barraclough benjamin ggaren keith_miller mark.lam mhahnenb msaboff oliver saam sam oldest_to_newest 1216696 0 fpizlo 2016-08-02 17:01:14 -0700 Specifically: JSTests/test262/test/built-ins/Object/freeze/15.2.3.9-2-c-2.js JSTests/test262/test/built-ins/Object/freeze/15.2.3.9-2-c-3.js JSTests/test262/test/built-ins/Object/freeze/15.2.3.9-2-c-4.js Which can be run with: jsc JSTests/test262/harness/assert.js JSTests/test262/harness/sta.js JSTests/test262/harness/propertyHelper.js <testFile> 1217023 1 fpizlo 2016-08-03 11:15:10 -0700 Wow, that's a silly goof. The optimization ended up setting ReadOnly on Access properties, which would prevent setters from being invoked. That's easy to fix. 1217030 2 285253 fpizlo 2016-08-03 11:27:00 -0700 Created attachment 285253 the patch 1217034 3 285253 mark.lam 2016-08-03 11:33:00 -0700 Comment on attachment 285253 the patch r=me 1217050 4 fpizlo 2016-08-03 11:52:37 -0700 Landed in https://trac.webkit.org/changeset/204093 285253 2016-08-03 11:27:00 -0700 2016-08-03 11:33:00 -0700 the patch blah.patch text/plain 4976 fpizlo SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMDQwODkpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE1IEBACisyMDE2LTA4LTAzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5j b20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjAzMzY4KTogYnJva2Ugc29tZSB0ZXN0MjYyIHRl c3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjA0 NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAg ICAgIEFkZGVkIGEgc3RyZXNzIHRlc3QgZm9yIHRoaXMgY2FzZSwgc2luY2Ugd2UgZG9uJ3QgYWx3 YXlzIHJ1biB0ZXN0MjYyLgorCisgICAgICAgICogc3RyZXNzL2ZyZWV6ZS1zZXR0ZXIuanM6IEFk ZGVkLgorICAgICAgICAobGV0Lm8uc2V0IGZvbyk6CisKIDIwMTYtMDgtMDMgIFNhYW0gQmFyYXRp ICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IG5lc3RlZCByZXN0IGRl c3RydWN0dXJpbmcgdy5yLnQgdGhlIEVTNyBzcGVjCkluZGV4OiBKU1Rlc3RzL3N0cmVzcy9mcmVl emUtc2V0dGVyLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL2ZyZWV6ZS1zZXR0ZXIu anMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3MvZnJlZXplLXNldHRlci5qcwkod29y a2luZyBjb3B5KQpAQCAtMCwwICsxLDIwIEBACisvL0AgcnVuRGVmYXVsdAorCisidXNlIHN0cmlj dCI7CisKK2xldCB4OworCitsZXQgbyA9IHsKKyAgICBzZXQgZm9vKHZhbHVlKQorICAgIHsKKyAg ICAgICAgeCA9IHZhbHVlOworICAgIH0KK307CisKK09iamVjdC5mcmVlemUobyk7CisKK28uZm9v ID0gNDI7CisKK2lmICh4ICE9IDQyKQorICAgIHRocm93ICJFcnJvcjogYmFkIHJlc3VsdDogIiAr IHg7CisKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA0MDg2KQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDIwIEBACisyMDE2LTA4LTAzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAg ICAgICAgUkVHUkVTU0lPTihyMjAzMzY4KTogYnJva2Ugc29tZSB0ZXN0MjYyIHRlc3RzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjA0NzkKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFRoZSBv cHRpbWl6YXRpb24gaW4gcjIwMzM2OCBvdmVybG9va2VkIGEgc3VidGxlIGRldGFpbDogZnJlZXpp bmcgZG9lcyBub3Qgc2V0IFJlYWRPbmx5IG9uCisgICAgICAgIEFjY2Vzc29yIHByb3BlcnRpZXMu CisKKyAgICAgICAgKiBydW50aW1lL1N0cnVjdHVyZS5jcHA6CisgICAgICAgIChKU0M6OlN0cnVj dHVyZTo6bm9uUHJvcGVydHlUcmFuc2l0aW9uKToKKyAgICAgICAgKiBydW50aW1lL1N0cnVjdHVy ZVRyYW5zaXRpb25UYWJsZS5oOgorICAgICAgICAoSlNDOjpzZXRzRG9udERlbGV0ZU9uQWxsUHJv cGVydGllcyk6CisgICAgICAgIChKU0M6OnNldHNSZWFkT25seU9uTm9uQWNjZXNzb3JQcm9wZXJ0 aWVzKToKKyAgICAgICAgKEpTQzo6c2V0c1JlYWRPbmx5T25BbGxQcm9wZXJ0aWVzKTogRGVsZXRl ZC4KKwogMjAxNi0wOC0wMyAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgog CiAgICAgICAgIExhY2tpbmcgc3VwcG9ydCBvbiBhIGFybS10cmFkaXRpb25hbCBkaXNhc3NlbWJs ZXIuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmUuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZS5jcHAJ KHJldmlzaW9uIDIwNDA4NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVj dHVyZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY1MiwxMiArNjUyLDggQEAgU3RydWN0dXJlKiBT dHJ1Y3R1cmU6Om5vblByb3BlcnR5VHJhbnNpdAogICAgIGlmIChwcmV2ZW50c0V4dGVuc2lvbnMo dHJhbnNpdGlvbktpbmQpKQogICAgICAgICB0cmFuc2l0aW9uLT5zZXREaWRQcmV2ZW50RXh0ZW5z aW9ucyh0cnVlKTsKICAgICAKLSAgICB1bnNpZ25lZCBhZGRpdGlvbmFsUHJvcGVydHlBdHRyaWJ1 dGVzID0gMDsKLSAgICBpZiAoc2V0c0RvbnREZWxldGVPbkFsbFByb3BlcnRpZXModHJhbnNpdGlv bktpbmQpKQotICAgICAgICBhZGRpdGlvbmFsUHJvcGVydHlBdHRyaWJ1dGVzIHw9IERvbnREZWxl dGU7Ci0gICAgaWYgKHNldHNSZWFkT25seU9uQWxsUHJvcGVydGllcyh0cmFuc2l0aW9uS2luZCkp Ci0gICAgICAgIGFkZGl0aW9uYWxQcm9wZXJ0eUF0dHJpYnV0ZXMgfD0gUmVhZE9ubHk7Ci0gICAg aWYgKGFkZGl0aW9uYWxQcm9wZXJ0eUF0dHJpYnV0ZXMpIHsKKyAgICBpZiAoc2V0c0RvbnREZWxl dGVPbkFsbFByb3BlcnRpZXModHJhbnNpdGlvbktpbmQpCisgICAgICAgIHx8IHNldHNSZWFkT25s eU9uTm9uQWNjZXNzb3JQcm9wZXJ0aWVzKHRyYW5zaXRpb25LaW5kKSkgewogICAgICAgICAvLyBX ZSBwaW4gdGhlIHByb3BlcnR5IHRhYmxlIG9uIHRyYW5zaXRpb25zIHRoYXQgZG8gd2hvbGVzYWxl IGVkaXRpbmcgb2YgdGhlIHByb3BlcnR5CiAgICAgICAgIC8vIHRhYmxlLCBzaW5jZSBvdXIgbG9n aWMgZm9yIHdhbGtpbmcgdGhlIHByb3BlcnR5IHRyYW5zaXRpb24gY2hhaW4gdG8gcmVtYXRlcmlh bGl6ZSB0aGUKICAgICAgICAgLy8gdGFibGUgZG9lc24ndCBrbm93IGhvdyB0byB0YWtlIGludG8g YWNjb3VudCBzdWNoIHdob2xlc2FsZSBlZGl0cy4KQEAgLTY2OCw4ICs2NjQsMTIgQEAgU3RydWN0 dXJlKiBTdHJ1Y3R1cmU6Om5vblByb3BlcnR5VHJhbnNpdAogICAgICAgICB0cmFuc2l0aW9uLT5w aW5Gb3JDYWNoaW5nKCk7CiAgICAgICAgIAogICAgICAgICBpZiAodHJhbnNpdGlvbi0+cHJvcGVy dHlUYWJsZSgpKSB7Ci0gICAgICAgICAgICBmb3IgKGF1dG8mIGVudHJ5IDogKnRyYW5zaXRpb24t PnByb3BlcnR5VGFibGUoKS5nZXQoKSkKLSAgICAgICAgICAgICAgICBlbnRyeS5hdHRyaWJ1dGVz IHw9IGFkZGl0aW9uYWxQcm9wZXJ0eUF0dHJpYnV0ZXM7CisgICAgICAgICAgICBmb3IgKGF1dG8m IGVudHJ5IDogKnRyYW5zaXRpb24tPnByb3BlcnR5VGFibGUoKS5nZXQoKSkgeworICAgICAgICAg ICAgICAgIGlmIChzZXRzRG9udERlbGV0ZU9uQWxsUHJvcGVydGllcyh0cmFuc2l0aW9uS2luZCkp CisgICAgICAgICAgICAgICAgICAgIGVudHJ5LmF0dHJpYnV0ZXMgfD0gRG9udERlbGV0ZTsKKyAg ICAgICAgICAgICAgICBpZiAoc2V0c1JlYWRPbmx5T25Ob25BY2Nlc3NvclByb3BlcnRpZXModHJh bnNpdGlvbktpbmQpICYmICEoZW50cnkuYXR0cmlidXRlcyAmIEFjY2Vzc29yKSkKKyAgICAgICAg ICAgICAgICAgICAgZW50cnkuYXR0cmlidXRlcyB8PSBSZWFkT25seTsKKyAgICAgICAgICAgIH0K ICAgICAgICAgfQogICAgIH0gZWxzZSB7CiAgICAgICAgIHRyYW5zaXRpb24tPnByb3BlcnR5VGFi bGUoKS5zZXQodm0sIHRyYW5zaXRpb24sIHN0cnVjdHVyZS0+dGFrZVByb3BlcnR5VGFibGVPckNs b25lSWZQaW5uZWQodm0pKTsKQEAgLTY3Nyw3ICs2NzcsNyBAQCBTdHJ1Y3R1cmUqIFN0cnVjdHVy ZTo6bm9uUHJvcGVydHlUcmFuc2l0CiAgICAgICAgIGNoZWNrT2Zmc2V0KHRyYW5zaXRpb24tPm1f b2Zmc2V0LCB0cmFuc2l0aW9uLT5pbmxpbmVDYXBhY2l0eSgpKTsKICAgICB9CiAgICAgCi0gICAg aWYgKHNldHNSZWFkT25seU9uQWxsUHJvcGVydGllcyh0cmFuc2l0aW9uS2luZCkKKyAgICBpZiAo c2V0c1JlYWRPbmx5T25Ob25BY2Nlc3NvclByb3BlcnRpZXModHJhbnNpdGlvbktpbmQpCiAgICAg ICAgICYmIHRyYW5zaXRpb24tPnByb3BlcnR5VGFibGUoKQogICAgICAgICAmJiAhdHJhbnNpdGlv bi0+cHJvcGVydHlUYWJsZSgpLT5pc0VtcHR5KCkpCiAgICAgICAgIHRyYW5zaXRpb24tPnNldEhh c1JlYWRPbmx5T3JHZXR0ZXJTZXR0ZXJQcm9wZXJ0aWVzRXhjbHVkaW5nUHJvdG8odHJ1ZSk7Cklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmVUcmFuc2l0aW9uVGFi bGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1 cmVUcmFuc2l0aW9uVGFibGUuaAkocmV2aXNpb24gMjA0MDg2KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlVHJhbnNpdGlvblRhYmxlLmgJKHdvcmtpbmcgY29weSkK QEAgLTEzMCw3ICsxMzAsNyBAQCBpbmxpbmUgYm9vbCBzZXRzRG9udERlbGV0ZU9uQWxsUHJvcGVy dGllCiAgICAgfQogfQogCi1pbmxpbmUgYm9vbCBzZXRzUmVhZE9ubHlPbkFsbFByb3BlcnRpZXMo Tm9uUHJvcGVydHlUcmFuc2l0aW9uIHRyYW5zaXRpb24pCitpbmxpbmUgYm9vbCBzZXRzUmVhZE9u bHlPbk5vbkFjY2Vzc29yUHJvcGVydGllcyhOb25Qcm9wZXJ0eVRyYW5zaXRpb24gdHJhbnNpdGlv bikKIHsKICAgICBzd2l0Y2ggKHRyYW5zaXRpb24pIHsKICAgICBjYXNlIE5vblByb3BlcnR5VHJh bnNpdGlvbjo6RnJlZXplOgo=