160477 2016-08-02 16:30:16 -0700 Drop custom bindings code for HTMLSelectElement.remove() 2016-08-02 19:57:46 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=160475 WebExposed P2 Normal --- 160394 1 cdumez cdumez cdumez commit-queue darin dbates rniwa sam oldest_to_newest 1216676 0 cdumez 2016-08-02 16:30:16 -0700 Drop custom bindings code for HTMLSelectElement.remove() and use overloading instead. 1216683 1 cdumez 2016-08-02 16:45:00 -0700 Bindings look like: EncodedJSValue JSC_HOST_CALL jsHTMLSelectElementPrototypeFunctionRemove(ExecState* state) { size_t argsCount = std::min<size_t>(1, state->argumentCount()); if (argsCount == 0) { return jsHTMLSelectElementPrototypeFunctionRemove1(state); } if (argsCount == 1) { JSValue distinguishingArg = state->uncheckedArgument(0); if (distinguishingArg.isObject() && asObject(distinguishingArg)->inherits(JSHTMLOptionElement::info())) return jsHTMLSelectElementPrototypeFunctionRemove3(state); if (distinguishingArg.isNumber()) return jsHTMLSelectElementPrototypeFunctionRemove2(state); return jsHTMLSelectElementPrototypeFunctionRemove2(state); } return throwVMTypeError(state); } 1216688 2 285162 cdumez 2016-08-02 16:51:21 -0700 Created attachment 285162 Patch 1216695 3 285164 cdumez 2016-08-02 16:57:53 -0700 Created attachment 285164 Patch 1216761 4 285164 commit-queue 2016-08-02 19:57:41 -0700 Comment on attachment 285164 Patch Clearing flags on attachment: 285164 Committed r204064: <http://trac.webkit.org/changeset/204064> 1216762 5 commit-queue 2016-08-02 19:57:46 -0700 All reviewed patches have been landed. Closing bug. 285162 2016-08-02 16:51:21 -0700 2016-08-02 16:57:50 -0700 Patch bug-160477-20160802165000.patch text/plain 3280 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0MDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjFmZjkzNzU2ODFlNzgw MjIxMmE1YzY0ZTBhOTMzNjIzNjgxOTc2MS4uNTBhMDczYmU4YzhiMDk1ZTIzY2YxNjczMDJiODZj OGY1OWY3ODk1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA4LTAyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRHJvcCBjdXN0b20gYmluZGlu Z3MgY29kZSBmb3IgSFRNTFNlbGVjdEVsZW1lbnQucmVtb3ZlKCkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDQ3NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERyb3AgY3VzdG9tIGJpbmRpbmdzIGNvZGUg Zm9yIEhUTUxTZWxlY3RFbGVtZW50LnJlbW92ZSgpIGFuZCB1c2UKKyAgICAgICAgb3ZlcmxvYWRp bmcgaW5zdGVhZC4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTSFRNTFNlbGVjdEVsZW1lbnRD dXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNIVE1MU2VsZWN0RWxlbWVudDo6cmVtb3Zl KTogRGVsZXRlZC4KKyAgICAgICAgKiBodG1sL0hUTUxTZWxlY3RFbGVtZW50LmlkbDoKKwogMjAx Ni0wOC0wMiAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIwMzc5OS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL0pTSFRNTFNlbGVjdEVsZW1lbnRDdXN0b20uY3BwIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvanMvSlNIVE1MU2VsZWN0RWxlbWVudEN1c3RvbS5jcHAKaW5kZXgg ZjcxMDkzNDM3MDBlZDczMWQ3ODJlYjc0ZGE4MTA2M2UxOWRmMjgxYS4uNDBkY2M0NjIzMzUyMGQ4 MTk3MGZlMWQ1ZGQ1OWYyYzlkYWZmMWU3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvanMvSlNIVE1MU2VsZWN0RWxlbWVudEN1c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvanMvSlNIVE1MU2VsZWN0RWxlbWVudEN1c3RvbS5jcHAKQEAgLTMyLDI2ICsz Miw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIHVzaW5nIG5hbWVzcGFjZSBKU0M7CiB1c2luZyBu YW1lc3BhY2UgSFRNTE5hbWVzOwogCi1KU1ZhbHVlIEpTSFRNTFNlbGVjdEVsZW1lbnQ6OnJlbW92 ZShFeGVjU3RhdGUmIHN0YXRlKQotewotICAgIEhUTUxTZWxlY3RFbGVtZW50JiBzZWxlY3QgPSB3 cmFwcGVkKCk7Ci0KLSAgICBpZiAoIXN0YXRlLmFyZ3VtZW50Q291bnQoKSkgewotICAgICAgICAv LyBXaGVuIGNhbGxlZCB3aXRoIG5vIGFyZ3VtZW50LCB3ZSBzaG91bGQgY2FsbCBFbGVtZW50Ojpy ZW1vdmUoKSB0byBkZXRhY2guCi0gICAgICAgIEV4Y2VwdGlvbkNvZGUgZWMgPSAwOwotICAgICAg ICBzZWxlY3QucmVtb3ZlKGVjKTsKLSAgICAgICAgc2V0RE9NRXhjZXB0aW9uKCZzdGF0ZSwgZWMp OwotICAgIH0gZWxzZSB7Ci0gICAgICAgIC8vIFRoZSBIVE1MU2VsZWN0RWxlbWVudDo6cmVtb3Zl KCkgZnVuY3Rpb24gY2FuIHRha2UgZWl0aGVyIGFuIG9wdGlvbiBvYmplY3Qgb3IgdGhlIGluZGV4 IG9mIGFuIG9wdGlvbi4KLSAgICAgICAgaWYgKEhUTUxPcHRpb25FbGVtZW50KiBvcHRpb24gPSBK U0hUTUxPcHRpb25FbGVtZW50Ojp0b1dyYXBwZWQoc3RhdGUuYXJndW1lbnQoMCkpKQotICAgICAg ICAgICAgc2VsZWN0LnJlbW92ZSgqb3B0aW9uKTsKLSAgICAgICAgZWxzZQotICAgICAgICAgICAg c2VsZWN0LnJlbW92ZUJ5SW5kZXgoc3RhdGUuYXJndW1lbnQoMCkudG9JbnQzMigmc3RhdGUpKTsK LSAgICB9Ci0KLSAgICByZXR1cm4ganNVbmRlZmluZWQoKTsKLX0KLQogdm9pZCBzZWxlY3RJbmRl eFNldHRlcihIVE1MU2VsZWN0RWxlbWVudCogc2VsZWN0LCBKU0M6OkV4ZWNTdGF0ZSogZXhlYywg dW5zaWduZWQgaW5kZXgsIEpTQzo6SlNWYWx1ZSB2YWx1ZSkKIHsKICAgICBpZiAodmFsdWUuaXNV bmRlZmluZWRPck51bGwoKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNl bGVjdEVsZW1lbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5p ZGwKaW5kZXggZDBkMjNiNzBkNGVlNjUwNjNkZmEyZjc4NTVjNTg5NjczNTc1YTlkNS4uZTI5MzNh NzVjZmIyNThlMzZjMDY1ZWZiMTE4YWZjNmFjNGY1ZWZiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MU2VsZWN0RWxlbWVudC5pZGwKQEAgLTU5LDEzICs1OSwxMSBAQAogICAgIC8vIHZvaWQg YWRkKChIVE1MT3B0aW9uRWxlbWVudCBvciBIVE1MT3B0R3JvdXBFbGVtZW50KSBlbGVtZW50LCBv cHRpb25hbCAoSFRNTEVsZW1lbnQgb3IgbG9uZyk/IGJlZm9yZSA9IG51bGwpOwogICAgIFtSYWlz ZXNFeGNlcHRpb25dIHZvaWQgYWRkKEhUTUxFbGVtZW50IGVsZW1lbnQsIGxvbmcgaW5kZXgpOwog ICAgIFtSYWlzZXNFeGNlcHRpb25dIHZvaWQgYWRkKEhUTUxFbGVtZW50IGVsZW1lbnQpOwotCi0g ICAgLy8gSW4gSmF2YVNjcmlwdCwgd2Ugc3VwcG9ydCBib3RoIG9wdGlvbiBpbmRleCBhbmQgb3B0 aW9uIG9iamVjdCBwYXJhbWV0ZXJzLgotICAgIC8vIEFzIG9mIHRoaXMgd3JpdGluZyB0aGlzIGNh bm5vdCBiZSBhdXRvLWdlbmVyYXRlZC4KLSAgICBbQ3VzdG9tXSB2b2lkIHJlbW92ZSgvKiBpbmRl eE9yT3B0aW9uICovKTsKLSNlbHNlCi0gICAgW0ltcGxlbWVudGVkQXM9cmVtb3ZlQnlJbmRleF0g dm9pZCByZW1vdmUobG9uZyBpbmRleCk7CiAjZW5kaWYKKyAgICBbUmFpc2VzRXhjZXB0aW9uXSB2 b2lkIHJlbW92ZSgpOyAvLyBDaGlsZE5vZGUgb3ZlcmxvYWQKKyAgICBbSW1wbGVtZW50ZWRBcz1y ZW1vdmVCeUluZGV4XSB2b2lkIHJlbW92ZShsb25nIGluZGV4KTsKKyAgICAvLyBGSVhNRTogVGhp cyBvdmVybG9hZCBpcyBub3QgaW4gdGhlIHNwZWNpZmljYXRpb24gYW5kIHdhcyBkcm9wcGVkIGlu IEJsaW5rLgorICAgIHZvaWQgcmVtb3ZlKEhUTUxPcHRpb25FbGVtZW50IG9wdGlvbik7CiAKICAg ICByZWFkb25seSBhdHRyaWJ1dGUgSFRNTENvbGxlY3Rpb24gc2VsZWN0ZWRPcHRpb25zOwogICAg IGF0dHJpYnV0ZSBsb25nIHNlbGVjdGVkSW5kZXg7Cg== 285164 2016-08-02 16:57:53 -0700 2016-08-02 19:57:41 -0700 Patch bug-160477-20160802165631.patch text/plain 3165 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0MDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjFmZjkzNzU2ODFlNzgw MjIxMmE1YzY0ZTBhOTMzNjIzNjgxOTc2MS4uNTBhMDczYmU4YzhiMDk1ZTIzY2YxNjczMDJiODZj OGY1OWY3ODk1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA4LTAyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRHJvcCBjdXN0b20gYmluZGlu Z3MgY29kZSBmb3IgSFRNTFNlbGVjdEVsZW1lbnQucmVtb3ZlKCkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDQ3NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERyb3AgY3VzdG9tIGJpbmRpbmdzIGNvZGUg Zm9yIEhUTUxTZWxlY3RFbGVtZW50LnJlbW92ZSgpIGFuZCB1c2UKKyAgICAgICAgb3ZlcmxvYWRp bmcgaW5zdGVhZC4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTSFRNTFNlbGVjdEVsZW1lbnRD dXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNIVE1MU2VsZWN0RWxlbWVudDo6cmVtb3Zl KTogRGVsZXRlZC4KKyAgICAgICAgKiBodG1sL0hUTUxTZWxlY3RFbGVtZW50LmlkbDoKKwogMjAx Ni0wOC0wMiAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIwMzc5OS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL0pTSFRNTFNlbGVjdEVsZW1lbnRDdXN0b20uY3BwIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvanMvSlNIVE1MU2VsZWN0RWxlbWVudEN1c3RvbS5jcHAKaW5kZXgg ZjcxMDkzNDM3MDBlZDczMWQ3ODJlYjc0ZGE4MTA2M2UxOWRmMjgxYS4uNDBkY2M0NjIzMzUyMGQ4 MTk3MGZlMWQ1ZGQ1OWYyYzlkYWZmMWU3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvanMvSlNIVE1MU2VsZWN0RWxlbWVudEN1c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvanMvSlNIVE1MU2VsZWN0RWxlbWVudEN1c3RvbS5jcHAKQEAgLTMyLDI2ICsz Miw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIHVzaW5nIG5hbWVzcGFjZSBKU0M7CiB1c2luZyBu YW1lc3BhY2UgSFRNTE5hbWVzOwogCi1KU1ZhbHVlIEpTSFRNTFNlbGVjdEVsZW1lbnQ6OnJlbW92 ZShFeGVjU3RhdGUmIHN0YXRlKQotewotICAgIEhUTUxTZWxlY3RFbGVtZW50JiBzZWxlY3QgPSB3 cmFwcGVkKCk7Ci0KLSAgICBpZiAoIXN0YXRlLmFyZ3VtZW50Q291bnQoKSkgewotICAgICAgICAv LyBXaGVuIGNhbGxlZCB3aXRoIG5vIGFyZ3VtZW50LCB3ZSBzaG91bGQgY2FsbCBFbGVtZW50Ojpy ZW1vdmUoKSB0byBkZXRhY2guCi0gICAgICAgIEV4Y2VwdGlvbkNvZGUgZWMgPSAwOwotICAgICAg ICBzZWxlY3QucmVtb3ZlKGVjKTsKLSAgICAgICAgc2V0RE9NRXhjZXB0aW9uKCZzdGF0ZSwgZWMp OwotICAgIH0gZWxzZSB7Ci0gICAgICAgIC8vIFRoZSBIVE1MU2VsZWN0RWxlbWVudDo6cmVtb3Zl KCkgZnVuY3Rpb24gY2FuIHRha2UgZWl0aGVyIGFuIG9wdGlvbiBvYmplY3Qgb3IgdGhlIGluZGV4 IG9mIGFuIG9wdGlvbi4KLSAgICAgICAgaWYgKEhUTUxPcHRpb25FbGVtZW50KiBvcHRpb24gPSBK U0hUTUxPcHRpb25FbGVtZW50Ojp0b1dyYXBwZWQoc3RhdGUuYXJndW1lbnQoMCkpKQotICAgICAg ICAgICAgc2VsZWN0LnJlbW92ZSgqb3B0aW9uKTsKLSAgICAgICAgZWxzZQotICAgICAgICAgICAg c2VsZWN0LnJlbW92ZUJ5SW5kZXgoc3RhdGUuYXJndW1lbnQoMCkudG9JbnQzMigmc3RhdGUpKTsK LSAgICB9Ci0KLSAgICByZXR1cm4ganNVbmRlZmluZWQoKTsKLX0KLQogdm9pZCBzZWxlY3RJbmRl eFNldHRlcihIVE1MU2VsZWN0RWxlbWVudCogc2VsZWN0LCBKU0M6OkV4ZWNTdGF0ZSogZXhlYywg dW5zaWduZWQgaW5kZXgsIEpTQzo6SlNWYWx1ZSB2YWx1ZSkKIHsKICAgICBpZiAodmFsdWUuaXNV bmRlZmluZWRPck51bGwoKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNl bGVjdEVsZW1lbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5p ZGwKaW5kZXggZDBkMjNiNzBkNGVlNjUwNjNkZmEyZjc4NTVjNTg5NjczNTc1YTlkNS4uYTk3ZGFj ZTc4OGFmNWY2MmM0NmIwYWZlMDJmNzQ1MWY0MDI1YzFiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MU2VsZWN0RWxlbWVudC5pZGwKQEAgLTYwLDEyICs2MCwxMiBAQAogICAgIFtSYWlzZXNF eGNlcHRpb25dIHZvaWQgYWRkKEhUTUxFbGVtZW50IGVsZW1lbnQsIGxvbmcgaW5kZXgpOwogICAg IFtSYWlzZXNFeGNlcHRpb25dIHZvaWQgYWRkKEhUTUxFbGVtZW50IGVsZW1lbnQpOwogCi0gICAg Ly8gSW4gSmF2YVNjcmlwdCwgd2Ugc3VwcG9ydCBib3RoIG9wdGlvbiBpbmRleCBhbmQgb3B0aW9u IG9iamVjdCBwYXJhbWV0ZXJzLgotICAgIC8vIEFzIG9mIHRoaXMgd3JpdGluZyB0aGlzIGNhbm5v dCBiZSBhdXRvLWdlbmVyYXRlZC4KLSAgICBbQ3VzdG9tXSB2b2lkIHJlbW92ZSgvKiBpbmRleE9y T3B0aW9uICovKTsKLSNlbHNlCi0gICAgW0ltcGxlbWVudGVkQXM9cmVtb3ZlQnlJbmRleF0gdm9p ZCByZW1vdmUobG9uZyBpbmRleCk7CisgICAgW1JhaXNlc0V4Y2VwdGlvbl0gdm9pZCByZW1vdmUo KTsgLy8gQ2hpbGROb2RlIG92ZXJsb2FkCisgICAgLy8gRklYTUU6IFRoaXMgb3ZlcmxvYWQgaXMg bm90IGluIHRoZSBzcGVjaWZpY2F0aW9uIGFuZCB3YXMgZHJvcHBlZCBpbiBCbGluay4KKyAgICB2 b2lkIHJlbW92ZShIVE1MT3B0aW9uRWxlbWVudCBvcHRpb24pOwogI2VuZGlmCisgICAgW0ltcGxl bWVudGVkQXM9cmVtb3ZlQnlJbmRleF0gdm9pZCByZW1vdmUobG9uZyBpbmRleCk7CisKIAogICAg IHJlYWRvbmx5IGF0dHJpYnV0ZSBIVE1MQ29sbGVjdGlvbiBzZWxlY3RlZE9wdGlvbnM7CiAgICAg YXR0cmlidXRlIGxvbmcgc2VsZWN0ZWRJbmRleDsK