160468 2016-08-02 15:02:52 -0700 Remove unused functions in URL 2016-08-02 15:32:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen commit-queue oldest_to_newest 1216615 0 achristensen 2016-08-02 15:02:52 -0700 Remove unused functions in URL 1216616 1 285144 achristensen 2016-08-02 15:03:23 -0700 Created attachment 285144 Patch 1216618 2 285144 ggaren 2016-08-02 15:04:54 -0700 Comment on attachment 285144 Patch r=me Do we have TestWebKitAPI tests for URL? 1216620 3 commit-queue 2016-08-02 15:04:58 -0700 Attachment 285144 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style. 1216622 4 achristensen 2016-08-02 15:05:33 -0700 (In reply to comment #2) > Do we have TestWebKitAPI tests for URL? We have a few such tests. 1216625 5 285144 darin 2016-08-02 15:09:42 -0700 Comment on attachment 285144 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285144&action=review > Source/WebCore/platform/URL.h:-198 > - void print() const; This function is intended to be used in the debugger. How did you determine it was unused? 1216627 6 achristensen 2016-08-02 15:12:25 -0700 (In reply to comment #5) > Comment on attachment 285144 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=285144&action=review > > > Source/WebCore/platform/URL.h:-198 > > - void print() const; > > This function is intended to be used in the debugger. How did you determine > it was unused? I searched for print() and found no call sites. I could leave it if you think it's useful 1216636 7 achristensen 2016-08-02 15:32:10 -0700 https://trac.webkit.org/changeset/204046 I left the print function in. Not everybody debugs exactly like I do :) 285144 2016-08-02 15:03:23 -0700 2016-08-02 15:04:54 -0700 Patch bug-160468-20160802150201.patch text/plain 3133 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNDA0MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE2LTA4LTAyICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHVu dXNlZCBmdW5jdGlvbnMgaW4gVVJMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNjA0NjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAgICAgICAqIHBhZ2UvU2Vj dXJpdHlPcmlnaW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2VjdXJpdHlPcmlnaW46OmV4dHJh Y3RJbm5lclVSTCk6CisgICAgICAgICogcGxhdGZvcm0vVVJMLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OmlzVmFsaWRQcm90b2NvbCk6CisgICAgICAgIChXZWJDb3JlOjpVUkw6OnN0cmlwcGVkRm9y VXNlQXNSZWZlcnJlcik6CisgICAgICAgIChXZWJDb3JlOjptaW1lVHlwZUZyb21VUkwpOgorICAg ICAgICAoV2ViQ29yZTo6VVJMOjpzdHJpbmdDZW50ZXJFbGxpcHNpemVkVG9MZW5ndGgpOgorICAg ICAgICAoV2ViQ29yZTo6VVJMOjpwcmludCk6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpV Ukw6OmlzU2FmZVRvU2VuZFRvQW5vdGhlclRocmVhZCk6IERlbGV0ZWQuCisgICAgICAgICogcGxh dGZvcm0vVVJMLmg6CisgICAgICAgIChXZWJDb3JlOjpVUkw6Om9wZXJhdG9yIE5TU3RyaW5nKik6 CisgICAgICAgIChXZWJDb3JlOjpVUkw6OmlubmVyVVJMKTogRGVsZXRlZC4KKwogMjAxNi0wOC0w MiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWJJRExdIEV4 dGVuZCBuZXcgb3ZlcmxvYWQgcmVzb2x1dGlvbiBhbGdvcml0aG0gc3VwcG9ydCB0byBjb25zdHJ1 Y3RvcnMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvU2VjdXJpdHlPcmlnaW4uY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvU2VjdXJpdHlPcmlnaW4uY3BwCShyZXZpc2lv biAyMDQwMzcpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL1NlY3VyaXR5T3JpZ2luLmNwcAkod29y a2luZyBjb3B5KQpAQCAtNjcsOCArNjcsNiBAQCBib29sIFNlY3VyaXR5T3JpZ2luOjpzaG91bGRV c2VJbm5lclVSTChjCiAvLyBzZWN1cml0eSBvcmlnaW4gY2FuIGJlIHBhcnNlZCB1c2luZyB0aGlz IGFsZ29yaXRobS4KIFVSTCBTZWN1cml0eU9yaWdpbjo6ZXh0cmFjdElubmVyVVJMKGNvbnN0IFVS TCYgdXJsKQogewotICAgIGlmICh1cmwuaW5uZXJVUkwoKSkKLSAgICAgICAgcmV0dXJuICp1cmwu aW5uZXJVUkwoKTsKICAgICAvLyBGSVhNRTogVXBkYXRlIHRoaXMgY2FsbHNpdGUgdG8gdXNlIHRo ZSBpbm5lclVSTCBtZW1iZXIgZnVuY3Rpb24gd2hlbgogICAgIC8vIHdlIGZpbmlzaCBpbXBsZW1l bnRpbmcgaXQuCiAgICAgcmV0dXJuIFVSTChQYXJzZWRVUkxTdHJpbmcsIGRlY29kZVVSTEVzY2Fw ZVNlcXVlbmNlcyh1cmwucGF0aCgpKSk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9V UkwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VSTC5jcHAJKHJl dmlzaW9uIDIwNDAzNykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VSTC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTIwNzAsMTMgKzIwNzAsNiBAQCBib29sIGlzVmFsaWRQcm90b2NvbChjb25z dCBTdHJpbmcmIHByb3RvCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKLSNpZm5kZWYgTkRFQlVHCi12 b2lkIFVSTDo6cHJpbnQoKSBjb25zdAotewotICAgIHByaW50ZigiJXNcbiIsIG1fc3RyaW5nLnV0 ZjgoKS5kYXRhKCkpOwotfQotI2VuZGlmCi0KIFN0cmluZyBVUkw6OnN0cmlwcGVkRm9yVXNlQXNS ZWZlcnJlcigpIGNvbnN0CiB7CiAgICAgVVJMIHJlZmVycmVyKCp0aGlzKTsKQEAgLTIyNzksMTEg KzIyNzIsNiBAQCBTdHJpbmcgbWltZVR5cGVGcm9tVVJMKGNvbnN0IFVSTCYgdXJsKQogICAgIHJl dHVybiBNSU1FVHlwZVJlZ2lzdHJ5OjpnZXRNSU1FVHlwZUZvckV4dGVuc2lvbihleHRlbnNpb24p OwogfQogCi1ib29sIFVSTDo6aXNTYWZlVG9TZW5kVG9Bbm90aGVyVGhyZWFkKCkgY29uc3QKLXsK LSAgICByZXR1cm4gbV9zdHJpbmcuaXNTYWZlVG9TZW5kVG9Bbm90aGVyVGhyZWFkKCk7Ci19Ci0K IFN0cmluZyBVUkw6OnN0cmluZ0NlbnRlckVsbGlwc2l6ZWRUb0xlbmd0aCh1bnNpZ25lZCBsZW5n dGgpIGNvbnN0CiB7CiAgICAgaWYgKHN0cmluZygpLmxlbmd0aCgpIDw9IGxlbmd0aCkKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VSTC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL1VSTC5oCShyZXZpc2lvbiAyMDQwMzcpCisrKyBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9VUkwuaAkod29ya2luZyBjb3B5KQpAQCAtMTkyLDE0ICsxOTIsNiBAQCBwdWJsaWM6 CiAgICAgb3BlcmF0b3IgTlNTdHJpbmcqKCkgY29uc3QgeyByZXR1cm4gc3RyaW5nKCk7IH0KICNl bmRpZgogCi0gICAgY29uc3QgVVJMKiBpbm5lclVSTCgpIGNvbnN0IHsgcmV0dXJuIDA7IH0KLQot I2lmbmRlZiBOREVCVUcKLSAgICB2b2lkIHByaW50KCkgY29uc3Q7Ci0jZW5kaWYKLQotICAgIGJv b2wgaXNTYWZlVG9TZW5kVG9Bbm90aGVyVGhyZWFkKCkgY29uc3Q7Ci0KICAgICB0ZW1wbGF0ZSA8 Y2xhc3MgRW5jb2Rlcj4gdm9pZCBlbmNvZGUoRW5jb2RlciYpIGNvbnN0OwogICAgIHRlbXBsYXRl IDxjbGFzcyBEZWNvZGVyPiBzdGF0aWMgYm9vbCBkZWNvZGUoRGVjb2RlciYsIFVSTCYpOwogCg==