160456 2016-08-02 10:33:17 -0700 HTMLCollection's named getter should only do 'name' attribute matching for HTMLElements 2016-08-02 12:15:08 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED WebExposed P2 Normal --- 1 cdumez cdumez cdumez commit-queue darin dbates esprehn+autocc gyuyoung.kim koivisto rniwa sam oldest_to_newest 1216521 0 cdumez 2016-08-02 10:33:17 -0700 HTMLCollection's named getter should only do 'name' attribute matching for HTMLElements: - https://dom.spec.whatwg.org/#dom-htmlcollection-nameditem Our slow path which relies on HTMLCollection::updateNamedElementCache() does the right thing. However, we have a fast path in CachedHTMLCollection<HTMLCollectionClass, traversalType>::namedItem() that is missing a check. Firefox and Chrome both behave correctly here. 1216524 1 285119 cdumez 2016-08-02 10:41:42 -0700 Created attachment 285119 Patch 1216527 2 285119 cdumez 2016-08-02 10:50:17 -0700 Comment on attachment 285119 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285119&action=review > LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt:11 > +FAIL hasOwnProperty, getOwnPropertyDescriptor, getOwnPropertyNames assert_true: desc.configurable expected true got false This is due to https://bugs.webkit.org/show_bug.cgi?id=160457 1216556 3 285119 cdumez 2016-08-02 12:15:02 -0700 Comment on attachment 285119 Patch Clearing flags on attachment: 285119 Committed r204034: <http://trac.webkit.org/changeset/204034> 1216557 4 cdumez 2016-08-02 12:15:08 -0700 All reviewed patches have been landed. Closing bug. 285119 2016-08-02 10:41:42 -0700 2016-08-02 12:15:02 -0700 Patch bug-160456-20160802104021.patch text/plain 5168 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0MDI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWJhM2ZkYjQzODBmODcz YzBmNDdiYTJiOWNiZjJmZTllZjVlZWYxYy4uZjMwYzU0MDhhNDZlZWQ3OWE2Mzc5NjQyM2E0ZTlh ODMxZGI4OWNhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE2LTA4LTAyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgSFRNTENvbGxlY3Rpb24ncyBu YW1lZCBnZXR0ZXIgc2hvdWxkIG9ubHkgZG8gJ25hbWUnIGF0dHJpYnV0ZSBtYXRjaGluZyBmb3Ig SFRNTEVsZW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNjA0NTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBIVE1MQ29sbGVjdGlvbidzIG5hbWVkIGdldHRlciBzaG91bGQgb25seSBkbyAnbmFtZScg YXR0cmlidXRlIG1hdGNoaW5nIGZvciBIVE1MRWxlbWVudHM6CisgICAgICAgIC0gaHR0cHM6Ly9k b20uc3BlYy53aGF0d2cub3JnLyNkb20taHRtbGNvbGxlY3Rpb24tbmFtZWRpdGVtCisKKyAgICAg ICAgT3VyIHNsb3cgcGF0aCB3aGljaCByZWxpZXMgb24gSFRNTENvbGxlY3Rpb246OnVwZGF0ZU5h bWVkRWxlbWVudENhY2hlKCkgZG9lcyB0aGUgcmlnaHQKKyAgICAgICAgdGhpbmcuIEhvd2V2ZXIs IHdlIGhhdmUgYSBmYXN0IHBhdGggaW4gCisgICAgICAgIENhY2hlZEhUTUxDb2xsZWN0aW9uPEhU TUxDb2xsZWN0aW9uQ2xhc3MsIHRyYXZlcnNhbFR5cGU+OjpuYW1lZEl0ZW0oKSB0aGF0IHdhcyBt aXNzaW5nIGEKKyAgICAgICAgY2hlY2suCisKKyAgICAgICAgRmlyZWZveCBhbmQgQ2hyb21lIGJv dGggYmVoYXZlIGNvcnJlY3RseSBoZXJlLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgcmViYXNl bGluZWQgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBodG1sL0NhY2hlZEhUTUxDb2xsZWN0 aW9uLmg6CisgICAgICAgIChXZWJDb3JlOjp0cmF2ZXJzYWxUeXBlPjo6bmFtZWRJdGVtKToKKwog MjAxNi0wOC0wMiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAg UmVtb3ZlIENhY2hlZFJlc291cmNlUmVxdWVzdCBpbml0aWF0aW5nRG9jdW1lbnRMb2FkZXIKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvQ2FjaGVkSFRNTENvbGxlY3Rpb24uaCBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvQ2FjaGVkSFRNTENvbGxlY3Rpb24uaAppbmRleCBhN2ZmM2EwYWM1 ZGExNTE1MDlmZTYzNDQxYjc1ZDU4MDMyZmM0MWFjLi5lZDdiYWQ2YWQ5NzYyMWQzMDc3MDhiYWY2 NTUzYjUwZDc0ODZmM2M5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0NhY2hlZEhU TUxDb2xsZWN0aW9uLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9DYWNoZWRIVE1MQ29sbGVj dGlvbi5oCkBAIC0xMzYsOSArMTM2LDEyIEBAIEVsZW1lbnQqIENhY2hlZEhUTUxDb2xsZWN0aW9u PEhUTUxDb2xsZWN0aW9uQ2xhc3MsIHRyYXZlcnNhbFR5cGU+OjpuYW1lZEl0ZW0oY29uCiAgICAg ICAgICAgICAgICAgY2FuZGlkYXRlID0gdHJlZVNjb3BlLmdldEVsZW1lbnRCeUlkKG5hbWUpOwog ICAgICAgICB9IGVsc2UgaWYgKHRyZWVTY29wZS5oYXNFbGVtZW50V2l0aE5hbWUoKm5hbWUuaW1w bCgpKSkgewogICAgICAgICAgICAgaWYgKCF0cmVlU2NvcGUuY29udGFpbnNNdWx0aXBsZUVsZW1l bnRzV2l0aE5hbWUobmFtZSkpIHsKLSAgICAgICAgICAgICAgICBjYW5kaWRhdGUgPSB0cmVlU2Nv cGUuZ2V0RWxlbWVudEJ5TmFtZShuYW1lKTsKLSAgICAgICAgICAgICAgICBpZiAoY2FuZGlkYXRl ICYmIHR5cGUoKSA9PSBEb2NBbGwgJiYgIW5hbWVTaG91bGRCZVZpc2libGVJbkRvY3VtZW50QWxs KCpjYW5kaWRhdGUpKQotICAgICAgICAgICAgICAgICAgICBjYW5kaWRhdGUgPSBudWxscHRyOwor ICAgICAgICAgICAgICAgIGlmICgoY2FuZGlkYXRlID0gdHJlZVNjb3BlLmdldEVsZW1lbnRCeU5h bWUobmFtZSkpKSB7CisgICAgICAgICAgICAgICAgICAgIGlmICghaXM8SFRNTEVsZW1lbnQ+KCpj YW5kaWRhdGUpKQorICAgICAgICAgICAgICAgICAgICAgICAgY2FuZGlkYXRlID0gbnVsbHB0cjsK KyAgICAgICAgICAgICAgICAgICAgZWxzZSBpZiAodHlwZSgpID09IERvY0FsbCAmJiAhbmFtZVNo b3VsZEJlVmlzaWJsZUluRG9jdW1lbnRBbGwoKmNhbmRpZGF0ZSkpCisgICAgICAgICAgICAgICAg ICAgICAgICBjYW5kaWRhdGUgPSBudWxscHRyOworICAgICAgICAgICAgICAgIH0KICAgICAgICAg ICAgIH0KICAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICByZXR1cm4gbnVsbHB0cjsKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9p bXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IDY3M2ViOGJhZTUwNGJkZGFiYWRjZGI4ZmUzYjUy YzI2YmJmMzQzM2EuLmUzMGFmYmM5MmQ3Y2NiNThkMzFlNWM2NjdmZWM3YWUxMTViZTZkNzAgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0 VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA4LTAy ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgSFRNTENvbGxlY3Rp b24ncyBuYW1lZCBnZXR0ZXIgc2hvdWxkIG9ubHkgZG8gJ25hbWUnIGF0dHJpYnV0ZSBtYXRjaGlu ZyBmb3IgSFRNTEVsZW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNjA0NTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9kb20vbm9kZXMvRG9jdW1lbnQtZ2V0RWxl bWVudHNCeVRhZ05hbWUtZXhwZWN0ZWQudHh0OgorICAgICAgICBSZWJhc2VsaW5lLiBXZSBhcmUg c3RpbGwgZmFpbGluZyBidXQgb24gdGhlIG5leHQgY2hlY2suCisKKyAgICAgICAgKiB3ZWItcGxh dGZvcm0tdGVzdHMvZG9tL25vZGVzL0VsZW1lbnQtY2hpbGRyZW4tZXhwZWN0ZWQudHh0OgorICAg ICAgICBSZWJhc2VsaW5lIG5vdyB0aGF0IG9uZSBtb3JlIGNoZWNrIGlzIHBhc3NpbmcuCisKIDIw MTYtMDgtMDIgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFNr aXAgZmV0Y2ggQVBJIHdvcmtlciB0ZXN0cyBpbiBEZWJ1ZyBtb2RlCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9ub2Rlcy9Eb2N1bWVu dC1nZXRFbGVtZW50c0J5VGFnTmFtZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9ub2Rlcy9Eb2N1bWVudC1nZXRFbGVtZW50c0J5 VGFnTmFtZS1leHBlY3RlZC50eHQKaW5kZXggMDc1NmRiYmNkNGQ3NmY5ZDAzYTJlM2RiODVmYjY1 NGQ3MjZmOTAyMS4uYzBmMGFlZDUwZWUzZDlkNDU4ZmI3YmI4MGNlMTMzNTExNzdkNjllMCAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9kb20v bm9kZXMvRG9jdW1lbnQtZ2V0RWxlbWVudHNCeVRhZ05hbWUtZXhwZWN0ZWQudHh0CisrKyBiL0xh eW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZG9tL25vZGVzL0RvY3Vt ZW50LWdldEVsZW1lbnRzQnlUYWdOYW1lLWV4cGVjdGVkLnR4dApAQCAtOCw3ICs4LDcgQEAgRkFJ TCBTaG91bGRuJ3QgYmUgYWJsZSB0byBzZXQgdW5zaWduZWQgcHJvcGVydGllcyBvbiBhIEhUTUxD b2xsZWN0aW9uIChzdHJpY3QgbW8KICAgICB9IiBkaWQgbm90IHRocm93CiBQQVNTIFNob3VsZCBi ZSBhYmxlIHRvIHNldCBleHBhbmRvIHNoYWRvd2luZyBhIHByb3RvIHByb3AgKGl0ZW0pIAogUEFT UyBTaG91bGQgYmUgYWJsZSB0byBzZXQgZXhwYW5kbyBzaGFkb3dpbmcgYSBwcm90byBwcm9wIChu YW1lZEl0ZW0pIAotRkFJTCBoYXNPd25Qcm9wZXJ0eSwgZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9y LCBnZXRPd25Qcm9wZXJ0eU5hbWVzIGFzc2VydF9mYWxzZTogZXhwZWN0ZWQgZmFsc2UgZ290IHRy dWUKK0ZBSUwgaGFzT3duUHJvcGVydHksIGdldE93blByb3BlcnR5RGVzY3JpcHRvciwgZ2V0T3du UHJvcGVydHlOYW1lcyBhc3NlcnRfdHJ1ZTogZGVzYy5jb25maWd1cmFibGUgZXhwZWN0ZWQgdHJ1 ZSBnb3QgZmFsc2UKIFBBU1MgSFRNTCBlbGVtZW50IHdpdGggdXBwZXJjYXNlIHRhZ05hbWUgbmV2 ZXIgbWF0Y2hlcyBpbiBIVE1MIERvY3VtZW50cyAKIFBBU1MgRWxlbWVudCBpbiBub24tSFRNTCBu YW1lc3BhY2UsIG5vIHByZWZpeCwgbG93ZXJjYXNlIG5hbWUgCiBQQVNTIEVsZW1lbnQgaW4gbm9u LUhUTUwgbmFtZXNwYWNlLCBubyBwcmVmaXgsIHVwcGVyY2FzZSBuYW1lIApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9kb20vbm9kZXMvRWxl bWVudC1jaGlsZHJlbi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2Vi LXBsYXRmb3JtLXRlc3RzL2RvbS9ub2Rlcy9FbGVtZW50LWNoaWxkcmVuLWV4cGVjdGVkLnR4dApp bmRleCBkNDE4NmJlNDZhZWUzYjQwN2ZkODQyNzk0MjlmYzI5M2IyMzg0ODVlLi5kNjEwMTEyZjk1 OWRiNjI4MjJmNzA1ZTM0ZGZlNWI4YWY0YzI4MzQxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9p bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9ub2Rlcy9FbGVtZW50LWNoaWxkcmVu LWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3Jt LXRlc3RzL2RvbS9ub2Rlcy9FbGVtZW50LWNoaWxkcmVuLWV4cGVjdGVkLnR4dApAQCAtMSw1ICsx LDUgQEAKIAogCiBQQVNTIEhUTUxDb2xsZWN0aW9uIGVkZ2UgY2FzZXMgCi1GQUlMIEhUTUxDb2xs ZWN0aW9uIGVkZ2UgY2FzZXMgMSBhc3NlcnRfZmFsc2U6IGV4cGVjdGVkIGZhbHNlIGdvdCB0cnVl CitQQVNTIEhUTUxDb2xsZWN0aW9uIGVkZ2UgY2FzZXMgMSAKIAo=