160439 2016-08-01 20:21:15 -0700 [JSC][ARM64] Fix branchTest32/64 taking an immediate as mask 2016-08-01 22:03:51 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin cdumez cmarcelo commit-queue fpizlo keith_miller mark.lam msaboff saam oldest_to_newest 1216358 0 benjamin 2016-08-01 20:21:15 -0700 [JSC][ARM64] Fix branchTest32/64 taking an immediate as mask 1216359 1 285066 benjamin 2016-08-01 20:23:36 -0700 Created attachment 285066 Patch 1216379 2 285066 fpizlo 2016-08-01 21:39:24 -0700 Comment on attachment 285066 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285066&action=review > Source/WTF/wtf/MathExtras.h:222 > + typedef typename std::make_unsigned<T>::type UnsignedT; > unsigned result = 0; > > - while (value >>= 1) > + UnsignedT unsignedValue = static_cast<UnsignedT>(value); > + while (unsignedValue >>= 1) lol 1216384 3 285066 commit-queue 2016-08-01 22:03:46 -0700 Comment on attachment 285066 Patch Clearing flags on attachment: 285066 Committed r204009: <http://trac.webkit.org/changeset/204009> 1216385 4 commit-queue 2016-08-01 22:03:51 -0700 All reviewed patches have been landed. Closing bug. 285066 2016-08-01 20:23:36 -0700 2016-08-01 22:03:46 -0700 Patch bug-160439-20160801202216.patch text/plain 4742 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0MDA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 OTg2YTIyYTFlMGM2ODRiM2RhNDA4MDI1NGVmMjM3ZjRkOTJlYzM2Li5mZDIxY2YzNmJiYTkxZDNl Mjc0MGNhN2VmYWJiZjQ3NzBmNmQyNTg3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNi0wOC0wMSAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBbSlNDXVtBUk02NF0gRml4IGJyYW5jaFRlc3QzMi82NCB0YWtpbmcg YW4gaW1tZWRpYXRlIGFzIG1hc2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2MDQzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNNjQuaDoKKyAgICAgICAg KEpTQzo6TWFjcm9Bc3NlbWJsZXJBUk02NDo6YnJhbmNoVGVzdDY0KToKKyAgICAgICAgKiBiMy9h aXIvQWlyT3Bjb2RlLm9wY29kZXM6CisgICAgICAgIEZpeCB0aGUgQVJNNjQgY29kZWdlbiB0byBs b3dlciBCaXRJbW02NCB3aXRob3V0IHVzaW5nIGEgc2NyYXRjaCByZWdpc3Rlci4KKwogMjAxNi0w Ny0yMiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFtCM10gRnVz aW5nIGltbWVkaWF0ZXMgaW50byB0ZXN0IGluc3RydWN0aW9ucyBzaG91bGQgd29yayBhZ2Fpbgpk aWZmIC0tZ2l0IGEvU291cmNlL1dURi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpp bmRleCA1OGQ3N2Y5MDUxM2U2NzNjZWM3YmJkZTA3MzNiZDE1NDViYzYyMGNjLi43NDUxNDA3Yjdm YTE4YjMzZjllNDlhNDhlMjFmODU3MzdkNTI1ODQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2 LTA4LTAxICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAg IFtKU0NdW0FSTTY0XSBGaXggYnJhbmNoVGVzdDMyLzY0IHRha2luZyBhbiBpbW1lZGlhdGUgYXMg bWFzaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYw NDM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3 dGYvTWF0aEV4dHJhcy5oOgorICAgICAgICAoZ2V0TFNCU2V0KToKKyAgICAgICAgVGhpcyB3YXMg bm90IHdvcmtpbmcgYXQgYWxsIGZvciBNYWNyb0Fzc2VtYmxlci4KKyAgICAgICAgU2luY2UgVHJ1 c3RlZEltbTMyLzY0IGFyZSBzaWduZWQgaW50ZWdlcnMsIHRoZSBhcml0aG1ldGljIHNoaWZ0IHdv dWxkCisgICAgICAgIG5ldmVyIGdldCByaWQgb2YgdGhlIHRvcCBiaXQgYW5kIHdlIGdldCBhbiBp bmZpbml0ZSBsb29wLgorCiAyMDE2LTA3LTI5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KIAogICAgICAgICBNYWtlIFN0cmluZ1ZpZXcgY2FwYWJsZSBvZiBiZWluZyBwYXNzZWQgb3Ig cmV0dXJuZWQgaW4gb25seSAyIHJlZ2lzdGVycy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk02NC5oIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTTY0LmgKaW5kZXggOTZmODYyZDkxNTll OGU2YjRhMjU3N2I5ODVhMDk0MzhjOTZkZWIyMC4uNzFmNDM4N2FiNGEzNjBhY2VmMTEzMGFjNjVm OWE3NWU5MDdhOWYxNiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxl ci9NYWNyb0Fzc2VtYmxlckFSTTY0LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2Vt Ymxlci9NYWNyb0Fzc2VtYmxlckFSTTY0LmgKQEAgLTI1MjAsOCArMjUyMCwyNCBAQCBwdWJsaWM6 CiAKICAgICBKdW1wIGJyYW5jaFRlc3Q2NChSZXN1bHRDb25kaXRpb24gY29uZCwgUmVnaXN0ZXJJ RCByZWcsIFRydXN0ZWRJbW02NCBtYXNrKQogICAgIHsKLSAgICAgICAgbW92ZShtYXNrLCBnZXRD YWNoZWREYXRhVGVtcFJlZ2lzdGVySURBbmRJbnZhbGlkYXRlKCkpOwotICAgICAgICByZXR1cm4g YnJhbmNoVGVzdDY0KGNvbmQsIHJlZywgZGF0YVRlbXBSZWdpc3Rlcik7CisgICAgICAgIGlmICht YXNrLm1fdmFsdWUgPT0gLTEpIHsKKyAgICAgICAgICAgIGlmICgoY29uZCA9PSBaZXJvKSB8fCAo Y29uZCA9PSBOb25aZXJvKSkKKyAgICAgICAgICAgICAgICByZXR1cm4gSnVtcChtYWtlQ29tcGFy ZUFuZEJyYW5jaDw2ND4oc3RhdGljX2Nhc3Q8WmVyb0NvbmRpdGlvbj4oY29uZCksIHJlZykpOwor ICAgICAgICAgICAgbV9hc3NlbWJsZXIudHN0PDY0PihyZWcsIHJlZyk7CisgICAgICAgIH0gZWxz ZSBpZiAoaGFzT25lQml0U2V0KG1hc2subV92YWx1ZSkgJiYgKChjb25kID09IFplcm8pIHx8IChj b25kID09IE5vblplcm8pKSkKKyAgICAgICAgICAgIHJldHVybiBKdW1wKG1ha2VUZXN0Qml0QW5k QnJhbmNoKHJlZywgZ2V0TFNCU2V0KG1hc2subV92YWx1ZSksIHN0YXRpY19jYXN0PFplcm9Db25k aXRpb24+KGNvbmQpKSk7CisgICAgICAgIGVsc2UgeworICAgICAgICAgICAgTG9naWNhbEltbWVk aWF0ZSBsb2dpY2FsSW1tID0gTG9naWNhbEltbWVkaWF0ZTo6Y3JlYXRlNjQobWFzay5tX3ZhbHVl KTsKKworICAgICAgICAgICAgaWYgKGxvZ2ljYWxJbW0uaXNWYWxpZCgpKSB7CisgICAgICAgICAg ICAgICAgbV9hc3NlbWJsZXIudHN0PDY0PihyZWcsIGxvZ2ljYWxJbW0pOworICAgICAgICAgICAg ICAgIHJldHVybiBKdW1wKG1ha2VCcmFuY2goY29uZCkpOworICAgICAgICAgICAgfQorCisgICAg ICAgICAgICBtb3ZlKG1hc2ssIGdldENhY2hlZERhdGFUZW1wUmVnaXN0ZXJJREFuZEludmFsaWRh dGUoKSk7CisgICAgICAgICAgICBtX2Fzc2VtYmxlci50c3Q8NjQ+KHJlZywgZGF0YVRlbXBSZWdp c3Rlcik7CisgICAgICAgIH0KKyAgICAgICAgcmV0dXJuIEp1bXAobWFrZUJyYW5jaChjb25kKSk7 CiAgICAgfQogCiAgICAgSnVtcCBicmFuY2hUZXN0NjQoUmVzdWx0Q29uZGl0aW9uIGNvbmQsIEFk ZHJlc3MgYWRkcmVzcywgUmVnaXN0ZXJJRCBtYXNrKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2IzL2Fpci9BaXJPcGNvZGUub3Bjb2RlcyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9iMy9haXIvQWlyT3Bjb2RlLm9wY29kZXMKaW5kZXggZTI5YzdlYzlhYzgxMjZhOTdiYmE2OTcx NTU4OWRhMTQxOGFhNTk1Zi4uYTQyODQ3NjljYjA3ODM3YzQ3MjZmMGVmMGY2NjE1YTcxMzM5ZDEx MSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL2Fpci9BaXJPcGNvZGUub3Bj b2RlcworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0Fpck9wY29kZS5vcGNvZGVz CkBAIC02ODAsNyArNjgwLDcgQEAgQnJhbmNoVGVzdDggVTpHOjMyLCBVOkc6OCwgVTpHOjggL2Jy YW5jaAogCiBCcmFuY2hUZXN0MzIgVTpHOjMyLCBVOkc6MzIsIFU6RzozMiAvYnJhbmNoCiAgICAg UmVzQ29uZCwgVG1wLCBUbXAKLSAgICB4ODY6IFJlc0NvbmQsIFRtcCwgQml0SW1tCisgICAgUmVz Q29uZCwgVG1wLCBCaXRJbW0KICAgICB4ODY6IFJlc0NvbmQsIEFkZHIsIEJpdEltbQogICAgIHg4 NjogUmVzQ29uZCwgSW5kZXgsIEJpdEltbQogCkBAIC02ODgsNiArNjg4LDcgQEAgQnJhbmNoVGVz dDMyIFU6RzozMiwgVTpHOjMyLCBVOkc6MzIgL2JyYW5jaAogIyBCcmFuY2hUZXN0MzIgaW4gbW9z dCBjYXNlcyB3aGVyZSB5b3UgdXNlIGFuIGltbWVkaWF0ZS4KIDY0OiBCcmFuY2hUZXN0NjQgVTpH OjMyLCBVOkc6NjQsIFU6Rzo2NCAvYnJhbmNoCiAgICAgUmVzQ29uZCwgVG1wLCBUbXAKKyAgICBh cm02NDogUmVzQ29uZCwgVG1wLCBCaXRJbW02NAogICAgIHg4NjogUmVzQ29uZCwgVG1wLCBCaXRJ bW0KICAgICB4ODY6IFJlc0NvbmQsIEFkZHIsIEJpdEltbQogICAgIHg4NjogUmVzQ29uZCwgQWRk ciwgVG1wCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9NYXRoRXh0cmFzLmggYi9Tb3VyY2Uv V1RGL3d0Zi9NYXRoRXh0cmFzLmgKaW5kZXggZGM2OTM4NTk1YTA4YjUzNDIzNzYzNTg1ZDQ1Y2Zm NTJmNjg5NDE1MS4uOGExMThlYzE4YWQ5MDFhOWU3NGZjODdmM2M0OWViZTEzMDhmYTc3ZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dURi93dGYvTWF0aEV4dHJhcy5oCisrKyBiL1NvdXJjZS9XVEYvd3Rm L01hdGhFeHRyYXMuaApAQCAtMjE1LDkgKzIxNSwxMSBAQCB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBp bmxpbmUgYm9vbCBoYXNUd29Pck1vcmVCaXRzU2V0KFQgdmFsdWUpCiAKIHRlbXBsYXRlIDx0eXBl bmFtZSBUPiBpbmxpbmUgdW5zaWduZWQgZ2V0TFNCU2V0KFQgdmFsdWUpCiB7CisgICAgdHlwZWRl ZiB0eXBlbmFtZSBzdGQ6Om1ha2VfdW5zaWduZWQ8VD46OnR5cGUgVW5zaWduZWRUOwogICAgIHVu c2lnbmVkIHJlc3VsdCA9IDA7CiAKLSAgICB3aGlsZSAodmFsdWUgPj49IDEpCisgICAgVW5zaWdu ZWRUIHVuc2lnbmVkVmFsdWUgPSBzdGF0aWNfY2FzdDxVbnNpZ25lZFQ+KHZhbHVlKTsKKyAgICB3 aGlsZSAodW5zaWduZWRWYWx1ZSA+Pj0gMSkKICAgICAgICAgKytyZXN1bHQ7CiAKICAgICByZXR1 cm4gcmVzdWx0Owo=