16043 2007-11-18 14:44:32 -0800 Remove InspectorController.log now that console.log works 2007-11-18 15:04:43 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P3 Trivial --- 1 timothy timothy oldest_to_newest 61594 0 timothy 2007-11-18 14:44:32 -0800 The InspectorController had a log function for when there was no working console in the engine. Now that console works in the Inspector, we can remove InspectorController.log and move to console. There are only two remaining places where InspectorController.log is used. 61595 1 17370 timothy 2007-11-18 14:46:39 -0800 Created attachment 17370 Patch 61598 2 17370 sam 2007-11-18 15:03:21 -0800 Comment on attachment 17370 Patch r=me 61599 3 timothy 2007-11-18 15:04:43 -0800 Landed in r27893. http://trac.webkit.org/projects/webkit/changeset/27893 17370 2007-11-18 14:46:39 -0800 2007-11-18 15:03:21 -0800 Patch 16043.patch text/plain 4406 timothy SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI3ODkx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMDctMTEt MTggIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAxNjA0MzogUmVtb3ZlIEluc3Bl Y3RvckNvbnRyb2xsZXIubG9nIG5vdyB0aGF0IGNvbnNvbGUubG9nIHdvcmtzCisgICAgICAgIGh0 dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDQzCisKKyAgICAgICAgUmVt b3ZlIHRoZSBsYXN0IHVzZXMgb2YgSW5zcGVjdG9yQ29udHJvbGxlci5sb2cuIE9uY2UgdXNlIHdh cyBubyBsb25nZXIgbmVlZGVkLAorICAgICAgICBjaGVja2luZyBhbiBlcnJvIGNhc2UgdGhhdCBj YW4ndCBoYXBwZW4gYW55bW9yZS4gVGhlIG90aGVyIGNhc2Ugbm93IHVzZXMgY29uc29sZS5lcnJv ci4KKworICAgICAgICAqIHBhZ2UvSW5zcGVjdG9yQ29udHJvbGxlci5jcHA6IFJlbW92ZSB0aGUg bG9nIGZ1bmN0aW9uLgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ29udHJvbGxlcjo6d2lu ZG93U2NyaXB0T2JqZWN0QXZhaWxhYmxlKTogUmVtb3ZlIHRoZSBsb2cgZnVuY3Rpb24gZnJvbQor ICAgICAgICBJbnNwZWN0b3JDb250cm9sbGVyIHNjcmlwdCBjbGFzcy4KKyAgICAgICAgKiBwYWdl L2luc3BlY3Rvci9Eb2N1bWVudFBhbmVsLmpzOiBSZW1vdmUgYSB1c2Ugb2YgSW5zcGVjdG9yQ29u dHJvbGxlci5sb2cgdGhhdCBpc24ndCBuZWVkZWQuCisgICAgICAgICogcGFnZS9pbnNwZWN0b3Iv UGFuZWwuanM6IENoYW5nZSBJbnNwZWN0b3JDb250cm9sbGVyLmxvZyB0byBjb25zb2xlLmxvZyBh bmQgZWFybHkgcmV0dXJuLgorCiAyMDA3LTExLTE4ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBA d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYWNpZWouCkluZGV4OiBwYWdlL0lu c3BlY3RvckNvbnRyb2xsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHBhZ2UvSW5zcGVjdG9yQ29udHJv bGxlci5jcHAJKHJldmlzaW9uIDI3ODgzKQorKysgcGFnZS9JbnNwZWN0b3JDb250cm9sbGVyLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNDI2LDIyICs0MjYsNiBAQCBzdGF0aWMgSlNWYWx1ZVJlZiBk ZXRhY2goSlNDb250ZXh0UmVmIGN0CiAgICAgcmV0dXJuIEpTVmFsdWVNYWtlVW5kZWZpbmVkKGN0 eCk7CiB9CiAKLXN0YXRpYyBKU1ZhbHVlUmVmIGxvZyhKU0NvbnRleHRSZWYgY3R4LCBKU09iamVj dFJlZiAvKmZ1bmN0aW9uKi8sIEpTT2JqZWN0UmVmIC8qdGhpc09iamVjdCovLCBzaXplX3QgYXJn dW1lbnRDb3VudCwgY29uc3QgSlNWYWx1ZVJlZiBhcmd1bWVudHNbXSwgSlNWYWx1ZVJlZiogLypl eGNlcHRpb24qLykKLXsKLSAgICBpZiAoYXJndW1lbnRDb3VudCA8IDEgfHwgIUpTVmFsdWVJc1N0 cmluZyhjdHgsIGFyZ3VtZW50c1swXSkpCi0gICAgICAgIHJldHVybiBKU1ZhbHVlTWFrZVVuZGVm aW5lZChjdHgpOwotCi0jaWZuZGVmIE5ERUJVRwotICAgIEpTU3RyaW5nUmVmIHN0cmluZyA9IEpT VmFsdWVUb1N0cmluZ0NvcHkoY3R4LCBhcmd1bWVudHNbMF0sIDApOwotICAgIFN0cmluZyBtZXNz YWdlKEpTU3RyaW5nR2V0Q2hhcmFjdGVyc1B0cihzdHJpbmcpLCBKU1N0cmluZ0dldExlbmd0aChz dHJpbmcpKTsKLSAgICBKU1N0cmluZ1JlbGVhc2Uoc3RyaW5nKTsKLQotICAgIGZwcmludGYoc3Rk ZXJyLCAiJXNcbiIsIG1lc3NhZ2UubGF0aW4xKCkuZGF0YSgpKTsKLSNlbmRpZgotCi0gICAgcmV0 dXJuIEpTVmFsdWVNYWtlVW5kZWZpbmVkKGN0eCk7Ci19Ci0KIHN0YXRpYyBKU1ZhbHVlUmVmIHNl YXJjaChKU0NvbnRleHRSZWYgY3R4LCBKU09iamVjdFJlZiAvKmZ1bmN0aW9uKi8sIEpTT2JqZWN0 UmVmIHRoaXNPYmplY3QsIHNpemVfdCBhcmd1bWVudENvdW50LCBjb25zdCBKU1ZhbHVlUmVmIGFy Z3VtZW50c1tdLCBKU1ZhbHVlUmVmKiAvKmV4Y2VwdGlvbiovKQogewogICAgIEluc3BlY3RvckNv bnRyb2xsZXIqIGNvbnRyb2xsZXIgPSByZWludGVycHJldF9jYXN0PEluc3BlY3RvckNvbnRyb2xs ZXIqPihKU09iamVjdEdldFByaXZhdGUodGhpc09iamVjdCkpOwpAQCAtNzQ2LDcgKzczMCw2IEBA IHZvaWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6d2luZG93U2NyaXB0T2IKICAgICAgICAgeyAid2lu ZG93VW5sb2FkaW5nIiwgdW5sb2FkaW5nLCBrSlNQcm9wZXJ0eUF0dHJpYnV0ZU5vbmUgfSwKICAg ICAgICAgeyAiYXR0YWNoIiwgYXR0YWNoLCBrSlNQcm9wZXJ0eUF0dHJpYnV0ZU5vbmUgfSwKICAg ICAgICAgeyAiZGV0YWNoIiwgZGV0YWNoLCBrSlNQcm9wZXJ0eUF0dHJpYnV0ZU5vbmUgfSwKLSAg ICAgICAgeyAibG9nIiwgbG9nLCBrSlNQcm9wZXJ0eUF0dHJpYnV0ZU5vbmUgfSwKICAgICAgICAg eyAic2VhcmNoIiwgc2VhcmNoLCBrSlNQcm9wZXJ0eUF0dHJpYnV0ZU5vbmUgfSwKICNpZiBFTkFC TEUoREFUQUJBU0UpCiAgICAgICAgIHsgImRhdGFiYXNlVGFibGVOYW1lcyIsIGRhdGFiYXNlVGFi bGVOYW1lcywga0pTUHJvcGVydHlBdHRyaWJ1dGVOb25lIH0sCkluZGV4OiBwYWdlL2luc3BlY3Rv ci9Eb2N1bWVudFBhbmVsLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHBhZ2UvaW5zcGVjdG9yL0RvY3VtZW50 UGFuZWwuanMJKHJldmlzaW9uIDI3ODgzKQorKysgcGFnZS9pbnNwZWN0b3IvRG9jdW1lbnRQYW5l bC5qcwkod29ya2luZyBjb3B5KQpAQCAtMTMwLDExICsxMzAsNiBAQCBXZWJJbnNwZWN0b3IuRG9j dW1lbnRQYW5lbC5wcm90b3R5cGUgPSB7CiAKICAgICBzZXQgZm9jdXNlZERPTU5vZGUoeCkKICAg ICB7Ci0gICAgICAgIGlmICh0aGlzLnJlc291cmNlLmNhdGVnb3J5ICE9PSBXZWJJbnNwZWN0b3Iu cmVzb3VyY2VDYXRlZ29yaWVzLmRvY3VtZW50cykgewotICAgICAgICAgICAgSW5zcGVjdG9yQ29u dHJvbGxlci5sb2coIkNhbGxlZCBzZXQgZm9jdXNlZERPTU5vZGUgb24gYSBub24tZG9jdW1lbnQg cmVzb3VyY2UgIiArIHRoaXMucmVzb3VyY2UuZGlzcGxheU5hbWUgKyAiIHdoaWNoIGlzIG5vdCBh IGRvY3VtZW50Iik7Ci0gICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIH0KLQogICAgICAgICBp ZiAodGhpcy5fZm9jdXNlZERPTU5vZGUgPT09IHgpIHsKICAgICAgICAgICAgIHZhciBub2RlSXRl bSA9IHRoaXMucmV2ZWFsTm9kZSh4KTsKICAgICAgICAgICAgIGlmIChub2RlSXRlbSkKSW5kZXg6 IHBhZ2UvaW5zcGVjdG9yL1BhbmVsLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHBhZ2UvaW5zcGVjdG9yL1Bh bmVsLmpzCShyZXZpc2lvbiAyNzg4MykKKysrIHBhZ2UvaW5zcGVjdG9yL1BhbmVsLmpzCSh3b3Jr aW5nIGNvcHkpCkBAIC0xNDAsNiArMTQwLDExIEBAIFdlYkluc3BlY3Rvci5QYW5lbC5wcm90b3R5 cGUgPSB7CiAgICAgICAgIGlmICh0aGlzLl9jdXJyZW50VmlldyA9PT0geCkKICAgICAgICAgICAg IHJldHVybjsKIAorICAgICAgICBpZiAodGhpcyAhPT0geC5wYW5lbCkgeworICAgICAgICAgICAg Y29uc29sZS5lcnJvcigiU2V0IGN1cnJlbnRWaWV3IHRvIGEgdmlldyAiICsgeC50aXRsZSArICIg d2hvc2UgcGFuZWwgaXMgbm90IHRoaXMgcGFuZWwiKTsKKyAgICAgICAgICAgIHJldHVybjsKKyAg ICAgICAgfQorCiAgICAgICAgIGlmICh0aGlzLl9jdXJyZW50VmlldykgewogICAgICAgICAgICAg dGhpcy5fY3VycmVudFZpZXcuYnV0dG9uRWxlbWVudC5yZW1vdmVTdHlsZUNsYXNzKCJzZWxlY3Rl ZCIpOwogICAgICAgICAgICAgdGhpcy5fY3VycmVudFZpZXcuY29udGVudEVsZW1lbnQucmVtb3Zl U3R5bGVDbGFzcygic2VsZWN0ZWQiKTsKQEAgLTE1NCw4ICsxNTksNiBAQCBXZWJJbnNwZWN0b3Iu UGFuZWwucHJvdG90eXBlID0gewogICAgICAgICAgICAgeC5jb250ZW50RWxlbWVudC5hZGRTdHls ZUNsYXNzKCJzZWxlY3RlZCIpOwogICAgICAgICAgICAgaWYgKHguc2hvdykKICAgICAgICAgICAg ICAgICB4LnNob3coKTsKLSAgICAgICAgICAgIGlmICh4LnBhbmVsICE9PSB0aGlzKQotICAgICAg ICAgICAgICAgIEluc3BlY3RvckNvbnRyb2xsZXIubG9nKCJTZXQgY3VycmVudFZpZXcgdG8gYSB2 aWV3ICIgKyB4LnRpdGxlICsgIiB3aG9zZSBwYW5lbCBpcyBub3QgdGhpcyBwYW5lbCIpOwogICAg ICAgICB9CiAgICAgfSwKIAo=