160425 2016-08-01 14:54:30 -0700 Rationalize varargs stack overflow checks 2016-08-01 15:22:32 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1216276 0 fpizlo 2016-08-01 14:54:30 -0700 Patch forthcoming. 1216277 1 285044 fpizlo 2016-08-01 14:56:17 -0700 Created attachment 285044 the patch 1216278 2 285044 msaboff 2016-08-01 14:59:40 -0700 Comment on attachment 285044 the patch r=me 1216284 3 fpizlo 2016-08-01 15:22:32 -0700 Landed in https://trac.webkit.org/changeset/203990 285044 2016-08-01 14:56:17 -0700 2016-08-01 14:59:50 -0700 the patch blah.patch text/plain 4749 fpizlo SW5kZXg6IEpTVGVzdHMvQ2hhbmdlbG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlbG9n CShyZXZpc2lvbiAyMDM5ODYpCisrKyBKU1Rlc3RzL0NoYW5nZWxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE2LTA4LTAxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5j b20+CisKKyAgICAgICAgUmF0aW9uYWxpemUgdmFyYXJncyBzdGFjayBvdmVyZmxvdyBjaGVja3MK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDQyNQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNz L2FyaXR5LWNoZWNrLWZ0bC10aHJvdy1tb3JlLWFyZ3MuanM6IEFkZGVkLgorICAgICAgICAoY2F0 Y2gpOgorCiAyMDE2LTA4LTAxICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29t PgogCiAgICAgICAgIFdlIHNob3VsZCBub3Qga2VlcCB0aGUgSmF2YVNjcmlwdCB0ZXN0cyBpbnNp ZGUgdGhlIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS8gZGlyZWN0b3J5LgpJbmRleDogSlNUZXN0cy9z dHJlc3MvYXJpdHktY2hlY2stZnRsLXRocm93LW1vcmUtYXJncy5qcwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBK U1Rlc3RzL3N0cmVzcy9hcml0eS1jaGVjay1mdGwtdGhyb3ctbW9yZS1hcmdzLmpzCShub25leGlz dGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL2FyaXR5LWNoZWNrLWZ0bC10aHJvdy1tb3JlLWFyZ3Mu anMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwyNSBAQAorLy8gUmVxdWlyZSBsb3RzIG9mIGFy Z3VtZW50cyBzbyB0aGF0IGFyaXR5IGZpeHVwIHdpbGwgbmVlZCBhIGxvdCBvZiBzdGFjaywgbWFr aW5nCisvLyBpdCBwcm9uZSB0byBzdGFjayBvdmVyZmxvdy4KK3ZhciBzY3JpcHQgPSAicmVjdXJz aW9uQ291bnQsICI7Citmb3IgKHZhciBpID0gMDsgaSA8IDUwMDA7ICsraSkKKyAgICBzY3JpcHQg Kz0gImR1bW15LCAiCitzY3JpcHQgKz0gImR1bW15IjsKK3ZhciBnID0gbmV3IEZ1bmN0aW9uKHNj cmlwdCwgInJldHVybiByZWN1cnNpb25Db3VudCA/IGcocmVjdXJzaW9uQ291bnQgLSAxKSA6IDA7 Iik7IC8vIEVuc3VyZSB0aGF0IGFyZ3VtZW50cyBhcmUgb2JzZXJ2ZWQuCisKK25vSW5saW5lKGcp OworCisvLyBFbnN1cmUgdGhhdCBmIGFuZCBnIGdldCBvcHRpbWl6ZWQuCitmb3IgKHZhciBpID0g MDsgaSA8IDEwMDAwOyArK2kpIHsKKyAgICAvLyBSZWN1cnNlIG9uY2UgdG8gZW5zdXJlIHByb2Zp bGluZyBhbG9uZyBhbGwgY29udHJvbCBmbG93IHBhdGhzLgorICAgIGcoMSk7Cit9CisKK3ByaW50 KCJoZXJlIik7CisKK3RyeSB7CisgICAgLy8gUmVjdXJzZSBlbm91Z2ggdGltZXMgdG8gdHJpZ2dl ciBhIHN0YWNrIG92ZXJmbG93IGV4Y2VwdGlvbi4KKyAgICBnKDEwMDAwMDApOworfSBjYXRjaChl KSB7CisgICAgaWYgKCEgKGUgaW5zdGFuY2VvZiBSYW5nZUVycm9yKSkKKyAgICAgICAgdGhyb3cg ImJhZCB2YWx1ZSBmb3IgZSI7Cit9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlz aW9uIDIwMzk4NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxNi0wOC0wMSAgRmlsaXAgUGl6bG8gIDxmcGl6bG9A YXBwbGUuY29tPgorCisgICAgICAgIFJhdGlvbmFsaXplIHZhcmFyZ3Mgc3RhY2sgb3ZlcmZsb3cg Y2hlY2tzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NjA0MjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGZ0bC9GVExMaW5rLmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpsaW5rKTogQWJvdmVPckVxdWFs IDAgaXMgYSB0YXV0b2xvZ3kuIFRoZSBjb2RlIG1lYW50IEdyZWF0ZXJUaGFuT3JFcXVhbCwgc2lu Y2UgdGhlIGVycm9yIGNvZGUgaXMgLTEuCisgICAgICAgICogcnVudGltZS9Db21tb25TbG93UGF0 aHMuaDoKKyAgICAgICAgKEpTQzo6Q29tbW9uU2xvd1BhdGhzOjphcml0eUNoZWNrRm9yKTogVXNl IHJvdW5kVXBUb011bHRpcGxlT2YoKSwgd2hpY2ggaXMgYWxtb3N0IGNlcnRhaW5seSB3aGF0IHdl IG1lYW50IHdoZW4gd2Ugc2FpZCAlLgorCiAyMDE2LTA4LTAxICBTYWFtIEJhcmF0aSAgPHNiYXJh dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFN1YiBzaG91bGQgYmUgYSBNYXRoIElDCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExpbmsuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTGluay5jcHAJKHJldmlzaW9uIDIwMzk4NikKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTGluay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0 MCw3ICsxNDAsNyBAQCB2b2lkIGxpbmsoU3RhdGUmIHN0YXRlKQogICAgICAgICBqaXQuc3RvcmVQ dHIoR1BSSW5mbzo6Y2FsbEZyYW1lUmVnaXN0ZXIsICZ2bS50b3BDYWxsRnJhbWUpOwogICAgICAg ICBDQ2FsbEhlbHBlcnM6OkNhbGwgY2FsbEFyaXR5Q2hlY2sgPSBqaXQuY2FsbCgpOwogCi0gICAg ICAgIGF1dG8gbm9FeGNlcHRpb24gPSBqaXQuYnJhbmNoMzIoQ0NhbGxIZWxwZXJzOjpBYm92ZU9y RXF1YWwsIEdQUkluZm86OnJldHVyblZhbHVlR1BSLCBDQ2FsbEhlbHBlcnM6OlRydXN0ZWRJbW0z MigwKSk7CisgICAgICAgIGF1dG8gbm9FeGNlcHRpb24gPSBqaXQuYnJhbmNoMzIoQ0NhbGxIZWxw ZXJzOjpHcmVhdGVyVGhhbk9yRXF1YWwsIEdQUkluZm86OnJldHVyblZhbHVlR1BSLCBDQ2FsbEhl bHBlcnM6OlRydXN0ZWRJbW0zMigwKSk7CiAgICAgICAgIGppdC5jb3B5Q2FsbGVlU2F2ZXNUb1ZN RW50cnlGcmFtZUNhbGxlZVNhdmVzQnVmZmVyKCk7CiAgICAgICAgIGppdC5tb3ZlKENDYWxsSGVs cGVyczo6VHJ1c3RlZEltbVB0cihqaXQudm0oKSksIEdQUkluZm86OmFyZ3VtZW50R1BSMCk7CiAg ICAgICAgIGppdC5tb3ZlKEdQUkluZm86OmNhbGxGcmFtZVJlZ2lzdGVyLCBHUFJJbmZvOjphcmd1 bWVudEdQUjEpOwpAQCAtMTQ4LDEwICsxNDgsMTAgQEAgdm9pZCBsaW5rKFN0YXRlJiBzdGF0ZSkK ICAgICAgICAgaml0Lmp1bXBUb0V4Y2VwdGlvbkhhbmRsZXIoKTsKICAgICAgICAgbm9FeGNlcHRp b24ubGluaygmaml0KTsKIAotI2lmICFBU1NFUlRfRElTQUJMRUQKLSAgICAgICAgaml0LmxvYWQ2 NCh2bS5hZGRyZXNzT2ZFeGNlcHRpb24oKSwgR1BSSW5mbzo6cmVnVDEpOwotICAgICAgICBqaXQu aml0QXNzZXJ0SXNOdWxsKEdQUkluZm86OnJlZ1QxKTsKLSNlbmRpZgorICAgICAgICBpZiAoIUFT U0VSVF9ESVNBQkxFRCkgeworICAgICAgICAgICAgaml0LmxvYWQ2NCh2bS5hZGRyZXNzT2ZFeGNl cHRpb24oKSwgR1BSSW5mbzo6cmVnVDEpOworICAgICAgICAgICAgaml0LmppdEFzc2VydElzTnVs bChHUFJJbmZvOjpyZWdUMSk7CisgICAgICAgIH0KIAogICAgICAgICBqaXQubW92ZShHUFJJbmZv OjpyZXR1cm5WYWx1ZUdQUiwgR1BSSW5mbzo6YXJndW1lbnRHUFIwKTsKICAgICAgICAgaml0LmVt aXRGdW5jdGlvbkVwaWxvZ3VlKCk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9Db21tb25TbG93UGF0aHMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9Db21tb25TbG93UGF0aHMuaAkocmV2aXNpb24gMjAzOTg2KQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29tbW9uU2xvd1BhdGhzLmgJKHdvcmtpbmcgY29weSkKQEAg LTYzLDggKzYzLDEwIEBAIEFMV0FZU19JTkxJTkUgaW50IGFyaXR5Q2hlY2tGb3IoRXhlY1N0YXQK ICAgICBpbnQgYWxpZ25lZEZyYW1lU2l6ZUZvclBhcmFtZXRlcnMgPSBXVEY6OnJvdW5kVXBUb011 bHRpcGxlT2Yoc3RhY2tBbGlnbm1lbnRSZWdpc3RlcnMoKSwKICAgICAgICAgbmV3Q29kZUJsb2Nr LT5udW1QYXJhbWV0ZXJzKCkgKyBDYWxsRnJhbWU6OmhlYWRlclNpemVJblJlZ2lzdGVycyk7CiAg ICAgaW50IHBhZGRlZFN0YWNrU3BhY2UgPSBhbGlnbmVkRnJhbWVTaXplRm9yUGFyYW1ldGVycyAt IGZyYW1lU2l6ZTsKKyAgICAKKyAgICBSZWdpc3RlciogbmV3U3RhY2sgPSBleGVjLT5yZWdpc3Rl cnMoKSAtIFdURjo6cm91bmRVcFRvTXVsdGlwbGVPZihzdGFja0FsaWdubWVudFJlZ2lzdGVycygp LCBwYWRkZWRTdGFja1NwYWNlKTsKIAotICAgIGlmIChVTkxJS0VMWSghdm0uZW5zdXJlU3RhY2tD YXBhY2l0eUZvcihleGVjLT5yZWdpc3RlcnMoKSAtIHBhZGRlZFN0YWNrU3BhY2UgJSBzdGFja0Fs aWdubWVudFJlZ2lzdGVycygpKSkpCisgICAgaWYgKFVOTElLRUxZKCF2bS5lbnN1cmVTdGFja0Nh cGFjaXR5Rm9yKG5ld1N0YWNrKSkpCiAgICAgICAgIHJldHVybiAtMTsKICAgICByZXR1cm4gcGFk ZGVkU3RhY2tTcGFjZTsKIH0K