160416 2016-08-01 12:22:00 -0700 [iOS] A video element that does not pause after exiting from fullscreen should be allowed to continue playing inline 2016-08-01 14:27:49 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue oldest_to_newest 1216206 0 eric.carlson 2016-08-01 12:22:00 -0700 A video element that does not pause after exiting from fullscreen should be allowed to continue playing inline. 1216207 1 eric.carlson 2016-08-01 12:22:52 -0700 <rdar://problem/27547583> 1216216 2 285030 eric.carlson 2016-08-01 12:31:59 -0700 Created attachment 285030 Proposed patch. 1216218 3 285031 eric.carlson 2016-08-01 12:34:07 -0700 Created attachment 285031 Proposed patch. 1216251 4 285031 commit-queue 2016-08-01 13:49:54 -0700 Comment on attachment 285031 Proposed patch. Clearing flags on attachment: 285031 Committed r203984: <http://trac.webkit.org/changeset/203984> 1216252 5 commit-queue 2016-08-01 13:49:58 -0700 All reviewed patches have been landed. Closing bug. 1216273 6 eric.carlson 2016-08-01 14:27:49 -0700 Correct, the Radar bug is actually <rdar://problem/27409854> 285030 2016-08-01 12:31:59 -0700 2016-08-01 12:34:07 -0700 Proposed patch. patch_1.txt text/plain 3588 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMzk4MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA4LTAxICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIEEgdmlkZW8g ZWxlbWVudCB0aGF0IGRvZXMgbm90IHBhdXNlIGFmdGVyIGV4aXRpbmcgZnJvbSBmdWxsc2NyZWVu IHNob3VsZCBiZSBhbGxvd2VkIHRvIGNvbnRpbnVlIHBsYXlpbmcgaW5saW5lCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjA0MTYKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzI3NTQ3NTgzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmV4aXRGdWxsc2NyZWVuKTogSWYgcGxheWJhY2sgbm9y bWFsbHkgcmVxdWlyZXMgZnVsbHNjcmVlbiBidXQgdGhlIAorICAgICAgICBlbGVtZW50IHdhcyBu b3QgcGF1c2VkIHdoZW4gZXhpdGluZyBmcm9tIGZ1bGxzY3JlZW4sIHNldCB0aGUgJ3BsYXlzaW5s aW5lJyBhdHRyaWJ1dGUgc28gd2Ugd29uJ3QKKyAgICAgICAgZm9yY2UgZnVsbHNjcmVlbiBpZiBw bGF5YmFjayBpcyBwYXVzZWQgYW5kIHJlc3VtZXMsIGFuZCBzZXQgdGhlICdjb250cm9scycgYXR0 cmlidXRlIHNvIHRoZQorICAgICAgICB1c2VyIGNhbiBjb250cm9sIHBsYXliYWNrLgorCiAyMDE2 LTA4LTAxICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdS RVNTSU9OIChyMTk2MzgzKTogRHJvcCBkb3duIENTUyBtZW51cyBub3Qgd29ya2luZyBvbiBjbmV0 LmNvbSwgYXBtZXguY29tCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1l bnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVu dC5jcHAJKHJldmlzaW9uIDIwMzc3MikKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlh RWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU0NjIsMTkgKzU0NjIsMjkgQEAgdm9pZCBI VE1MTWVkaWFFbGVtZW50OjpleGl0RnVsbHNjcmVlbigpCiAjZW5kaWYKICAgICBpZiAoaGFzTWVk aWFDb250cm9scygpKQogICAgICAgICBtZWRpYUNvbnRyb2xzKCktPmV4aXRlZEZ1bGxzY3JlZW4o KTsKLSAgICBpZiAoZG9jdW1lbnQoKS5wYWdlKCkgJiYgaXM8SFRNTFZpZGVvRWxlbWVudD4oKnRo aXMpKSB7Ci0gICAgICAgIGlmIChtX21lZGlhU2Vzc2lvbi0+cmVxdWlyZXNGdWxsc2NyZWVuRm9y VmlkZW9QbGF5YmFjaygqdGhpcykgJiYgKCFkb2N1bWVudCgpLnNldHRpbmdzKCkgfHwgIWRvY3Vt ZW50KCkuc2V0dGluZ3MoKS0+YWxsb3dzSW5saW5lTWVkaWFQbGF5YmFja0FmdGVyRnVsbHNjcmVl bigpIHx8IGlzVmlkZW9Ub29TbWFsbEZvcklubGluZVBsYXliYWNrKCkpKQorCisgICAgaWYgKCFk b2N1bWVudCgpLnBhZ2UoKSB8fCAhaXM8SFRNTFZpZGVvRWxlbWVudD4oKnRoaXMpKQorICAgICAg ICByZXR1cm47CisKKyAgICBpZiAoIXBhdXNlZCgpICYmIG1fbWVkaWFTZXNzaW9uLT5yZXF1aXJl c0Z1bGxzY3JlZW5Gb3JWaWRlb1BsYXliYWNrKCp0aGlzKSkgeworICAgICAgICBpZiAoIWRvY3Vt ZW50KCkuc2V0dGluZ3MoKSB8fCAhZG9jdW1lbnQoKS5zZXR0aW5ncygpLT5hbGxvd3NJbmxpbmVN ZWRpYVBsYXliYWNrQWZ0ZXJGdWxsc2NyZWVuKCkgfHwgaXNWaWRlb1Rvb1NtYWxsRm9ySW5saW5l UGxheWJhY2soKSkKICAgICAgICAgICAgIHBhdXNlSW50ZXJuYWwoKTsKKyAgICAgICAgZWxzZSB7 CisgICAgICAgICAgICAvLyBBbGxvdyBpbmxpbmUgcGxheWJhY2ssIGJ1dCBzZXQgJ3BsYXlzaW5s aW5lJyBzbyBwYXVzaW5nIGFuZCBzdGFydGluZyBhZ2FpbiAoZS5nLiB3aGVuIHNjcnViYmluZykg d29uJ3QgZ28gYmFjayB0byBmdWxsc2NyZWVuLgorICAgICAgICAgICAgLy8gQWxzbyBzZXQgdGhl IGNvbnRyb2xzIGF0dHJpYnV0ZSBzbyB0aGUgdXNlciB3aWxsIGJlIGFibGUgdG8gY29udHJvbCBw bGF5YmFjay4KKyAgICAgICAgICAgIHNldEJvb2xlYW5BdHRyaWJ1dGUoSFRNTE5hbWVzOjpwbGF5 c2lubGluZUF0dHIsIHRydWUpOworICAgICAgICAgICAgc2V0Q29udHJvbHModHJ1ZSk7CisgICAg ICAgIH0KKyAgICB9CiAKICNpZiBQTEFURk9STShNQUMpICYmIEVOQUJMRShWSURFT19QUkVTRU5U QVRJT05fTU9ERSkKLSAgICAgICAgaWYgKGRvY3VtZW50KCkuYWN0aXZlRE9NT2JqZWN0c0FyZVN1 c3BlbmRlZCgpIHx8IGRvY3VtZW50KCkuYWN0aXZlRE9NT2JqZWN0c0FyZVN0b3BwZWQoKSkKLSAg ICAgICAgICAgIGRvY3VtZW50KCkucGFnZSgpLT5jaHJvbWUoKS5jbGllbnQoKS5leGl0VmlkZW9G dWxsc2NyZWVuVG9Nb2RlV2l0aG91dEFuaW1hdGlvbihkb3duY2FzdDxIVE1MVmlkZW9FbGVtZW50 PigqdGhpcyksIFZpZGVvRnVsbHNjcmVlbk1vZGVOb25lKTsKLSAgICAgICAgZWxzZQotI2VuZGlm Ci0gICAgICAgIGlmIChkb2N1bWVudCgpLnBhZ2UoKS0+Y2hyb21lKCkuY2xpZW50KCkuc3VwcG9y dHNWaWRlb0Z1bGxzY3JlZW4ob2xkVmlkZW9GdWxsc2NyZWVuTW9kZSkpIHsKLSAgICAgICAgICAg IGRvY3VtZW50KCkucGFnZSgpLT5jaHJvbWUoKS5jbGllbnQoKS5leGl0VmlkZW9GdWxsc2NyZWVu Rm9yVmlkZW9FbGVtZW50KGRvd25jYXN0PEhUTUxWaWRlb0VsZW1lbnQ+KCp0aGlzKSk7Ci0gICAg ICAgICAgICBzY2hlZHVsZUV2ZW50KGV2ZW50TmFtZXMoKS53ZWJraXRlbmRmdWxsc2NyZWVuRXZl bnQpOwotICAgICAgICB9CisgICAgaWYgKGRvY3VtZW50KCkuYWN0aXZlRE9NT2JqZWN0c0FyZVN1 c3BlbmRlZCgpIHx8IGRvY3VtZW50KCkuYWN0aXZlRE9NT2JqZWN0c0FyZVN0b3BwZWQoKSkKKyAg ICAgICAgZG9jdW1lbnQoKS5wYWdlKCktPmNocm9tZSgpLmNsaWVudCgpLmV4aXRWaWRlb0Z1bGxz Y3JlZW5Ub01vZGVXaXRob3V0QW5pbWF0aW9uKGRvd25jYXN0PEhUTUxWaWRlb0VsZW1lbnQ+KCp0 aGlzKSwgVmlkZW9GdWxsc2NyZWVuTW9kZU5vbmUpOworICAgIGVsc2UKKyNlbmRpZgorICAgIGlm IChkb2N1bWVudCgpLnBhZ2UoKS0+Y2hyb21lKCkuY2xpZW50KCkuc3VwcG9ydHNWaWRlb0Z1bGxz Y3JlZW4ob2xkVmlkZW9GdWxsc2NyZWVuTW9kZSkpIHsKKyAgICAgICAgZG9jdW1lbnQoKS5wYWdl KCktPmNocm9tZSgpLmNsaWVudCgpLmV4aXRWaWRlb0Z1bGxzY3JlZW5Gb3JWaWRlb0VsZW1lbnQo ZG93bmNhc3Q8SFRNTFZpZGVvRWxlbWVudD4oKnRoaXMpKTsKKyAgICAgICAgc2NoZWR1bGVFdmVu dChldmVudE5hbWVzKCkud2Via2l0ZW5kZnVsbHNjcmVlbkV2ZW50KTsKICAgICB9CiB9CiAK 285031 2016-08-01 12:34:07 -0700 2016-08-01 13:49:54 -0700 Proposed patch. patch_1.txt text/plain 3588 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMzk4MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA4LTAxICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIEEgdmlkZW8g ZWxlbWVudCB0aGF0IGRvZXMgbm90IHBhdXNlIGFmdGVyIGV4aXRpbmcgZnJvbSBmdWxsc2NyZWVu IHNob3VsZCBiZSBhbGxvd2VkIHRvIGNvbnRpbnVlIHBsYXlpbmcgaW5saW5lCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjA0MTYKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzI3NDA5ODU0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmV4aXRGdWxsc2NyZWVuKTogSWYgcGxheWJhY2sgbm9y bWFsbHkgcmVxdWlyZXMgZnVsbHNjcmVlbiBidXQgdGhlIAorICAgICAgICBlbGVtZW50IHdhcyBu b3QgcGF1c2VkIHdoZW4gZXhpdGluZyBmcm9tIGZ1bGxzY3JlZW4sIHNldCB0aGUgJ3BsYXlzaW5s aW5lJyBhdHRyaWJ1dGUgc28gd2Ugd29uJ3QKKyAgICAgICAgZm9yY2UgZnVsbHNjcmVlbiBpZiBw bGF5YmFjayBpcyBwYXVzZWQgYW5kIHJlc3VtZXMsIGFuZCBzZXQgdGhlICdjb250cm9scycgYXR0 cmlidXRlIHNvIHRoZQorICAgICAgICB1c2VyIGNhbiBjb250cm9sIHBsYXliYWNrLgorCiAyMDE2 LTA4LTAxICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdS RVNTSU9OIChyMTk2MzgzKTogRHJvcCBkb3duIENTUyBtZW51cyBub3Qgd29ya2luZyBvbiBjbmV0 LmNvbSwgYXBtZXguY29tCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1l bnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVu dC5jcHAJKHJldmlzaW9uIDIwMzc3MikKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlh RWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU0NjIsMTkgKzU0NjIsMjkgQEAgdm9pZCBI VE1MTWVkaWFFbGVtZW50OjpleGl0RnVsbHNjcmVlbigpCiAjZW5kaWYKICAgICBpZiAoaGFzTWVk aWFDb250cm9scygpKQogICAgICAgICBtZWRpYUNvbnRyb2xzKCktPmV4aXRlZEZ1bGxzY3JlZW4o KTsKLSAgICBpZiAoZG9jdW1lbnQoKS5wYWdlKCkgJiYgaXM8SFRNTFZpZGVvRWxlbWVudD4oKnRo aXMpKSB7Ci0gICAgICAgIGlmIChtX21lZGlhU2Vzc2lvbi0+cmVxdWlyZXNGdWxsc2NyZWVuRm9y VmlkZW9QbGF5YmFjaygqdGhpcykgJiYgKCFkb2N1bWVudCgpLnNldHRpbmdzKCkgfHwgIWRvY3Vt ZW50KCkuc2V0dGluZ3MoKS0+YWxsb3dzSW5saW5lTWVkaWFQbGF5YmFja0FmdGVyRnVsbHNjcmVl bigpIHx8IGlzVmlkZW9Ub29TbWFsbEZvcklubGluZVBsYXliYWNrKCkpKQorCisgICAgaWYgKCFk b2N1bWVudCgpLnBhZ2UoKSB8fCAhaXM8SFRNTFZpZGVvRWxlbWVudD4oKnRoaXMpKQorICAgICAg ICByZXR1cm47CisKKyAgICBpZiAoIXBhdXNlZCgpICYmIG1fbWVkaWFTZXNzaW9uLT5yZXF1aXJl c0Z1bGxzY3JlZW5Gb3JWaWRlb1BsYXliYWNrKCp0aGlzKSkgeworICAgICAgICBpZiAoIWRvY3Vt ZW50KCkuc2V0dGluZ3MoKSB8fCAhZG9jdW1lbnQoKS5zZXR0aW5ncygpLT5hbGxvd3NJbmxpbmVN ZWRpYVBsYXliYWNrQWZ0ZXJGdWxsc2NyZWVuKCkgfHwgaXNWaWRlb1Rvb1NtYWxsRm9ySW5saW5l UGxheWJhY2soKSkKICAgICAgICAgICAgIHBhdXNlSW50ZXJuYWwoKTsKKyAgICAgICAgZWxzZSB7 CisgICAgICAgICAgICAvLyBBbGxvdyBpbmxpbmUgcGxheWJhY2ssIGJ1dCBzZXQgJ3BsYXlzaW5s aW5lJyBzbyBwYXVzaW5nIGFuZCBzdGFydGluZyBhZ2FpbiAoZS5nLiB3aGVuIHNjcnViYmluZykg d29uJ3QgZ28gYmFjayB0byBmdWxsc2NyZWVuLgorICAgICAgICAgICAgLy8gQWxzbyBzZXQgdGhl IGNvbnRyb2xzIGF0dHJpYnV0ZSBzbyB0aGUgdXNlciB3aWxsIGJlIGFibGUgdG8gY29udHJvbCBw bGF5YmFjay4KKyAgICAgICAgICAgIHNldEJvb2xlYW5BdHRyaWJ1dGUoSFRNTE5hbWVzOjpwbGF5 c2lubGluZUF0dHIsIHRydWUpOworICAgICAgICAgICAgc2V0Q29udHJvbHModHJ1ZSk7CisgICAg ICAgIH0KKyAgICB9CiAKICNpZiBQTEFURk9STShNQUMpICYmIEVOQUJMRShWSURFT19QUkVTRU5U QVRJT05fTU9ERSkKLSAgICAgICAgaWYgKGRvY3VtZW50KCkuYWN0aXZlRE9NT2JqZWN0c0FyZVN1 c3BlbmRlZCgpIHx8IGRvY3VtZW50KCkuYWN0aXZlRE9NT2JqZWN0c0FyZVN0b3BwZWQoKSkKLSAg ICAgICAgICAgIGRvY3VtZW50KCkucGFnZSgpLT5jaHJvbWUoKS5jbGllbnQoKS5leGl0VmlkZW9G dWxsc2NyZWVuVG9Nb2RlV2l0aG91dEFuaW1hdGlvbihkb3duY2FzdDxIVE1MVmlkZW9FbGVtZW50 PigqdGhpcyksIFZpZGVvRnVsbHNjcmVlbk1vZGVOb25lKTsKLSAgICAgICAgZWxzZQotI2VuZGlm Ci0gICAgICAgIGlmIChkb2N1bWVudCgpLnBhZ2UoKS0+Y2hyb21lKCkuY2xpZW50KCkuc3VwcG9y dHNWaWRlb0Z1bGxzY3JlZW4ob2xkVmlkZW9GdWxsc2NyZWVuTW9kZSkpIHsKLSAgICAgICAgICAg IGRvY3VtZW50KCkucGFnZSgpLT5jaHJvbWUoKS5jbGllbnQoKS5leGl0VmlkZW9GdWxsc2NyZWVu Rm9yVmlkZW9FbGVtZW50KGRvd25jYXN0PEhUTUxWaWRlb0VsZW1lbnQ+KCp0aGlzKSk7Ci0gICAg ICAgICAgICBzY2hlZHVsZUV2ZW50KGV2ZW50TmFtZXMoKS53ZWJraXRlbmRmdWxsc2NyZWVuRXZl bnQpOwotICAgICAgICB9CisgICAgaWYgKGRvY3VtZW50KCkuYWN0aXZlRE9NT2JqZWN0c0FyZVN1 c3BlbmRlZCgpIHx8IGRvY3VtZW50KCkuYWN0aXZlRE9NT2JqZWN0c0FyZVN0b3BwZWQoKSkKKyAg ICAgICAgZG9jdW1lbnQoKS5wYWdlKCktPmNocm9tZSgpLmNsaWVudCgpLmV4aXRWaWRlb0Z1bGxz Y3JlZW5Ub01vZGVXaXRob3V0QW5pbWF0aW9uKGRvd25jYXN0PEhUTUxWaWRlb0VsZW1lbnQ+KCp0 aGlzKSwgVmlkZW9GdWxsc2NyZWVuTW9kZU5vbmUpOworICAgIGVsc2UKKyNlbmRpZgorICAgIGlm IChkb2N1bWVudCgpLnBhZ2UoKS0+Y2hyb21lKCkuY2xpZW50KCkuc3VwcG9ydHNWaWRlb0Z1bGxz Y3JlZW4ob2xkVmlkZW9GdWxsc2NyZWVuTW9kZSkpIHsKKyAgICAgICAgZG9jdW1lbnQoKS5wYWdl KCktPmNocm9tZSgpLmNsaWVudCgpLmV4aXRWaWRlb0Z1bGxzY3JlZW5Gb3JWaWRlb0VsZW1lbnQo ZG93bmNhc3Q8SFRNTFZpZGVvRWxlbWVudD4oKnRoaXMpKTsKKyAgICAgICAgc2NoZWR1bGVFdmVu dChldmVudE5hbWVzKCkud2Via2l0ZW5kZnVsbHNjcmVlbkV2ZW50KTsKICAgICB9CiB9CiAK