160414 2016-08-01 12:07:59 -0700 [Tools] The GDB backtrace report tool don't checks the gdb return code. 2016-08-01 18:51:46 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 clopez clopez ap bugs-noreply cgarcia commit-queue glenn lforschler ossy pnormand oldest_to_newest 1216198 0 clopez 2016-08-01 12:07:59 -0700 There is an issue with current Debug builds of WebKitGTK+ and GDB. Check #159919 GDB=7.7.1 segfaults when trying to analyze a core produced on a Debug build of WebKitGTK+ without producing any output. The WebKit tooling don't checks the return code and assumes that an empty stdout means that the corefile was not generated as expected. So, it returns this: """ crash log for WebKitWebProcess (pid 7371): Coredump core-pid_7371.dump not found. To enable crash logs: - run this command as super-user: echo "|Tools/Scripts/process-linux-coredump /home/clopez/webkit/cores/core-pid_%p.dump" > /proc/sys/kernel/core_pattern - enable core dumps: ulimit -c unlimited - set the WEBKIT_CORE_DUMPS_DIRECTORY environment variable: export WEBKIT_CORE_DUMPS_DIRECTORY=/home/clopez/webkit/cores STDERR: STDERR: warning: core file may not match specified executable file. STDERR: <empty> """ Which is at best, misleading. We should detect the return code from GDB and inform about it when it is non-zero. 1216202 1 285026 clopez 2016-08-01 12:18:47 -0700 Created attachment 285026 Patch 1216204 2 commit-queue 2016-08-01 12:20:08 -0700 Attachment 285026 did not pass style-queue: ERROR: Tools/Scripts/webkitpy/port/linux_get_crash_log.py:49: missing whitespace around operator [pep8/E225] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1216209 3 285028 clopez 2016-08-01 12:23:33 -0700 Created attachment 285028 Patch 1216212 4 clopez 2016-08-01 12:26:22 -0700 Example of -crash-log.txt file produced after this patch: """ crash log for WebKitWebProcess (pid 11081): ERROR: The gdb process exited with non-zero return code -11 STDERR: STDERR: warning: core file may not match specified executable file. STDERR: <empty> """ And if using gdb=>7.11.1 which don't segfaults but fails to generate the backtrace, we get: """ crash log for WebKitWebProcess (pid 12130): ERROR: The gdb process exited with non-zero return code 1 [New LWP 12130] [New LWP 12148] [New LWP 12142] [New LWP 12153] [New LWP 12146] [New LWP 12139] [New LWP 12144] [New LWP 12150] [New LWP 12149] [New LWP 12140] [New LWP 12145] [New LWP 12152] [New LWP 12141] [New LWP 12147] [New LWP 12151] cp-support.c:1615: demangler-warning: unable to demangle '_ZSt7forwardIRZN6WebKit29NetworkConnectionToWebProcess26writeBlobsToTemporaryFilesERKN3WTF6VectorINS2_6StringELm0ENS2_15CrashOnOverflowELm16EEEmEUlRT_E_EOS9_RNSt16remove_referenceIS9_E4typeE' (demangler failed with signal 11) A problem internal to GDB has been detected, further debugging may prove unreliable. Quit this debugging session? (y or n) [answered Y; input not from terminal] STDERR: STDERR: warning: core file may not match specified executable file. STDERR: STDERR: warning: Could not load shared library symbols for linux-vdso.so.1. STDERR: Do you need "set solib-search-path" or "set sysroot"? """ 1216351 5 285028 clopez 2016-08-01 18:51:37 -0700 Comment on attachment 285028 Patch Clearing flags on attachment: 285028 Committed r204007: <http://trac.webkit.org/changeset/204007> 1216352 6 clopez 2016-08-01 18:51:46 -0700 All reviewed patches have been landed. Closing bug. 285026 2016-08-01 12:18:47 -0700 2016-08-01 12:23:26 -0700 Patch bug-160414-20160801211726.patch text/plain 1609 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzODE4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTBkNzU5MjllMDc0OTg2OTkzYzQ4MTgzOTkyYWUyYWE4 MTU0MWNhMS4uZjcyMzMxNmQ1NmRlZWRjMzA3Mjc3MjYwMzdlNzVjODRhZDdmNzE3YiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE2LTA4LTAxICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtUb29sc10gVGhlIEdEQiBiYWNrdHJhY2UgcmVwb3J0IHRvb2wg ZG9uJ3QgY2hlY2tzIHRoZSBnZGIgcmV0dXJuIGNvZGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjA0MTQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9saW51eF9n ZXRfY3Jhc2hfbG9nLnB5OgorICAgICAgICAoR0RCQ3Jhc2hMb2dHZW5lcmF0b3IuX3dhaXRfZm9y X2NvcmVmaWxlKToKKwogMjAxNi0wNy0yNyAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxl LmNvbT4KIAogICAgICAgICBMYXlvdXRUZXN0UmVsYXkgc2hvdWxkIHdhaXQgZm9yIFdlYktpdFRl c3RSdW5uZXJBcHAgaW5zdGFsbGF0aW9uIHRvIGNvbXBsZXRlCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3BvcnQvbGludXhfZ2V0X2NyYXNoX2xvZy5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvcG9ydC9saW51eF9nZXRfY3Jhc2hfbG9nLnB5CmluZGV4IDExMGNhYzZhYTcy OTdiY2FmZTc5ZjYwYjQzMjMzMjNkOTA3NjNiZGUuLjYzYWU5MzgyMDhiOGI2MTYyMjI4MjVhMDFm NTM2MDZlYzAyNzVmNTIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9s aW51eF9nZXRfY3Jhc2hfbG9nLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9s aW51eF9nZXRfY3Jhc2hfbG9nLnB5CkBAIC00NSw2ICs0NSw4IEBAIGNsYXNzIEdEQkNyYXNoTG9n R2VuZXJhdG9yKG9iamVjdCk6CiAgICAgICAgIHByb2MgPSBzdWJwcm9jZXNzLlBvcGVuKGNtZCwg c3RkaW49Tm9uZSwgc3Rkb3V0PXN1YnByb2Nlc3MuUElQRSwgc3RkZXJyPXN1YnByb2Nlc3MuUElQ RSkKICAgICAgICAgc3Rkb3V0LCBzdGRlcnIgPSBwcm9jLmNvbW11bmljYXRlKCkKICAgICAgICAg ZXJyb3JzID0gW3N0ZGVycl9saW5lLnN0cmlwKCkuZGVjb2RlKCd1dGY4JywgJ2lnbm9yZScpIGZv ciBzdGRlcnJfbGluZSBpbiBzdGRlcnIuc3BsaXRsaW5lcygpXQorICAgICAgICBpZiBwcm9jLnJl dHVybmNvZGUgIT0gMDoKKyAgICAgICAgICAgIHN0ZG91dCA9ICgnRVJST1I6IFRoZSBnZGIgcHJv Y2VzcyBleGl0ZWQgd2l0aCBub24temVybyByZXR1cm4gY29kZSAlc1xuXG4nICVwcm9jLnJldHVy bmNvZGUpICsgc3Rkb3V0CiAgICAgICAgIHJldHVybiAoc3Rkb3V0LmRlY29kZSgndXRmOCcsICdp Z25vcmUnKSwgZXJyb3JzKQogCiAgICAgZGVmIGdlbmVyYXRlX2NyYXNoX2xvZyhzZWxmLCBzdGRv dXQsIHN0ZGVycik6Cg== 285028 2016-08-01 12:23:33 -0700 2016-08-01 18:51:37 -0700 Patch bug-160414-20160801212213.patch text/plain 1610 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzODE4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTBkNzU5MjllMDc0OTg2OTkzYzQ4MTgzOTkyYWUyYWE4 MTU0MWNhMS4uZjcyMzMxNmQ1NmRlZWRjMzA3Mjc3MjYwMzdlNzVjODRhZDdmNzE3YiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE2LTA4LTAxICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtUb29sc10gVGhlIEdEQiBiYWNrdHJhY2UgcmVwb3J0IHRvb2wg ZG9uJ3QgY2hlY2tzIHRoZSBnZGIgcmV0dXJuIGNvZGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjA0MTQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9saW51eF9n ZXRfY3Jhc2hfbG9nLnB5OgorICAgICAgICAoR0RCQ3Jhc2hMb2dHZW5lcmF0b3IuX3dhaXRfZm9y X2NvcmVmaWxlKToKKwogMjAxNi0wNy0yNyAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxl LmNvbT4KIAogICAgICAgICBMYXlvdXRUZXN0UmVsYXkgc2hvdWxkIHdhaXQgZm9yIFdlYktpdFRl c3RSdW5uZXJBcHAgaW5zdGFsbGF0aW9uIHRvIGNvbXBsZXRlCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3BvcnQvbGludXhfZ2V0X2NyYXNoX2xvZy5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvcG9ydC9saW51eF9nZXRfY3Jhc2hfbG9nLnB5CmluZGV4IDExMGNhYzZhYTcy OTdiY2FmZTc5ZjYwYjQzMjMzMjNkOTA3NjNiZGUuLjMwYjhlYTQ4MjYyMWM1NWYzODgxZGZhZTEy NDZjODUzYTY0MmU1YzYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9s aW51eF9nZXRfY3Jhc2hfbG9nLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9s aW51eF9nZXRfY3Jhc2hfbG9nLnB5CkBAIC00NSw2ICs0NSw4IEBAIGNsYXNzIEdEQkNyYXNoTG9n R2VuZXJhdG9yKG9iamVjdCk6CiAgICAgICAgIHByb2MgPSBzdWJwcm9jZXNzLlBvcGVuKGNtZCwg c3RkaW49Tm9uZSwgc3Rkb3V0PXN1YnByb2Nlc3MuUElQRSwgc3RkZXJyPXN1YnByb2Nlc3MuUElQ RSkKICAgICAgICAgc3Rkb3V0LCBzdGRlcnIgPSBwcm9jLmNvbW11bmljYXRlKCkKICAgICAgICAg ZXJyb3JzID0gW3N0ZGVycl9saW5lLnN0cmlwKCkuZGVjb2RlKCd1dGY4JywgJ2lnbm9yZScpIGZv ciBzdGRlcnJfbGluZSBpbiBzdGRlcnIuc3BsaXRsaW5lcygpXQorICAgICAgICBpZiBwcm9jLnJl dHVybmNvZGUgIT0gMDoKKyAgICAgICAgICAgIHN0ZG91dCA9ICgnRVJST1I6IFRoZSBnZGIgcHJv Y2VzcyBleGl0ZWQgd2l0aCBub24temVybyByZXR1cm4gY29kZSAlc1xuXG4nICUgcHJvYy5yZXR1 cm5jb2RlKSArIHN0ZG91dAogICAgICAgICByZXR1cm4gKHN0ZG91dC5kZWNvZGUoJ3V0ZjgnLCAn aWdub3JlJyksIGVycm9ycykKIAogICAgIGRlZiBnZW5lcmF0ZV9jcmFzaF9sb2coc2VsZiwgc3Rk b3V0LCBzdGRlcnIpOgo=