16041 2007-11-18 13:47:25 -0800 REGRESSION: the Database panel in the Inspector stopped showing errors 2007-11-18 18:40:24 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED Regression P1 Major --- 1 timothy timothy ddkilzer oldest_to_newest 61588 0 timothy 2007-11-18 13:47:25 -0800 With the new Database API the change to the Inspector code made it stop showing errors. 61589 1 17369 timothy 2007-11-18 13:50:52 -0800 Created attachment 17369 Patch 61596 2 17369 beidson 2007-11-18 14:57:00 -0800 Comment on attachment 17369 Patch I wonder what the "The “%@”\ntable is empty." gobbledy-gook is about... It comes up twice, but then later it seems %@ suffices in a similar situation. If there's a good explanation then r=me 61597 3 timothy 2007-11-18 15:01:53 -0800 The patch doesn't show UTF-8 correctly, it is fine in the file. Landed in r27892. http://trac.webkit.org/projects/webkit/changeset/27892 61605 4 ddkilzer 2007-11-18 18:32:06 -0800 (In reply to comment #2) > (From update of attachment 17369 [edit]) > I wonder what the "The “%@”\ntable is empty." gobbledy-gook is about... It > comes up twice, but then later it seems %@ suffices in a similar situation. > If there's a good explanation then r=me (In reply to comment #3) > The patch doesn't show UTF-8 correctly, it is fine in the file. Could this be a format-string bug in patch? What command did you use to create the patch, Tim? 61606 5 timothy 2007-11-18 18:40:24 -0800 I used svn-create-patch. Using svn diff gives me expected UTF-8. 17369 2007-11-18 13:50:52 -0800 2007-11-18 14:57:00 -0800 Patch 16041.patch text/plain 7697 timothy SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI3ODkw KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMTEt MTggIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAxNjA0MTogUkVHUkVTU0lPTjog dGhlIERhdGFiYXNlIHBhbmVsIGluIHRoZSBJbnNwZWN0b3Igc3RvcHBlZCBzaG93aW5nIGVycm9y cworICAgICAgICBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjA0MQor CisgICAgICAgICogcGFnZS9pbnNwZWN0b3IvRGF0YWJhc2VQYW5lbC5qczogSW1wbGVtZW50IGVy cm9yIGNhbGxiYWNrcyB0byBwYXNzIHRvIGV4ZWN1dGVTcWwoKQorICAgICAgICAgIGFuZCB0cmFu c2FjdGlvbigpLiBSZWZhY3RvcmVkIHNvbWUgY29kZSBmb3IgdGhlIHN1Y2Nlc3MgYW5kIGVycm9y IGNhbGxiYWNrcyB0byB1c2UuCisKIDIwMDctMTEtMTggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxh cEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llai4KSW5kZXg6IHBhZ2Uv aW5zcGVjdG9yL0RhdGFiYXNlUGFuZWwuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcGFnZS9pbnNwZWN0b3Iv RGF0YWJhc2VQYW5lbC5qcwkocmV2aXNpb24gMjc4ODMpCisrKyBwYWdlL2luc3BlY3Rvci9EYXRh YmFzZVBhbmVsLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0xODcsOCArMTg3LDggQEAgcmV0dXJuIHsK ICAgICAgICAgdmFyIHF1ZXJ5ID0gIlNFTEVDVCAqIEZST00gIiArIHRoaXMuY3VycmVudFRhYmxl OwogICAgICAgICB0aGlzLnJlc291cmNlLmRhdGFiYXNlLnRyYW5zYWN0aW9uKGZ1bmN0aW9uKHR4 KQogICAgICAgICB7Ci0gICAgICAgICAgICB0eC5leGVjdXRlU3FsKHF1ZXJ5LCBbXSwgZnVuY3Rp b24odHgsIHJlc3VsdCkgeyBwYW5lbC5icm93c2VRdWVyeUZpbmlzaGVkKHJlc3VsdCkgfSwgZnVu Y3Rpb24odHgsZXJyKXsgYWxlcnQoZXJyLm1lc3NhZ2UpOyB9KTsKLSAgICAgICAgfSk7CisgICAg ICAgICAgICB0eC5leGVjdXRlU3FsKHF1ZXJ5LCBbXSwgZnVuY3Rpb24odHgsIHJlc3VsdCkgeyBw YW5lbC5icm93c2VRdWVyeUZpbmlzaGVkKHJlc3VsdCkgfSwgZnVuY3Rpb24odHgsIGVycm9yKSB7 IHBhbmVsLmJyb3dzZVF1ZXJ5RXJyb3IoZXJyb3IpIH0pOworICAgICAgICB9LCBmdW5jdGlvbih0 eCwgZXJyb3IpIHsgcGFuZWwuYnJvd3NlUXVlcnlFcnJvcihlcnJvcikgfSk7CiAgICAgfSwKIAog ICAgIGJyb3dzZVF1ZXJ5RmluaXNoZWQ6IGZ1bmN0aW9uKHJlc3VsdCkKQEAgLTE5NiwzNyArMTk2 LDQxIEBAIHJldHVybiB7CiAgICAgICAgIHRoaXMudmlld3MuYnJvd3NlLmNvbnRlbnRFbGVtZW50 LnJlbW92ZUNoaWxkcmVuKCk7CiAKICAgICAgICAgdmFyIHRhYmxlID0gdGhpcy5fdGFibGVGb3JS ZXN1bHQocmVzdWx0KTsKLSAgICAgICAgaWYgKHRhYmxlKSB7Ci0gICAgICAgICAgICB2YXIgcm93 Q291bnQgPSB0YWJsZS5nZXRFbGVtZW50c0J5VGFnTmFtZSgidHIiKS5sZW5ndGg7Ci0gICAgICAg ICAgICB2YXIgY29sdW1uQ291bnQgPSB0YWJsZS5nZXRFbGVtZW50c0J5VGFnTmFtZSgidHIiKS5p dGVtKDApLmdldEVsZW1lbnRzQnlUYWdOYW1lKCJ0aCIpLmxlbmd0aDsKKyAgICAgICAgaWYgKCF0 YWJsZSkgeworICAgICAgICAgICAgdmFyIGVtcHR5TXNnRWxlbWVudCA9IGRvY3VtZW50LmNyZWF0 ZUVsZW1lbnQoImRpdiIpOworICAgICAgICAgICAgZW1wdHlNc2dFbGVtZW50LmNsYXNzTmFtZSA9 ICJkYXRhYmFzZS10YWJsZS1lbXB0eSI7CisgICAgICAgICAgICBlbXB0eU1zZ0VsZW1lbnQudGV4 dENvbnRlbnQgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlRoZSDigJwlQOKAnVxudGFibGUgaXMg ZW1wdHkuIiwgdGhpcy5jdXJyZW50VGFibGUpOworICAgICAgICAgICAgdGhpcy52aWV3cy5icm93 c2UuY29udGVudEVsZW1lbnQuYXBwZW5kQ2hpbGQoZW1wdHlNc2dFbGVtZW50KTsKKyAgICAgICAg ICAgIHJldHVybjsKKyAgICAgICAgfQogCi0gICAgICAgICAgICB2YXIgdHIgPSBkb2N1bWVudC5j cmVhdGVFbGVtZW50KCJ0ciIpOwotICAgICAgICAgICAgdHIuY2xhc3NOYW1lID0gImRhdGFiYXNl LXJlc3VsdC1maWxsZXItcm93IjsKLSAgICAgICAgICAgIHRhYmxlLmFwcGVuZENoaWxkKHRyKTsK KyAgICAgICAgdmFyIHJvd0NvdW50ID0gdGFibGUuZ2V0RWxlbWVudHNCeVRhZ05hbWUoInRyIiku bGVuZ3RoOworICAgICAgICB2YXIgY29sdW1uQ291bnQgPSB0YWJsZS5nZXRFbGVtZW50c0J5VGFn TmFtZSgidHIiKS5pdGVtKDApLmdldEVsZW1lbnRzQnlUYWdOYW1lKCJ0aCIpLmxlbmd0aDsKIAot ICAgICAgICAgICAgaWYgKCEocm93Q291bnQgJSAyKSkKLSAgICAgICAgICAgICAgICB0ci5hZGRT dHlsZUNsYXNzKCJhbHRlcm5hdGUiKTsKKyAgICAgICAgdmFyIHRyID0gZG9jdW1lbnQuY3JlYXRl RWxlbWVudCgidHIiKTsKKyAgICAgICAgdHIuY2xhc3NOYW1lID0gImRhdGFiYXNlLXJlc3VsdC1m aWxsZXItcm93IjsKKyAgICAgICAgdGFibGUuYXBwZW5kQ2hpbGQodHIpOworCisgICAgICAgIGlm ICghKHJvd0NvdW50ICUgMikpCisgICAgICAgICAgICB0ci5hZGRTdHlsZUNsYXNzKCJhbHRlcm5h dGUiKTsKKworICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IGNvbHVtbkNvdW50OyArK2kpIHsK KyAgICAgICAgICAgIHZhciB0ZCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInRkIik7CisgICAg ICAgICAgICB0ci5hcHBlbmRDaGlsZCh0ZCk7CisgICAgICAgIH0KIAotICAgICAgICAgICAgZm9y ICh2YXIgaSA9IDA7IGkgPCBjb2x1bW5Db3VudDsgKytpKSB7Ci0gICAgICAgICAgICAgICAgdmFy IHRkID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgidGQiKTsKLSAgICAgICAgICAgICAgICB0ci5h cHBlbmRDaGlsZCh0ZCk7Ci0gICAgICAgICAgICB9CisgICAgICAgIHRhYmxlLmFkZFN0eWxlQ2xh c3MoImRhdGFiYXNlLWJyb3dzZS10YWJsZSIpOworICAgICAgICB0aGlzLnZpZXdzLmJyb3dzZS5j b250ZW50RWxlbWVudC5hcHBlbmRDaGlsZCh0YWJsZSk7CisgICAgfSwKIAotICAgICAgICAgICAg dGFibGUuYWRkU3R5bGVDbGFzcygiZGF0YWJhc2UtYnJvd3NlLXRhYmxlIik7Ci0gICAgICAgICAg ICB0aGlzLnZpZXdzLmJyb3dzZS5jb250ZW50RWxlbWVudC5hcHBlbmRDaGlsZCh0YWJsZSk7Ci0g ICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICBpZiAoIXJlc3VsdC5lcnJvckNvZGUpIHsKLSAg ICAgICAgICAgICAgICB2YXIgZW1wdHlNc2dFbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVu dCgiZGl2Iik7Ci0gICAgICAgICAgICAgICAgZW1wdHlNc2dFbGVtZW50LmNsYXNzTmFtZSA9ICJk YXRhYmFzZS10YWJsZS1lbXB0eSI7Ci0gICAgICAgICAgICAgICAgZW1wdHlNc2dFbGVtZW50LnRl eHRDb250ZW50ID0gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJUaGUg4oCcJUDigJ1cbnRhYmxlIGlz IGVtcHR5LiIsIHRoaXMuY3VycmVudFRhYmxlKTsKLSAgICAgICAgICAgICAgICB0aGlzLnZpZXdz LmJyb3dzZS5jb250ZW50RWxlbWVudC5hcHBlbmRDaGlsZChlbXB0eU1zZ0VsZW1lbnQpOwotICAg ICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgICAgICB2YXIgZXJyb3JNc2dFbGVtZW50ID0g ZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7Ci0gICAgICAgICAgICAgICAgZXJyb3JNc2dF bGVtZW50LmNsYXNzTmFtZSA9ICJkYXRhYmFzZS10YWJsZS1lcnJvciI7Ci0gICAgICAgICAgICAg ICAgZXJyb3JNc2dFbGVtZW50LnRleHRDb250ZW50ID0gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJB biBlcnJvciBvY2N1cnJlZCB0cnlpbmcgdG9cbnJlYWQgdGhlIOKAnCVA4oCdIHRhYmxlLiIsIHRo aXMuY3VycmVudFRhYmxlKTsKLSAgICAgICAgICAgICAgICB0aGlzLnZpZXdzLmJyb3dzZS5jb250 ZW50RWxlbWVudC5hcHBlbmRDaGlsZChlcnJvck1zZ0VsZW1lbnQpOwotICAgICAgICAgICAgfQot ICAgICAgICB9CisgICAgYnJvd3NlUXVlcnlFcnJvcjogZnVuY3Rpb24oZXJyb3IpCisgICAgewor ICAgICAgICB0aGlzLnZpZXdzLmJyb3dzZS5jb250ZW50RWxlbWVudC5yZW1vdmVDaGlsZHJlbigp OworCisgICAgICAgIHZhciBlcnJvck1zZ0VsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50 KCJkaXYiKTsKKyAgICAgICAgZXJyb3JNc2dFbGVtZW50LmNsYXNzTmFtZSA9ICJkYXRhYmFzZS10 YWJsZS1lcnJvciI7CisgICAgICAgIGVycm9yTXNnRWxlbWVudC50ZXh0Q29udGVudCA9IFdlYklu c3BlY3Rvci5VSVN0cmluZygiQW4gZXJyb3Igb2NjdXJyZWQgdHJ5aW5nIHRvXG5yZWFkIHRoZSDi gJwlQOKAnSB0YWJsZS4iLCB0aGlzLmN1cnJlbnRUYWJsZSk7CisgICAgICAgIHRoaXMudmlld3Mu YnJvd3NlLmNvbnRlbnRFbGVtZW50LmFwcGVuZENoaWxkKGVycm9yTXNnRWxlbWVudCk7CiAgICAg fSwKIAogICAgIHF1ZXJ5SW5wdXRLZXlwcmVzczogZnVuY3Rpb24oZXZlbnQpCkBAIC0yNDQsNyAr MjQ4LDcgQEAgcmV0dXJuIHsKICAgICAgICAgfQogICAgIH0sCiAKLSAgICBxdWVyeUZpbmlzaGVk OiBmdW5jdGlvbihxdWVyeSwgcmVzdWx0KQorICAgIGFwcGVuZFF1ZXJ5UmVzdWx0OiBmdW5jdGlv bihxdWVyeSwgcmVzdWx0LCByZXN1bHRDbGFzc05hbWUpCiAgICAgewogICAgICAgICB2YXIgY29t bWFuZEl0ZW0gPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJsaSIpOwogICAgICAgICBjb21tYW5k SXRlbS5jbGFzc05hbWUgPSAiZGF0YWJhc2UtY29tbWFuZCI7CkBAIC0yNTgsMzAgKzI2MiwzOCBA QCByZXR1cm4gewogICAgICAgICByZXN1bHREaXYuY2xhc3NOYW1lID0gImRhdGFiYXNlLWNvbW1h bmQtcmVzdWx0IjsKICAgICAgICAgY29tbWFuZEl0ZW0uYXBwZW5kQ2hpbGQocmVzdWx0RGl2KTsK IAotICAgICAgICBpZiAoIXJlc3VsdC5lcnJvckNvZGUpIHsKLSAgICAgICAgICAgIHZhciB0YWJs ZSA9IHRoaXMuX3RhYmxlRm9yUmVzdWx0KHJlc3VsdCk7Ci0gICAgICAgICAgICBpZiAodGFibGUp Ci0gICAgICAgICAgICAgICAgcmVzdWx0RGl2LmFwcGVuZENoaWxkKHRhYmxlKTsKLSAgICAgICAg fSBlbHNlIHsKLSAgICAgICAgICAgIGlmICh0aGlzLmN1cnJlbnRWaWV3ICE9PSB0aGlzLnZpZXdz LnF1ZXJ5KQotICAgICAgICAgICAgICAgIHRoaXMuY3VycmVudFZpZXcgPSB0aGlzLnZpZXdzLnF1 ZXJ5OworICAgICAgICBpZiAocmVzdWx0Q2xhc3NOYW1lKQorICAgICAgICAgICAgcmVzdWx0RGl2 LmFkZFN0eWxlQ2xhc3MocmVzdWx0Q2xhc3NOYW1lKTsKIAotICAgICAgICAgICAgaWYgKHJlc3Vs dC5lcnJvckNvZGUgPT0gMSkgewotICAgICAgICAgICAgICAgIHJlc3VsdERpdi5jbGFzc05hbWUg Kz0gIiBlcnJvciI7Ci0gICAgICAgICAgICAgICAgcmVzdWx0RGl2LnRleHRDb250ZW50ID0gcmVz dWx0LmVycm9yOwotICAgICAgICAgICAgfSBlbHNlIGlmIChyZXN1bHQuZXJyb3JDb2RlID09IDIp IHsKLSAgICAgICAgICAgICAgICByZXN1bHREaXYuY2xhc3NOYW1lICs9ICIgZXJyb3IiOwotICAg ICAgICAgICAgICAgIHJlc3VsdERpdi50ZXh0Q29udGVudCA9IFdlYkluc3BlY3Rvci5VSVN0cmlu ZygiRGF0YWJhc2Ugbm8gbG9uZ2VyIGhhcyBleHBlY3RlZCB2ZXJzaW9uLiIpOwotICAgICAgICAg ICAgfSBlbHNlIHsKLSAgICAgICAgICAgICAgICByZXN1bHREaXYuY2xhc3NOYW1lICs9ICIgZXJy b3IiOwotICAgICAgICAgICAgICAgIHJlc3VsdERpdi50ZXh0Q29udGVudCA9IFdlYkluc3BlY3Rv ci5VSVN0cmluZygiQW4gdW5leHBlY3RlZCBlcnJvciAlQCBvY2N1cmVkLiIsIHJlc3VsdC5lcnJv ckNvZGUpOwotICAgICAgICAgICAgfQotICAgICAgICB9CisgICAgICAgIGlmICh0eXBlb2YgcmVz dWx0ID09PSAic3RyaW5nIiB8fCByZXN1bHQgaW5zdGFuY2VvZiBTdHJpbmcpCisgICAgICAgICAg ICByZXN1bHREaXYudGV4dENvbnRlbnQgPSByZXN1bHQ7CisgICAgICAgIGVsc2UgaWYgKHJlc3Vs dCAmJiByZXN1bHQubm9kZU5hbWUpCisgICAgICAgICAgICByZXN1bHREaXYuYXBwZW5kQ2hpbGQo cmVzdWx0KTsKIAogICAgICAgICB0aGlzLnZpZXdzLnF1ZXJ5LmNvbW1hbmRMaXN0RWxlbWVudC5h cHBlbmRDaGlsZChjb21tYW5kSXRlbSk7CiAgICAgICAgIGNvbW1hbmRJdGVtLnNjcm9sbEludG9W aWV3KGZhbHNlKTsKICAgICB9LAogCisgICAgcXVlcnlGaW5pc2hlZDogZnVuY3Rpb24ocXVlcnks IHJlc3VsdCkKKyAgICB7CisgICAgICAgIHRoaXMuYXBwZW5kUXVlcnlSZXN1bHQocXVlcnksIHRo aXMuX3RhYmxlRm9yUmVzdWx0KHJlc3VsdCkpOworICAgIH0sCisKKyAgICBxdWVyeUVycm9yOiBm dW5jdGlvbihxdWVyeSwgZXJyb3IpCisgICAgeworICAgICAgICBpZiAodGhpcy5jdXJyZW50Vmll dyAhPT0gdGhpcy52aWV3cy5xdWVyeSkKKyAgICAgICAgICAgIHRoaXMuY3VycmVudFZpZXcgPSB0 aGlzLnZpZXdzLnF1ZXJ5OworCisgICAgICAgIGlmIChlcnJvci5jb2RlID09IDEpCisgICAgICAg ICAgICB2YXIgbWVzc2FnZSA9IGVycm9yLm1lc3NhZ2U7CisgICAgICAgIGVsc2UgaWYgKGVycm9y LmNvZGUgPT0gMikKKyAgICAgICAgICAgIHZhciBtZXNzYWdlID0gV2ViSW5zcGVjdG9yLlVJU3Ry aW5nKCJEYXRhYmFzZSBubyBsb25nZXIgaGFzIGV4cGVjdGVkIHZlcnNpb24uIik7CisgICAgICAg IGVsc2UKKyAgICAgICAgICAgIHZhciBtZXNzYWdlID0gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJB biB1bmV4cGVjdGVkIGVycm9yICVAIG9jY3VyZWQuIiwgZXJyb3IuY29kZSk7CisKKyAgICAgICAg dGhpcy5hcHBlbmRRdWVyeVJlc3VsdChxdWVyeSwgbWVzc2FnZSwgImVycm9yIik7CisgICAgfSwK KwogICAgIF9vblF1ZXJ5SW5wdXRFbnRlclByZXNzZWQ6IGZ1bmN0aW9uKGV2ZW50KQogICAgIHsK ICAgICAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKQEAgLTI5NCw4ICszMDYsOCBAQCByZXR1 cm4gewogICAgICAgICB2YXIgcGFuZWwgPSB0aGlzOwogICAgICAgICB0aGlzLnJlc291cmNlLmRh dGFiYXNlLnRyYW5zYWN0aW9uKGZ1bmN0aW9uKHR4KSAKICAgICAgICAgewotICAgICAgICAgICAg dHguZXhlY3V0ZVNxbChxdWVyeSwgW10sIGZ1bmN0aW9uKHR4LCByZXN1bHQpIHsgcGFuZWwucXVl cnlGaW5pc2hlZChxdWVyeSwgcmVzdWx0KSB9LCBmdW5jdGlvbih0eCxlcnIpeyBhbGVydChlcnIu bWVzc2FnZSk7IH0pOwotICAgICAgICB9KTsKKyAgICAgICAgICAgIHR4LmV4ZWN1dGVTcWwocXVl cnksIFtdLCBmdW5jdGlvbih0eCwgcmVzdWx0KSB7IHBhbmVsLnF1ZXJ5RmluaXNoZWQocXVlcnks IHJlc3VsdCkgfSwgZnVuY3Rpb24odHgsIGVycm9yKSB7IHBhbmVsLnF1ZXJ5RXJyb3IocXVlcnks IGVycm9yKSB9KTsKKyAgICAgICAgfSwgZnVuY3Rpb24odHgsIGVycm9yKSB7IHBhbmVsLnF1ZXJ5 RXJyb3IocXVlcnksIGVycm9yKSB9KTsKIAogICAgICAgICB0aGlzLnF1ZXJ5UHJvbXB0SGlzdG9y eS5wdXNoKHF1ZXJ5KTsKICAgICAgICAgdGhpcy5xdWVyeVByb21wdEhpc3RvcnlPZmZzZXQgPSAw Owo=