160391 2016-07-31 13:17:03 -0700 [GTK] Document how to initialize WebKitFaviconDatabase 2016-08-03 07:37:02 -0700 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro berto bugs-noreply cgarcia commit-queue gustavo mcatanzaro mrobinson oldest_to_newest 1215961 0 mcatanzaro 2016-07-31 13:17:03 -0700 webkit_favicon_database_get_favicon_finish() can return WEBKIT_FAVICON_DATABASE_ERROR_NOT_INITIALIZED but the only documentation on how to avoid this is in webkit_web_context_set_favicon_database_directory(), which is not mentioned anywhere in the WebKitFaviconDatabase documentation. 1216771 1 285188 mcatanzaro 2016-08-02 20:40:28 -0700 Created attachment 285188 Patch 1216775 2 commit-queue 2016-08-02 20:46:33 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1216912 3 285188 commit-queue 2016-08-03 07:36:58 -0700 Comment on attachment 285188 Patch Clearing flags on attachment: 285188 Committed r204080: <http://trac.webkit.org/changeset/204080> 1216913 4 commit-queue 2016-08-03 07:37:02 -0700 All reviewed patches have been landed. Closing bug. 285188 2016-08-02 20:40:28 -0700 2016-08-03 07:36:58 -0700 Patch bug-160391-20160802223906.patch text/plain 1834 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0MDY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjdkNzA4YzM1OTRmMjZj YzI4YTk1ODNiNTU2N2ViZGZhMTU2Mjk3YS4uOWM0ZmVhNzk2ODU0MWM3NGYwYzJkZWE2YzRiMWNl ODMyNDUwOWM3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE2LTA4LTAyICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBE b2N1bWVudCBob3cgdG8gaW5pdGlhbGl6ZSBXZWJLaXRGYXZpY29uRGF0YWJhc2UKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDM5MQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9n dGsvV2ViS2l0RmF2aWNvbkRhdGFiYXNlLmNwcDoKKwogMjAxNi0wOC0wMiAgVGltIEhvcnRvbiAg PHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMjAzMzg1 KTogRnJlcXVlbnQgUkVMRUFTRV9BU1NFUlQgaW4gV2ViS2l0OjpSZW1vdGVMYXllclRyZWVEcmF3 aW5nQXJlYTo6Zmx1c2hMYXllcnMoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9ndGsvV2ViS2l0RmF2aWNvbkRhdGFiYXNlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEZhdmljb25EYXRhYmFzZS5jcHAKaW5kZXggODBhYzE1YTcy ZTUzNDUzY2QyMjc3OGNjY2VjZWNiODk5OTIwMmJkMy4uNzQ2NTRiYjRmODg4ZTQ4NjM4ZmYzZTUz NmQ1MDU5NmVmMDI5MjAyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9ndGsvV2ViS2l0RmF2aWNvbkRhdGFiYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2d0ay9XZWJLaXRGYXZpY29uRGF0YWJhc2UuY3BwCkBAIC0yNTksNiArMjU5LDEy IEBAIEdRdWFyayB3ZWJraXRfZmF2aWNvbl9kYXRhYmFzZV9lcnJvcl9xdWFyayh2b2lkKQogICog VGhpcyBpcyBhbiBhc3luY2hyb25vdXMgbWV0aG9kLiBXaGVuIHRoZSBvcGVyYXRpb24gaXMgZmlu aXNoZWQsIGNhbGxiYWNrIHdpbGwKICAqIGJlIGludm9rZWQuIFlvdSBjYW4gdGhlbiBjYWxsIHdl YmtpdF9mYXZpY29uX2RhdGFiYXNlX2dldF9mYXZpY29uX2ZpbmlzaCgpCiAgKiB0byBnZXQgdGhl IHJlc3VsdCBvZiB0aGUgb3BlcmF0aW9uLgorICoKKyAqIFlvdSBtdXN0IGNhbGwgd2Via2l0X3dl Yl9jb250ZXh0X3NldF9mYXZpY29uX2RhdGFiYXNlX2RpcmVjdG9yeSgpIGZvcgorICogdGhlICNX ZWJLaXRXZWJDb250ZXh0IGFzc29jaWF0ZWQgd2l0aCB0aGlzICNXZWJLaXRGYXZpY29uRGF0YWJh c2UKKyAqIGJlZm9yZSBhdHRlbXB0aW5nIHRvIHVzZSB0aGlzIGZ1bmN0aW9uOyBvdGhlcndpc2Us CisgKiB3ZWJraXRfZmF2aWNvbl9kYXRhYmFzZV9nZXRfZmF2aWNvbl9maW5pc2goKSB3aWxsIHJl dHVybgorICogJVdFQktJVF9GQVZJQ09OX0RBVEFCQVNFX0VSUk9SX05PVF9JTklUSUFMSVpFRC4K ICAqLwogdm9pZCB3ZWJraXRfZmF2aWNvbl9kYXRhYmFzZV9nZXRfZmF2aWNvbihXZWJLaXRGYXZp Y29uRGF0YWJhc2UqIGRhdGFiYXNlLCBjb25zdCBnY2hhciogcGFnZVVSSSwgR0NhbmNlbGxhYmxl KiBjYW5jZWxsYWJsZSwgR0FzeW5jUmVhZHlDYWxsYmFjayBjYWxsYmFjaywgZ3BvaW50ZXIgdXNl ckRhdGEpCiB7Cg==