160373 2016-07-29 20:07:16 -0700 Web Inspector: Waterfall graph in Network tab shows too much whitespace/dead time 2016-08-01 14:05:06 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1215806 0 mattbaker 2016-07-29 20:07:16 -0700 Summary: Waterfall graph in Network tab shows too much whitespace/dead time. There are two issues: 1) The end time keeps growing until stopUpdatingCurrentTime is called, which is done on a 250ms debounce. 2) WebInspector.timelineManager.persistentNetworkTimeline.startTime is used as the zero time, and clearing the grid doesn't affect this value. 1215807 1 webkit-bug-importer 2016-07-29 20:07:51 -0700 <rdar://problem/27622485> 1215809 2 284931 mattbaker 2016-07-29 20:21:04 -0700 Created attachment 284931 [Patch] Proposed Fix 1216260 3 284931 commit-queue 2016-08-01 14:05:03 -0700 Comment on attachment 284931 [Patch] Proposed Fix Clearing flags on attachment: 284931 Committed r203986: <http://trac.webkit.org/changeset/203986> 1216261 4 commit-queue 2016-08-01 14:05:06 -0700 All reviewed patches have been landed. Closing bug. 284931 2016-07-29 20:21:04 -0700 2016-08-01 14:05:03 -0700 [Patch] Proposed Fix bug-160373-20160729201949.patch text/plain 6218 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzOTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAx Yjc5OWU0YWUxOGQwM2RmZWZjMmE0MDhhYjVlNGY3NWNjNTYwZmY3Li42NjIyZGQyOThiYWE5NDU5 NjU2YTZmZGY2YmM0MjkwY2M4YmI3MWYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwzNSBAQAogMjAxNi0wNy0yOSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogV2F0ZXJmYWxsIGdyYXBoIGluIE5ldHdvcmsgdGFi IHNob3dzIHRvbyBtdWNoIHdoaXRlc3BhY2UvZGVhZCB0aW1lCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjAzNzMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUcmFjayB0aGUgc3RhcnQgYW5kIGVuZCB0aW1l IHNlcGFyYXRlIGZyb20gdGhlIHJ1bGVyIHRvIHJlbW92ZQorICAgICAgICBsZWFkaW5nL3RyYWls aW5nIHdoaXRlc3BhY2UgaW4gdGhlIGdyYXBoLiBBbHNvIHByZXZlbnQgbmV0d29yaworICAgICAg ICByZWNvcmQgYmFycyBmcm9tIGJlaW5nIGNsaXBwZWQuCisKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL1ZpZXdzL05ldHdvcmtHcmlkQ29udGVudFZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuTmV0d29ya0dyaWRDb250ZW50Vmlldyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTmV0d29y a0dyaWRDb250ZW50Vmlldy5wcm90b3R5cGUuZ2V0IHplcm9UaW1lKToKKyAgICAgICAgU2V0IGVx dWFsIHRvIHRoZSBydWxlciBzdGFydCB0aW1lLgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5ldHdv cmtHcmlkQ29udGVudFZpZXcucHJvdG90eXBlLnJlc2V0KToKKyAgICAgICAgUmVzZXQgc3RhcnQg YW5kIGVuZCB0aW1lLgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5ldHdvcmtHcmlkQ29udGVudFZp ZXcucHJvdG90eXBlLmxheW91dCk6CisgICAgICAgIFNldCB0aGUgaW5pdGlhbCB2YWx1ZXMgZm9y IHJ1bGVyIHN0YXJ0L3plcm8gdGltZSBpZiBuZWVkZWQuCisgICAgICAgIChXZWJJbnNwZWN0b3Iu TmV0d29ya0dyaWRDb250ZW50Vmlldy5wcm90b3R5cGUuX25ldHdvcmtUaW1lbGluZVJlY29yZEFk ZGVkKToKKyAgICAgICAgU2V0IHRoZSBzdGFydCB0aW1lIGlmIG5lZWRlZC4KKyAgICAgICAgUmVk dWNlIGRlYm91bmNlIGZyb20gMjUwbXMgdG8gMTUwbXMuIFRoaXMgcHJldmVudHMgdGhlIGN1cnJl bnQgdGltZSBmcm9tCisgICAgICAgIGV4Y2VlZGluZyB0aGUgZW5kIHRpbWUgYnkgYXMgd2lkZSBh IG1hcmdpbiwgd2hpbGUga2VlcGluZyB0aGUgY3VycmVudAorICAgICAgICB0aW1lICJ0aW1lciIg ZnJvbSBiZWluZyByZXN0YXJ0ZWQgdG9vIGZyZXF1ZW50bHkuCisKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5OZXR3b3JrR3JpZENvbnRlbnRWaWV3LnByb3RvdHlwZS5fc3RvcFVwZGF0aW5nQ3VycmVu dFRpbWUpOgorICAgICAgICBVcGRhdGUgdGhlIHJ1bGVyIGVuZCB0aW1lIGFuZCBzY2hlZHVsZSBh IGxheW91dC4KKyAgICAgICAgQWRkIHBhZGRpbmcgZXF1YWwgdG8gdGhlIHRpbWUgbmVlZGVkIHRv IGRyYXcgYSBuZXR3b3JrIGJhciBhdCBtaW5pbXVtIHdpZHRoCisgICAgICAgIHRvIHByZXZlbnQg YmFycyBmcm9tIGJlaW5nIGNsaXBwZWQuCisKKzIwMTYtMDctMjkgIE1hdHQgQmFrZXIgIDxtYXR0 YmFrZXJAYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEluYWN0aXZlL2FjdGl2 ZSBuZXR3b3JrIGJhciBzZWdtZW50cyBvdmVybGFwIHdoZW4gbGF0ZW5jeSBpcyB6ZXJvCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjAxNDcKICAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzI3NTE2MDA3PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya0dyaWRDb250ZW50Vmlldy5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtHcmlkQ29udGVu dFZpZXcuanMKaW5kZXggYWNiM2M4OGFjZTliZjIwMTg2YWY3OTI0MTNjMDUwNWJiMTczYTRjMy4u ZjE5ZjhjMTI5MzExZjYxZTk4OGExZmQzZWNjNjc0YzJmMWJhM2M1ZCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya0dyaWRDb250ZW50 Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9O ZXR3b3JrR3JpZENvbnRlbnRWaWV3LmpzCkBAIC0xMDcsNiArMTA3LDggQEAgV2ViSW5zcGVjdG9y Lk5ldHdvcmtHcmlkQ29udGVudFZpZXcgPSBjbGFzcyBOZXR3b3JrR3JpZENvbnRlbnRWaWV3IGV4 dGVuZHMgV2ViSW4KICAgICAgICAgdGhpcy5fcGVuZGluZ1JlY29yZHMgPSBbXTsKICAgICAgICAg dGhpcy5fbG9hZGluZ1Jlc291cmNlQ291bnQgPSAwOwogICAgICAgICB0aGlzLl9sYXN0VXBkYXRl VGltZXN0YW1wID0gTmFOOworICAgICAgICB0aGlzLl9zdGFydFRpbWUgPSBOYU47CisgICAgICAg IHRoaXMuX2VuZFRpbWUgPSBOYU47CiAgICAgICAgIHRoaXMuX3NjaGVkdWxlZEN1cnJlbnRUaW1l VXBkYXRlSWRlbnRpZmllciA9IHVuZGVmaW5lZDsKICAgICB9CiAKQEAgLTExNiw2ICsxMTgsNyBA QCBXZWJJbnNwZWN0b3IuTmV0d29ya0dyaWRDb250ZW50VmlldyA9IGNsYXNzIE5ldHdvcmtHcmlk Q29udGVudFZpZXcgZXh0ZW5kcyBXZWJJbgogICAgIGdldCBzdGFydFRpbWUoKSB7IHJldHVybiB0 aGlzLl90aW1lbGluZVJ1bGVyLnN0YXJ0VGltZTsgfQogICAgIGdldCBjdXJyZW50VGltZSgpIHsg cmV0dXJuIHRoaXMuZW5kVGltZSB8fCB0aGlzLnN0YXJ0VGltZTsgfQogICAgIGdldCBlbmRUaW1l KCkgeyByZXR1cm4gdGhpcy5fdGltZWxpbmVSdWxlci5lbmRUaW1lOyB9CisgICAgZ2V0IHplcm9U aW1lKCkgeyByZXR1cm4gdGhpcy5fdGltZWxpbmVSdWxlci5zdGFydFRpbWU7IH0KIAogICAgIGdl dCBzZWxlY3Rpb25QYXRoQ29tcG9uZW50cygpCiAgICAgewpAQCAtMTI3LDExICsxMzAsNiBAQCBX ZWJJbnNwZWN0b3IuTmV0d29ya0dyaWRDb250ZW50VmlldyA9IGNsYXNzIE5ldHdvcmtHcmlkQ29u dGVudFZpZXcgZXh0ZW5kcyBXZWJJbgogICAgICAgICByZXR1cm4gW3BhdGhDb21wb25lbnRdOwog ICAgIH0KIAotICAgIGdldCB6ZXJvVGltZSgpCi0gICAgewotICAgICAgICByZXR1cm4gV2ViSW5z cGVjdG9yLnRpbWVsaW5lTWFuYWdlci5wZXJzaXN0ZW50TmV0d29ya1RpbWVsaW5lLnN0YXJ0VGlt ZTsKLSAgICB9Ci0KICAgICBnZXQgbmF2aWdhdGlvbkl0ZW1zKCkKICAgICB7CiAgICAgICAgIHJl dHVybiBbdGhpcy5fY2xlYXJOZXR3b3JrSXRlbXNOYXZpZ2F0aW9uSXRlbV07CkBAIC0xNjksNiAr MTY3LDggQEAgV2ViSW5zcGVjdG9yLk5ldHdvcmtHcmlkQ29udGVudFZpZXcgPSBjbGFzcyBOZXR3 b3JrR3JpZENvbnRlbnRWaWV3IGV4dGVuZHMgV2ViSW4KIAogICAgICAgICB0aGlzLl9sb2FkaW5n UmVzb3VyY2VDb3VudCA9IDA7CiAgICAgICAgIHRoaXMuX2xhc3RVcGRhdGVUaW1lc3RhbXAgPSBO YU47CisgICAgICAgIHRoaXMuX3N0YXJ0VGltZSA9IE5hTjsKKyAgICAgICAgdGhpcy5fZW5kVGlt ZSA9IE5hTjsKIAogICAgICAgICB0aGlzLl90aW1lbGluZVJ1bGVyLnN0YXJ0VGltZSA9IDA7CiAg ICAgICAgIHRoaXMuX3RpbWVsaW5lUnVsZXIuZW5kVGltZSA9IDA7CkBAIC0xNzgsOCArMTc4LDEw IEBAIFdlYkluc3BlY3Rvci5OZXR3b3JrR3JpZENvbnRlbnRWaWV3ID0gY2xhc3MgTmV0d29ya0dy aWRDb250ZW50VmlldyBleHRlbmRzIFdlYkluCiAKICAgICBsYXlvdXQoKQogICAgIHsKLSAgICAg ICAgdGhpcy5fdGltZWxpbmVSdWxlci56ZXJvVGltZSA9IHRoaXMuemVyb1RpbWU7Ci0gICAgICAg IHRoaXMuX3RpbWVsaW5lUnVsZXIuc3RhcnRUaW1lID0gdGhpcy56ZXJvVGltZTsKKyAgICAgICAg aWYgKCFpc05hTih0aGlzLl9zdGFydFRpbWUpKSB7CisgICAgICAgICAgICB0aGlzLl90aW1lbGlu ZVJ1bGVyLnplcm9UaW1lID0gdGhpcy5fc3RhcnRUaW1lOworICAgICAgICAgICAgdGhpcy5fdGlt ZWxpbmVSdWxlci5zdGFydFRpbWUgPSB0aGlzLl9zdGFydFRpbWU7CisgICAgICAgIH0KIAogICAg ICAgICBpZiAodGhpcy5zdGFydFRpbWUgPj0gdGhpcy5lbmRUaW1lKQogICAgICAgICAgICAgcmV0 dXJuOwpAQCAtMjE5LDcgKzIyMSw3IEBAIFdlYkluc3BlY3Rvci5OZXR3b3JrR3JpZENvbnRlbnRW aWV3ID0gY2xhc3MgTmV0d29ya0dyaWRDb250ZW50VmlldyBleHRlbmRzIFdlYkluCiAKICAgICBf bmV0d29ya1RpbWVsaW5lUmVjb3JkQWRkZWQoZXZlbnQpCiAgICAgewotICAgICAgICB2YXIgcmVz b3VyY2VUaW1lbGluZVJlY29yZCA9IGV2ZW50LmRhdGEucmVjb3JkOworICAgICAgICBsZXQgcmVz b3VyY2VUaW1lbGluZVJlY29yZCA9IGV2ZW50LmRhdGEucmVjb3JkOwogICAgICAgICBjb25zb2xl LmFzc2VydChyZXNvdXJjZVRpbWVsaW5lUmVjb3JkIGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLlJl c291cmNlVGltZWxpbmVSZWNvcmQpOwogCiAgICAgICAgIGxldCB1cGRhdGUgPSAoZXZlbnQpID0+ IHsKQEAgLTIzMyw3ICsyMzUsOCBAQCBXZWJJbnNwZWN0b3IuTmV0d29ya0dyaWRDb250ZW50Vmll dyA9IGNsYXNzIE5ldHdvcmtHcmlkQ29udGVudFZpZXcgZXh0ZW5kcyBXZWJJbgogICAgICAgICAg ICAgaWYgKHRoaXMuX2xvYWRpbmdSZXNvdXJjZUNvdW50KQogICAgICAgICAgICAgICAgIHJldHVy bjsKIAotICAgICAgICAgICAgdGhpcy5kZWJvdW5jZSgyNTApLl9zdG9wVXBkYXRpbmdDdXJyZW50 VGltZSgpOworICAgICAgICAgICAgdGhpcy5fZW5kVGltZSA9IHJlc291cmNlVGltZWxpbmVSZWNv cmQuZW5kVGltZTsKKyAgICAgICAgICAgIHRoaXMuZGVib3VuY2UoMTUwKS5fc3RvcFVwZGF0aW5n Q3VycmVudFRpbWUoKTsKICAgICAgICAgfTsKIAogICAgICAgICB0aGlzLl9wZW5kaW5nUmVjb3Jk cy5wdXNoKHJlc291cmNlVGltZWxpbmVSZWNvcmQpOwpAQCAtMjQ5LDggKzI1MiwxMiBAQCBXZWJJ bnNwZWN0b3IuTmV0d29ya0dyaWRDb250ZW50VmlldyA9IGNsYXNzIE5ldHdvcmtHcmlkQ29udGVu dFZpZXcgZXh0ZW5kcyBXZWJJbgogICAgICAgICByZXNvdXJjZS5hZGRFdmVudExpc3RlbmVyKFdl Ykluc3BlY3Rvci5SZXNvdXJjZS5FdmVudC5Mb2FkaW5nRGlkRmFpbCwgdXBkYXRlLCB0aGlzKTsK IAogICAgICAgICB0aGlzLl9sb2FkaW5nUmVzb3VyY2VDb3VudCsrOwotICAgICAgICBpZiAodGhp cy5fbG9hZGluZ1Jlc291cmNlQ291bnQgJiYgIXRoaXMuX3NjaGVkdWxlZEN1cnJlbnRUaW1lVXBk YXRlSWRlbnRpZmllcikKKyAgICAgICAgaWYgKHRoaXMuX2xvYWRpbmdSZXNvdXJjZUNvdW50ICYm ICF0aGlzLl9zY2hlZHVsZWRDdXJyZW50VGltZVVwZGF0ZUlkZW50aWZpZXIpIHsKKyAgICAgICAg ICAgIGlmIChpc05hTih0aGlzLl9zdGFydFRpbWUpKQorICAgICAgICAgICAgICAgIHRoaXMuX3N0 YXJ0VGltZSA9IHJlc291cmNlVGltZWxpbmVSZWNvcmQuc3RhcnRUaW1lOworCiAgICAgICAgICAg ICB0aGlzLl9zdGFydFVwZGF0aW5nQ3VycmVudFRpbWUoKTsKKyAgICAgICAgfQogICAgIH0KIAog ICAgIF90cmVlRWxlbWVudFBhdGhDb21wb25lbnRTZWxlY3RlZChldmVudCkKQEAgLTMyNSw2ICsz MzIsOSBAQCBXZWJJbnNwZWN0b3IuTmV0d29ya0dyaWRDb250ZW50VmlldyA9IGNsYXNzIE5ldHdv cmtHcmlkQ29udGVudFZpZXcgZXh0ZW5kcyBXZWJJbgogCiAgICAgICAgIGNhbmNlbEFuaW1hdGlv bkZyYW1lKHRoaXMuX3NjaGVkdWxlZEN1cnJlbnRUaW1lVXBkYXRlSWRlbnRpZmllcik7CiAgICAg ICAgIHRoaXMuX3NjaGVkdWxlZEN1cnJlbnRUaW1lVXBkYXRlSWRlbnRpZmllciA9IHVuZGVmaW5l ZDsKKworICAgICAgICB0aGlzLl90aW1lbGluZVJ1bGVyLmVuZFRpbWUgPSB0aGlzLl9lbmRUaW1l ICsgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkQmFyLk1pbmltdW1XaWR0aFBpeGVscyAqIHRo aXMuc2Vjb25kc1BlclBpeGVsOworICAgICAgICB0aGlzLm5lZWRzTGF5b3V0KCk7CiAgICAgfQog fTsKIAo=