160371 2016-07-29 18:50:22 -0700 Add an option to run the MotionMark tests with classic tile size (512x512) 2016-08-01 11:46:42 -0700 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sabouhallawa sabouhallawa cdumez commit-queue dino jonlee rniwa simon.fraser oldest_to_newest 1215795 0 sabouhallawa 2016-07-29 18:50:22 -0700 This option allows measuring the performance of the css tests without the big tile improvement. 1215800 1 284929 sabouhallawa 2016-07-29 19:14:37 -0700 Created attachment 284929 Patch 1215998 2 284929 darin 2016-07-31 20:55:15 -0700 Comment on attachment 284929 Patch Seems OK for now, but seems a bit tied to implementation details of WebKit as opposed to general web platform principles. 1216172 3 sabouhallawa 2016-08-01 11:24:48 -0700 (In reply to comment #2) > Comment on attachment 284929 [details] > Patch > > Seems OK for now, but seems a bit tied to implementation details of WebKit > as opposed to general web platform principles. This is a debug option which is only visible in the MotionMark debug page. We use the debug page to test MotionMark or WebKit implementation details. We can decide which tweaks can make the measurements more accurate and how we can improve the WebKit performance. Also I think tiling is an implementation detail and I am not aware of any specs that specify the tile implementation or size. 1216187 4 284929 commit-queue 2016-08-01 11:46:36 -0700 Comment on attachment 284929 Patch Clearing flags on attachment: 284929 Committed r203978: <http://trac.webkit.org/changeset/203978> 1216188 5 commit-queue 2016-08-01 11:46:42 -0700 All reviewed patches have been landed. Closing bug. 284929 2016-07-29 19:14:37 -0700 2016-08-01 11:46:36 -0700 Patch bug-160371-20160729191322.patch text/plain 5520 sabouhallawa SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMDM5MzYpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE2LTA3LTI5ICBT YWlkIEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRk IGFuIG9wdGlvbiB0byBydW4gdGhlIE1vdGlvbk1hcmsgdGVzdHMgd2l0aCBjbGFzc2ljIHRpbGUg c2l6ZSAoNTEyeDUxMikKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE2MDM3MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFNldHRpbmcgdGhlIGJvZHkgdG8gbGFyZ2Ugc2l6ZSAoMzAwMHgzMDAwKSBhbmQgb3Zl cmZsb3cgdG8gc2Nyb2xsIGZvcmNlcworICAgICAgICB0aGUgY2xhc3NpYyB0aWxlIHNpemUgKDUx Mng1MTIpLiBUaGlzIG9wdGlvbiBkb2VzIG5vdCBhZmZlY3QgdGhlIGNhbnZhcworICAgICAgICB0 ZXN0cyBiZWNhdXNlIHRoZSBjYW52YXMgaXMgZGlzcGxheWVkIG9uIG9uZSB0aWxlIHJlZ2FyZGxl c3Mgb2YgaXRzIHNpemUuCisKKyAgICAgICAgKiBBbmltb21ldGVyL2RldmVsb3Blci5odG1sOgor ICAgICAgICAqIEFuaW1vbWV0ZXIvcmVzb3VyY2VzL2RlYnVnLXJ1bm5lci9hbmltb21ldGVyLmNz czoKKyAgICAgICAgKGJvZHkuc2hvd2luZy10ZXN0LWNvbnRhaW5lci50aWxlcy1iaWcpOgorICAg ICAgICAoYm9keS5zaG93aW5nLXRlc3QtY29udGFpbmVyLnRpbGVzLWNsYXNzaWMpOgorICAgICAg ICAqIEFuaW1vbWV0ZXIvcmVzb3VyY2VzL2RlYnVnLXJ1bm5lci9hbmltb21ldGVyLmpzOgorICAg ICAgICAqIEFuaW1vbWV0ZXIvcmVzb3VyY2VzL3J1bm5lci9hbmltb21ldGVyLmpzOgorICAgICAg ICAod2luZG93LmJlbmNobWFya0NvbnRyb2xsZXIuc3RhcnRCZW5jaG1hcmspOgorCiAyMDE2LTA2 LTI5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgR2VuZXJhdG9y cyB2aW9sYXRlIGJ5dGVjb2RlIGxpdmVuZXNzIHZhbGlkYXRpb24KSW5kZXg6IFBlcmZvcm1hbmNl VGVzdHMvQW5pbW9tZXRlci9kZXZlbG9wZXIuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBQZXJmb3JtYW5j ZVRlc3RzL0FuaW1vbWV0ZXIvZGV2ZWxvcGVyLmh0bWwJKHJldmlzaW9uIDIwMzkyMykKKysrIFBl cmZvcm1hbmNlVGVzdHMvQW5pbW9tZXRlci9kZXZlbG9wZXIuaHRtbAkod29ya2luZyBjb3B5KQpA QCAtNDgsNiArNDgsMTMgQEAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDwv dWw+CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDwvbGk+CiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIDxsaT4KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIDxoMz5UaWxlczo8L2gzPgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg PHVsPgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDxsaT48bGFiZWw+ PGlucHV0IG5hbWU9InRpbGVzIiB0eXBlPSJyYWRpbyIgdmFsdWU9ImJpZyIgY2hlY2tlZD4gQmln IHRpbGVzPC9sYWJlbD48L2xpPgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIDxsaT48bGFiZWw+PGlucHV0IG5hbWU9InRpbGVzIiB0eXBlPSJyYWRpbyIgdmFsdWU9ImNs YXNzaWMiPiBDbGFzc2ljIHRpbGVzICg1MTJ4NTEyKTwvbGFiZWw+PC9saT4KKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIDwvdWw+CisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIDwvbGk+CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDxsaT4KICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDxoMz5BZGp1c3RpbmcgdGhlIHRlc3QgY29t cGxleGl0eTo8L2gzPgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPHVsPgog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDxsaT48bGFiZWw+PGlucHV0 IG5hbWU9ImNvbnRyb2xsZXIiIHR5cGU9InJhZGlvIiB2YWx1ZT0iZml4ZWQiPiBLZWVwIGF0IGEg Zml4ZWQgY29tcGxleGl0eTwvbGFiZWw+PC9saT4KSW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQW5p bW9tZXRlci9yZXNvdXJjZXMvZGVidWctcnVubmVyL2FuaW1vbWV0ZXIuY3NzCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFBlcmZvcm1hbmNlVGVzdHMvQW5pbW9tZXRlci9yZXNvdXJjZXMvZGVidWctcnVubmVyL2Fu aW1vbWV0ZXIuY3NzCShyZXZpc2lvbiAyMDM5MjMpCisrKyBQZXJmb3JtYW5jZVRlc3RzL0FuaW1v bWV0ZXIvcmVzb3VyY2VzL2RlYnVnLXJ1bm5lci9hbmltb21ldGVyLmNzcwkod29ya2luZyBjb3B5 KQpAQCAtMzUwLDYgKzM1MCwxNiBAQCBsYWJlbC50cmVlLWxhYmVsIHsKICAgICBiYWNrZ3JvdW5k LWNvbG9yOiByZ2IoMjM1LCA5NiwgMzIpOwogfQogCitib2R5LnNob3dpbmctdGVzdC1jb250YWlu ZXIudGlsZXMtYmlnIHsKKyAgICBvdmVyZmxvdzogaGlkZGVuOworfQorCitib2R5LnNob3dpbmct dGVzdC1jb250YWluZXIudGlsZXMtY2xhc3NpYyB7CisgICAgd2lkdGg6IDMwMDBweDsKKyAgICBo ZWlnaHQ6IDMwMDBweDsKKyAgICBvdmVyZmxvdzogc2Nyb2xsOworfQorCiAvKiAtLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLSAqLwogLyogICAgICAgICAgICAgICAgICAgICAgICAgICBSZXN1bHRzIFNlY3Rpb24g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKi8KIC8qIC0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t ICovCkluZGV4OiBQZXJmb3JtYW5jZVRlc3RzL0FuaW1vbWV0ZXIvcmVzb3VyY2VzL2RlYnVnLXJ1 bm5lci9hbmltb21ldGVyLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1hbmNlVGVzdHMvQW5pbW9t ZXRlci9yZXNvdXJjZXMvZGVidWctcnVubmVyL2FuaW1vbWV0ZXIuanMJKHJldmlzaW9uIDIwMzky MykKKysrIFBlcmZvcm1hbmNlVGVzdHMvQW5pbW9tZXRlci9yZXNvdXJjZXMvZGVidWctcnVubmVy L2FuaW1vbWV0ZXIuanMJKHdvcmtpbmcgY29weSkKQEAgLTIxNiw2ICsyMTYsMTQgQEAgd2luZG93 Lm9wdGlvbnNNYW5hZ2VyID0KICAgICAgICAgZG9jdW1lbnQuYm9keS5jbGFzc0xpc3QucmVtb3Zl KCJkaXNwbGF5LXByb2dyZXNzLWJhciIpOwogCiAgICAgICAgIGRvY3VtZW50LmJvZHkuY2xhc3NM aXN0LmFkZCgiZGlzcGxheS0iICsgb3B0aW9uc01hbmFnZXIudmFsdWVGb3JPcHRpb24oImRpc3Bs YXkiKSk7CisgICAgfSwKKyAgICAKKyAgICB1cGRhdGVUaWxlczogZnVuY3Rpb24oKQorICAgIHsK KyAgICAgICAgZG9jdW1lbnQuYm9keS5jbGFzc0xpc3QucmVtb3ZlKCJ0aWxlcy1iaWciKTsKKyAg ICAgICAgZG9jdW1lbnQuYm9keS5jbGFzc0xpc3QucmVtb3ZlKCJ0aWxlcy1jbGFzc2ljIik7CisK KyAgICAgICAgZG9jdW1lbnQuYm9keS5jbGFzc0xpc3QuYWRkKCJ0aWxlcy0iICsgb3B0aW9uc01h bmFnZXIudmFsdWVGb3JPcHRpb24oInRpbGVzIikpOwogICAgIH0KIH07CiAKQEAgLTUwMyw2ICs1 MTEsNyBAQCBVdGlsaXRpZXMuZXh0ZW5kT2JqZWN0KHdpbmRvdy5iZW5jaG1hcmtDCiAgICAgICAg IGRvY3VtZW50LmZvcm1zWyJjb21wbGV4aXR5LWdyYXBoLW9wdGlvbnMiXS5hZGRFdmVudExpc3Rl bmVyKCJjaGFuZ2UiLCBiZW5jaG1hcmtDb250cm9sbGVyLm9uQ29tcGxleGl0eUdyYXBoT3B0aW9u c0NoYW5nZWQsIHRydWUpOwogICAgICAgICBvcHRpb25zTWFuYWdlci51cGRhdGVVSUZyb21Mb2Nh bFN0b3JhZ2UoKTsKICAgICAgICAgb3B0aW9uc01hbmFnZXIudXBkYXRlRGlzcGxheSgpOworICAg ICAgICBvcHRpb25zTWFuYWdlci51cGRhdGVUaWxlcygpOwogCiAgICAgICAgIGlmIChiZW5jaG1h cmtDb250cm9sbGVyLnN0YXJ0QmVuY2htYXJrSW1tZWRpYXRlbHlJZkVuY29kZWQoKSkKICAgICAg ICAgICAgIHJldHVybjsKQEAgLTU1NiwxMiArNTY1LDE2IEBAIFV0aWxpdGllcy5leHRlbmRPYmpl Y3Qod2luZG93LmJlbmNobWFya0MKIAogICAgIG9uQmVuY2htYXJrT3B0aW9uc0NoYW5nZWQ6IGZ1 bmN0aW9uKGV2ZW50KQogICAgIHsKLSAgICAgICAgaWYgKGV2ZW50LnRhcmdldC5uYW1lID09ICJj b250cm9sbGVyIikgeworICAgICAgICBzd2l0Y2ggKGV2ZW50LnRhcmdldC5uYW1lKSB7CisgICAg ICAgIGNhc2UgImNvbnRyb2xsZXIiOgogICAgICAgICAgICAgc3VpdGVzTWFuYWdlci51cGRhdGVF ZGl0c0VsZW1lbnRzU3RhdGUoKTsKLSAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgfQotICAg ICAgICBpZiAoZXZlbnQudGFyZ2V0Lm5hbWUgPT0gImRpc3BsYXkiKSB7CisgICAgICAgICAgICBi cmVhazsKKyAgICAgICAgY2FzZSAiZGlzcGxheSI6CiAgICAgICAgICAgICBvcHRpb25zTWFuYWdl ci51cGRhdGVEaXNwbGF5KCk7CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgY2FzZSAidGls ZXMiOgorICAgICAgICAgICAgb3B0aW9uc01hbmFnZXIudXBkYXRlVGlsZXMoKTsKKyAgICAgICAg ICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgfSwKIApJbmRleDogUGVyZm9ybWFuY2VUZXN0cy9B bmltb21ldGVyL3Jlc291cmNlcy9ydW5uZXIvYW5pbW9tZXRlci5qcwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBQ ZXJmb3JtYW5jZVRlc3RzL0FuaW1vbWV0ZXIvcmVzb3VyY2VzL3J1bm5lci9hbmltb21ldGVyLmpz CShyZXZpc2lvbiAyMDM5MjMpCisrKyBQZXJmb3JtYW5jZVRlc3RzL0FuaW1vbWV0ZXIvcmVzb3Vy Y2VzL3J1bm5lci9hbmltb21ldGVyLmpzCSh3b3JraW5nIGNvcHkpCkBAIC01MDYsNiArNTA2LDcg QEAgd2luZG93LmJlbmNobWFya0NvbnRyb2xsZXIgPSB7CiAgICAgICAgIHZhciBvcHRpb25zID0g ewogICAgICAgICAgICAgInRlc3QtaW50ZXJ2YWwiOiAzMCwKICAgICAgICAgICAgICJkaXNwbGF5 IjogIm1pbmltYWwiLAorICAgICAgICAgICAgInRpbGVzIjogImJpZyIsCiAgICAgICAgICAgICAi Y29udHJvbGxlciI6ICJyYW1wIiwKICAgICAgICAgICAgICJrYWxtYW4tcHJvY2Vzcy1lcnJvciI6 IDEsCiAgICAgICAgICAgICAia2FsbWFuLW1lYXN1cmVtZW50LWVycm9yIjogNCwK