160364 2016-07-29 16:30:11 -0700 [GTK][Unix] Implement missing WebKit::SharedMemory::create() function 2016-07-31 01:32:36 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 154553 1 aperez aperez aestes beidson bugs-noreply cgarcia commit-queue koivisto mcatanzaro oldest_to_newest 1215743 0 aperez 2016-07-29 16:30:11 -0700 The WebKit::SharedMemory::create() function is missing for the Unix platform, which is also used by the GTK port. 1215745 1 284916 aperez 2016-07-29 16:38:15 -0700 Created attachment 284916 Patch 1215830 2 284916 cgarcia 2016-07-29 23:58:16 -0700 Comment on attachment 284916 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284916&action=review > Source/WebKit2/ChangeLog:3 > + Implement WebKit::SharedMemory::create() for the Unix platform. Please, use the actual bug title here. > Source/WebKit2/ChangeLog:14 > + (WebKit::accessModeMMap): Added helper function to convert a > + SharedMemory::Protection value into flags useable with mmap(). You are not adding it, but moving it, no? > Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp:109 > +RefPtr<SharedMemory> SharedMemory::create(void* addr, size_t size, Protection protection) Do not use abbreviations, use either just data or address, but not addr > Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp:153 > + return SharedMemory::create(0, size, SharedMemory::Protection::ReadWrite); Use nullptr instead of 0. 1215839 3 284939 aperez 2016-07-30 03:46:13 -0700 Created attachment 284939 Patch 1215840 4 aperez 2016-07-30 03:49:43 -0700 (In reply to comment #2) > Comment on attachment 284916 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=284916&action=review > > > Source/WebKit2/ChangeLog:3 > > + Implement WebKit::SharedMemory::create() for the Unix platform. > > Please, use the actual bug title here. Done. > > Source/WebKit2/ChangeLog:14 > > + (WebKit::accessModeMMap): Added helper function to convert a > > + SharedMemory::Protection value into flags useable with mmap(). > > You are not adding it, but moving it, no? The function did not exist before (It has a couple of lines picked from the old implementation of SharedMemory::allocate(), though). > > Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp:109 > > +RefPtr<SharedMemory> SharedMemory::create(void* addr, size_t size, Protection protection) > > Do not use abbreviations, use either just data or address, but not addr > > > Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp:153 > > + return SharedMemory::create(0, size, SharedMemory::Protection::ReadWrite); > > Use nullptr instead of 0. Fixed. 1215937 5 284939 commit-queue 2016-07-31 01:32:31 -0700 Comment on attachment 284939 Patch Clearing flags on attachment: 284939 Committed r203954: <http://trac.webkit.org/changeset/203954> 1215938 6 commit-queue 2016-07-31 01:32:36 -0700 All reviewed patches have been landed. Closing bug. 284916 2016-07-29 16:38:15 -0700 2016-07-30 03:46:04 -0700 Patch bug-160364-20160730023659.patch text/plain 3357 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzOTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTYxNDVjOTBiZmQ4Y2I2 ZmQyMTNhNDlmMDU4ZjdlYWFkMGNjNmViMS4uZjE2ZDUxNDAwZThjM2M2ZDExY2I0OTQ0MWY1NGUy OTQ1MWQwODY4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE2LTA3LTI5ICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgSW1wbGVt ZW50IFdlYktpdDo6U2hhcmVkTWVtb3J5OjpjcmVhdGUoKSBmb3IgdGhlIFVuaXggcGxhdGZvcm0u CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjAzNjQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgV2Vi S2l0OjpTaGFyZWRNZW1vcnk6OmNyZWF0ZSgpIGZ1bmN0aW9uIGlzIG1pc3NpbmcgZm9yIHRoZSBV bml4CisgICAgICAgIHBsYXRmb3JtLCB3aGljaCBpcyBhbHNvIHVzZWQgYnkgdGhlIEdUSysgcG9y dC4gVGhlIGxhdHRlciBpcyBnb2luZworICAgICAgICB0byBuZWVkIHRoaXMgaW4gcGxhY2UgdG8g dXNlIHRoZSBjb21tb24gY29udGVudCBmaWx0ZXJpbmcgY29kZS4KKworICAgICAgICAqIFBsYXRm b3JtL3VuaXgvU2hhcmVkTWVtb3J5VW5peC5jcHA6CisgICAgICAgIChXZWJLaXQ6OmFjY2Vzc01v ZGVNTWFwKTogQWRkZWQgaGVscGVyIGZ1bmN0aW9uIHRvIGNvbnZlcnQgYQorICAgICAgICBTaGFy ZWRNZW1vcnk6OlByb3RlY3Rpb24gdmFsdWUgaW50byBmbGFncyB1c2VhYmxlIHdpdGggbW1hcCgp LgorICAgICAgICAoV2ViS2l0OjpTaGFyZWRNZW1vcnk6OmNyZWF0ZSk6IEFkZGVkLiBJbXBsZW1l bnRhdGlvbiByZXVzZXMgY29kZQorICAgICAgICBleGlzdGluZyBpbiB0aGUgU2hhcmVkTWVtb3J5 OjphbGxvY2F0ZSgpIGZ1bmN0aW9uLgorICAgICAgICAoV2ViS2l0OjpTaGFyZWRNZW1vcnk6OmFs bG9jYXRlKTogUmVpbXBsZW1lbnRlZCBpbiB0ZXJtcyBvZgorICAgICAgICBTaGFyZWRNZW1vcnk6 OmNyZWF0ZSgpLgorCiAyMDE2LTA3LTI4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3Jn PgogCiAgICAgICAgIENyYXNoIHdpdGggYW4gSW52YWxpZCBXZWIgUHJvY2VzcyBJUEMgTWVzc2Fn ZSBJRDogV2ViUGFnZVByb3h5LkF0dHJpYnV0ZWRTdHJpbmdGb3JDaGFyYWN0ZXJSYW5nZUNhbGxi YWNrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS91bml4L1NoYXJlZE1lbW9y eVVuaXguY3BwIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vdW5peC9TaGFyZWRNZW1vcnlVbml4 LmNwcAppbmRleCAyMjA1OTJmZDEzYmVmYzA2OGIyZjBmMTU0N2Q0YTkwNDcwOTAzNzJkLi5hMDQx Y2RlNGIzNzBjYmVhZWZkMGQ2Y2ZkYTQxMTY4N2ZkZTZhNzYyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9QbGF0Zm9ybS91bml4L1NoYXJlZE1lbW9yeVVuaXguY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1BsYXRmb3JtL3VuaXgvU2hhcmVkTWVtb3J5VW5peC5jcHAKQEAgLTkzLDcgKzkzLDIw IEBAIHZvaWQgU2hhcmVkTWVtb3J5OjpIYW5kbGU6OmFkb3B0QXR0YWNobWVudChJUEM6OkF0dGFj aG1lbnQmJiBhdHRhY2htZW50KQogICAgIG1fYXR0YWNobWVudCA9IFdURk1vdmUoYXR0YWNobWVu dCk7CiB9CiAKLVJlZlB0cjxTaGFyZWRNZW1vcnk+IFNoYXJlZE1lbW9yeTo6YWxsb2NhdGUoc2l6 ZV90IHNpemUpCitzdGF0aWMgaW5saW5lIGludCBhY2Nlc3NNb2RlTU1hcChTaGFyZWRNZW1vcnk6 OlByb3RlY3Rpb24gcHJvdGVjdGlvbikKK3sKKyAgICBzd2l0Y2ggKHByb3RlY3Rpb24pIHsKKyAg ICBjYXNlIFNoYXJlZE1lbW9yeTo6UHJvdGVjdGlvbjo6UmVhZE9ubHk6CisgICAgICAgIHJldHVy biBQUk9UX1JFQUQ7CisgICAgY2FzZSBTaGFyZWRNZW1vcnk6OlByb3RlY3Rpb246OlJlYWRXcml0 ZToKKyAgICAgICAgcmV0dXJuIFBST1RfUkVBRCB8IFBST1RfV1JJVEU7CisgICAgfQorCisgICAg QVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgcmV0dXJuIFBST1RfUkVBRCB8IFBST1RfV1JJVEU7 Cit9CisKK1JlZlB0cjxTaGFyZWRNZW1vcnk+IFNoYXJlZE1lbW9yeTo6Y3JlYXRlKHZvaWQqIGFk ZHIsIHNpemVfdCBzaXplLCBQcm90ZWN0aW9uIHByb3RlY3Rpb24pCiB7CiAgICAgQ1N0cmluZyB0 ZW1wTmFtZTsKIApAQCAtMTE5LDcgKzEzMiw3IEBAIFJlZlB0cjxTaGFyZWRNZW1vcnk+IFNoYXJl ZE1lbW9yeTo6YWxsb2NhdGUoc2l6ZV90IHNpemUpCiAgICAgICAgIH0KICAgICB9CiAKLSAgICB2 b2lkKiBkYXRhID0gbW1hcCgwLCBzaXplLCBQUk9UX1JFQUQgfCBQUk9UX1dSSVRFLCBNQVBfU0hB UkVELCBmaWxlRGVzY3JpcHRvciwgMCk7CisgICAgdm9pZCogZGF0YSA9IG1tYXAoYWRkciwgc2l6 ZSwgYWNjZXNzTW9kZU1NYXAocHJvdGVjdGlvbiksIE1BUF9TSEFSRUQsIGZpbGVEZXNjcmlwdG9y LCAwKTsKICAgICBpZiAoZGF0YSA9PSBNQVBfRkFJTEVEKSB7CiAgICAgICAgIGNsb3NlV2l0aFJl dHJ5KGZpbGVEZXNjcmlwdG9yKTsKICAgICAgICAgc2htX3VubGluayh0ZW1wTmFtZS5kYXRhKCkp OwpAQCAtMTM1LDE3ICsxNDgsOSBAQCBSZWZQdHI8U2hhcmVkTWVtb3J5PiBTaGFyZWRNZW1vcnk6 OmFsbG9jYXRlKHNpemVfdCBzaXplKQogICAgIHJldHVybiBpbnN0YW5jZS5yZWxlYXNlKCk7CiB9 CiAKLXN0YXRpYyBpbmxpbmUgaW50IGFjY2Vzc01vZGVNTWFwKFNoYXJlZE1lbW9yeTo6UHJvdGVj dGlvbiBwcm90ZWN0aW9uKQorUmVmUHRyPFNoYXJlZE1lbW9yeT4gU2hhcmVkTWVtb3J5OjphbGxv Y2F0ZShzaXplX3Qgc2l6ZSkKIHsKLSAgICBzd2l0Y2ggKHByb3RlY3Rpb24pIHsKLSAgICBjYXNl IFNoYXJlZE1lbW9yeTo6UHJvdGVjdGlvbjo6UmVhZE9ubHk6Ci0gICAgICAgIHJldHVybiBQUk9U X1JFQUQ7Ci0gICAgY2FzZSBTaGFyZWRNZW1vcnk6OlByb3RlY3Rpb246OlJlYWRXcml0ZToKLSAg ICAgICAgcmV0dXJuIFBST1RfUkVBRCB8IFBST1RfV1JJVEU7Ci0gICAgfQotCi0gICAgQVNTRVJU X05PVF9SRUFDSEVEKCk7Ci0gICAgcmV0dXJuIFBST1RfUkVBRCB8IFBST1RfV1JJVEU7CisgICAg cmV0dXJuIFNoYXJlZE1lbW9yeTo6Y3JlYXRlKDAsIHNpemUsIFNoYXJlZE1lbW9yeTo6UHJvdGVj dGlvbjo6UmVhZFdyaXRlKTsKIH0KIAogUmVmUHRyPFNoYXJlZE1lbW9yeT4gU2hhcmVkTWVtb3J5 OjptYXAoY29uc3QgSGFuZGxlJiBoYW5kbGUsIFByb3RlY3Rpb24gcHJvdGVjdGlvbikK 284939 2016-07-30 03:46:13 -0700 2016-07-31 01:32:31 -0700 Patch bug-160364-20160730134456.patch text/plain 3375 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzOTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTYxNDVjOTBiZmQ4Y2I2 ZmQyMTNhNDlmMDU4ZjdlYWFkMGNjNmViMS4uZDg3MDQyYTA3OTFjYzFjM2FmOTJhMjI2Y2I0ZDE1 NDE3MWE3ZTVjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE2LTA3LTMwICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11b VW5peF0gSW1wbGVtZW50IG1pc3NpbmcgV2ViS2l0OjpTaGFyZWRNZW1vcnk6OmNyZWF0ZSgpIGZ1 bmN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NjAzNjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGUgV2ViS2l0OjpTaGFyZWRNZW1vcnk6OmNyZWF0ZSgpIGZ1bmN0aW9uIGlzIG1pc3NpbmcgZm9y IHRoZSBVbml4CisgICAgICAgIHBsYXRmb3JtLCB3aGljaCBpcyBhbHNvIHVzZWQgYnkgdGhlIEdU SysgcG9ydC4gVGhlIGxhdHRlciBpcyBnb2luZworICAgICAgICB0byBuZWVkIHRoaXMgaW4gcGxh Y2UgdG8gdXNlIHRoZSBjb21tb24gY29udGVudCBmaWx0ZXJpbmcgY29kZS4KKworICAgICAgICAq IFBsYXRmb3JtL3VuaXgvU2hhcmVkTWVtb3J5VW5peC5jcHA6CisgICAgICAgIChXZWJLaXQ6OmFj Y2Vzc01vZGVNTWFwKTogQWRkZWQgaGVscGVyIGZ1bmN0aW9uIHRvIGNvbnZlcnQgYQorICAgICAg ICBTaGFyZWRNZW1vcnk6OlByb3RlY3Rpb24gdmFsdWUgaW50byBmbGFncyB1c2VhYmxlIHdpdGgg bW1hcCgpLgorICAgICAgICAoV2ViS2l0OjpTaGFyZWRNZW1vcnk6OmNyZWF0ZSk6IEFkZGVkLiBJ bXBsZW1lbnRhdGlvbiByZXVzZXMgY29kZQorICAgICAgICBleGlzdGluZyBpbiB0aGUgU2hhcmVk TWVtb3J5OjphbGxvY2F0ZSgpIGZ1bmN0aW9uLgorICAgICAgICAoV2ViS2l0OjpTaGFyZWRNZW1v cnk6OmFsbG9jYXRlKTogUmVpbXBsZW1lbnRlZCBpbiB0ZXJtcyBvZgorICAgICAgICBTaGFyZWRN ZW1vcnk6OmNyZWF0ZSgpLgorCiAyMDE2LTA3LTI4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJr aXQub3JnPgogCiAgICAgICAgIENyYXNoIHdpdGggYW4gSW52YWxpZCBXZWIgUHJvY2VzcyBJUEMg TWVzc2FnZSBJRDogV2ViUGFnZVByb3h5LkF0dHJpYnV0ZWRTdHJpbmdGb3JDaGFyYWN0ZXJSYW5n ZUNhbGxiYWNrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS91bml4L1NoYXJl ZE1lbW9yeVVuaXguY3BwIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vdW5peC9TaGFyZWRNZW1v cnlVbml4LmNwcAppbmRleCAyMjA1OTJmZDEzYmVmYzA2OGIyZjBmMTU0N2Q0YTkwNDcwOTAzNzJk Li5hYTVlYWEwODMxNTIwM2QyNGUyN2E2OWE5MjE5ZjEzMGQzNTNhYWY2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS91bml4L1NoYXJlZE1lbW9yeVVuaXguY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1BsYXRmb3JtL3VuaXgvU2hhcmVkTWVtb3J5VW5peC5jcHAKQEAgLTkzLDcg KzkzLDIwIEBAIHZvaWQgU2hhcmVkTWVtb3J5OjpIYW5kbGU6OmFkb3B0QXR0YWNobWVudChJUEM6 OkF0dGFjaG1lbnQmJiBhdHRhY2htZW50KQogICAgIG1fYXR0YWNobWVudCA9IFdURk1vdmUoYXR0 YWNobWVudCk7CiB9CiAKLVJlZlB0cjxTaGFyZWRNZW1vcnk+IFNoYXJlZE1lbW9yeTo6YWxsb2Nh dGUoc2l6ZV90IHNpemUpCitzdGF0aWMgaW5saW5lIGludCBhY2Nlc3NNb2RlTU1hcChTaGFyZWRN ZW1vcnk6OlByb3RlY3Rpb24gcHJvdGVjdGlvbikKK3sKKyAgICBzd2l0Y2ggKHByb3RlY3Rpb24p IHsKKyAgICBjYXNlIFNoYXJlZE1lbW9yeTo6UHJvdGVjdGlvbjo6UmVhZE9ubHk6CisgICAgICAg IHJldHVybiBQUk9UX1JFQUQ7CisgICAgY2FzZSBTaGFyZWRNZW1vcnk6OlByb3RlY3Rpb246OlJl YWRXcml0ZToKKyAgICAgICAgcmV0dXJuIFBST1RfUkVBRCB8IFBST1RfV1JJVEU7CisgICAgfQor CisgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgcmV0dXJuIFBST1RfUkVBRCB8IFBST1Rf V1JJVEU7Cit9CisKK1JlZlB0cjxTaGFyZWRNZW1vcnk+IFNoYXJlZE1lbW9yeTo6Y3JlYXRlKHZv aWQqIGFkZHJlc3MsIHNpemVfdCBzaXplLCBQcm90ZWN0aW9uIHByb3RlY3Rpb24pCiB7CiAgICAg Q1N0cmluZyB0ZW1wTmFtZTsKIApAQCAtMTE5LDcgKzEzMiw3IEBAIFJlZlB0cjxTaGFyZWRNZW1v cnk+IFNoYXJlZE1lbW9yeTo6YWxsb2NhdGUoc2l6ZV90IHNpemUpCiAgICAgICAgIH0KICAgICB9 CiAKLSAgICB2b2lkKiBkYXRhID0gbW1hcCgwLCBzaXplLCBQUk9UX1JFQUQgfCBQUk9UX1dSSVRF LCBNQVBfU0hBUkVELCBmaWxlRGVzY3JpcHRvciwgMCk7CisgICAgdm9pZCogZGF0YSA9IG1tYXAo YWRkcmVzcywgc2l6ZSwgYWNjZXNzTW9kZU1NYXAocHJvdGVjdGlvbiksIE1BUF9TSEFSRUQsIGZp bGVEZXNjcmlwdG9yLCAwKTsKICAgICBpZiAoZGF0YSA9PSBNQVBfRkFJTEVEKSB7CiAgICAgICAg IGNsb3NlV2l0aFJldHJ5KGZpbGVEZXNjcmlwdG9yKTsKICAgICAgICAgc2htX3VubGluayh0ZW1w TmFtZS5kYXRhKCkpOwpAQCAtMTM1LDE3ICsxNDgsOSBAQCBSZWZQdHI8U2hhcmVkTWVtb3J5PiBT aGFyZWRNZW1vcnk6OmFsbG9jYXRlKHNpemVfdCBzaXplKQogICAgIHJldHVybiBpbnN0YW5jZS5y ZWxlYXNlKCk7CiB9CiAKLXN0YXRpYyBpbmxpbmUgaW50IGFjY2Vzc01vZGVNTWFwKFNoYXJlZE1l bW9yeTo6UHJvdGVjdGlvbiBwcm90ZWN0aW9uKQorUmVmUHRyPFNoYXJlZE1lbW9yeT4gU2hhcmVk TWVtb3J5OjphbGxvY2F0ZShzaXplX3Qgc2l6ZSkKIHsKLSAgICBzd2l0Y2ggKHByb3RlY3Rpb24p IHsKLSAgICBjYXNlIFNoYXJlZE1lbW9yeTo6UHJvdGVjdGlvbjo6UmVhZE9ubHk6Ci0gICAgICAg IHJldHVybiBQUk9UX1JFQUQ7Ci0gICAgY2FzZSBTaGFyZWRNZW1vcnk6OlByb3RlY3Rpb246OlJl YWRXcml0ZToKLSAgICAgICAgcmV0dXJuIFBST1RfUkVBRCB8IFBST1RfV1JJVEU7Ci0gICAgfQot Ci0gICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgcmV0dXJuIFBST1RfUkVBRCB8IFBST1Rf V1JJVEU7CisgICAgcmV0dXJuIFNoYXJlZE1lbW9yeTo6Y3JlYXRlKG51bGxwdHIsIHNpemUsIFNo YXJlZE1lbW9yeTo6UHJvdGVjdGlvbjo6UmVhZFdyaXRlKTsKIH0KIAogUmVmUHRyPFNoYXJlZE1l bW9yeT4gU2hhcmVkTWVtb3J5OjptYXAoY29uc3QgSGFuZGxlJiBoYW5kbGUsIFByb3RlY3Rpb24g cHJvdGVjdGlvbikK