160363 2016-07-29 16:18:01 -0700 [GTK] Implement missing WebCore::moveFile() using GLib functions 2016-07-31 22:45:18 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 154553 1 aperez aperez achristensen beidson bugs-noreply cgarcia commit-queue darin mcatanzaro oldest_to_newest 1215738 0 aperez 2016-07-29 16:18:01 -0700 An implementation of WebCore::moveFile() is not available for the GTK+ port. 1215740 1 284914 aperez 2016-07-29 16:20:31 -0700 Created attachment 284914 Patch 1215828 2 284914 cgarcia 2016-07-29 23:50:00 -0700 Comment on attachment 284914 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284914&action=review Thanks! > Source/WebCore/platform/glib/FileSystemGlib.cpp:381 > + return !g_rename(oldFilename.get(), oldFilename.get()); g_rename returns -1 in case of failure, I prefer to explicitly check that like all other functions in this file do. return rename != -1 1215829 3 284914 cgarcia 2016-07-29 23:50:46 -0700 Comment on attachment 284914 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284914&action=review > Source/WebCore/ChangeLog:3 > + Implement WebCore::moveFile() using GLib. And please, use the actual bug title here. prepare-ChangeLog should do the right thing for you. 1215838 4 284938 aperez 2016-07-30 02:33:01 -0700 Created attachment 284938 Patch 1215841 5 aperez 2016-07-30 03:52:03 -0700 An updated patch is now uploaded. (In reply to comment #3) > Comment on attachment 284914 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=284914&action=review > > > Source/WebCore/ChangeLog:3 > > + Implement WebCore::moveFile() using GLib. > > And please, use the actual bug title here. prepare-ChangeLog should do the > right thing for you. I couldn't figure out how to make this work, but instead I have discovered that the following works like a charm: % webkit-patch prepare -g HEAD --update-changelogs <BUGID> 1215849 6 mcatanzaro 2016-07-30 09:07:48 -0700 prepare-ChangeLog -b <BUGID> 1215935 7 cgarcia 2016-07-31 01:13:11 -0700 (In reply to comment #6) > prepare-ChangeLog -b <BUGID> prepare-ChangeLog -g HEAD -b <BUGID> 1215936 8 284938 cgarcia 2016-07-31 01:14:45 -0700 Comment on attachment 284938 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284938&action=review > Source/WebCore/platform/glib/FileSystemGlib.cpp:381 > + return g_rename(oldFilename.get(), oldFilename.get()) != -1; I didn't notice this in the previous patch, but you are using oldFilename in both arguments! :-D 1215973 9 284971 aperez 2016-07-31 15:28:08 -0700 Created attachment 284971 Patch 1215974 10 aperez 2016-07-31 15:29:10 -0700 (In reply to comment #8) > Comment on attachment 284938 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=284938&action=review > > > Source/WebCore/platform/glib/FileSystemGlib.cpp:381 > > + return g_rename(oldFilename.get(), oldFilename.get()) != -1; > > I didn't notice this in the previous patch, but you are using oldFilename in > both arguments! :-D Ouch, good catch! I have just uploaded a fixed version of the patch. 1216025 11 284971 commit-queue 2016-07-31 22:45:14 -0700 Comment on attachment 284971 Patch Clearing flags on attachment: 284971 Committed r203960: <http://trac.webkit.org/changeset/203960> 1216026 12 commit-queue 2016-07-31 22:45:18 -0700 All reviewed patches have been landed. Closing bug. 284914 2016-07-29 16:20:31 -0700 2016-07-30 02:32:55 -0700 Patch bug-160363-20160730021915.patch text/plain 1537 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzOTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzg2ZmJhOTI1NjhjODhk M2NjMDNjYmU2MWY1MzNhODEzNmZkYjE2Ni4uMThjMWEyYWNkNWZkZjM3Mjc1ZDY0YmNjZmZlYjdi YTg1ZDYzZGE0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE2LTA3LTI5ICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgSW1wbGVt ZW50IFdlYkNvcmU6Om1vdmVGaWxlKCkgdXNpbmcgR0xpYi4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDM2MworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ2xpYi9GaWxlU3lzdGVtR2xp Yi5jcHA6CisgICAgICAgIChXZWJDb3JlOjptb3ZlRmlsZSk6IEZ1bmN0aW9uIGFkZGVkLgorCiAy MDE2LTA3LTI5ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAg ICAgICAgQmFja3NwYWNlIGtleSByZW1vdmVzIG9ubHkgdGhlIHJhaW5ib3cgZnJvbSB0aGUgcmFp bmJvdyBmbGFnCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9nbGliL0ZpbGVT eXN0ZW1HbGliLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dsaWIvRmlsZVN5c3RlbUds aWIuY3BwCmluZGV4IDExNzQwOTFiMThhOTU1M2FlOTk4ZDc2Y2E4MjdhYTI4NzJiMmMwM2YuLjVh YzU1ZGNmM2U3ZmZmY2ExMjQ0ZjlhMGZmNjg3Njc4ODg0MjJhZTggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dsaWIvRmlsZVN5c3RlbUdsaWIuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dsaWIvRmlsZVN5c3RlbUdsaWIuY3BwCkBAIC0zNjgsNiArMzY4LDE5 IEBAIGludCByZWFkRnJvbUZpbGUoUGxhdGZvcm1GaWxlSGFuZGxlIGhhbmRsZSwgY2hhciogZGF0 YSwgaW50IGxlbmd0aCkKICAgICByZXR1cm4gLTE7CiB9CiAKK2Jvb2wgbW92ZUZpbGUoY29uc3Qg U3RyaW5nJiBvbGRQYXRoLCBjb25zdCBTdHJpbmcmIG5ld1BhdGgpCit7CisgICAgR1VuaXF1ZVB0 cjxnY2hhcj4gb2xkRmlsZW5hbWUgPSB1bmVzY2FwZWRGaWxlbmFtZShvbGRQYXRoKTsKKyAgICBp ZiAoIW9sZEZpbGVuYW1lKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBHVW5pcXVlUHRy PGdjaGFyPiBuZXdGaWxlbmFtZSA9IHVuZXNjYXBlZEZpbGVuYW1lKG5ld1BhdGgpOworICAgIGlm ICghbmV3RmlsZW5hbWUpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIHJldHVybiAhZ19y ZW5hbWUob2xkRmlsZW5hbWUuZ2V0KCksIG9sZEZpbGVuYW1lLmdldCgpKTsKK30KKwogYm9vbCB1 bmxvYWRNb2R1bGUoUGxhdGZvcm1Nb2R1bGUgbW9kdWxlKQogewogI2lmIE9TKFdJTkRPV1MpCg== 284938 2016-07-30 02:33:01 -0700 2016-07-31 15:27:59 -0700 Patch bug-160363-20160730123145.patch text/plain 1565 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzOTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzg2ZmJhOTI1NjhjODhk M2NjMDNjYmU2MWY1MzNhODEzNmZkYjE2Ni4uMzJhNTQ4ZTQwM2NjNDFlYjA5ZWU1ZDgzNWI3NDg1 ZmQwOWIzYzM4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE2LTA3LTMwICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10g SW1wbGVtZW50IG1pc3NpbmcgV2ViQ29yZTo6bW92ZUZpbGUoKSB1c2luZyBHTGliIGZ1bmN0aW9u cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwMzYz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9nbGliL0ZpbGVTeXN0ZW1HbGliLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om1vdmVGaWxl KTogRnVuY3Rpb24gYWRkZWQuCisKIDIwMTYtMDctMjkgIE15bGVzIEMuIE1heGZpZWxkICA8bW1h eGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBCYWNrc3BhY2Uga2V5IHJlbW92ZXMgb25seSB0 aGUgcmFpbmJvdyBmcm9tIHRoZSByYWluYm93IGZsYWcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dsaWIvRmlsZVN5c3RlbUdsaWIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ2xpYi9GaWxlU3lzdGVtR2xpYi5jcHAKaW5kZXggMTE3NDA5MWIxOGE5NTUzYWU5OThk NzZjYTgyN2FhMjg3MmIyYzAzZi4uZGQ4YjM1YWI3ZDI4YjlmMjNjM2IwODdkMDMxMTY3ZDFmYjM0 ZjdiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ2xpYi9GaWxlU3lzdGVt R2xpYi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ2xpYi9GaWxlU3lzdGVtR2xp Yi5jcHAKQEAgLTM2OCw2ICszNjgsMTkgQEAgaW50IHJlYWRGcm9tRmlsZShQbGF0Zm9ybUZpbGVI YW5kbGUgaGFuZGxlLCBjaGFyKiBkYXRhLCBpbnQgbGVuZ3RoKQogICAgIHJldHVybiAtMTsKIH0K IAorYm9vbCBtb3ZlRmlsZShjb25zdCBTdHJpbmcmIG9sZFBhdGgsIGNvbnN0IFN0cmluZyYgbmV3 UGF0aCkKK3sKKyAgICBHVW5pcXVlUHRyPGdjaGFyPiBvbGRGaWxlbmFtZSA9IHVuZXNjYXBlZEZp bGVuYW1lKG9sZFBhdGgpOworICAgIGlmICghb2xkRmlsZW5hbWUpCisgICAgICAgIHJldHVybiBm YWxzZTsKKworICAgIEdVbmlxdWVQdHI8Z2NoYXI+IG5ld0ZpbGVuYW1lID0gdW5lc2NhcGVkRmls ZW5hbWUobmV3UGF0aCk7CisgICAgaWYgKCFuZXdGaWxlbmFtZSkKKyAgICAgICAgcmV0dXJuIGZh bHNlOworCisgICAgcmV0dXJuIGdfcmVuYW1lKG9sZEZpbGVuYW1lLmdldCgpLCBvbGRGaWxlbmFt ZS5nZXQoKSkgIT0gLTE7Cit9CisKIGJvb2wgdW5sb2FkTW9kdWxlKFBsYXRmb3JtTW9kdWxlIG1v ZHVsZSkKIHsKICNpZiBPUyhXSU5ET1dTKQo= 284971 2016-07-31 15:28:08 -0700 2016-07-31 22:45:14 -0700 Patch bug-160363-20160801012649.patch text/plain 1565 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzOTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzg2ZmJhOTI1NjhjODhk M2NjMDNjYmU2MWY1MzNhODEzNmZkYjE2Ni4uMzJhNTQ4ZTQwM2NjNDFlYjA5ZWU1ZDgzNWI3NDg1 ZmQwOWIzYzM4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE2LTA3LTMwICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10g SW1wbGVtZW50IG1pc3NpbmcgV2ViQ29yZTo6bW92ZUZpbGUoKSB1c2luZyBHTGliIGZ1bmN0aW9u cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwMzYz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9nbGliL0ZpbGVTeXN0ZW1HbGliLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om1vdmVGaWxl KTogRnVuY3Rpb24gYWRkZWQuCisKIDIwMTYtMDctMjkgIE15bGVzIEMuIE1heGZpZWxkICA8bW1h eGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBCYWNrc3BhY2Uga2V5IHJlbW92ZXMgb25seSB0 aGUgcmFpbmJvdyBmcm9tIHRoZSByYWluYm93IGZsYWcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dsaWIvRmlsZVN5c3RlbUdsaWIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ2xpYi9GaWxlU3lzdGVtR2xpYi5jcHAKaW5kZXggMTE3NDA5MWIxOGE5NTUzYWU5OThk NzZjYTgyN2FhMjg3MmIyYzAzZi4uOTdlNjYxNTk5NWYxNmRhODQ4YzliYjRmYzhmODY2OWY0ZDBm MDQ5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ2xpYi9GaWxlU3lzdGVt R2xpYi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ2xpYi9GaWxlU3lzdGVtR2xp Yi5jcHAKQEAgLTM2OCw2ICszNjgsMTkgQEAgaW50IHJlYWRGcm9tRmlsZShQbGF0Zm9ybUZpbGVI YW5kbGUgaGFuZGxlLCBjaGFyKiBkYXRhLCBpbnQgbGVuZ3RoKQogICAgIHJldHVybiAtMTsKIH0K IAorYm9vbCBtb3ZlRmlsZShjb25zdCBTdHJpbmcmIG9sZFBhdGgsIGNvbnN0IFN0cmluZyYgbmV3 UGF0aCkKK3sKKyAgICBHVW5pcXVlUHRyPGdjaGFyPiBvbGRGaWxlbmFtZSA9IHVuZXNjYXBlZEZp bGVuYW1lKG9sZFBhdGgpOworICAgIGlmICghb2xkRmlsZW5hbWUpCisgICAgICAgIHJldHVybiBm YWxzZTsKKworICAgIEdVbmlxdWVQdHI8Z2NoYXI+IG5ld0ZpbGVuYW1lID0gdW5lc2NhcGVkRmls ZW5hbWUobmV3UGF0aCk7CisgICAgaWYgKCFuZXdGaWxlbmFtZSkKKyAgICAgICAgcmV0dXJuIGZh bHNlOworCisgICAgcmV0dXJuIGdfcmVuYW1lKG9sZEZpbGVuYW1lLmdldCgpLCBuZXdGaWxlbmFt ZS5nZXQoKSkgIT0gLTE7Cit9CisKIGJvb2wgdW5sb2FkTW9kdWxlKFBsYXRmb3JtTW9kdWxlIG1v ZHVsZSkKIHsKICNpZiBPUyhXSU5ET1dTKQo=