160350 2016-07-29 11:39:12 -0700 Remove an unused line of code. 2016-07-29 11:49:48 -0700 1 1 1 Unclassified WebKit SVG WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 160344 1 mark.lam mark.lam ggaren mmaxfield sabouhallawa zimmermann oldest_to_newest 1215621 0 mark.lam 2016-07-29 11:39:12 -0700 SVGInlineTextBox::paintText() instantiates a local variable selectionTextRun. Thanks to analysis by Said Abou-Hallawa, we know that selectionTextRun was introduced in https://trac.webkit.org/changeset/61393, but was later rendered unused in https://trac.webkit.org/changeset/62099 because we switched to using paintTextWithShadows() with the selectionStyle. Hence, selectionTextRun can be removed. 1215626 1 284877 mark.lam 2016-07-29 11:43:23 -0700 Created attachment 284877 proposed patch. 1215634 2 mark.lam 2016-07-29 11:49:48 -0700 Thanks for the review. Landed in r203910: <http://trac.webkit.org/r203910>. 284877 2016-07-29 11:43:23 -0700 2016-07-29 11:45:11 -0700 proposed patch. bug-160350.patch text/plain 1828 mark.lam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMzkwNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE2LTA3LTI5ICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgYW4gdW51c2VkIGxpbmUg b2YgY29kZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE2MDM1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoZXJlJ3Mgbm8gYmVoYXZpb3IgY2hhbmdlLiAgSnVzdCBy ZW1vdmluZyBkZWFkIGNvZGUuCisKKyAgICAgICAgU1ZHSW5saW5lVGV4dEJveDo6cGFpbnRUZXh0 KCkgaW5zdGFudGlhdGVzIGEgbG9jYWwgdmFyaWFibGUgc2VsZWN0aW9uVGV4dFJ1bi4gCisgICAg ICAgIFRoYW5rcyB0byBhbmFseXNpcyBieSBTYWlkIEFib3UtSGFsbGF3YSwgd2Uga25vdyB0aGF0 IHNlbGVjdGlvblRleHRSdW4KKyAgICAgICAgd2FzIGludHJvZHVjZWQgaW4gaHR0cHM6Ly90cmFj LndlYmtpdC5vcmcvY2hhbmdlc2V0LzYxMzkzLCBidXQgd2FzIGxhdGVyCisgICAgICAgIHJlbmRl cmVkIHVudXNlZCBpbiBodHRwczovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvNjIwOTkgYmVj YXVzZSB3ZQorICAgICAgICBzd2l0Y2hlZCB0byB1c2luZyBwYWludFRleHRXaXRoU2hhZG93cygp IHdpdGggdGhlIHNlbGVjdGlvblN0eWxlLiAgSGVuY2UsCisgICAgICAgIHNlbGVjdGlvblRleHRS dW4gY2FuIGJlIHJlbW92ZWQuCisKKyAgICAgICAgKiByZW5kZXJpbmcvc3ZnL1NWR0lubGluZVRl eHRCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHSW5saW5lVGV4dEJveDo6cGFpbnRUZXh0 KToKKwogMjAxNi0wNy0yOSAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4K IAogICAgICAgICBDaGFuZ2UgaW50ZXJuYWwgQVZDYXB0dXJlRGV2aWNlVHlwZSB0eXBlZGVmIG5h bWUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvU1ZHSW5saW5lVGV4dEJveC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9TVkdJbmxpbmVU ZXh0Qm94LmNwcAkocmV2aXNpb24gMjAzOTA2KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L3N2Zy9TVkdJbmxpbmVUZXh0Qm94LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjEyLDcgKzYxMiw2 IEBAIHZvaWQgU1ZHSW5saW5lVGV4dEJveDo6cGFpbnRUZXh0KEdyYXBoaWMKICAgICBpZiAoc3R5 bGUgIT0gc2VsZWN0aW9uU3R5bGUpCiAgICAgICAgIFNWR1Jlc291cmNlc0NhY2hlOjpjbGllbnRT dHlsZUNoYW5nZWQocGFyZW50KCktPnJlbmRlcmVyKCksIFN0eWxlRGlmZmVyZW5jZVJlcGFpbnQs ICpzZWxlY3Rpb25TdHlsZSk7CiAKLSAgICBUZXh0UnVuIHNlbGVjdGlvblRleHRSdW4gPSBjb25z dHJ1Y3RUZXh0UnVuKHNlbGVjdGlvblN0eWxlLCBmcmFnbWVudCk7CiAgICAgcGFpbnRUZXh0V2l0 aFNoYWRvd3MoY29udGV4dCwgc2VsZWN0aW9uU3R5bGUsIHRleHRSdW4sIGZyYWdtZW50LCBzdGFy dFBvc2l0aW9uLCBlbmRQb3NpdGlvbik7CiAKICAgICBpZiAoc3R5bGUgIT0gc2VsZWN0aW9uU3R5 bGUpCg==