160344 2016-07-29 10:12:52 -0700 Make StringView capable of being passed /returned in only 2 registers. 2016-07-30 14:24:36 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 160350 1 mark.lam mark.lam andersca ap benjamin cdumez cmarcelo commit-queue darin ddkilzer fpizlo ggaren keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1215573 0 mark.lam 2016-07-29 10:12:52 -0700 We just need to #if out copy and move constructors and assignment operators. 1215585 1 284872 mark.lam 2016-07-29 10:30:33 -0700 Created attachment 284872 proposed patch. 1215594 2 284872 ggaren 2016-07-29 10:49:08 -0700 Comment on attachment 284872 proposed patch. /Volumes/Data/EWS/WebKit/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp:615:13: error: unused variable 'selectionTextRun' [-Werror,-Wunused-variable] TextRun selectionTextRun = constructTextRun(selectionStyle, fragment); 1215597 3 mark.lam 2016-07-29 10:51:56 -0700 (In reply to comment #2) > Comment on attachment 284872 [details] > proposed patch. > > /Volumes/Data/EWS/WebKit/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp: > 615:13: error: unused variable 'selectionTextRun' [-Werror,-Wunused-variable] > TextRun selectionTextRun = constructTextRun(selectionStyle, fragment); Does not appear to be related to my patch at all. 1215601 4 284872 ggaren 2016-07-29 10:57:56 -0700 Comment on attachment 284872 proposed patch. r=me 1215618 5 284872 mark.lam 2016-07-29 11:32:10 -0700 Comment on attachment 284872 proposed patch. I'll land this manually later. 1215636 6 mark.lam 2016-07-29 11:54:43 -0700 Thanks for the review. Landed in r203911: <http://trac.webkit.org/r203911>. 1215641 7 darin 2016-07-29 12:01:11 -0700 Thanks, Mark. This is great! 1215657 8 mark.lam 2016-07-29 12:30:13 -0700 Follow up build fix in r203915: <http://trac.webkit.org/r203915>. 1215658 9 webkit-bug-importer 2016-07-29 12:32:16 -0700 <rdar://problem/27613944> 1215663 10 ap 2016-07-29 12:43:02 -0700 > #if defined(NDEBUG) || COMPILER(MSVC) || 1 > #define CHECK_STRINGVIEW_LIFETIME 0 This is pre-existing code, however I'm curious anyway - is there a bug tracking re-enabling the checks? 1215669 11 darin 2016-07-29 12:54:51 -0700 Wow, did not realize these were turned off. Do we know exactly when we turned them off and why? Should find out when that || 1 was added. 1215675 12 mark.lam 2016-07-29 12:57:13 -0700 (In reply to comment #11) > Wow, did not realize these were turned off. Do we know exactly when we > turned them off and why? Should find out when that || 1 was added. See https://trac.webkit.org/changeset/174397 from Oct 2014. (In reply to comment #10) > This is pre-existing code, however I'm curious anyway - is there a bug > tracking re-enabling the checks? Apparently, no. 1215895 13 mark.lam 2016-07-30 14:24:36 -0700 Will work on re-enabling the StringView life-cycle checks in https://bugs.webkit.org/show_bug.cgi?id=160384. 284872 2016-07-29 10:30:33 -0700 2016-07-29 11:32:10 -0700 proposed patch. bug-160344.patch text/plain 3058 mark.lam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMDM4NTIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDM5IEBACisyMDE2LTA3LTI5ICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIFN0cmluZ1ZpZXcgY2FwYWJsZSBvZiBiZWluZyBw YXNzZWQgb3IgcmV0dXJuZWQgaW4gb25seSAyIHJlZ2lzdGVycy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDM0NAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGp1c3QgbmVlZCB0byAjaWYgb3V0IGNv cHkgYW5kIG1vdmUgY29uc3RydWN0b3JzIGFuZCBhc3NpZ25tZW50IG9wZXJhdG9ycy4KKworICAg ICAgICBBZnRlciB0aGlzIGNoYW5nZSwgdGhlIGZvbGxvd2luZyB0ZXN0IGNvZGU6CisKKyAgICAg ICAgICAgIEpTX0VYUE9SVF9QUklWQVRFIFN0cmluZ1ZpZXcgcmV0dXJuU3RyaW5nVmlldyhTdHJp bmdWaWV3IHN2KQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIHJldHVybiBzdjsKKyAg ICAgICAgICAgIH0KKworICAgICAgICAuLi4gY29tcGlsZXMgdG8gdGhlIGZvbGxvd2luZyBmb3Ig eDg2XzY0OgorCisgICAgICAgICAgICBfX1pOM0pTQzE2cmV0dXJuU3RyaW5nVmlld0VOM1dURjEw U3RyaW5nVmlld0U6CisgICAgICAgICAgICAwMDAwMDAwMDAwOTNmYjIwICAgICAgICBwdXNocSAg ICVyYnAKKyAgICAgICAgICAgIDAwMDAwMDAwMDA5M2ZiMjEgICAgICAgIG1vdnEgICAgJXJzcCwg JXJicAorICAgICAgICAgICAgMDAwMDAwMDAwMDkzZmIyNCAgICAgICAgbW92cSAgICAlcmRpLCAl cmF4IC8vIENvcHkgZnJvbSBhcmcgd29yZCAwIHRvIHJldCB3b3JkIDAuCisgICAgICAgICAgICAw MDAwMDAwMDAwOTNmYjI3ICAgICAgICBtb3ZxICAgICVyc2ksICVyZHggLy8gQ29weSBmcm9tIGFy ZyB3b3JkIDEgdG8gcmV0IHdvcmQgMS4KKyAgICAgICAgICAgIDAwMDAwMDAwMDA5M2ZiMmEgICAg ICAgIHBvcHEgICAgJXJicAorICAgICAgICAgICAgMDAwMDAwMDAwMDkzZmIyYiAgICAgICAgcmV0 cQorCisgICAgICAgIC4uLiBhbmQgdGhpcyBmb3IgYXJtNjQ6CisKKyAgICAgICAgICAgIF9fWk4z SlNDMTZyZXR1cm5TdHJpbmdWaWV3RU4zV1RGMTBTdHJpbmdWaWV3RToKKyAgICAgICAgICAgIDAw MDAwMDAwMDA4MTg1MDQgICAgICAgIHJldCAvLyBhcmcgd29yZCAwIGFuZCAxIGFyZSBpbiB0aGUg c2FtZSByZWdzIGFzIHJldCB3b3JkIDAgYW5kIDEuCisKKyAgICAgICAgKiB3dGYvdGV4dC9TdHJp bmdWaWV3Lmg6CisgICAgICAgIChXVEY6OlN0cmluZ1ZpZXc6OlN0cmluZ1ZpZXcpOgorICAgICAg ICAoV1RGOjpTdHJpbmdWaWV3Ojp+U3RyaW5nVmlldyk6CisgICAgICAgIChXVEY6OlN0cmluZ1Zp ZXc6Om9wZXJhdG9yPSk6CisKIDIwMTYtMDctMjggIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUu Y29tPgogCiAgICAgICAgIFN0cmluZ1ZpZXcgc2hvdWxkIGhhdmUgYW4gZXhwbGljaXQgbV9pczhC aXQgZmllbGQuCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ1ZpZXcuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ1ZpZXcuaAkocmV2aXNpb24gMjAzODUy KQorKysgU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdWaWV3LmgJKHdvcmtpbmcgY29weSkKQEAg LTQ4LDE3ICs0OCwxNyBAQCBuYW1lc3BhY2UgV1RGIHsKIHVzaW5nIENoYXJhY3Rlck1hdGNoRnVu Y3Rpb24gPSBib29sICgqKShVQ2hhcik7CiAKIC8vIFN0cmluZ1ZpZXcgaXMgYSBub24tb3duaW5n IHJlZmVyZW5jZSB0byBhIHN0cmluZywgc2ltaWxhciB0byB0aGUgcHJvcG9zZWQgc3RkOjpzdHJp bmdfdmlldy4KLS8vIFdoZXRoZXIgdGhlIHN0cmluZyBpcyA4LWJpdCBvciAxNi1iaXQgaXMgZW5j b2RlZCBpbiB0aGUgdXBwZXIgYml0IG9mIHRoZSBsZW5ndGggbWVtYmVyLgotLy8gVGhpcyBtZWFu cyB0aGF0IHN0cmluZ3MgbG9uZ2VyIHRoYW4gMiBnaWdhY2hhcmFjdGVycyBjYW5ub3QgYmUgcmVw cmVzZW50ZWQuCiAKIGNsYXNzIFN0cmluZ1ZpZXcgewogcHVibGljOgogICAgIFN0cmluZ1ZpZXco KTsKKyNpZiBDSEVDS19TVFJJTkdWSUVXX0xJRkVUSU1FCiAgICAgflN0cmluZ1ZpZXcoKTsKICAg ICBTdHJpbmdWaWV3KFN0cmluZ1ZpZXcmJik7CiAgICAgU3RyaW5nVmlldyhjb25zdCBTdHJpbmdW aWV3Jik7CiAgICAgU3RyaW5nVmlldyYgb3BlcmF0b3I9KFN0cmluZ1ZpZXcmJik7CiAgICAgU3Ry aW5nVmlldyYgb3BlcmF0b3I9KGNvbnN0IFN0cmluZ1ZpZXcmKTsKKyNlbmRpZgogCiAgICAgU3Ry aW5nVmlldyhjb25zdCBTdHJpbmcmKTsKICAgICBTdHJpbmdWaWV3KGNvbnN0IFN0cmluZ0ltcGwm KTsKQEAgLTIwMiw2ICsyMDIsNyBAQCBpbmxpbmUgU3RyaW5nVmlldzo6U3RyaW5nVmlldygpCiAg ICAgLy8gRklYTUU6IEl0J3MgcGVjdWxpYXIgdGhhdCBudWxsIHN0cmluZ3MgYXJlIDE2LWJpdCBh bmQgZW1wdHkgc3RyaW5ncyByZXR1cm4gOC1iaXQgKGFjY29yZGluZyB0byB0aGUgaXM4Qml0IGZ1 bmN0aW9uKS4KIH0KIAorI2lmIENIRUNLX1NUUklOR1ZJRVdfTElGRVRJTUUKIGlubGluZSBTdHJp bmdWaWV3Ojp+U3RyaW5nVmlldygpCiB7CiAgICAgc2V0VW5kZXJseWluZ1N0cmluZyhudWxscHRy KTsKQEAgLTI1OCw2ICsyNTksNyBAQCBpbmxpbmUgU3RyaW5nVmlldyYgU3RyaW5nVmlldzo6b3Bl cmF0b3I9CiAKICAgICByZXR1cm4gKnRoaXM7CiB9CisjZW5kaWYgLy8gQ0hFQ0tfU1RSSU5HVklF V19MSUZFVElNRQogCiBpbmxpbmUgdm9pZCBTdHJpbmdWaWV3Ojppbml0aWFsaXplKGNvbnN0IExD aGFyKiBjaGFyYWN0ZXJzLCB1bnNpZ25lZCBsZW5ndGgpCiB7Cg==