160333 2016-07-28 22:39:40 -0700 Ignore most check-webkit-style checks for ANGLE project 2016-07-29 18:26:50 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=160332 P2 Normal --- 1 ddkilzer ddkilzer aakash_jain achristensen commit-queue dbates dino glenn lforschler oldest_to_newest 1215498 0 ddkilzer 2016-07-28 22:39:40 -0700 The ANGLE project source does not match WebKit style. Instead, we preserve it so that merging upstream changes is easier. For this reason, we should relax what check-webkit-style accepts to avoid the horror of Bug 160332 Comment #3. 1215500 1 284848 ddkilzer 2016-07-28 22:46:00 -0700 Created attachment 284848 Patch v1 1215552 2 aakash_jain 2016-07-29 07:02:24 -0700 unofficial r+ 1215782 3 284848 dbates 2016-07-29 18:05:39 -0700 Comment on attachment 284848 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=284848&action=review > Tools/ChangeLog:11 > + - No carriage returns (DOS line endings). Eww :( 1215785 4 284848 commit-queue 2016-07-29 18:26:46 -0700 Comment on attachment 284848 Patch v1 Clearing flags on attachment: 284848 Committed r203936: <http://trac.webkit.org/changeset/203936> 1215786 5 commit-queue 2016-07-29 18:26:50 -0700 All reviewed patches have been landed. Closing bug. 284848 2016-07-28 22:46:00 -0700 2016-07-29 18:26:46 -0700 Patch v1 bug-160333-v1.diff text/plain 1276 ddkilzer SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwMzg1NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE2LTA3LTI4ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+ CisKKyAgICAgICAgSWdub3JlIG1vc3QgY2hlY2std2Via2l0LXN0eWxlIGNoZWNrcyBmb3IgQU5H TEUgcHJvamVjdAorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTYwMzMzPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9jaGVja2VyLnB5OiBJZ25vcmUgYWxsIGNoZWNrZXJzIGV4Y2VwdDoKKyAgICAg ICAgLSBObyB0YWJzLgorICAgICAgICAtIE5vIHNwYWNlcyBhdCB0aGUgZW5kIG9mIGxpbmVzLgor ICAgICAgICAtIE5vIGNhcnJpYWdlIHJldHVybnMgKERPUyBsaW5lIGVuZGluZ3MpLgorCiAyMDE2 LTA3LTI4ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAg ICAgUmVtb3ZlIGRlcHJlY2F0ZWQgU1BJIGZvciB2aWRlbyBpbmxpbmUgLyBmdWxsc2NyZWVuIGNv bnRyb2xzCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5CShyZXZp c2lvbiAyMDM4MjgpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkJ KHdvcmtpbmcgY29weSkKQEAgLTI0NCw2ICsyNDQsNyBAQCBfUEFUSF9SVUxFU19TUEVDSUZJRVIg PSBbCiAgICAgIyAgIE5vIGNhcnJpYWdlLXJldHVybiBsaW5lIGVuZGluZ3M6IHNpbmNlIHRoaXMg aXMgZWFzeSB0byBjb3JyZWN0LgogICAgICMKICAgICAoW29zLnBhdGguam9pbignd2Via2l0cHkn LCAndGhpcmRwYXJ0eScpLAorICAgICAgb3MucGF0aC5qb2luKCdTb3VyY2UnLCAnVGhpcmRQYXJ0 eScsICdBTkdMRScpLAogICAgICAgb3MucGF0aC5qb2luKCdTb3VyY2UnLCAnVGhpcmRQYXJ0eScs ICdicm90bGknKSwKICAgICAgIG9zLnBhdGguam9pbignU291cmNlJywgJ1RoaXJkUGFydHknLCAn d29mZjInKV0sCiAgICAgIFsiLSIsCg==