160330 2016-07-28 17:24:14 -0700 Web Inspector: Assertion in NetworkGridContentView when updating data grid for the first time 2016-07-29 11:41:46 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1215472 0 mattbaker 2016-07-28 17:24:14 -0700 Summary: Assertion in NetworkGridContentView when updating data grid for the first time: console.assert(isFinite(secondsPerPixel) && secondsPerPixel > 0); Steps to Reproduce: 1. Open Inspector > Network tab 2. Reload the page => Assertion adding first resource grid node [Error] Assertion Failed refreshGraph (TimelineDataGridNode.js:230) layout (NetworkGridContentView.js:185) _layoutSubtree (View.js:250) updateLayout (View.js:147) _update (NetworkGridContentView.js:299) _update 1215473 1 webkit-bug-importer 2016-07-28 17:24:46 -0700 <rdar://problem/27600905> 1215476 2 284843 mattbaker 2016-07-28 17:40:30 -0700 Created attachment 284843 [Patch] Proposed Fix 1215617 3 284843 bburg 2016-07-29 11:21:38 -0700 Comment on attachment 284843 [Patch] Proposed Fix r=me 1215624 4 284843 commit-queue 2016-07-29 11:41:42 -0700 Comment on attachment 284843 [Patch] Proposed Fix Clearing flags on attachment: 284843 Committed r203908: <http://trac.webkit.org/changeset/203908> 1215625 5 commit-queue 2016-07-29 11:41:46 -0700 All reviewed patches have been landed. Closing bug. 284843 2016-07-28 17:40:30 -0700 2016-07-29 11:41:42 -0700 [Patch] Proposed Fix bug-160330-20160728173917.patch text/plain 3034 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzODQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAz MmNkZWM0YjY1NjJlMTdmM2FjNzY4ZjQyOTQ3OTA3ZjFmOTM0NDAzLi42ODIxYWRiZDM5ZDI5Yzcx YjYwOTY5MWRhODdmNjBlYjRlMDYwNjgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxNi0wNy0yOCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQXNzZXJ0aW9uIGluIE5ldHdvcmtHcmlkQ29udGVu dFZpZXcgd2hlbiB1cGRhdGluZyBkYXRhIGdyaWQgZm9yIHRoZSBmaXJzdCB0aW1lCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjAzMzAKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzI3NjAwOTA1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdoZW4gdGhlIGZpcnN0IGdyaWQgbm9kZSBpcyBhZGRlZCwgYSB2 aWV3IGxheW91dCBhbmQgY3VycmVudCB0aW1lIHVwZGF0ZQorICAgICAgICBhcmUgc2NoZWR1bGVk LiBBIHZpZXcgbGF5b3V0IG9jY3VycmluZyBiZWZvcmUgdGhlIGN1cnJlbnQgdGltZSBpcyB1cGRh dGVkCisgICAgICAgIHNob3VsZCBiZSBza2lwcGVkLCBzaW5jZSB0aGUgcnVsZXIgZW5kIHRpbWUg aGFzbid0IGJlZW4gc2V0LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3Jr R3JpZENvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5ldHdvcmtHcmlkQ29u dGVudFZpZXcucHJvdG90eXBlLmxheW91dCk6CisgICAgICAgIFNraXAgbGF5b3V0IHVudGlsIGN1 cnJlbnQgdGltZSBpcyB1cGRhdGVkLgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5ldHdvcmtHcmlk Q29udGVudFZpZXcucHJvdG90eXBlLl91cGRhdGUpOgorICAgICAgICBSZW1vdmUgdW51c2VkIHZh cmlhYmxlcyBgc3RhcnRUaW1lYCBhbmQgYGVuZFRpbWVgLiBEb24ndCBmb3JjZSBhIGxheW91dAor ICAgICAgICBpZiB0aGUgZWxhcHNlZCB0aW1lIGlzIHplcm8uCisKIDIwMTYtMDctMjggIENocmlz IER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBQYXJhbWV0ZXJzIHRvIEV2ZW50 LmluaXRFdmVudCgpIHNob3VsZCBiZSBtYW5kYXRvcnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtHcmlkQ29udGVudFZpZXcuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrR3JpZENv bnRlbnRWaWV3LmpzCmluZGV4IDgwNDcwM2EyNmE5NzBmODI2MWIxOTU0ZTBkODU4N2E5YjhjMjk3 ZTkuLmFjYjNjODhhY2U5YmYyMDE4NmFmNzkyNDEzYzA1MDViYjE3M2E0YzMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtHcmlkQ29u dGVudFZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvTmV0d29ya0dyaWRDb250ZW50Vmlldy5qcwpAQCAtMTgxLDYgKzE4MSw5IEBAIFdlYkluc3Bl Y3Rvci5OZXR3b3JrR3JpZENvbnRlbnRWaWV3ID0gY2xhc3MgTmV0d29ya0dyaWRDb250ZW50Vmll dyBleHRlbmRzIFdlYkluCiAgICAgICAgIHRoaXMuX3RpbWVsaW5lUnVsZXIuemVyb1RpbWUgPSB0 aGlzLnplcm9UaW1lOwogICAgICAgICB0aGlzLl90aW1lbGluZVJ1bGVyLnN0YXJ0VGltZSA9IHRo aXMuemVyb1RpbWU7CiAKKyAgICAgICAgaWYgKHRoaXMuc3RhcnRUaW1lID49IHRoaXMuZW5kVGlt ZSkKKyAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICBmb3IgKGxldCBkYXRhR3JpZE5vZGUg b2YgdGhpcy5fZGF0YUdyaWQuY2hpbGRyZW4pCiAgICAgICAgICAgICBkYXRhR3JpZE5vZGUucmVm cmVzaEdyYXBoKCk7CiAKQEAgLTI4NywxNyArMjkwLDE0IEBAIFdlYkluc3BlY3Rvci5OZXR3b3Jr R3JpZENvbnRlbnRWaWV3ID0gY2xhc3MgTmV0d29ya0dyaWRDb250ZW50VmlldyBleHRlbmRzIFdl YkluCiAgICAgewogICAgICAgICBjb25zb2xlLmFzc2VydCh0aGlzLl9zY2hlZHVsZWRDdXJyZW50 VGltZVVwZGF0ZUlkZW50aWZpZXIpOwogCi0gICAgICAgIGxldCBzdGFydFRpbWUgPSB0aGlzLnN0 YXJ0VGltZTsKLSAgICAgICAgbGV0IGN1cnJlbnRUaW1lID0gdGhpcy5jdXJyZW50VGltZTsKLSAg ICAgICAgbGV0IGVuZFRpbWUgPSB0aGlzLmVuZFRpbWU7Ci0gICAgICAgIGxldCB0aW1lc3BhblNp bmNlTGFzdFVwZGF0ZSA9ICh0aW1lc3RhbXAgLSB0aGlzLl9sYXN0VXBkYXRlVGltZXN0YW1wKSAv IDEwMDAgfHwgMDsKKyAgICAgICAgaWYgKCFpc05hTih0aGlzLl9sYXN0VXBkYXRlVGltZXN0YW1w KSkgeworICAgICAgICAgICAgbGV0IHRpbWVzcGFuU2luY2VMYXN0VXBkYXRlID0gKHRpbWVzdGFt cCAtIHRoaXMuX2xhc3RVcGRhdGVUaW1lc3RhbXApIC8gMTAwMCB8fCAwOworICAgICAgICAgICAg dGhpcy5fdGltZWxpbmVSdWxlci5lbmRUaW1lID0gdGhpcy5jdXJyZW50VGltZSArIHRpbWVzcGFu U2luY2VMYXN0VXBkYXRlOwogCi0gICAgICAgIGN1cnJlbnRUaW1lICs9IHRpbWVzcGFuU2luY2VM YXN0VXBkYXRlOworICAgICAgICAgICAgdGhpcy51cGRhdGVMYXlvdXQoKTsKKyAgICAgICAgfQog Ci0gICAgICAgIHRoaXMuX3RpbWVsaW5lUnVsZXIuZW5kVGltZSA9IGN1cnJlbnRUaW1lOwogICAg ICAgICB0aGlzLl9sYXN0VXBkYXRlVGltZXN0YW1wID0gdGltZXN0YW1wOwotICAgICAgICB0aGlz LnVwZGF0ZUxheW91dCgpOwotCiAgICAgICAgIHRoaXMuX3NjaGVkdWxlZEN1cnJlbnRUaW1lVXBk YXRlSWRlbnRpZmllciA9IHJlcXVlc3RBbmltYXRpb25GcmFtZSh0aGlzLl91cGRhdGVDYWxsYmFj ayk7CiAgICAgfQogCg==