160325 2016-07-28 16:10:17 -0700 Function Call on NULL Object 2016-08-01 10:51:24 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbedard webkit-unassigned commit-queue darin lforschler oldest_to_newest 1215435 0 jbedard 2016-07-28 16:10:17 -0700 In InjectedBundle.cpp, the 'reset' signal is received at the beginning of a test run. In this reset, all web notifications are removed from the test runner. However, the first reset message is received before the test runner has been instantiated. 1215436 1 jbedard 2016-07-28 16:11:51 -0700 Note that this problem was only revealed with UBSan since removeAllWebNotifications() does not actually need the test runner to be instantiated to function. Another possible solution is to make this function a static one, but that would pollute the global namespace and may not be desired. 1215439 2 284832 jbedard 2016-07-28 16:15:48 -0700 Created attachment 284832 Patch 1215453 3 darin 2016-07-28 16:33:14 -0700 (In reply to comment #1) > Another possible solution is to make this function a static one, but that > would pollute the global namespace and may not be desired. We should make it a static member function. That won’t pollute any namespaces at all. 1215561 4 284867 jbedard 2016-07-29 09:15:10 -0700 Created attachment 284867 Patch 1215562 5 jbedard 2016-07-29 09:17:26 -0700 I made all functions in this family static, since none of them actually need the object to work. As a larger architectural question: why aren't more functions in the TestRunner static? Inspection of the code seems to indicate that most functions in the TestRunner could be declared as static. 1216141 6 darin 2016-08-01 10:31:43 -0700 (In reply to comment #5) > As a larger architectural question: why aren't more functions in the > TestRunner static? Inspection of the code seems to indicate that most > functions in the TestRunner could be declared as static. TestRunner is primarily an object that exposes bindings to be called from JavaScript using the JavaScript testRunner object exposed to tests. People writing these functions probably don’t think about which ones do and don’t need the state; it would be fine, although not particularly important, to change any that can be static member functions to be defined that way. 1216155 7 284867 commit-queue 2016-08-01 10:51:20 -0700 Comment on attachment 284867 Patch Clearing flags on attachment: 284867 Committed r203975: <http://trac.webkit.org/changeset/203975> 1216156 8 commit-queue 2016-08-01 10:51:24 -0700 All reviewed patches have been landed. Closing bug. 284832 2016-07-28 16:15:48 -0700 2016-07-29 09:15:06 -0700 Patch bug-160325-20160728161435.patch text/plain 1339 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwMzg0NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE2LTA3LTI4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBGdW5jdGlvbiBDYWxsIG9uIE5VTEwgT2JqZWN0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjAzMjUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvSW5q ZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwOgorICAgICAgICAoV1RSOjpJbmplY3RlZEJ1 bmRsZTo6ZGlkUmVjZWl2ZU1lc3NhZ2VUb1BhZ2UpOiBGaXhlZCByZW1vdmVBbGxXZWJOb3RpZmlj YXRpb25zKCkgYmVpbmcgY2FsbGVkIGJ5IGEgTlVMTCB0ZXN0IHJ1bm5lci4KKwogMjAxNi0wNy0y OCAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBGcmVx dWVudCBhbmltYXRpb24gbGFncyB3aGVuIGludGVyYWN0aW5nIHdpdGggU2FmYXJpIChzaWRlYmFy LCB0YWIgc3dpdGNoaW5nLCBldGMuKQpJbmRleDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9Jbmpl Y3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViS2l0 VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHAJKHJldmlzaW9uIDIw MzgzMCkKKysrIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRC dW5kbGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xOTAsNyArMTkwLDggQEAgdm9pZCBJbmplY3Rl ZEJ1bmRsZTo6ZGlkUmVjZWl2ZU1lc3NhZ2VUbwogICAgICAgICBtX3BpeGVsUmVzdWx0SXNQZW5k aW5nID0gZmFsc2U7CiAKICAgICAgICAgcmVzZXRMb2NhbFNldHRpbmdzKCk7Ci0gICAgICAgIG1f dGVzdFJ1bm5lci0+cmVtb3ZlQWxsV2ViTm90aWZpY2F0aW9uUGVybWlzc2lvbnMoKTsKKyAgICAg ICAgaWYgKG1fdGVzdFJ1bm5lcikKKyAgICAgICAgICAgIG1fdGVzdFJ1bm5lci0+cmVtb3ZlQWxs V2ViTm90aWZpY2F0aW9uUGVybWlzc2lvbnMoKTsKIAogICAgICAgICBJbmplY3RlZEJ1bmRsZTo6 cGFnZSgpLT5yZXNldEFmdGVyVGVzdCgpOwogCg== 284867 2016-07-29 09:15:10 -0700 2016-08-01 10:51:20 -0700 Patch bug-160325-20160729091356.patch text/plain 2356 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwMzkwMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE2LTA3LTI5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBGdW5jdGlvbiBDYWxsIG9uIE5VTEwgT2JqZWN0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjAzMjUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvSW5q ZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwOgorICAgICAgICAoV1RSOjpJbmplY3RlZEJ1 bmRsZTo6ZGlkUmVjZWl2ZU1lc3NhZ2VUb1BhZ2UpOiBDaGFuZ2VkIHJlbW92ZUFsbFdlYk5vdGlm aWNhdGlvblBlcm1pc3Npb25zKCkgY2FsbCB0byBzdGF0aWMgZnVuY3Rpb24gY2FsbC4KKyAgICAg ICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL1Rlc3RSdW5uZXIuaDogTWFkZSBh bGwgd2ViLW5vdGlmaWNhdGlvbiBmdW5jdGlvbnMgc3RhdGljLgorCiAyMDE2LTA3LTI5ICBUaWJv ciBNZXN6YXJvcyAgPHRtZXN6YXJvcy51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgogCiAg ICAgICAgIFVwZGF0ZSBmb3IgY29udHJpYnV0b3JzLmpzb24KSW5kZXg6IFRvb2xzL1dlYktpdFRl c3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3Bw CShyZXZpc2lvbiAyMDM5MDApCisrKyBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVu ZGxlL0luamVjdGVkQnVuZGxlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTkwLDcgKzE5MCw3IEBA IHZvaWQgSW5qZWN0ZWRCdW5kbGU6OmRpZFJlY2VpdmVNZXNzYWdlVG8KICAgICAgICAgbV9waXhl bFJlc3VsdElzUGVuZGluZyA9IGZhbHNlOwogCiAgICAgICAgIHJlc2V0TG9jYWxTZXR0aW5ncygp OwotICAgICAgICBtX3Rlc3RSdW5uZXItPnJlbW92ZUFsbFdlYk5vdGlmaWNhdGlvblBlcm1pc3Np b25zKCk7CisgICAgICAgIFRlc3RSdW5uZXI6OnJlbW92ZUFsbFdlYk5vdGlmaWNhdGlvblBlcm1p c3Npb25zKCk7CiAKICAgICAgICAgSW5qZWN0ZWRCdW5kbGU6OnBhZ2UoKS0+cmVzZXRBZnRlclRl c3QoKTsKIApJbmRleDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9UZXN0 UnVubmVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1 bmRsZS9UZXN0UnVubmVyLmgJKHJldmlzaW9uIDIwMzkwMCkKKysrIFRvb2xzL1dlYktpdFRlc3RS dW5uZXIvSW5qZWN0ZWRCdW5kbGUvVGVzdFJ1bm5lci5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNjks MTAgKzI2OSwxMCBAQCBwdWJsaWM6CiAgICAgYm9vbCBoYXNDdXN0b21GdWxsU2NyZWVuQmVoYXZp b3IoKSBjb25zdCB7IHJldHVybiBtX2N1c3RvbUZ1bGxTY3JlZW5CZWhhdmlvcjsgfQogCiAgICAg Ly8gV2ViIG5vdGlmaWNhdGlvbnMuCi0gICAgdm9pZCBncmFudFdlYk5vdGlmaWNhdGlvblBlcm1p c3Npb24oSlNTdHJpbmdSZWYgb3JpZ2luKTsKLSAgICB2b2lkIGRlbnlXZWJOb3RpZmljYXRpb25Q ZXJtaXNzaW9uKEpTU3RyaW5nUmVmIG9yaWdpbik7Ci0gICAgdm9pZCByZW1vdmVBbGxXZWJOb3Rp ZmljYXRpb25QZXJtaXNzaW9ucygpOwotICAgIHZvaWQgc2ltdWxhdGVXZWJOb3RpZmljYXRpb25D bGljayhKU1ZhbHVlUmVmIG5vdGlmaWNhdGlvbik7CisgICAgc3RhdGljIHZvaWQgZ3JhbnRXZWJO b3RpZmljYXRpb25QZXJtaXNzaW9uKEpTU3RyaW5nUmVmIG9yaWdpbik7CisgICAgc3RhdGljIHZv aWQgZGVueVdlYk5vdGlmaWNhdGlvblBlcm1pc3Npb24oSlNTdHJpbmdSZWYgb3JpZ2luKTsKKyAg ICBzdGF0aWMgdm9pZCByZW1vdmVBbGxXZWJOb3RpZmljYXRpb25QZXJtaXNzaW9ucygpOworICAg IHN0YXRpYyB2b2lkIHNpbXVsYXRlV2ViTm90aWZpY2F0aW9uQ2xpY2soSlNWYWx1ZVJlZiBub3Rp ZmljYXRpb24pOwogCiAgICAgLy8gR2VvbG9jYXRpb24uCiAgICAgdm9pZCBzZXRHZW9sb2NhdGlv blBlcm1pc3Npb24oYm9vbCk7Cg==