160324 2016-07-28 15:57:45 -0700 ASSERTION FAILED in errorProtoFuncToString() when Error name is a single char string. 2016-08-04 17:22:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam benjamin fpizlo ggaren keith_miller msaboff rhodovan.u-szeged saam webkit-bug-importer oldest_to_newest 1215426 0 mark.lam 2016-07-28 15:57:45 -0700 The issue is that errorProtoFuncToString() is using jsNontrivialString() to generate the error string even when the name string can be a single character string. This is incorrect. We should be using jsString() instead. 1215428 1 mark.lam 2016-07-28 15:58:58 -0700 <rdar://problem/27389572> 1215431 2 284827 mark.lam 2016-07-28 16:03:03 -0700 Created attachment 284827 proposed patch. 1215432 3 284827 keith_miller 2016-07-28 16:06:37 -0700 Comment on attachment 284827 proposed patch. r=me. 1215480 4 mark.lam 2016-07-28 18:25:08 -0700 Thanks for the review. Landed in r203853: <http://trac.webkit.org/r203853>. 1217683 5 mark.lam 2016-08-04 17:22:14 -0700 *** Bug 149253 has been marked as a duplicate of this bug. *** 284827 2016-07-28 16:03:03 -0700 2016-07-28 16:06:37 -0700 proposed patch. bug-160324.patch text/plain 2491 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAzODQ3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE2LTA3LTI4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB U1NFUlRJT04gRkFJTEVEIGluIGVycm9yUHJvdG9GdW5jVG9TdHJpbmcoKSB3aGVuIEVycm9yIG5h bWUgaXMgYSBzaW5nbGUgY2hhciBzdHJpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNjAzMjQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI3Mzg5 NTcyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZSBpc3N1ZSBpcyB0aGF0IGVycm9yUHJvdG9GdW5jVG9TdHJpbmcoKSB3YXMgdXNpbmcganNOb250 cml2aWFsU3RyaW5nKCkgdG8KKyAgICAgICAgZ2VuZXJhdGUgdGhlIGVycm9yIHN0cmluZyBldmVu IHdoZW4gdGhlIG5hbWUgc3RyaW5nIGNhbiBiZSBhIHNpbmdsZSBjaGFyYWN0ZXIKKyAgICAgICAg c3RyaW5nLiAgVGhpcyBpcyBpbmNvcnJlY3QuICBXZSBzaG91bGQgYmUgdXNpbmcganNTdHJpbmco KSBpbnN0ZWFkLgorCisgICAgICAgICogcnVudGltZS9FcnJvclByb3RvdHlwZS5jcHA6CisgICAg ICAgIChKU0M6OmVycm9yUHJvdG9GdW5jVG9TdHJpbmcpOgorICAgICAgICAqIHRlc3RzL3N0cmVz cy9lcnJvcnMtd2l0aC1zaW1wbGUtbmFtZXMtb3ItbWVzc2FnZXMtc2hvdWxkLW5vdC1jcmFzaC10 b1N0cmluZy5qczogQWRkZWQuCisKIDIwMTYtMDctMjggIE1hcmsgTGFtICA8bWFyay5sYW1AYXBw bGUuY29tPgogCiAgICAgICAgIFN0cmluZ1ZpZXcgc2hvdWxkIGhhdmUgYW4gZXhwbGljaXQgbV9p czhCaXQgZmllbGQuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FcnJvclBy b3RvdHlwZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv RXJyb3JQcm90b3R5cGUuY3BwCShyZXZpc2lvbiAyMDM4MzQpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9FcnJvclByb3RvdHlwZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExOCw3 ICsxMTgsNyBAQCBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGVycm9yUHJvdG9GCiAKICAg ICAvLyA5LiBJZiBtc2cgaXMgdGhlIGVtcHR5IFN0cmluZywgcmV0dXJuIG5hbWUuCiAgICAgaWYg KCFtZXNzYWdlU3RyaW5nLmxlbmd0aCgpKQotICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2Rl KG5hbWUuaXNTdHJpbmcoKSA/IG5hbWUgOiBqc05vbnRyaXZpYWxTdHJpbmcoZXhlYywgbmFtZVN0 cmluZykpOworICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKG5hbWUuaXNTdHJpbmcoKSA/ IG5hbWUgOiBqc1N0cmluZyhleGVjLCBuYW1lU3RyaW5nKSk7CiAKICAgICAvLyAxMC4gUmV0dXJu IHRoZSByZXN1bHQgb2YgY29uY2F0ZW5hdGluZyBuYW1lLCAiOiIsIGEgc2luZ2xlIHNwYWNlIGNo YXJhY3RlciwgYW5kIG1zZy4KICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzTWFrZU5vbnRy aXZpYWxTdHJpbmcoZXhlYywgbmFtZVN0cmluZywgIjogIiwgbWVzc2FnZVN0cmluZykpOwpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9lcnJvcnMtd2l0aC1zaW1wbGUt bmFtZXMtb3ItbWVzc2FnZXMtc2hvdWxkLW5vdC1jcmFzaC10b1N0cmluZy5qcwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2Vycm9ycy13aXRoLXNpbXBs ZS1uYW1lcy1vci1tZXNzYWdlcy1zaG91bGQtbm90LWNyYXNoLXRvU3RyaW5nLmpzCShub25leGlz dGVudCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvZXJyb3JzLXdpdGgt c2ltcGxlLW5hbWVzLW9yLW1lc3NhZ2VzLXNob3VsZC1ub3QtY3Jhc2gtdG9TdHJpbmcuanMJKHdv cmtpbmcgY29weSkKQEAgLTAsMCArMSwxMiBAQAorLy9AIHJ1bkRlZmF1bHQKKy8vIFRoaXMgdGVz dCBzaG91bGQgbm90IGNyYXNoLgorCitFcnJvci5wcm90b3R5cGUubmFtZSA9IDAKK0Vycm9yKCku dG9TdHJpbmcoKTsKK0Vycm9yKCIxIikudG9TdHJpbmcoKTsKK0Vycm9yKDApLnRvU3RyaW5nKCk7 CisKK0Vycm9yLnByb3RvdHlwZS5uYW1lID0gIiIKK0Vycm9yKCkudG9TdHJpbmcoKTsKK0Vycm9y KCIxIikudG9TdHJpbmcoKTsKK0Vycm9yKDApLnRvU3RyaW5nKCk7Cg==