160323 2016-07-28 15:54:28 -0700 window.open.length should be 0 2016-07-28 16:30:56 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED WebExposed P2 Normal --- 1 cdumez cdumez cdumez commit-queue darin dbates esprehn+autocc kondapallykalyan rniwa sam oldest_to_newest 1215423 0 cdumez 2016-07-28 15:54:28 -0700 window.open.length should be 0 as all its parameters are optional: - https://html.spec.whatwg.org/multipage/browsers.html#the-window-object It is 2 in WebKit. Firefox and Chrome agree with the specification and return 0. 1215427 1 284826 cdumez 2016-07-28 15:58:06 -0700 Created attachment 284826 Patch 1215449 2 284826 commit-queue 2016-07-28 16:30:51 -0700 Comment on attachment 284826 Patch Clearing flags on attachment: 284826 Committed r203849: <http://trac.webkit.org/changeset/203849> 1215450 3 commit-queue 2016-07-28 16:30:56 -0700 All reviewed patches have been landed. Closing bug. 284826 2016-07-28 15:58:06 -0700 2016-07-28 16:30:51 -0700 Patch bug-160323-20160728155653.patch text/plain 7348 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzODQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGUwZDlmMGU2ZWM5ZTQx OTk4ZDUyNDkxMmJkMTY2YmUyNzViNmMyMy4uNGUwZTU0YzUwZjEyODczYmEyYjgyZWJjOGJkZjM5 ZmJmYWRmNzFiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDE2LTA3LTI4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgd2luZG93Lm9wZW4ubGVuZ3Ro IHNob3VsZCBiZSAwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNjAzMjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICB3aW5kb3cub3Blbi5sZW5ndGggc2hvdWxkIGJlIDAgYXMgYWxsIGl0cyBwYXJhbWV0ZXJz IGFyZSBvcHRpb25hbDoKKyAgICAgICAgLSBodHRwczovL2h0bWwuc3BlYy53aGF0d2cub3JnL211 bHRpcGFnZS9icm93c2Vycy5odG1sI3RoZS13aW5kb3ctb2JqZWN0CisKKyAgICAgICAgSXQgaXMg MiBpbiBXZWJLaXQuIEZpcmVmb3ggYW5kIENocm9tZSBhZ3JlZSB3aXRoIHRoZSBzcGVjaWZpY2F0 aW9uIGFuZCByZXR1cm4gMC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHJlYmFzZWxpbmVkIGV4 aXN0aW5nIHRlc3QuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0N1c3RvbS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpKU0RPTVdpbmRvdzo6b3Blbik6CisgICAgICAgIE1pbm9y IGNvZGUgb3B0aW1pemF0aW9uLgorCisgICAgICAgICogcGFnZS9ET01XaW5kb3cuaWRsOgorICAg ICAgICBVcGRhdGUgSURMIHRvIG1hdGNoIHRoZSBzcGVjaWZpY2F0aW9uIGFuZCBvdXIgY3VzdG9t IGltcGxlbWVudGF0aW9uLgorICAgICAgICBUaGlzIG1ha2VzIHVzIHJldHVybiB0aGUgcmlnaHQg Imxlbmd0aCIgdmFsdWUuCisKKzIwMTYtMDctMjggIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxl LmNvbT4KKwogICAgICAgICBQYXJhbWV0ZXIgdG8gdGFibGUuZGVsZXRlUm93KCkgLyBib2R5LmRl bGV0ZVJvdygpIHNob3VsZCBiZSBtYW5kYXRvcnkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDMwNwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0N1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9KU0RPTVdpbmRvd0N1c3RvbS5jcHAKaW5kZXggY2ZkMmRhN2M3MTY1NzFhYTM0ODNl MjMxNDNkOThiYjg0ZThiZWIyMy4uYTY3YTlhOTFlYTJiMzFkZDM4OWNhYTc1NDNhYWQwYzg5M2Vl NzRiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01XaW5kb3dD dXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93Q3Vz dG9tLmNwcApAQCAtNDQ0LDE0ICs0NDQsMTUgQEAgSlNWYWx1ZSBKU0RPTVdpbmRvdzo6b3BlbihF eGVjU3RhdGUmIHN0YXRlKQogICAgIFN0cmluZyB1cmxTdHJpbmcgPSB2YWx1ZVRvU3RyaW5nV2l0 aFVuZGVmaW5lZE9yTnVsbENoZWNrKCZzdGF0ZSwgc3RhdGUuYXJndW1lbnQoMCkpOwogICAgIGlm IChzdGF0ZS5oYWRFeGNlcHRpb24oKSkKICAgICAgICAgcmV0dXJuIGpzVW5kZWZpbmVkKCk7Ci0g ICAgQXRvbWljU3RyaW5nIGZyYW1lTmFtZSA9IHN0YXRlLmFyZ3VtZW50KDEpLmlzVW5kZWZpbmVk T3JOdWxsKCkgPyAiX2JsYW5rIiA6IHN0YXRlLmFyZ3VtZW50KDEpLnRvU3RyaW5nKCZzdGF0ZSkt PnZhbHVlKCZzdGF0ZSk7CisgICAgSlNWYWx1ZSB0YXJnZXRWYWx1ZSA9IHN0YXRlLmFyZ3VtZW50 KDEpOworICAgIEF0b21pY1N0cmluZyB0YXJnZXQgPSB0YXJnZXRWYWx1ZS5pc1VuZGVmaW5lZE9y TnVsbCgpID8gQXRvbWljU3RyaW5nKCJfYmxhbmsiLCBBdG9taWNTdHJpbmc6OkNvbnN0cnVjdEZy b21MaXRlcmFsKSA6IHRhcmdldFZhbHVlLnRvU3RyaW5nKCZzdGF0ZSktPnRvQXRvbWljU3RyaW5n KCZzdGF0ZSk7CiAgICAgaWYgKHN0YXRlLmhhZEV4Y2VwdGlvbigpKQogICAgICAgICByZXR1cm4g anNVbmRlZmluZWQoKTsKICAgICBTdHJpbmcgd2luZG93RmVhdHVyZXNTdHJpbmcgPSB2YWx1ZVRv U3RyaW5nV2l0aFVuZGVmaW5lZE9yTnVsbENoZWNrKCZzdGF0ZSwgc3RhdGUuYXJndW1lbnQoMikp OwogICAgIGlmIChzdGF0ZS5oYWRFeGNlcHRpb24oKSkKICAgICAgICAgcmV0dXJuIGpzVW5kZWZp bmVkKCk7CiAKLSAgICBSZWZQdHI8RE9NV2luZG93PiBvcGVuZWRXaW5kb3cgPSB3cmFwcGVkKCku b3Blbih1cmxTdHJpbmcsIGZyYW1lTmFtZSwgd2luZG93RmVhdHVyZXNTdHJpbmcsIGFjdGl2ZURP TVdpbmRvdygmc3RhdGUpLCBmaXJzdERPTVdpbmRvdygmc3RhdGUpKTsKKyAgICBSZWZQdHI8RE9N V2luZG93PiBvcGVuZWRXaW5kb3cgPSB3cmFwcGVkKCkub3Blbih1cmxTdHJpbmcsIHRhcmdldCwg d2luZG93RmVhdHVyZXNTdHJpbmcsIGFjdGl2ZURPTVdpbmRvdygmc3RhdGUpLCBmaXJzdERPTVdp bmRvdygmc3RhdGUpKTsKICAgICBpZiAoIW9wZW5lZFdpbmRvdykKICAgICAgICAgcmV0dXJuIGpz VW5kZWZpbmVkKCk7CiAgICAgcmV0dXJuIHRvSlMoJnN0YXRlLCBvcGVuZWRXaW5kb3cuZ2V0KCkp OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsIGIvU291cmNl L1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsCmluZGV4IDdlMTY2NmYxNGU3Y2Y5NjgzODI5OGQ3 OTNkZjRhMmI2MTkxMTAwMzQuLjE5Y2YyYWJlYTBhYWMzY2M1YjViMWE3N2U1Y2YwOWYxNWZkMjcw MmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmlkbAorKysgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5pZGwKQEAgLTY1LDkgKzY1LDcgQEAKICAgICB2 b2lkIHByaW50KCk7CiAgICAgdm9pZCBzdG9wKCk7CiAKLSAgICBbQ3VzdG9tXSBET01XaW5kb3cg b3BlbihET01TdHJpbmcgdXJsLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgIERPTVN0cmlu ZyBuYW1lLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgIG9wdGlvbmFsIERPTVN0cmluZyBv cHRpb25zKTsKKyAgICBbQ3VzdG9tXSBET01XaW5kb3cgb3BlbihvcHRpb25hbCBET01TdHJpbmcg dXJsID0gImFib3V0OmJsYW5rIiwgb3B0aW9uYWwgRE9NU3RyaW5nIHRhcmdldCA9ICJfYmxhbmsi LCBbVHJlYXROdWxsQXM9RW1wdHlTdHJpbmddIG9wdGlvbmFsIERPTVN0cmluZyBmZWF0dXJlcyA9 ICIiKTsKIAogICAgIFtDdXN0b21dIGFueSBzaG93TW9kYWxEaWFsb2coRE9NU3RyaW5nIHVybCwK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG9wdGlvbmFsIGFueSBkaWFs b2dBcmdzLApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCmluZGV4IDhlY2VkNjBkYjYxYjU3ZjA5ZDFiNWYyZTI2YzBjZWNiZDY5NzU3MjMu LmMyZWIxZWJhNjc1NjgzZjJjNTRmZmEyNWEzNDQ2OWNiNzcyNzNmYTYgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsNSAr MSwxNyBAQAogMjAxNi0wNy0yOCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCisg ICAgICAgIHdpbmRvdy5vcGVuLmxlbmd0aCBzaG91bGQgYmUgMAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwMzIzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIGV4aXN0aW5nIHRlc3QgdG8gcmVm bGVjdCBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBqcy9kb20vZnVuY3Rpb24tbGVuZ3Ro LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBqcy9kb20vZnVuY3Rpb24tbGVuZ3RoLmh0bWw6CisK KzIwMTYtMDctMjggIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKwogICAgICAgICBQ YXJhbWV0ZXIgdG8gdGFibGUuZGVsZXRlUm93KCkgLyBib2R5LmRlbGV0ZVJvdygpIHNob3VsZCBi ZSBtYW5kYXRvcnkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE2MDMwNwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdl TG9nIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwppbmRleCA2YzZjZGEzNzIw YzI3YTc4ZmRjMjI2NDg2ZjRiN2ViNzg3ZjQ0Zjc1Li4yNjdhZGI3NzZjYjlhYWJiNzBmNjRjNGIy OTA2MzZlNGYwMzQwYjM5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hh bmdlTG9nCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKQEAgLTEsNSAr MSwxNiBAQAogMjAxNi0wNy0yOCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCisg ICAgICAgIHdpbmRvdy5vcGVuLmxlbmd0aCBzaG91bGQgYmUgMAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwMzIzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmViYXNlbGluZSBXM0MgdGVzdCBub3cgdGhh dCBvbmUgbW9yZSBjaGVjayBpcyBwYXNzaW5nLgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRl c3RzL2h0bWwvZG9tL2ludGVyZmFjZXMtZXhwZWN0ZWQudHh0OgorCisyMDE2LTA3LTI4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKICAgICAgICAgUGFyYW1ldGVyIHRvIHRhYmxl LmRlbGV0ZVJvdygpIC8gYm9keS5kZWxldGVSb3coKSBzaG91bGQgYmUgbWFuZGF0b3J5CiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjAzMDcKIApkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1s L2RvbS9pbnRlcmZhY2VzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9kb20vaW50ZXJmYWNlcy1leHBlY3RlZC50eHQKaW5kZXgg YjY0Njc4MzhiN2FhY2MzNWU4N2M1ZTJlYTA4ZmNkNjIyNWZjMWYwYS4uYzVmMzliOGEwMWM1NzVh N2JlNDcyN2YwNmExOGI0ZDY2ZTc2OWU4NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2RvbS9pbnRlcmZhY2VzLWV4cGVjdGVkLnR4 dAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwv ZG9tL2ludGVyZmFjZXMtZXhwZWN0ZWQudHh0CkBAIC01MTg3LDcgKzUxODcsNyBAQCBQQVNTIFdp bmRvdyBpbnRlcmZhY2U6IGF0dHJpYnV0ZSBsZW5ndGgKIFBBU1MgV2luZG93IGludGVyZmFjZTog YXR0cmlidXRlIG9wZW5lciAKIFBBU1MgV2luZG93IGludGVyZmFjZTogYXR0cmlidXRlIHBhcmVu dCAKIFBBU1MgV2luZG93IGludGVyZmFjZTogYXR0cmlidXRlIGZyYW1lRWxlbWVudCAKLUZBSUwg V2luZG93IGludGVyZmFjZTogb3BlcmF0aW9uIG9wZW4oRE9NU3RyaW5nLERPTVN0cmluZyxET01T dHJpbmcsYm9vbGVhbikgYXNzZXJ0X2VxdWFsczogcHJvcGVydHkgaGFzIHdyb25nIC5sZW5ndGgg ZXhwZWN0ZWQgMCBidXQgZ290IDIKK1BBU1MgV2luZG93IGludGVyZmFjZTogb3BlcmF0aW9uIG9w ZW4oRE9NU3RyaW5nLERPTVN0cmluZyxET01TdHJpbmcsYm9vbGVhbikgCiBQQVNTIFdpbmRvdyBp bnRlcmZhY2U6IGF0dHJpYnV0ZSBuYXZpZ2F0b3IgCiBGQUlMIFdpbmRvdyBpbnRlcmZhY2U6IGF0 dHJpYnV0ZSBleHRlcm5hbCBhc3NlcnRfb3duX3Byb3BlcnR5OiBUaGUgZ2xvYmFsIG9iamVjdCBt dXN0IGhhdmUgYSBwcm9wZXJ0eSAiZXh0ZXJuYWwiIGV4cGVjdGVkIHByb3BlcnR5ICJleHRlcm5h bCIgbWlzc2luZwogUEFTUyBXaW5kb3cgaW50ZXJmYWNlOiBhdHRyaWJ1dGUgYXBwbGljYXRpb25D YWNoZSAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2pzL2RvbS9mdW5jdGlvbi1sZW5ndGgtZXhw ZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvanMvZG9tL2Z1bmN0aW9uLWxlbmd0aC1leHBlY3RlZC50 eHQKaW5kZXggNGEzNmI5OGY2YjhjMjIwODI0YmI5MmVhMDg1YWMxM2E2MDRiNDdlYS4uNDhlNDVj MzA2ZTM3YTZhZDU2NmJlNTcyMDFhYWIxZTcxOWI5NjU2YSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvanMvZG9tL2Z1bmN0aW9uLWxlbmd0aC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMv anMvZG9tL2Z1bmN0aW9uLWxlbmd0aC1leHBlY3RlZC50eHQKQEAgLTQsNyArNCw3IEBAIE9uIHN1 Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2Vk IGJ5ICJURVNUIENPTVBMRVRFCiAKIAogUEFTUyB3aW5kb3cuY29uZmlybS5sZW5ndGggaXMgMAot UEFTUyB3aW5kb3cub3Blbi5sZW5ndGggaXMgMgorUEFTUyB3aW5kb3cub3Blbi5sZW5ndGggaXMg MAogUEFTUyB3aW5kb3cuc2hvd01vZGFsRGlhbG9nLmxlbmd0aCBpcyAxCiBQQVNTIHdpbmRvdy5z ZXRUaW1lb3V0Lmxlbmd0aCBpcyAxCiBQQVNTIHdpbmRvdy5jbGVhclRpbWVvdXQubGVuZ3RoIGlz IDAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2pzL2RvbS9mdW5jdGlvbi1sZW5ndGguaHRtbCBi L0xheW91dFRlc3RzL2pzL2RvbS9mdW5jdGlvbi1sZW5ndGguaHRtbAppbmRleCBmMjM3NDU2Mzc2 ZTA4OGFjMjk4NzdkNjViMTM4YzI4NmFmZTAxZTBmLi5hZThiOGRlZGU5Mzc4ZTg3NDUxODk4OTNi OTFmYWU1OWRiZDBhNDEyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9qcy9kb20vZnVuY3Rpb24t bGVuZ3RoLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvanMvZG9tL2Z1bmN0aW9uLWxlbmd0aC5odG1s CkBAIC04LDcgKzgsNyBAQAogZGVzY3JpcHRpb24oIlRoaXMgdGVzdHMgdGhlIGxlbmd0aCBwcm9w ZXJ0eSBvZiBmdW5jdGlvbnMuIik7CiAKIHNob3VsZEJlKCd3aW5kb3cuY29uZmlybS5sZW5ndGgn LCAnMCcpOwotc2hvdWxkQmUoJ3dpbmRvdy5vcGVuLmxlbmd0aCcsICcyJyk7CitzaG91bGRCZSgn d2luZG93Lm9wZW4ubGVuZ3RoJywgJzAnKTsKIHNob3VsZEJlKCd3aW5kb3cuc2hvd01vZGFsRGlh bG9nLmxlbmd0aCcsICcxJyk7CiBzaG91bGRCZSgnd2luZG93LnNldFRpbWVvdXQubGVuZ3RoJywg JzEnKTsKIHNob3VsZEJlKCd3aW5kb3cuY2xlYXJUaW1lb3V0Lmxlbmd0aCcsICcwJyk7Cg==