160296 2016-07-28 09:01:46 -0700 First parameter to SVGDocument.createEvent() should be mandatory 2016-07-28 11:15:37 -0700 1 1 1 Unclassified WebKit SVG WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED WebExposed P2 Normal --- 1 cdumez cdumez achristensen commit-queue darin dbates rniwa sabouhallawa sam zimmermann oldest_to_newest 1215237 0 cdumez 2016-07-28 09:01:46 -0700 First parameter to SVGDocument.createEvent() should be mandatory: - https://www.w3.org/TR/SVG2/struct.html#InterfaceDocumentExtensions - https://dom.spec.whatwg.org/#document Firefox and Chrome agree with the specification. 1215238 1 284784 cdumez 2016-07-28 09:04:39 -0700 Created attachment 284784 Patch 1215259 2 284784 achristensen 2016-07-28 10:40:20 -0700 Comment on attachment 284784 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284784&action=review > LayoutTests/svg/dom/SVGDocument-createEvent-expected.txt:6 > +PASS svgDocument.createEvent() threw exception TypeError: Not enough arguments. Chrome canary and firefox fail this test :( 1215265 3 cdumez 2016-07-28 10:45:39 -0700 (In reply to comment #2) > Comment on attachment 284784 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=284784&action=review > > > LayoutTests/svg/dom/SVGDocument-createEvent-expected.txt:6 > > +PASS svgDocument.createEvent() threw exception TypeError: Not enough arguments. > > Chrome canary and firefox fail this test :( Only because my test checks for a specific exception message and their exception message is different? 1215268 4 284784 achristensen 2016-07-28 10:51:11 -0700 Comment on attachment 284784 Patch Yep, I just saw the red FAIL. They indeed just have a different message. No problem 1215281 5 284784 commit-queue 2016-07-28 11:15:32 -0700 Comment on attachment 284784 Patch Clearing flags on attachment: 284784 Committed r203821: <http://trac.webkit.org/changeset/203821> 1215282 6 commit-queue 2016-07-28 11:15:37 -0700 All reviewed patches have been landed. Closing bug. 284784 2016-07-28 09:04:39 -0700 2016-07-28 11:15:32 -0700 Patch bug-160296-20160728090327.patch text/plain 4184 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzODA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOThhYTUwYjA5NjM0OWQ3 Y2Q4Yjk4OTNkMTZkNTU3ZDNhZDJlMzU4OC4uOTljMjFiNjM5MTQ1OWFiYWI0YWU0M2RkZTgxNTFi OWNhMjY3NDdmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE2LTA3LTI4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRmlyc3QgcGFyYW1ldGVyIHRv IFNWR0RvY3VtZW50LmNyZWF0ZUV2ZW50KCkgc2hvdWxkIGJlIG1hbmRhdG9yeQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwMjk2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRmlyc3QgcGFyYW1ldGVyIHRv IFNWR0RvY3VtZW50LmNyZWF0ZUV2ZW50KCkgc2hvdWxkIGJlIG1hbmRhdG9yeToKKyAgICAgICAg LSBodHRwczovL3d3dy53My5vcmcvVFIvU1ZHMi9zdHJ1Y3QuaHRtbCNJbnRlcmZhY2VEb2N1bWVu dEV4dGVuc2lvbnMKKyAgICAgICAgLSBodHRwczovL2RvbS5zcGVjLndoYXR3Zy5vcmcvI2RvY3Vt ZW50CisKKyAgICAgICAgVGhpcyBwYXRjaCBkcm9wcyBjcmVhdGVFdmVudCgpIGZyb20gU1ZHRG9j dW1lbnQgc28gdGhhdCB0aGUgc3BlYy1jb21wbGlhbnQKKyAgICAgICAgRG9jdW1lbnQuY3JlYXRl RXZlbnQoKSBpcyB1c2VkIGluc3RlYWQuIEluIHRoZSBzcGVjaWZpY2F0aW9uLCBTVkdEb2N1bWVu dAorICAgICAgICBubyBsb25nZXIgZXhpc3RzIGFuZCBpcyBhIHNpbXBsZSBEb2N1bWVudC4KKwor ICAgICAgICBGaXJlZm94IGFuZCBDaHJvbWUgYWdyZWUgd2l0aCB0aGUgc3BlY2lmaWNhdGlvbi4K KworICAgICAgICBUZXN0OiBzdmcvZG9tL1NWR0RvY3VtZW50LWNyZWF0ZUV2ZW50Lmh0bWwKKwor ICAgICAgICAqIHN2Zy9TVkdEb2N1bWVudC5pZGw6CisKIDIwMTYtMDctMjcgIENocmlzIER1bWV6 ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBGaXJzdCBwYXJhbWV0ZXIgdG8gSFRNTE1l ZGlhRWxlbWVudC5jYW5QbGF5VHlwZSgpIHNob3VsZCBiZSBtYW5kYXRvcnkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdEb2N1bWVudC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9zdmcv U1ZHRG9jdW1lbnQuaWRsCmluZGV4IDVjODhmYzI4YTM5OWE1OGZlZDY1MDYzZTk1YzNhMTRlMTQ3 NDRjOWMuLjY0YjEzZDM5OGQ0NjQ4MmQ4N2I5YTIyNjYyOGIzOTc5MmNjN2M5M2IgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdEb2N1bWVudC5pZGwKKysrIGIvU291cmNlL1dlYkNv cmUvc3ZnL1NWR0RvY3VtZW50LmlkbApAQCAtMjEsMTAgKzIxLDYgQEAKIAogLy8gRklYTUU6IFRo aXMgaW50ZXJmYWNlIG5vIGxvbmdlciBleGlzdHMgaW4gU1ZHMi4KIGludGVyZmFjZSBTVkdEb2N1 bWVudCA6IFhNTERvY3VtZW50IHsKLSAgICByZWFkb25seSBhdHRyaWJ1dGUgU1ZHU1ZHRWxlbWVu dCAgICAgICAgcm9vdEVsZW1lbnQ7Ci0KLSAgICAvLyBPdmVyd3JpdGUgdGhlIG9uZSBpbiBldmVu dHM6OkRvY3VtZW50RXZlbnQKLSAgICAvLyBGSVhNRTogVXNpbmcgInVuZGVmaW5lZCIgYXMgZGVm YXVsdCBwYXJhbWV0ZXIgdmFsdWUgaXMgd3JvbmcuCi0gICAgW1JhaXNlc0V4Y2VwdGlvbl0gRXZl bnQgY3JlYXRlRXZlbnQob3B0aW9uYWwgRE9NU3RyaW5nIGV2ZW50VHlwZSA9ICJ1bmRlZmluZWQi KTsKKyAgICByZWFkb25seSBhdHRyaWJ1dGUgU1ZHU1ZHRWxlbWVudD8gcm9vdEVsZW1lbnQ7CiB9 OwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKaW5kZXggYzQxYjQ0NzFjOTdlYzliNzUwOGVkYjBhMDVjYjYwNGFkNTJhMDNiYy4uY2Rl MzMxM2FhODUzY2U4NTQ1ODYzNTVjN2VlNzE0ZjkyMTlhY2QxYiAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE2LTA3LTI4ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg ICAgRmlyc3QgcGFyYW1ldGVyIHRvIFNWR0RvY3VtZW50LmNyZWF0ZUV2ZW50KCkgc2hvdWxkIGJl IG1hbmRhdG9yeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTYwMjk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkIHRlc3QgY292ZXJhZ2UuCisKKyAgICAgICAgKiBzdmcvZG9tL1NWR0RvY3VtZW50LWNy ZWF0ZUV2ZW50LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogc3ZnL2RvbS9TVkdEb2N1 bWVudC1jcmVhdGVFdmVudC5odG1sOiBBZGRlZC4KKwogMjAxNi0wNy0yNyAgQ2hyaXMgRHVtZXog IDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEZpcnN0IHBhcmFtZXRlciB0byBIVE1MTWVk aWFFbGVtZW50LmNhblBsYXlUeXBlKCkgc2hvdWxkIGJlIG1hbmRhdG9yeQpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvc3ZnL2RvbS9TVkdEb2N1bWVudC1jcmVhdGVFdmVudC1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy9zdmcvZG9tL1NWR0RvY3VtZW50LWNyZWF0ZUV2ZW50LWV4cGVjdGVkLnR4 dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi4wMDZmYWMwMWVjZjBmMGExM2YzMzFhZTFiY2QyNjY0OGUxMmU3MjY5Ci0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvc3ZnL2RvbS9TVkdEb2N1bWVudC1jcmVhdGVF dmVudC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMiBAQAorVGVzdCBTVkdEb2N1bWVudC5jcmVh dGVFdmVudCgpIG9wZXJhdGlvbi4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVz IG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BB U1Mgc3ZnRG9jdW1lbnQuY3JlYXRlRXZlbnQoKSB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBO b3QgZW5vdWdoIGFyZ3VtZW50cy4KK1BBU1MgZXZlbnQgPSBzdmdEb2N1bWVudC5jcmVhdGVFdmVu dCgnbW91c2VldmVudCcpIGRpZCBub3QgdGhyb3cgZXhjZXB0aW9uLgorUEFTUyBldmVudC5fX3By b3RvX18gaXMgTW91c2VFdmVudC5wcm90b3R5cGUKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlz IHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdmcvZG9t L1NWR0RvY3VtZW50LWNyZWF0ZUV2ZW50Lmh0bWwgYi9MYXlvdXRUZXN0cy9zdmcvZG9tL1NWR0Rv Y3VtZW50LWNyZWF0ZUV2ZW50Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNmE5MDJhOGM4Y2NhMjhlOGFhYjg5 NjNmMjI2Y2ZjZWFlZWFjMDgwYwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3N2Zy9k b20vU1ZHRG9jdW1lbnQtY3JlYXRlRXZlbnQuaHRtbApAQCAtMCwwICsxLDE2IEBACis8IURPQ1RZ UEUgaHRtbD4KKzxodG1sPgorPGJvZHk+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pz LXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CitkZXNjcmlwdGlvbigiVGVzdCBTVkdE b2N1bWVudC5jcmVhdGVFdmVudCgpIG9wZXJhdGlvbi4iKTsKKwordmFyIHN2Z0RvY3VtZW50ID0g ZG9jdW1lbnQuaW1wbGVtZW50YXRpb24uY3JlYXRlRG9jdW1lbnQoImh0dHA6Ly93d3cudzMub3Jn LzIwMDAvc3ZnIiwgInN2ZyIpOworc2hvdWxkVGhyb3coInN2Z0RvY3VtZW50LmNyZWF0ZUV2ZW50 KCkiLCAiJ1R5cGVFcnJvcjogTm90IGVub3VnaCBhcmd1bWVudHMnIik7CitzaG91bGROb3RUaHJv dygiZXZlbnQgPSBzdmdEb2N1bWVudC5jcmVhdGVFdmVudCgnbW91c2VldmVudCcpIik7CitzaG91 bGRCZSgiZXZlbnQuX19wcm90b19fIiwgIk1vdXNlRXZlbnQucHJvdG90eXBlIik7CisKKzwvc2Ny aXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2Ny aXB0PgorPC9ib2R5PgorPC9odG1sPgo=