160265 2016-07-27 13:33:39 -0700 Captions do not render in PiP window when element is hidden 2016-08-02 15:00:23 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified REOPENED InRadar P2 Normal --- 160467 160271 1 eric.carlson eric.carlson commit-queue simon.fraser webkit-bug-importer oldest_to_newest 1215004 0 eric.carlson 2016-07-27 13:33:39 -0700 Video from an element with 'visibility:hidden' renders in the PiP window, but captions do not. 1215005 1 eric.carlson 2016-07-27 13:34:01 -0700 <rdar://problem/27556788> 1215008 2 284724 eric.carlson 2016-07-27 13:46:23 -0700 Created attachment 284724 Proposed patch. 1215009 3 webkit-bug-importer 2016-07-27 13:47:07 -0700 <rdar://problem/27575156> 1215042 4 eric.carlson 2016-07-27 14:47:48 -0700 Simon and I talked about how to make this testable. Filed https://bugs.webkit.org/show_bug.cgi?id=160271 for that work. 1215052 5 284724 commit-queue 2016-07-27 15:07:40 -0700 Comment on attachment 284724 Proposed patch. Clearing flags on attachment: 284724 Committed r203799: <http://trac.webkit.org/changeset/203799> 1215053 6 commit-queue 2016-07-27 15:07:45 -0700 All reviewed patches have been landed. Closing bug. 1216613 7 commit-queue 2016-08-02 15:00:23 -0700 Re-opened since this is blocked by bug 160467 284724 2016-07-27 13:46:23 -0700 2016-07-27 15:07:40 -0700 Proposed patch. render_captions_patch.txt text/plain 3534 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMzc4NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE2LTA3LTI3ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIENhcHRpb25zIGRvIG5v dCByZW5kZXIgaW4gUGlQIHdpbmRvdyB3aGVuIGVsZW1lbnQgaXMgaGlkZGVuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjAyNjUKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzI3NTU2Nzg4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6TWVkaWFDb250cm9sVGV4dFRyYWNrQ29udGFpbmVyRWxlbWVudDo6 Y3JlYXRlVGV4dFRyYWNrUmVwcmVzZW50YXRpb25JbWFnZSk6IFBhc3MgbmV3IGZsYWcgc28KKyAg ICAgICAgY2FwdGlvbiBsYXllcnMgYXJlIGFsd2F5cyByZW5kZXJlZC4KKworICAgICAgICAqIHJl bmRlcmluZy9SZW5kZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6 cGFpbnRMYXllckNvbnRlbnRzKTogUGFpbnQgbm9uLXZpc2libGUgbGF5ZXJzIHdoZW4gUGFpbnRM YXllcklnbm9yZVZpc2liaWxpdHkKKyAgICAgICAgZmxhZyBpcyBzZXQuCisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlckxheWVyLmg6IERlZmluZSBQYWludExheWVySWdub3JlVmlzaWJpbGl0eS4K KwogMjAxNi0wNy0yNyAgSmF2aWVyIEZlcm5hbmRleiAgPGpmZXJuYW5kZXpAaWdhbGlhLmNvbT4K IAogICAgICAgICBbY3NzLWdyaWRdIFRoZSBpc1ZhbGlkVHJhbnNpdGlvbiBmdW5jdGlvbiBtdXN0 IG5vdCBhbHRlciB0aGUgR3JpZFNpemluZ0RhdGEgb2JqZWN0CkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwCShyZXZpc2lv biAyMDM3NzIpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xFbGVt ZW50cy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzNzIsNyArMTM3Miw3IEBAIFJlZlB0cjxJbWFn ZT4gTWVkaWFDb250cm9sVGV4dFRyYWNrQ29udGEKICAgICBpZiAoIWJ1ZmZlcikKICAgICAgICAg cmV0dXJuIG51bGxwdHI7CiAKLSAgICBsYXllci0+cGFpbnQoYnVmZmVyLT5jb250ZXh0KCksIHBh aW50aW5nUmVjdCwgTGF5b3V0U2l6ZSgpLCBQYWludEJlaGF2aW9yRmxhdHRlbkNvbXBvc2l0aW5n TGF5ZXJzLCBudWxscHRyLCBSZW5kZXJMYXllcjo6UGFpbnRMYXllclBhaW50aW5nQ29tcG9zaXRp bmdBbGxQaGFzZXMpOworICAgIGxheWVyLT5wYWludChidWZmZXItPmNvbnRleHQoKSwgcGFpbnRp bmdSZWN0LCBMYXlvdXRTaXplKCksIFBhaW50QmVoYXZpb3JGbGF0dGVuQ29tcG9zaXRpbmdMYXll cnMsIG51bGxwdHIsIFJlbmRlckxheWVyOjpQYWludExheWVyUGFpbnRpbmdDb21wb3NpdGluZ0Fs bFBoYXNlcyB8IFJlbmRlckxheWVyOjpQYWludExheWVySWdub3JlVmlzaWJpbGl0eSk7CiAKICAg ICByZXR1cm4gSW1hZ2VCdWZmZXI6OnNpbmtJbnRvSW1hZ2UoV1RGTW92ZShidWZmZXIpKTsKIH0K SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAkocmV2aXNpb24g MjAzNzcyKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtNDI3NCw3ICs0Mjc0LDcgQEAgdm9pZCBSZW5kZXJMYXllcjo6cGFpbnRM YXllckNvbnRlbnRzKEdyYQogICAgIGJvb2wgc2hvdWxkUGFpbnRPdXRsaW5lID0gaXNTZWxmUGFp bnRpbmdMYXllciAmJiAhaXNQYWludGluZ092ZXJsYXlTY3JvbGxiYXJzCiAgICAgICAgICYmICgo aXNQYWludGluZ1Njcm9sbGluZ0NvbnRlbnQgJiYgaXNQYWludGluZ0NvbXBvc2l0ZWRCYWNrZ3Jv dW5kKQogICAgICAgICB8fCAoIWlzUGFpbnRpbmdTY3JvbGxpbmdDb250ZW50ICYmIGlzUGFpbnRp bmdDb21wb3NpdGVkRm9yZWdyb3VuZCkpOwotICAgIGJvb2wgc2hvdWxkUGFpbnRDb250ZW50ID0g bV9oYXNWaXNpYmxlQ29udGVudCAmJiBpc1NlbGZQYWludGluZ0xheWVyICYmICFpc1BhaW50aW5n T3ZlcmxheVNjcm9sbGJhcnM7CisgICAgYm9vbCBzaG91bGRQYWludENvbnRlbnQgPSAobV9oYXNW aXNpYmxlQ29udGVudCB8fCBwYWludEZsYWdzICYgUGFpbnRMYXllcklnbm9yZVZpc2liaWxpdHkp ICYmIGlzU2VsZlBhaW50aW5nTGF5ZXIgJiYgIWlzUGFpbnRpbmdPdmVybGF5U2Nyb2xsYmFyczsK IAogICAgIGlmIChsb2NhbFBhaW50RmxhZ3MgJiBQYWludExheWVyUGFpbnRpbmdSb290QmFja2dy b3VuZE9ubHkgJiYgIXJlbmRlcmVyKCkuaXNSZW5kZXJWaWV3KCkgJiYgIXJlbmRlcmVyKCkuaXNE b2N1bWVudEVsZW1lbnRSZW5kZXJlcigpKQogICAgICAgICByZXR1cm47CkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuaAkocmV2aXNpb24gMjAzNzcyKQorKysgU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ1Nyw2 ICs0NTcsNyBAQCBwdWJsaWM6CiAgICAgICAgIFBhaW50TGF5ZXJQYWludGluZ1Jvb3RCYWNrZ3Jv dW5kT25seSAgICAgICAgICAgID0gMSA8PCAxMSwKICAgICAgICAgUGFpbnRMYXllclBhaW50aW5n U2tpcFJvb3RCYWNrZ3JvdW5kICAgICAgICAgICAgPSAxIDw8IDEyLAogICAgICAgICBQYWludExh eWVyUGFpbnRpbmdDaGlsZENsaXBwaW5nTWFza1BoYXNlICAgICAgICA9IDEgPDwgMTMsCisgICAg ICAgIFBhaW50TGF5ZXJJZ25vcmVWaXNpYmlsaXR5ICAgICAgICAgICAgICAgICAgICAgID0gMSA8 PCAxNCwKICAgICAgICAgUGFpbnRMYXllclBhaW50aW5nQ29tcG9zaXRpbmdBbGxQaGFzZXMgICAg ICAgICAgPSBQYWludExheWVyUGFpbnRpbmdDb21wb3NpdGluZ0JhY2tncm91bmRQaGFzZSB8IFBh aW50TGF5ZXJQYWludGluZ0NvbXBvc2l0aW5nRm9yZWdyb3VuZFBoYXNlCiAgICAgfTsKICAgICAK