160228 2016-07-26 17:46:13 -0700 [JSC] Fix a bunch of use-after-free of DFG::Node 2016-07-28 09:24:18 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 160098 1 benjamin benjamin commit-queue ddkilzer keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1214775 0 benjamin 2016-07-26 17:46:13 -0700 [JSC] Fix a bunch of use-after-free of DFG::Node 1214777 1 284659 benjamin 2016-07-26 17:57:45 -0700 Created attachment 284659 Patch 1214778 2 284660 benjamin 2016-07-26 18:14:16 -0700 Created attachment 284660 Patch 1214782 3 284660 benjamin 2016-07-26 18:46:41 -0700 Comment on attachment 284660 Patch Before you ask: yep, that pisses me off *A LOT* to add yet another run of liveness+interpreter :( 1214904 4 284660 mark.lam 2016-07-27 08:33:05 -0700 Comment on attachment 284660 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284660&action=review LGTM > Source/JavaScriptCore/ChangeLog:27 > + Just invalidation. Nothing wrong here since the useless nodes where > + kept live while iterating the blocks. typo: /where kept/were kept/. 1215082 5 benjamin 2016-07-27 16:24:08 -0700 Committed r203802: <http://trac.webkit.org/changeset/203802> 1215241 6 webkit-bug-importer 2016-07-28 09:24:18 -0700 <rdar://problem/27590480> 284659 2016-07-26 17:57:45 -0700 2016-07-26 18:14:14 -0700 Patch bug-160228-20160726175636.patch text/plain 7967 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzNzAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 ZDkzYWQyN2JlNzcyNWYzMzc2ODBlMjJlNTU0YTViM2E3MWE5ZmQxLi44YmIzZWJkMjNmNjViNmRi NzdiMzgzOGY0MTU1OWRhYmViOGM3YjQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSw0MiBAQAorMjAxNi0wNy0yNiAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBbSlNDXSBGaXggYSBidW5jaCBvZiB1c2UtYWZ0ZXItZnJlZSBvZiBE Rkc6Ok5vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE2MDIyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEZUTCBoYWQgYSBmZXcgcGxhY2VzIHdoZXJlIHdlIHVzZSBhIG5vZGUgYWZ0ZXIgaXQgaGFzIGJl ZW4KKyAgICAgICAgZGVsZXRlZC4gVGhlIGRhbmdsaW5nIHBvaW50ZXJzIGNvbWUgZnJvbSB0aGUg U1NBIGxpdmVuZXNzIGluZm9ybWF0aW9uCisgICAgICAgIGtlcHQgb24gdGhlIGJhc2ljIGJsb2Nr cy4KKworICAgICAgICBUaGlzIHBhdGNoIGZpeGVzIHRoZSBpc3N1ZXMgSSBjb3VsZCBmaW5kIGFu ZCBhZGRzIGxpdmVuZXNzIGludmFsaWRhdGlvbgorICAgICAgICB0byBoZWxwIGZpbmRpbmcgZGVw ZW5kZW5jaWVzIGxpa2UgdGhlc2UuCisKKyAgICAgICAgKiBkZmcvREZHQmFzaWNCbG9jay5oOgor ICAgICAgICAoSlNDOjpERkc6OkJhc2ljQmxvY2s6OlNTQURhdGE6OmludmFsaWRhdGUpOgorCisg ICAgICAgICogZGZnL0RGR0NvbnN0YW50Rm9sZGluZ1BoYXNlLmNwcDoKKyAgICAgICAgKEpTQzo6 REZHOjpDb25zdGFudEZvbGRpbmdQaGFzZTo6cnVuKToKKyAgICAgICAgQ29uc3RhbnQgZm9sZGlu ZyBwaGFzZSB3YXMgZGVsZXRpbmcgbm9kZXMgaW4gdGhlIGxvb3Agb3ZlciBiYXNpYyBibG9ja3Mu CisgICAgICAgIFRoZSBwcm9ibGVtIGlzIHRoZSBkZWxldGVkIG5vZGVzIGNhbiBiZSByZWZlcmVu Y2VkIGJ5IG90aGVyIGJsb2Nrcy4KKyAgICAgICAgV2hlbiB0aGUgYWJzdHJhY3QgaW50ZXJwcmV0 ZXIgd2FzIG1hbmlwdWxhdGluZyB0aGUgYWJzdHJhY3QgdmFsdWVzIG9mIHRob3NlCisgICAgICAg IGl0IHdhcyBkb2luZyBzbyBvbiB0aGUgZGVhZCBub2Rlcy4KKworICAgICAgICAqIGRmZy9ERkdD b25zdGFudEhvaXN0aW5nUGhhc2UuY3BwOgorICAgICAgICBKdXN0IGludmFsaWRhdGlvbi4gTm90 aGluZyB3cm9uZyBoZXJlIHNpbmNlIHRoZSB1c2VsZXNzIG5vZGVzIHdoZXJlCisgICAgICAgIGtl cHQgbGl2ZSB3aGlsZSBpdGVyYXRpbmcgdGhlIGJsb2Nrcy4KKworICAgICAgICAqIGRmZy9ERkdH cmFwaC5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6R3JhcGg6OmtpbGxCbG9ja0FuZEl0c0NvbnRl bnRzKToKKyAgICAgICAgKEpTQzo6REZHOjpHcmFwaDo6a2lsbFVucmVhY2hhYmxlQmxvY2tzKToK KyAgICAgICAgKEpTQzo6REZHOjpHcmFwaDo6aW52YWxpZGF0ZU5vZGVMaXZlbmVzcyk6CisKKyAg ICAgICAgKiBkZmcvREZHR3JhcGguaDoKKyAgICAgICAgKiBkZmcvREZHUGxhbi5jcHA6CisgICAg ICAgIChKU0M6OkRGRzo6UGxhbjo6Y29tcGlsZUluVGhyZWFkSW1wbCk6CisgICAgICAgIFdlIGhh ZCBhIGxvdCBvZiB1c2UtYWZ0ZXItZnJlZSBpbiBMQ0lNIGJlY2F1c2Ugd2Ugd2VyZSB1c2luZyB0 aGUgc3RhbGUKKyAgICAgICAgbGl2ZSBub2RlcyBkZWxldGVkIGJ5IHByZXZpb3VzIHBoYXNlcy4K KwogMjAxNi0wNy0yNSAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KIAog ICAgICAgICBbSlNDXSBERkc6Ok5vZGUgc2hvdWxkIG5vdCBoYXZlIGl0cyBvd24gYWxsb2NhdG9y CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Jhc2ljQmxvY2suaCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQmFzaWNCbG9jay5oCmluZGV4IDA0ZWRjZTgz MjhmMzc4ZDM4MTFkMjJkOTIxNDkyMTFlMGM5YWVjOTIuLjkzMWRhZWY0Y2QzODg4ODNiNDE5OTgz YTU2ODlhM2VjMTAzYzg0Y2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHQmFzaWNCbG9jay5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQmFzaWNC bG9jay5oCkBAIC0yMzksNiArMjM5LDE0IEBAIHN0cnVjdCBCYXNpY0Jsb2NrIDogUmVmQ291bnRl ZDxCYXNpY0Jsb2NrPiB7CiAgICAgc3RydWN0IFNTQURhdGEgewogICAgICAgICBXVEZfTUFLRV9G QVNUX0FMTE9DQVRFRDsKICAgICBwdWJsaWM6CisgICAgICAgIHZvaWQgaW52YWxpZGF0ZSgpCisg ICAgICAgIHsKKyAgICAgICAgICAgIGxpdmVBdFRhaWwuY2xlYXIoKTsKKyAgICAgICAgICAgIGxp dmVBdEhlYWQuY2xlYXIoKTsKKyAgICAgICAgICAgIHZhbHVlc0F0SGVhZC5jbGVhcigpOworICAg ICAgICAgICAgdmFsdWVzQXRUYWlsLmNsZWFyKCk7CisgICAgICAgIH0KKwogICAgICAgICBBdmFp bGFiaWxpdHlNYXAgYXZhaWxhYmlsaXR5QXRIZWFkOwogICAgICAgICBBdmFpbGFiaWxpdHlNYXAg YXZhaWxhYmlsaXR5QXRUYWlsOwogICAgICAgICAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHQ29uc3RhbnRGb2xkaW5nUGhhc2UuY3BwIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdDb25zdGFudEZvbGRpbmdQaGFzZS5jcHAKaW5kZXggNDk1YTA2NDk1Mzgy MzdhZmEzODNiMmY3MWUyZTgwN2ViNTE2M2IxMS4uOTM5MGFkZjY4MTU1YjRkYWYyM2RlZjAyYWJl ZTFiZTNhZmMwODVlNiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdD b25zdGFudEZvbGRpbmdQaGFzZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdDb25zdGFudEZvbGRpbmdQaGFzZS5jcHAKQEAgLTcxLDYgKzcxLDcgQEAgcHVibGljOgogICAg ICAgICAgICAgLy8gSXQncyBub3cgcG9zc2libGUgdG8gc2ltcGxpZnkgYmFzaWMgYmxvY2tzIGJ5 IHBsYWNpbmcgYW4gVW5yZWFjaGFibGUgdGVybWluYXRvciByaWdodAogICAgICAgICAgICAgLy8g YWZ0ZXIgYW55dGhpbmcgdGhhdCBpbnZhbGlkYXRlcyBBSS4KICAgICAgICAgICAgIGJvb2wgZGlk Q2xpcEJsb2NrID0gZmFsc2U7CisgICAgICAgICAgICBWZWN0b3I8Tm9kZSo+IG5vZGVzVG9EZWxl dGU7CiAgICAgICAgICAgICBmb3IgKEJhc2ljQmxvY2sqIGJsb2NrIDogbV9ncmFwaC5ibG9ja3NJ bk5hdHVyYWxPcmRlcigpKSB7CiAgICAgICAgICAgICAgICAgbV9zdGF0ZS5iZWdpbkJhc2ljQmxv Y2soYmxvY2spOwogICAgICAgICAgICAgICAgIGZvciAodW5zaWduZWQgbm9kZUluZGV4ID0gMDsg bm9kZUluZGV4IDwgYmxvY2stPnNpemUoKTsgKytub2RlSW5kZXgpIHsKQEAgLTgzLDcgKzg0LDcg QEAgcHVibGljOgogICAgICAgICAgICAgICAgICAgICBpZiAoIW1fc3RhdGUuaXNWYWxpZCgpKSB7 CiAgICAgICAgICAgICAgICAgICAgICAgICBOb2RlT3JpZ2luIG9yaWdpbiA9IGJsb2NrLT5hdChu b2RlSW5kZXgpLT5vcmlnaW47CiAgICAgICAgICAgICAgICAgICAgICAgICBmb3IgKHVuc2lnbmVk IGtpbGxJbmRleCA9IG5vZGVJbmRleDsga2lsbEluZGV4IDwgYmxvY2stPnNpemUoKTsgKytraWxs SW5kZXgpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgbV9ncmFwaC5kZWxldGVOb2RlKGJs b2NrLT5hdChraWxsSW5kZXgpKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBub2Rlc1Rv RGVsZXRlLmFwcGVuZChibG9jay0+YXQoa2lsbEluZGV4KSk7CiAgICAgICAgICAgICAgICAgICAg ICAgICBibG9jay0+cmVzaXplKG5vZGVJbmRleCk7CiAgICAgICAgICAgICAgICAgICAgICAgICBi bG9jay0+YXBwZW5kTm9kZShtX2dyYXBoLCBTcGVjTm9uZSwgVW5yZWFjaGFibGUsIG9yaWdpbik7 CiAgICAgICAgICAgICAgICAgICAgICAgICBkaWRDbGlwQmxvY2sgPSB0cnVlOwpAQCAtOTYsNiAr OTcsMTIgQEAgcHVibGljOgogCiAgICAgICAgICAgICBpZiAoZGlkQ2xpcEJsb2NrKSB7CiAgICAg ICAgICAgICAgICAgY2hhbmdlZCA9IHRydWU7CisKKyAgICAgICAgICAgICAgICBtX2dyYXBoLmlu dmFsaWRhdGVOb2RlTGl2ZW5lc3MoKTsKKworICAgICAgICAgICAgICAgIGZvciAoTm9kZSogbm9k ZSA6IG5vZGVzVG9EZWxldGUpCisgICAgICAgICAgICAgICAgICAgIG1fZ3JhcGgubV9hbGxvY2F0 b3IuZnJlZShub2RlKTsKKwogICAgICAgICAgICAgICAgIG1fZ3JhcGguaW52YWxpZGF0ZUNGRygp OwogICAgICAgICAgICAgICAgIG1fZ3JhcGgucmVzZXRSZWFjaGFiaWxpdHkoKTsKICAgICAgICAg ICAgICAgICBtX2dyYXBoLmtpbGxVbnJlYWNoYWJsZUJsb2NrcygpOwpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDb25zdGFudEhvaXN0aW5nUGhhc2UuY3BwIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDb25zdGFudEhvaXN0aW5nUGhhc2UuY3BwCmluZGV4 IDdiNDkxYzI5NmRlNWYxNDljM2RmNTQwNWMxODA5M2ZiZjBmMmQ3NDQuLjhhNDViMzRiZWEyZmQw ZDE1YTgxNGI4ZWY5NDc5ZDMyNmY3NGZjMWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHQ29uc3RhbnRIb2lzdGluZ1BoYXNlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR0NvbnN0YW50SG9pc3RpbmdQaGFzZS5jcHAKQEAgLTEyOCw2ICsxMjgs NyBAQCBwdWJsaWM6CiAgICAgICAgIH0KICAgICAgICAgCiAgICAgICAgIC8vIEFuZCBmaW5hbGx5 IGZyZWUgdGhlIGNvbnN0YW50cyB0aGF0IHdlIHJlbW92ZWQuCisgICAgICAgIG1fZ3JhcGguaW52 YWxpZGF0ZU5vZGVMaXZlbmVzcygpOwogICAgICAgICBmb3IgKE5vZGUqIG5vZGUgOiB0b0ZyZWUp CiAgICAgICAgICAgICBtX2dyYXBoLmRlbGV0ZU5vZGUobm9kZSk7CiAgICAgICAgIApkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR0dyYXBoLmNwcAppbmRleCA5YjJjYzkwNDJmZTkxMTc3MDBjYjJi Mjg3ZGExZTFiYTAzODA3NTI2Li5hYWEyYTljMTFkYTdhNzRhZWJmZTUzMDExZmY4MzRjNjg1MTJm ODAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0dyYXBoLmNwcAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0dyYXBoLmNwcApAQCAtNzM3LDYgKzcz Nyw4IEBAIHZvaWQgR3JhcGg6OmNvbXB1dGVSZWZDb3VudHMoKQogCiB2b2lkIEdyYXBoOjpraWxs QmxvY2tBbmRJdHNDb250ZW50cyhCYXNpY0Jsb2NrKiBibG9jaykKIHsKKyAgICBpZiAoYXV0byYg c3NhRGF0YSA9IGJsb2NrLT5zc2EpCisgICAgICAgIHNzYURhdGEtPmludmFsaWRhdGUoKTsKICAg ICBmb3IgKHVuc2lnbmVkIHBoaUluZGV4ID0gYmxvY2stPnBoaXMuc2l6ZSgpOyBwaGlJbmRleC0t OykKICAgICAgICAgZGVsZXRlTm9kZShibG9jay0+cGhpc1twaGlJbmRleF0pOwogICAgIGZvciAo Tm9kZSogbm9kZSA6ICpibG9jaykKQEAgLTc0Nyw5ICs3NDksOCBAQCB2b2lkIEdyYXBoOjpraWxs QmxvY2tBbmRJdHNDb250ZW50cyhCYXNpY0Jsb2NrKiBibG9jaykKIAogdm9pZCBHcmFwaDo6a2ls bFVucmVhY2hhYmxlQmxvY2tzKCkKIHsKLSAgICAvLyBGSVhNRTogVGhpcyBwcm9iYWJseSBjcmVh dGVzIGRhbmdsaW5nIHJlZmVyZW5jZXMgZnJvbSBVcHNpbG9ucyB0byBQaGlzIGluIFNTQS4KLSAg ICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5MTY0Ci0gICAg CisgICAgaW52YWxpZGF0ZU5vZGVMaXZlbmVzcygpOworCiAgICAgZm9yIChCbG9ja0luZGV4IGJs b2NrSW5kZXggPSAwOyBibG9ja0luZGV4IDwgbnVtQmxvY2tzKCk7ICsrYmxvY2tJbmRleCkgewog ICAgICAgICBCYXNpY0Jsb2NrKiBibG9jayA9IHRoaXMtPmJsb2NrKGJsb2NrSW5kZXgpOwogICAg ICAgICBpZiAoIWJsb2NrKQpAQCAtNzcxLDYgKzc3MiwxNSBAQCB2b2lkIEdyYXBoOjppbnZhbGlk YXRlQ0ZHKCkKICAgICBtX2JhY2t3YXJkc0NGRyA9IG51bGxwdHI7CiB9CiAKK3ZvaWQgR3JhcGg6 OmludmFsaWRhdGVOb2RlTGl2ZW5lc3MoKQoreworICAgIGlmIChtX2Zvcm0gIT0gU1NBKQorICAg ICAgICByZXR1cm47CisKKyAgICBmb3IgKEJhc2ljQmxvY2sqIGJsb2NrIDogYmxvY2tzSW5OYXR1 cmFsT3JkZXIoKSkKKyAgICAgICAgYmxvY2stPnNzYS0+aW52YWxpZGF0ZSgpOworfQorCiB2b2lk IEdyYXBoOjpzdWJzdGl0dXRlR2V0TG9jYWwoQmFzaWNCbG9jayYgYmxvY2ssIHVuc2lnbmVkIHN0 YXJ0SW5kZXhJbkJsb2NrLCBWYXJpYWJsZUFjY2Vzc0RhdGEqIHZhcmlhYmxlQWNjZXNzRGF0YSwg Tm9kZSogbmV3R2V0TG9jYWwpCiB7CiAgICAgZm9yICh1bnNpZ25lZCBpbmRleEluQmxvY2sgPSBz dGFydEluZGV4SW5CbG9jazsgaW5kZXhJbkJsb2NrIDwgYmxvY2suc2l6ZSgpOyArK2luZGV4SW5C bG9jaykgewpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5o IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5oCmluZGV4IDJhOGEzYjYwYWJk NWFmNjQyYjY0ZTgxZWFmMGI1MzJmNGM5MmVlY2QuLjk2YjQ3ZDE5NzA5YzViYmE2NzgyMzljNzMw NDM5Njk3NGZlMTQwMmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH R3JhcGguaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0dyYXBoLmgKQEAgLTU0 MCw2ICs1NDAsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBzdWJzdGl0dXRlR2V0TG9jYWwoQmFzaWNC bG9jayYgYmxvY2ssIHVuc2lnbmVkIHN0YXJ0SW5kZXhJbkJsb2NrLCBWYXJpYWJsZUFjY2Vzc0Rh dGEqIHZhcmlhYmxlQWNjZXNzRGF0YSwgTm9kZSogbmV3R2V0TG9jYWwpOwogICAgIAogICAgIHZv aWQgaW52YWxpZGF0ZUNGRygpOworICAgIHZvaWQgaW52YWxpZGF0ZU5vZGVMaXZlbmVzcygpOwog ICAgIAogICAgIHZvaWQgY2xlYXJGbGFnc09uQWxsTm9kZXMoTm9kZUZsYWdzKTsKICAgICAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHUGxhbi5jcHAgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR1BsYW4uY3BwCmluZGV4IDI1MTU1NGIyYWY3YTM4Yzk1M2Ew MzJiZWZhM2QyY2U3MDY5ZDM2NzUuLmI0Zjg2M2E2Njg0MGRhYzRkNDVkNTZiYjJlMjJiNjU3Mjhk NDBjMTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHUGxhbi5jcHAK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQbGFuLmNwcApAQCAtNDI4LDYgKzQy OCw4IEBAIFBsYW46OkNvbXBpbGF0aW9uUGF0aCBQbGFuOjpjb21waWxlSW5UaHJlYWRJbXBsKCkK ICAgICAgICAgLy8gd3Jvbmcgd2l0aCBydW5uaW5nIExJQ00gZWFybGllciwgaWYgd2Ugd2FudGVk IHRvIHB1dCBvdGhlciBDRkcgdHJhbnNmb3JtcyBhYm92ZSB0aGlzIHBvaW50LgogICAgICAgICAv LyBBbHRlcm5hdGl2ZWx5LCB3ZSBjb3VsZCBydW4gbG9vcCBwcmUtaGVhZGVyIGNyZWF0aW9uIGFm dGVyIFNTQSBjb252ZXJzaW9uIC0gYnV0IGlmIHdlIGRpZCB0aGF0CiAgICAgICAgIC8vIHRoZW4g d2UnZCBuZWVkIHRvIGRvIHNvbWUgc2ltcGxlIFNTQSBmaXgtdXAuCisgICAgICAgIHBlcmZvcm1M aXZlbmVzc0FuYWx5c2lzKGRmZyk7CisgICAgICAgIHBlcmZvcm1DRkEoZGZnKTsKICAgICAgICAg cGVyZm9ybUxJQ00oZGZnKTsKIAogICAgICAgICAvLyBGSVhNRTogQ3VycmVudGx5OiBJbnRlZ2Vy UmFuZ2VPcHRpbWl6YXRpb24gKm11c3QqIGJlIHJ1biBhZnRlciBMSUNNLgo= 284660 2016-07-26 18:14:16 -0700 2016-07-27 08:33:05 -0700 Patch bug-160228-20160726181307.patch text/plain 7639 benjamin SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAzNzU3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDQyIEBA CisyMDE2LTA3LTI2ICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisg ICAgICAgIFtKU0NdIEZpeCBhIGJ1bmNoIG9mIHVzZS1hZnRlci1mcmVlIG9mIERGRzo6Tm9kZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwMjI4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRlRMIGhhZCBh IGZldyBwbGFjZXMgd2hlcmUgd2UgdXNlIGEgbm9kZSBhZnRlciBpdCBoYXMgYmVlbgorICAgICAg ICBkZWxldGVkLiBUaGUgZGFuZ2xpbmcgcG9pbnRlcnMgY29tZSBmcm9tIHRoZSBTU0EgbGl2ZW5l c3MgaW5mb3JtYXRpb24KKyAgICAgICAga2VwdCBvbiB0aGUgYmFzaWMgYmxvY2tzLgorCisgICAg ICAgIFRoaXMgcGF0Y2ggZml4ZXMgdGhlIGlzc3VlcyBJIGNvdWxkIGZpbmQgYW5kIGFkZHMgbGl2 ZW5lc3MgaW52YWxpZGF0aW9uCisgICAgICAgIHRvIGhlbHAgZmluZGluZyBkZXBlbmRlbmNpZXMg bGlrZSB0aGVzZS4KKworICAgICAgICAqIGRmZy9ERkdCYXNpY0Jsb2NrLmg6CisgICAgICAgIChK U0M6OkRGRzo6QmFzaWNCbG9jazo6U1NBRGF0YTo6aW52YWxpZGF0ZSk6CisKKyAgICAgICAgKiBk ZmcvREZHQ29uc3RhbnRGb2xkaW5nUGhhc2UuY3BwOgorICAgICAgICAoSlNDOjpERkc6OkNvbnN0 YW50Rm9sZGluZ1BoYXNlOjpydW4pOgorICAgICAgICBDb25zdGFudCBmb2xkaW5nIHBoYXNlIHdh cyBkZWxldGluZyBub2RlcyBpbiB0aGUgbG9vcCBvdmVyIGJhc2ljIGJsb2Nrcy4KKyAgICAgICAg VGhlIHByb2JsZW0gaXMgdGhlIGRlbGV0ZWQgbm9kZXMgY2FuIGJlIHJlZmVyZW5jZWQgYnkgb3Ro ZXIgYmxvY2tzLgorICAgICAgICBXaGVuIHRoZSBhYnN0cmFjdCBpbnRlcnByZXRlciB3YXMgbWFu aXB1bGF0aW5nIHRoZSBhYnN0cmFjdCB2YWx1ZXMgb2YgdGhvc2UKKyAgICAgICAgaXQgd2FzIGRv aW5nIHNvIG9uIHRoZSBkZWFkIG5vZGVzLgorCisgICAgICAgICogZGZnL0RGR0NvbnN0YW50SG9p c3RpbmdQaGFzZS5jcHA6CisgICAgICAgIEp1c3QgaW52YWxpZGF0aW9uLiBOb3RoaW5nIHdyb25n IGhlcmUgc2luY2UgdGhlIHVzZWxlc3Mgbm9kZXMgd2hlcmUKKyAgICAgICAga2VwdCBsaXZlIHdo aWxlIGl0ZXJhdGluZyB0aGUgYmxvY2tzLgorCisgICAgICAgICogZGZnL0RGR0dyYXBoLmNwcDoK KyAgICAgICAgKEpTQzo6REZHOjpHcmFwaDo6a2lsbEJsb2NrQW5kSXRzQ29udGVudHMpOgorICAg ICAgICAoSlNDOjpERkc6OkdyYXBoOjpraWxsVW5yZWFjaGFibGVCbG9ja3MpOgorICAgICAgICAo SlNDOjpERkc6OkdyYXBoOjppbnZhbGlkYXRlTm9kZUxpdmVuZXNzKToKKworICAgICAgICAqIGRm Zy9ERkdHcmFwaC5oOgorICAgICAgICAqIGRmZy9ERkdQbGFuLmNwcDoKKyAgICAgICAgKEpTQzo6 REZHOjpQbGFuOjpjb21waWxlSW5UaHJlYWRJbXBsKToKKyAgICAgICAgV2UgaGFkIGEgbG90IG9m IHVzZS1hZnRlci1mcmVlIGluIExDSU0gYmVjYXVzZSB3ZSB3ZXJlIHVzaW5nIHRoZSBzdGFsZQor ICAgICAgICBsaXZlIG5vZGVzIGRlbGV0ZWQgYnkgcHJldmlvdXMgcGhhc2VzLgorCiAyMDE2LTA3 LTI2ICBDYWl0bGluIFBvdHRlciAgPGNhaXRwQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0pTQ10g T2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcnMgc2hvdWxkIG5vdCBhZGQgdW5kZWZpbmVk IHByb3BzIHRvIHJlc3VsdApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCYXNp Y0Jsb2NrLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCYXNp Y0Jsb2NrLmgJKHJldmlzaW9uIDIwMzc1NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHQmFzaWNCbG9jay5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMzksNiArMjM5LDE0IEBAIHN0cnVj dCBCYXNpY0Jsb2NrIDogUmVmQ291bnRlZDxCYXNpY0Jsb2MKICAgICBzdHJ1Y3QgU1NBRGF0YSB7 CiAgICAgICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogICAgIHB1YmxpYzoKKyAgICAgICAg dm9pZCBpbnZhbGlkYXRlKCkKKyAgICAgICAgeworICAgICAgICAgICAgbGl2ZUF0VGFpbC5jbGVh cigpOworICAgICAgICAgICAgbGl2ZUF0SGVhZC5jbGVhcigpOworICAgICAgICAgICAgdmFsdWVz QXRIZWFkLmNsZWFyKCk7CisgICAgICAgICAgICB2YWx1ZXNBdFRhaWwuY2xlYXIoKTsKKyAgICAg ICAgfQorCiAgICAgICAgIEF2YWlsYWJpbGl0eU1hcCBhdmFpbGFiaWxpdHlBdEhlYWQ7CiAgICAg ICAgIEF2YWlsYWJpbGl0eU1hcCBhdmFpbGFiaWxpdHlBdFRhaWw7CiAgICAgICAgIApJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDb25zdGFudEZvbGRpbmdQaGFzZS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDb25zdGFudEZvbGRpbmdQ aGFzZS5jcHAJKHJldmlzaW9uIDIwMzc1NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHQ29uc3RhbnRGb2xkaW5nUGhhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MSw2ICs3MSw3 IEBAIHB1YmxpYzoKICAgICAgICAgICAgIC8vIEl0J3Mgbm93IHBvc3NpYmxlIHRvIHNpbXBsaWZ5 IGJhc2ljIGJsb2NrcyBieSBwbGFjaW5nIGFuIFVucmVhY2hhYmxlIHRlcm1pbmF0b3IgcmlnaHQK ICAgICAgICAgICAgIC8vIGFmdGVyIGFueXRoaW5nIHRoYXQgaW52YWxpZGF0ZXMgQUkuCiAgICAg ICAgICAgICBib29sIGRpZENsaXBCbG9jayA9IGZhbHNlOworICAgICAgICAgICAgVmVjdG9yPE5v ZGUqPiBub2Rlc1RvRGVsZXRlOwogICAgICAgICAgICAgZm9yIChCYXNpY0Jsb2NrKiBibG9jayA6 IG1fZ3JhcGguYmxvY2tzSW5OYXR1cmFsT3JkZXIoKSkgewogICAgICAgICAgICAgICAgIG1fc3Rh dGUuYmVnaW5CYXNpY0Jsb2NrKGJsb2NrKTsKICAgICAgICAgICAgICAgICBmb3IgKHVuc2lnbmVk IG5vZGVJbmRleCA9IDA7IG5vZGVJbmRleCA8IGJsb2NrLT5zaXplKCk7ICsrbm9kZUluZGV4KSB7 CkBAIC04Myw3ICs4NCw3IEBAIHB1YmxpYzoKICAgICAgICAgICAgICAgICAgICAgaWYgKCFtX3N0 YXRlLmlzVmFsaWQoKSkgewogICAgICAgICAgICAgICAgICAgICAgICAgTm9kZU9yaWdpbiBvcmln aW4gPSBibG9jay0+YXQobm9kZUluZGV4KS0+b3JpZ2luOwogICAgICAgICAgICAgICAgICAgICAg ICAgZm9yICh1bnNpZ25lZCBraWxsSW5kZXggPSBub2RlSW5kZXg7IGtpbGxJbmRleCA8IGJsb2Nr LT5zaXplKCk7ICsra2lsbEluZGV4KQotICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1fZ3Jh cGgubV9hbGxvY2F0b3IuZnJlZShibG9jay0+YXQoa2lsbEluZGV4KSk7CisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgbm9kZXNUb0RlbGV0ZS5hcHBlbmQoYmxvY2stPmF0KGtpbGxJbmRleCkp OwogICAgICAgICAgICAgICAgICAgICAgICAgYmxvY2stPnJlc2l6ZShub2RlSW5kZXgpOwogICAg ICAgICAgICAgICAgICAgICAgICAgYmxvY2stPmFwcGVuZE5vZGUobV9ncmFwaCwgU3BlY05vbmUs IFVucmVhY2hhYmxlLCBvcmlnaW4pOwogICAgICAgICAgICAgICAgICAgICAgICAgZGlkQ2xpcEJs b2NrID0gdHJ1ZTsKQEAgLTk2LDYgKzk3LDEyIEBAIHB1YmxpYzoKIAogICAgICAgICAgICAgaWYg KGRpZENsaXBCbG9jaykgewogICAgICAgICAgICAgICAgIGNoYW5nZWQgPSB0cnVlOworCisgICAg ICAgICAgICAgICAgbV9ncmFwaC5pbnZhbGlkYXRlTm9kZUxpdmVuZXNzKCk7CisKKyAgICAgICAg ICAgICAgICBmb3IgKE5vZGUqIG5vZGUgOiBub2Rlc1RvRGVsZXRlKQorICAgICAgICAgICAgICAg ICAgICBtX2dyYXBoLm1fYWxsb2NhdG9yLmZyZWUobm9kZSk7CisKICAgICAgICAgICAgICAgICBt X2dyYXBoLmludmFsaWRhdGVDRkcoKTsKICAgICAgICAgICAgICAgICBtX2dyYXBoLnJlc2V0UmVh Y2hhYmlsaXR5KCk7CiAgICAgICAgICAgICAgICAgbV9ncmFwaC5raWxsVW5yZWFjaGFibGVCbG9j a3MoKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ29uc3RhbnRIb2lzdGlu Z1BoYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Nv bnN0YW50SG9pc3RpbmdQaGFzZS5jcHAJKHJldmlzaW9uIDIwMzc1NykKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHQ29uc3RhbnRIb2lzdGluZ1BoYXNlLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMTI4LDYgKzEyOCw3IEBAIHB1YmxpYzoKICAgICAgICAgfQogICAgICAgICAKICAgICAg ICAgLy8gQW5kIGZpbmFsbHkgZnJlZSB0aGUgY29uc3RhbnRzIHRoYXQgd2UgcmVtb3ZlZC4KKyAg ICAgICAgbV9ncmFwaC5pbnZhbGlkYXRlTm9kZUxpdmVuZXNzKCk7CiAgICAgICAgIGZvciAoTm9k ZSogbm9kZSA6IHRvRnJlZSkKICAgICAgICAgICAgIG1fZ3JhcGgubV9hbGxvY2F0b3IuZnJlZShu b2RlKTsKICAgICAgICAgCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0dyYXBo LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0dyYXBoLmNw cAkocmV2aXNpb24gMjAzNzU3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFw aC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc0NCw2ICs3NDQsOCBAQCB2b2lkIEdyYXBoOjpjb21w dXRlUmVmQ291bnRzKCkKIAogdm9pZCBHcmFwaDo6a2lsbEJsb2NrQW5kSXRzQ29udGVudHMoQmFz aWNCbG9jayogYmxvY2spCiB7CisgICAgaWYgKGF1dG8mIHNzYURhdGEgPSBibG9jay0+c3NhKQor ICAgICAgICBzc2FEYXRhLT5pbnZhbGlkYXRlKCk7CiAgICAgZm9yICh1bnNpZ25lZCBwaGlJbmRl eCA9IGJsb2NrLT5waGlzLnNpemUoKTsgcGhpSW5kZXgtLTspCiAgICAgICAgIG1fYWxsb2NhdG9y LmZyZWUoYmxvY2stPnBoaXNbcGhpSW5kZXhdKTsKICAgICBmb3IgKHVuc2lnbmVkIG5vZGVJbmRl eCA9IGJsb2NrLT5zaXplKCk7IG5vZGVJbmRleC0tOykKQEAgLTc1NCw5ICs3NTYsOCBAQCB2b2lk IEdyYXBoOjpraWxsQmxvY2tBbmRJdHNDb250ZW50cyhCYXNpCiAKIHZvaWQgR3JhcGg6OmtpbGxV bnJlYWNoYWJsZUJsb2NrcygpCiB7Ci0gICAgLy8gRklYTUU6IFRoaXMgcHJvYmFibHkgY3JlYXRl cyBkYW5nbGluZyByZWZlcmVuY2VzIGZyb20gVXBzaWxvbnMgdG8gUGhpcyBpbiBTU0EuCi0gICAg Ly8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTE2NAotICAgIAor ICAgIGludmFsaWRhdGVOb2RlTGl2ZW5lc3MoKTsKKwogICAgIGZvciAoQmxvY2tJbmRleCBibG9j a0luZGV4ID0gMDsgYmxvY2tJbmRleCA8IG51bUJsb2NrcygpOyArK2Jsb2NrSW5kZXgpIHsKICAg ICAgICAgQmFzaWNCbG9jayogYmxvY2sgPSB0aGlzLT5ibG9jayhibG9ja0luZGV4KTsKICAgICAg ICAgaWYgKCFibG9jaykKQEAgLTc3OCw2ICs3NzksMTUgQEAgdm9pZCBHcmFwaDo6aW52YWxpZGF0 ZUNGRygpCiAgICAgbV9iYWNrd2FyZHNDRkcgPSBudWxscHRyOwogfQogCit2b2lkIEdyYXBoOjpp bnZhbGlkYXRlTm9kZUxpdmVuZXNzKCkKK3sKKyAgICBpZiAobV9mb3JtICE9IFNTQSkKKyAgICAg ICAgcmV0dXJuOworCisgICAgZm9yIChCYXNpY0Jsb2NrKiBibG9jayA6IGJsb2Nrc0luTmF0dXJh bE9yZGVyKCkpCisgICAgICAgIGJsb2NrLT5zc2EtPmludmFsaWRhdGUoKTsKK30KKwogdm9pZCBH cmFwaDo6c3Vic3RpdHV0ZUdldExvY2FsKEJhc2ljQmxvY2smIGJsb2NrLCB1bnNpZ25lZCBzdGFy dEluZGV4SW5CbG9jaywgVmFyaWFibGVBY2Nlc3NEYXRhKiB2YXJpYWJsZUFjY2Vzc0RhdGEsIE5v ZGUqIG5ld0dldExvY2FsKQogewogICAgIGZvciAodW5zaWduZWQgaW5kZXhJbkJsb2NrID0gc3Rh cnRJbmRleEluQmxvY2s7IGluZGV4SW5CbG9jayA8IGJsb2NrLnNpemUoKTsgKytpbmRleEluQmxv Y2spIHsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHR3JhcGguaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0dyYXBoLmgJKHJldmlzaW9uIDIw Mzc1NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHR3JhcGguaAkod29ya2luZyBj b3B5KQpAQCAtNTMzLDYgKzUzMyw3IEBAIHB1YmxpYzoKICAgICB2b2lkIHN1YnN0aXR1dGVHZXRM b2NhbChCYXNpY0Jsb2NrJiBibG9jaywgdW5zaWduZWQgc3RhcnRJbmRleEluQmxvY2ssIFZhcmlh YmxlQWNjZXNzRGF0YSogdmFyaWFibGVBY2Nlc3NEYXRhLCBOb2RlKiBuZXdHZXRMb2NhbCk7CiAg ICAgCiAgICAgdm9pZCBpbnZhbGlkYXRlQ0ZHKCk7CisgICAgdm9pZCBpbnZhbGlkYXRlTm9kZUxp dmVuZXNzKCk7CiAgICAgCiAgICAgdm9pZCBjbGVhckZsYWdzT25BbGxOb2RlcyhOb2RlRmxhZ3Mp OwogICAgIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQbGFuLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1BsYW4uY3BwCShyZXZpc2lv biAyMDM3NTcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1BsYW4uY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC00MjgsNiArNDI4LDggQEAgUGxhbjo6Q29tcGlsYXRpb25QYXRoIFBsYW46 OmNvbXBpbGVJblRocgogICAgICAgICAvLyB3cm9uZyB3aXRoIHJ1bm5pbmcgTElDTSBlYXJsaWVy LCBpZiB3ZSB3YW50ZWQgdG8gcHV0IG90aGVyIENGRyB0cmFuc2Zvcm1zIGFib3ZlIHRoaXMgcG9p bnQuCiAgICAgICAgIC8vIEFsdGVybmF0aXZlbHksIHdlIGNvdWxkIHJ1biBsb29wIHByZS1oZWFk ZXIgY3JlYXRpb24gYWZ0ZXIgU1NBIGNvbnZlcnNpb24gLSBidXQgaWYgd2UgZGlkIHRoYXQKICAg ICAgICAgLy8gdGhlbiB3ZSdkIG5lZWQgdG8gZG8gc29tZSBzaW1wbGUgU1NBIGZpeC11cC4KKyAg ICAgICAgcGVyZm9ybUxpdmVuZXNzQW5hbHlzaXMoZGZnKTsKKyAgICAgICAgcGVyZm9ybUNGQShk ZmcpOwogICAgICAgICBwZXJmb3JtTElDTShkZmcpOwogCiAgICAgICAgIC8vIEZJWE1FOiBDdXJy ZW50bHk6IEludGVnZXJSYW5nZU9wdGltaXphdGlvbiAqbXVzdCogYmUgcnVuIGFmdGVyIExJQ00u Cg==