160225 2016-07-26 17:25:16 -0700 Disable WebCoreNSURLSessionTest on ios-simulator 2016-07-27 10:17:07 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryanhaddad ryanhaddad ap jer.noble oldest_to_newest 1214765 0 ryanhaddad 2016-07-26 17:25:16 -0700 Disable API test WebCoreNSURLSessionTest.BasicOperation on ios-simulator 1214766 1 ryanhaddad 2016-07-26 17:30:25 -0700 <rdar://problem/26433289> 1214767 2 284657 ryanhaddad 2016-07-26 17:31:41 -0700 Created attachment 284657 Patch 1214784 3 284657 ap 2016-07-26 19:21:12 -0700 Comment on attachment 284657 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284657&action=review > Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:164 > +#endif > > TEST_F(WebCoreNSURLSessionTest, InvalidateEmpty) Is it only the BasicOperation test? I assumed that all WebCoreNSURLSessionTest needed to be disabled. 1214803 4 284670 ryanhaddad 2016-07-26 20:43:44 -0700 Created attachment 284670 Patch This patch disables all of the WebCoreNSURLSession tests on iOS. 1214805 5 ryanhaddad 2016-07-26 20:44:55 -0700 (In reply to comment #3) > Comment on attachment 284657 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=284657&action=review > > > Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:164 > > +#endif > > > > TEST_F(WebCoreNSURLSessionTest, InvalidateEmpty) > > Is it only the BasicOperation test? I assumed that all > WebCoreNSURLSessionTest needed to be disabled. This was the only one that asserted, but yes, we may as well disable them all. New patch uploaded. 1214814 6 ap 2016-07-26 22:04:27 -0700 The new patch breaks Mac build: /Volumes/Data/EWS/WebKit/Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:139:5: error: unknown type name 'WebCoreNSURLSession'; did you mean 'WebCoreNSURLSessionTest'? WebCoreNSURLSession* session = [[WebCoreNSURLSession alloc] initWithResourceLoader:*loader delegate:delegate delegateQueue:[NSOperationQueue mainQueue]]; 1214821 7 284675 ryanhaddad 2016-07-26 22:38:14 -0700 Created attachment 284675 Patch Patch for EWS 1214954 8 284675 ryanhaddad 2016-07-27 10:17:03 -0700 Comment on attachment 284675 Patch Clearing flags on attachment: 284675 Committed r203781: <http://trac.webkit.org/changeset/203781> 1214955 9 ryanhaddad 2016-07-27 10:17:07 -0700 All reviewed patches have been landed. Closing bug. 284657 2016-07-26 17:31:41 -0700 2016-07-26 20:43:41 -0700 Patch bug-160225-20160726173032.patch text/plain 1403 ryanhaddad U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzNzU1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjViYTkwYTM1YjFlYzEzM2RiNzFmZjk0MTM3YjliNWY2 ODBjMmFjOS4uNDVkZGEwOTJhYWFlMzFmZTE0MzE3MzBlNmQwNzBlOTA5NGU4NDE2NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE2LTA3LTI2ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgorCisg ICAgICAgIERpc2FibGUgQVBJIHRlc3QgV2ViQ29yZU5TVVJMU2Vzc2lvblRlc3QuQmFzaWNPcGVy YXRpb24gb24gaW9zLXNpbXVsYXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTYwMjI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvV2ViQ29yZU5TVVJM U2Vzc2lvbi5tbToKKwogMjAxNi0wNy0yNiAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNl bkB3ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCB0ZXN0cyBhZnRlciByMjAzNzQzLgpkaWZmIC0t Z2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1dlYkNvcmVOU1VSTFNlc3Np b24ubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvV2ViQ29yZU5TVVJMU2Vz c2lvbi5tbQppbmRleCA0YTk4ZjFkMzg5Y2FkYjg1M2VlNTAxYTU1Zjc5YTI3ZWFmYTFjMTE3Li5j NjVlMjJlYmJjYzhjOWY2OTA3YzAyZjEzZTc0YWU3YTA2NjExNGYwIDEwMDY0NAotLS0gYS9Ub29s cy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvV2ViQ29yZU5TVVJMU2Vzc2lvbi5tbQorKysg Yi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvV2ViQ29yZU5TVVJMU2Vzc2lvbi5t bQpAQCAtMTM0LDYgKzEzNCw3IEBAIHB1YmxpYzoKICAgICB9CiB9OwogCisjaWYgIVBMQVRGT1JN KElPUykKIFRFU1RfRihXZWJDb3JlTlNVUkxTZXNzaW9uVGVzdCwgQmFzaWNPcGVyYXRpb24pCiB7 CiAgICAgV2ViQ29yZU5TVVJMU2Vzc2lvbiogc2Vzc2lvbiA9IFtbV2ViQ29yZU5TVVJMU2Vzc2lv biBhbGxvY10gaW5pdFdpdGhSZXNvdXJjZUxvYWRlcjoqbG9hZGVyIGRlbGVnYXRlOmRlbGVnYXRl IGRlbGVnYXRlUXVldWU6W05TT3BlcmF0aW9uUXVldWUgbWFpblF1ZXVlXV07CkBAIC0xNTgsNiAr MTU5LDcgQEAgVEVTVF9GKFdlYkNvcmVOU1VSTFNlc3Npb25UZXN0LCBCYXNpY09wZXJhdGlvbikK IAogICAgIFtzZXNzaW9uIHJlbGVhc2VdOwogfQorI2VuZGlmCiAKIFRFU1RfRihXZWJDb3JlTlNV UkxTZXNzaW9uVGVzdCwgSW52YWxpZGF0ZUVtcHR5KQogewo= 284670 2016-07-26 20:43:44 -0700 2016-07-26 22:38:12 -0700 Patch bug-160225-20160726204235.patch text/plain 1209 ryanhaddad U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzNzU1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjViYTkwYTM1YjFlYzEzM2RiNzFmZjk0MTM3YjliNWY2 ODBjMmFjOS4uZDAxNWU3Zjk1NTM1Mzg0ZWJjMzUyYWQ1NDRhMjMwYWEzZjRmOWI5OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE2LTA3LTI2ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgorCisg ICAgICAgIERpc2FibGUgV2ViQ29yZU5TVVJMU2Vzc2lvblRlc3QgQVBJIHRlc3RzIG9uIGlvcy1z aW11bGF0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE2MDIyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1dlYkNvcmVOU1VSTFNlc3Npb24ubW06CisK IDIwMTYtMDctMjYgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4K IAogICAgICAgICBGaXggdGVzdHMgYWZ0ZXIgcjIwMzc0My4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9XZWJDb3JlTlNVUkxTZXNzaW9uLm1tIGIvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1dlYkNvcmVOU1VSTFNlc3Npb24ubW0KaW5kZXgg NGE5OGYxZDM4OWNhZGI4NTNlZTUwMWE1NWY3OWEyN2VhZmExYzExNy4uMTQzNzJlZDJlZTVlOTI4 ZWU4OGY2ZTUwY2E2MDE3ZjQ0YjI4ZmZjZCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJDb3JlL1dlYkNvcmVOU1VSTFNlc3Npb24ubW0KKysrIGIvVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJDb3JlL1dlYkNvcmVOU1VSTFNlc3Npb24ubW0KQEAgLTI1LDcgKzI1 LDcgQEAKIAogI2ltcG9ydCAiY29uZmlnLmgiCiAKLSNpZiBQTEFURk9STShJT1MpIHx8IF9fTUFD X09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMTAwCisjaWYgIVBMQVRGT1JNKElPUykg fHwgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDExMDAKIAogI2ltcG9ydCAi UGxhdGZvcm1VdGlsaXRpZXMuaCIKICNpbXBvcnQgPEphdmFTY3JpcHRDb3JlL0luaXRpYWxpemVU aHJlYWRpbmcuaD4K 284675 2016-07-26 22:38:14 -0700 2016-07-27 10:17:03 -0700 Patch bug-160225-20160726223705.patch text/plain 1209 ryanhaddad U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzNzYzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjViYTkwYTM1YjFlYzEzM2RiNzFmZjk0MTM3YjliNWY2 ODBjMmFjOS4uZDAxNWU3Zjk1NTM1Mzg0ZWJjMzUyYWQ1NDRhMjMwYWEzZjRmOWI5OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE2LTA3LTI2ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgorCisg ICAgICAgIERpc2FibGUgV2ViQ29yZU5TVVJMU2Vzc2lvblRlc3QgQVBJIHRlc3RzIG9uIGlvcy1z aW11bGF0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE2MDIyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1dlYkNvcmVOU1VSTFNlc3Npb24ubW06CisK IDIwMTYtMDctMjYgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4K IAogICAgICAgICBGaXggdGVzdHMgYWZ0ZXIgcjIwMzc0My4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9XZWJDb3JlTlNVUkxTZXNzaW9uLm1tIGIvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1dlYkNvcmVOU1VSTFNlc3Npb24ubW0KaW5kZXgg NGE5OGYxZDM4OWNhZGI4NTNlZTUwMWE1NWY3OWEyN2VhZmExYzExNy4uMTY0MTNjZjJkMmE3NzRh ODE3YjU0ZjMzYjY1MDUwYTZiZDFmOTNmOCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJDb3JlL1dlYkNvcmVOU1VSTFNlc3Npb24ubW0KKysrIGIvVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJDb3JlL1dlYkNvcmVOU1VSTFNlc3Npb24ubW0KQEAgLTI1LDcgKzI1 LDcgQEAKIAogI2ltcG9ydCAiY29uZmlnLmgiCiAKLSNpZiBQTEFURk9STShJT1MpIHx8IF9fTUFD X09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMTAwCisjaWYgIVBMQVRGT1JNKElPUykg JiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDExMDAKIAogI2ltcG9ydCAi UGxhdGZvcm1VdGlsaXRpZXMuaCIKICNpbXBvcnQgPEphdmFTY3JpcHRDb3JlL0luaXRpYWxpemVU aHJlYWRpbmcuaD4K