160224 2016-07-26 16:51:51 -0700 Align Node.isEqualNode() with the specification 2016-07-26 20:43:48 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED WebExposed P2 Normal --- 1 cdumez cdumez benjamin cdumez commit-queue darin dbates esprehn+autocc kangil.han rniwa sam oldest_to_newest 1214758 0 cdumez 2016-07-26 16:51:51 -0700 Align Node.isEqualNode() with the specification: - https://dom.spec.whatwg.org/#dom-node-isequalnode - https://dom.spec.whatwg.org/#concept-node-equals 1214781 1 284661 cdumez 2016-07-26 18:26:58 -0700 Created attachment 284661 Patch 1214802 2 284661 commit-queue 2016-07-26 20:43:42 -0700 Comment on attachment 284661 Patch Clearing flags on attachment: 284661 Committed r203759: <http://trac.webkit.org/changeset/203759> 1214804 3 commit-queue 2016-07-26 20:43:48 -0700 All reviewed patches have been landed. Closing bug. 284661 2016-07-26 18:26:58 -0700 2016-07-26 20:43:42 -0700 Patch bug-160224-20160726182548.patch text/plain 7370 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzNzQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDVkOTQyODZmODQxZmFh MzkxODExYTIwMWY2NDRlNDIyNzY4NmQwOS4uODJjZTE2NzFjYTEyYzBjMzNkYmE4MzA0ZTE4ZWEz MzcyNWQzZWVjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDE2LTA3LTI2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQWxpZ24gTm9kZS5pc0VxdWFs Tm9kZSgpIHdpdGggdGhlIHNwZWNpZmljYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDIyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFsaWduIG91ciBpbXBsZW1lbnRhdGlvbiBmb3IgTm9kZS5p c0VxdWFsTm9kZSgpIHRvIG1hdGNoIG1vcmUgY2xvc2VseQorICAgICAgICB0aGUgdGV4dCBvZiB0 aGUgc3BlY2lmaWNhdGlvbjoKKyAgICAgICAgLSBodHRwczovL2RvbS5zcGVjLndoYXR3Zy5vcmcv I2RvbS1ub2RlLWlzZXF1YWxub2RlCisgICAgICAgIC0gaHR0cHM6Ly9kb20uc3BlYy53aGF0d2cu b3JnLyNjb25jZXB0LW5vZGUtZXF1YWxzCisKKyAgICAgICAgVGhpcyBhbHNvIGZpeGVzIGEgYnVn IHdoZXJlIGlzRXF1YWxOb2RlKCkgd291bGQgc29tZXRpbWVzIHJldHVybiBmYWxzZQorICAgICAg ICB3cm9uZ2x5IGZvciBlbGVtZW50cyBiZWNhdXNlIHdlIHdlcmUgY29tcGFyaW5nIHRoZSB2YWx1 ZSByZXR1cm5lZCBieQorICAgICAgICBub2RlTmFtZSgpIHdoaWNoIHJldHVybnMgdGhlIHRhZ05h bWUgb2YgZWxlbWVudHMuIFRoZSBpc3N1ZSB3YXMgdGhhdAorICAgICAgICB0aGUgdGFnTmFtZSdz IGNhc2UgbWF5IGRpZmZlciBkZXBlbmRpbmcgb24gdGhlIGVsZW1lbnQgYmVpbmcgaW4gYW4KKyAg ICAgICAgSFRNTERvY3VtZW50IG9yIG5vdC4gV2Ugbm93IGNvbXBhcmUgRWxlbWVudDo6dGFnUU5h bWUoKSBpbnN0ZWFkIHdoaWNoCisgICAgICAgIGVuZHMgdXAgY29tcGFyaW5nIG5hbWVzcGFjZSAv IG5hbWVzcGFjZSBwcmVmaXggYW5kIGxvY2FsTmFtZSwgYXMgcGVyCisgICAgICAgIHRoZSBzcGVj aWZpY2F0aW9uLiBUaGUgbmV3IGJlaGF2aW9yIG1hdGNoZXMgRmlyZWZveCBhbmQgQ2hyb21lIGFu ZAorICAgICAgICBoZWxwcyB1cyBwYXNzIGFuIGV4dHJhIFczQyB0ZXN0LgorCisgICAgICAgIE5v IG5ldyB0ZXN0cywgcmViYXNlbGluZWQgZXhpc3RpbmcgdGVzdC4KKworICAgICAgICAqIGRvbS9O b2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5vZGU6OmlzRXF1YWxOb2RlKToKKwogMjAxNi0w Ny0yNiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIG9u cGF5bWVudGF1dGhvcml6ZWQgY2FsbGJhY2sgbm90IHJlY2VpdmVkIHdoZW4gYXV0aG9yaXppbmcg Zm9yIGEgc2Vjb25kIHRpbWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAppbmRleCBhYTI1YjA4OTExNDg1ODZhYWNi MTc5YTMxNjAyMTRmNTY3ZjdhNjFjLi5kNzE3NDRlZjlkMDM3YjZiNzY5OWI1ZDBjNWZmNTM5NjU0 NTVkNGI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCkBAIC0xMjE2LDIzICsxMjE2LDYwIEBAIGJvb2wgTm9k ZTo6aXNFcXVhbE5vZGUoTm9kZSogb3RoZXIpIGNvbnN0CiAgICAgaWYgKG5vZGVUeXBlICE9IG90 aGVyLT5ub2RlVHlwZSgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgCi0gICAgaWYgKG5v ZGVOYW1lKCkgIT0gb3RoZXItPm5vZGVOYW1lKCkpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLSAg ICAKLSAgICBpZiAobG9jYWxOYW1lKCkgIT0gb3RoZXItPmxvY2FsTmFtZSgpKQotICAgICAgICBy ZXR1cm4gZmFsc2U7Ci0gICAgCi0gICAgaWYgKG5hbWVzcGFjZVVSSSgpICE9IG90aGVyLT5uYW1l c3BhY2VVUkkoKSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIAotICAgIGlmIChwcmVmaXgo KSAhPSBvdGhlci0+cHJlZml4KCkpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAKLSAgICBp ZiAobm9kZVZhbHVlKCkgIT0gb3RoZXItPm5vZGVWYWx1ZSgpKQotICAgICAgICByZXR1cm4gZmFs c2U7Ci0gICAgCi0gICAgaWYgKGlzPEVsZW1lbnQ+KCp0aGlzKSAmJiAhZG93bmNhc3Q8RWxlbWVu dD4oKnRoaXMpLmhhc0VxdWl2YWxlbnRBdHRyaWJ1dGVzKGRvd25jYXN0PEVsZW1lbnQ+KG90aGVy KSkpCi0gICAgICAgIHJldHVybiBmYWxzZTsKKyAgICBzd2l0Y2ggKG5vZGVUeXBlKSB7CisgICAg Y2FzZSBOb2RlOjpET0NVTUVOVF9UWVBFX05PREU6IHsKKyAgICAgICAgYXV0byYgdGhpc0RvY1R5 cGUgPSBkb3duY2FzdDxEb2N1bWVudFR5cGU+KCp0aGlzKTsKKyAgICAgICAgYXV0byYgb3RoZXJE b2NUeXBlID0gZG93bmNhc3Q8RG9jdW1lbnRUeXBlPigqb3RoZXIpOworICAgICAgICBpZiAodGhp c0RvY1R5cGUubmFtZSgpICE9IG90aGVyRG9jVHlwZS5uYW1lKCkpCisgICAgICAgICAgICByZXR1 cm4gZmFsc2U7CisgICAgICAgIGlmICh0aGlzRG9jVHlwZS5wdWJsaWNJZCgpICE9IG90aGVyRG9j VHlwZS5wdWJsaWNJZCgpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICBpZiAo dGhpc0RvY1R5cGUuc3lzdGVtSWQoKSAhPSBvdGhlckRvY1R5cGUuc3lzdGVtSWQoKSkKKyAgICAg ICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgaWYgKHRoaXNEb2NUeXBlLmludGVybmFsU3Vi c2V0KCkgIT0gb3RoZXJEb2NUeXBlLmludGVybmFsU3Vic2V0KCkpCisgICAgICAgICAgICByZXR1 cm4gZmFsc2U7CisgICAgICAgIGJyZWFrOworICAgICAgICB9CisgICAgY2FzZSBOb2RlOjpFTEVN RU5UX05PREU6IHsKKyAgICAgICAgYXV0byYgdGhpc0VsZW1lbnQgPSBkb3duY2FzdDxFbGVtZW50 PigqdGhpcyk7CisgICAgICAgIGF1dG8mIG90aGVyRWxlbWVudCA9IGRvd25jYXN0PEVsZW1lbnQ+ KCpvdGhlcik7CisgICAgICAgIGlmICh0aGlzRWxlbWVudC50YWdRTmFtZSgpICE9IG90aGVyRWxl bWVudC50YWdRTmFtZSgpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICBpZiAo IXRoaXNFbGVtZW50Lmhhc0VxdWl2YWxlbnRBdHRyaWJ1dGVzKCZvdGhlckVsZW1lbnQpKQorICAg ICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICBicmVhazsKKyAgICAgICAgfQorICAgIGNh c2UgTm9kZTo6UFJPQ0VTU0lOR19JTlNUUlVDVElPTl9OT0RFOiB7CisgICAgICAgIGF1dG8mIHRo aXNQcm9jZXNzaW5nSW5zdHJ1Y3Rpb24gPSBkb3duY2FzdDxQcm9jZXNzaW5nSW5zdHJ1Y3Rpb24+ KCp0aGlzKTsKKyAgICAgICAgYXV0byYgb3RoZXJQcm9jZXNzaW5nSW5zdHJ1Y3Rpb24gPSBkb3du Y2FzdDxQcm9jZXNzaW5nSW5zdHJ1Y3Rpb24+KCpvdGhlcik7CisgICAgICAgIGlmICh0aGlzUHJv Y2Vzc2luZ0luc3RydWN0aW9uLnRhcmdldCgpICE9IG90aGVyUHJvY2Vzc2luZ0luc3RydWN0aW9u LnRhcmdldCgpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICBpZiAodGhpc1By b2Nlc3NpbmdJbnN0cnVjdGlvbi5kYXRhKCkgIT0gb3RoZXJQcm9jZXNzaW5nSW5zdHJ1Y3Rpb24u ZGF0YSgpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICBicmVhazsKKyAgICAg ICAgfQorICAgIGNhc2UgTm9kZTo6Q0RBVEFfU0VDVElPTl9OT0RFOgorICAgIGNhc2UgTm9kZTo6 VEVYVF9OT0RFOgorICAgIGNhc2UgTm9kZTo6Q09NTUVOVF9OT0RFOiB7CisgICAgICAgIGF1dG8m IHRoaXNDaGFyYWN0ZXJEYXRhID0gZG93bmNhc3Q8Q2hhcmFjdGVyRGF0YT4oKnRoaXMpOworICAg ICAgICBhdXRvJiBvdGhlckNoYXJhY3RlckRhdGEgPSBkb3duY2FzdDxDaGFyYWN0ZXJEYXRhPigq b3RoZXIpOworICAgICAgICBpZiAodGhpc0NoYXJhY3RlckRhdGEuZGF0YSgpICE9IG90aGVyQ2hh cmFjdGVyRGF0YS5kYXRhKCkpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIGJy ZWFrOworICAgICAgICB9CisgICAgY2FzZSBOb2RlOjpBVFRSSUJVVEVfTk9ERTogeworICAgICAg ICBhdXRvJiB0aGlzQXR0cmlidXRlID0gZG93bmNhc3Q8QXR0cj4oKnRoaXMpOworICAgICAgICBh dXRvJiBvdGhlckF0dHJpYnV0ZSA9IGRvd25jYXN0PEF0dHI+KCpvdGhlcik7CisgICAgICAgIGlm ICh0aGlzQXR0cmlidXRlLnF1YWxpZmllZE5hbWUoKSAhPSBvdGhlckF0dHJpYnV0ZS5xdWFsaWZp ZWROYW1lKCkpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIGlmICh0aGlzQXR0 cmlidXRlLnZhbHVlKCkgIT0gb3RoZXJBdHRyaWJ1dGUudmFsdWUoKSkKKyAgICAgICAgICAgIHJl dHVybiBmYWxzZTsKKyAgICAgICAgYnJlYWs7CisgICAgICAgIH0KKyAgICBjYXNlIE5vZGU6OkRP Q1VNRU5UX05PREU6CisgICAgY2FzZSBOb2RlOjpET0NVTUVOVF9GUkFHTUVOVF9OT0RFOgorICAg ICAgICBicmVhazsKKyAgICB9CiAgICAgCiAgICAgTm9kZSogY2hpbGQgPSBmaXJzdENoaWxkKCk7 CiAgICAgTm9kZSogb3RoZXJDaGlsZCA9IG90aGVyLT5maXJzdENoaWxkKCk7CkBAIC0xMjQ4LDIy ICsxMjg1LDYgQEAgYm9vbCBOb2RlOjppc0VxdWFsTm9kZShOb2RlKiBvdGhlcikgY29uc3QKICAg ICBpZiAob3RoZXJDaGlsZCkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIAotICAgIGlmIChu b2RlVHlwZSA9PSBET0NVTUVOVF9UWVBFX05PREUpIHsKLSAgICAgICAgY29uc3QgRG9jdW1lbnRU eXBlKiBkb2N1bWVudFR5cGVUaGlzID0gc3RhdGljX2Nhc3Q8Y29uc3QgRG9jdW1lbnRUeXBlKj4o dGhpcyk7Ci0gICAgICAgIGNvbnN0IERvY3VtZW50VHlwZSogZG9jdW1lbnRUeXBlT3RoZXIgPSBz dGF0aWNfY2FzdDxjb25zdCBEb2N1bWVudFR5cGUqPihvdGhlcik7Ci0gICAgICAgIAotICAgICAg ICBpZiAoZG9jdW1lbnRUeXBlVGhpcy0+cHVibGljSWQoKSAhPSBkb2N1bWVudFR5cGVPdGhlci0+ cHVibGljSWQoKSkKLSAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLQotICAgICAgICBpZiAoZG9j dW1lbnRUeXBlVGhpcy0+c3lzdGVtSWQoKSAhPSBkb2N1bWVudFR5cGVPdGhlci0+c3lzdGVtSWQo KSkKLSAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLQotICAgICAgICBpZiAoZG9jdW1lbnRUeXBl VGhpcy0+aW50ZXJuYWxTdWJzZXQoKSAhPSBkb2N1bWVudFR5cGVPdGhlci0+aW50ZXJuYWxTdWJz ZXQoKSkKLSAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLQotICAgICAgICAvLyBGSVhNRTogV2Ug ZG9uJ3QgY29tcGFyZSBlbnRpdGllcyBvciBub3RhdGlvbnMgYmVjYXVzZSBjdXJyZW50bHkgYm90 aCBhcmUgYWx3YXlzIGVtcHR5LgotICAgIH0KLSAgICAKICAgICByZXR1cm4gdHJ1ZTsKIH0KIApk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZyBiL0xheW91dFRl c3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKaW5kZXggNzk4MjFmYzU5OWNhNWRmZjEwMTE5OGRj YWVhZmMxODU5NDJhMzEyOS4uZjNmZjE1MTMxYjczNTVmYzY5NGE2Yjc3NTMwYzc2MzM3NDkyODBj OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZworKysgYi9M YXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTYt MDctMjYgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAorICAgICAgICBBbGlnbiBO b2RlLmlzRXF1YWxOb2RlKCkgd2l0aCB0aGUgc3BlY2lmaWNhdGlvbgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwMjI0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmViYXNlbGluZSBXM0MgdGVzdCBub3cg dGhhdCBvbmUgbW9yZSBjaGVjayBpcyBwYXNzaW5nLiBXZSBhcmUgbm93CisgICAgICAgIHBhc3Np bmcgYWxsIHRoZSBjaGVja3MgaW4gdGhpcyB0ZXN0IGxpa2UgRmlyZWZveCBhbmQgQ2hyb21lLgor CisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9ub2Rlcy9Ob2RlLWlzRXF1YWxOb2Rl LWV4cGVjdGVkLnR4dDoKKworMjAxNi0wNy0yNiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUu Y29tPgorCiAgICAgICAgIFJhbmdlLnByb3RvdHlwZS5jb21wYXJlQm91bmRhcnlQb2ludHMubGVu Z3RoIHNob3VsZCBiZSAyCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNjAyMTcKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy9kb20vbm9kZXMvTm9kZS1pc0VxdWFsTm9kZS1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9ub2Rlcy9O b2RlLWlzRXF1YWxOb2RlLWV4cGVjdGVkLnR4dAppbmRleCAxMzlkNDE4N2Q0ZmQ1ZDJhNGY3NTBh NGU4NTk4OTk5YmE1ODg2YTUwLi44NTdiZjU0ZjFmZGZkMWRkZTEwODJlZTk5MDhjZWJkOGU0OWMx N2Q1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL2RvbS9ub2Rlcy9Ob2RlLWlzRXF1YWxOb2RlLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRU ZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9ub2Rlcy9Ob2RlLWlzRXF1 YWxOb2RlLWV4cGVjdGVkLnR4dApAQCAtNiw2ICs2LDYgQEAgUEFTUyBwcm9jZXNzaW5nIGluc3Ry dWN0aW9ucyBzaG91bGQgYmUgY29tcGFyZWQgb24gdGFyZ2V0IGFuZCBkYXRhCiBQQVNTIHRleHQg bm9kZXMgc2hvdWxkIGJlIGNvbXBhcmVkIG9uIGRhdGEgCiBQQVNTIGNvbW1lbnRzIHNob3VsZCBi ZSBjb21wYXJlZCBvbiBkYXRhIAogUEFTUyBkb2N1bWVudCBmcmFnbWVudHMgc2hvdWxkIG5vdCBi ZSBjb21wYXJlZCBiYXNlZCBvbiBwcm9wZXJ0aWVzIAotRkFJTCBkb2N1bWVudHMgc2hvdWxkIG5v dCBiZSBjb21wYXJlZCBiYXNlZCBvbiBwcm9wZXJ0aWVzIGFzc2VydF90cnVlOiBkZWZhdWx0IEhU TUwgZG9jdW1lbnRzLCBjcmVhdGVkIGRpZmZlcmVudCB3YXlzIGV4cGVjdGVkIHRydWUgZ290IGZh bHNlCitQQVNTIGRvY3VtZW50cyBzaG91bGQgbm90IGJlIGNvbXBhcmVkIGJhc2VkIG9uIHByb3Bl cnRpZXMgCiBQQVNTIG5vZGUgZXF1YWxpdHkgdGVzdGluZyBzaG91bGQgdGVzdCBkZXNjZW5kYW50 IGVxdWFsaXR5IHRvbyAKIAo=