160208 2016-07-26 13:35:57 -0700 Occasional crash in WebCore::RenderVTTCue::initializeLayoutParameters 2016-07-26 14:36:35 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 1214640 0 eric.carlson 2016-07-26 13:35:57 -0700 From crash logs, it seems that RenderVTTCue::firstChild is sometimes NULL when it should not be. Debug builds ASSERT when this is true, but release builds should not crash. 1214641 1 eric.carlson 2016-07-26 13:36:31 -0700 rdar://problem/21090897 1214645 2 284625 eric.carlson 2016-07-26 13:43:43 -0700 Created attachment 284625 Proposed patch. 1214661 3 284625 darin 2016-07-26 14:15:13 -0700 Comment on attachment 284625 Proposed patch. OK 1214669 4 284625 commit-queue 2016-07-26 14:36:31 -0700 Comment on attachment 284625 Proposed patch. Clearing flags on attachment: 284625 Committed r203737: <http://trac.webkit.org/changeset/203737> 1214670 5 commit-queue 2016-07-26 14:36:35 -0700 All reviewed patches have been landed. Closing bug. 284625 2016-07-26 13:43:43 -0700 2016-07-26 14:36:31 -0700 Proposed patch. null_first_child_patch.txt text/plain 1270 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMzczMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA3LTI2ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIE9jY2FzaW9uYWwgY3Jh c2ggaW4gV2ViQ29yZTo6UmVuZGVyVlRUQ3VlOjppbml0aWFsaXplTGF5b3V0UGFyYW1ldGVycwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwMjA4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZW5kZXJp bmcvUmVuZGVyVlRUQ3VlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclZUVEN1ZTo6aW5p dGlhbGl6ZUxheW91dFBhcmFtZXRlcnMpOiBSZXR1cm4gd2hlbiBmaXJzdENoaWxkIGlzIE5VTEwg c28gYQorICAgICAgICByZWxlYXNlIGJ1aWxkIHdpbGwgbm90IGNyYXNoLgorCiAyMDE2LTA3LTI2 ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBbRmV0Y2ggQVBJ XSBBZGQgc3VwcG9ydCBmb3IgZmV0Y2ggbW9kZSwgaW4gcGFydGljdWxhciBjb3JzCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVlRUQ3VlLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVlRUQ3VlLmNwcAkocmV2aXNpb24gMjAzNjk4 KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZUVEN1ZS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTcwLDYgKzcwLDggQEAgdm9pZCBSZW5kZXJWVFRDdWU6OmxheW91dCgpCiBib29s IFJlbmRlclZUVEN1ZTo6aW5pdGlhbGl6ZUxheW91dFBhcmFtZXRlcnMoSW5saW5lRmxvd0JveCom IGZpcnN0TGluZUJveCwgTGF5b3V0VW5pdCYgc3RlcCwgTGF5b3V0VW5pdCYgcG9zaXRpb24pCiB7 CiAgICAgQVNTRVJUKGZpcnN0Q2hpbGQoKSk7CisgICAgaWYgKCFmaXJzdENoaWxkKCkpCisgICAg ICAgIHJldHVybiBmYWxzZTsKIAogICAgIFJlbmRlckJsb2NrKiBwYXJlbnRCbG9jayA9IGNvbnRh aW5pbmdCbG9jaygpOwogCg==