160199 2016-07-26 09:36:42 -0700 MediaFragmentURIParser rejects valid NPT strings if 'hours' is defined using 1 digit 2024-05-18 02:47:16 -0700 1 1 1 Unclassified WebKit Media WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Minor --- 1 fvallee webkit-unassigned eric.carlson jeremyj-wk jer.noble webkit-bug-importer oldest_to_newest 1214560 0 fvallee 2016-07-26 09:36:42 -0700 If a media uri contains a fragment, the MediaFragmentURIParser (Source/WebCore/html/MediaFragmentURIParser.cpp) is used to get the temporal clipping values (if any). Based on https://www.w3.org/TR/media-frags/#rtsp: "Minutes and seconds must be specified as exactly two digits, hours and fractional seconds can be any number of digits". As far as I understand the specifications, "t=0:02:00,121.5" is valid (it's an example from the W3C specs anyway) but this string is rejected by the MediaFragmentURIParser (Source/WebCore/html/MediaFragmentURIParser.cpp) =================== Steps to reproduce: The regression test LayoutTests/media/media-fragments/TC0078.html can PASS using "t=00:00:03,00:00:07" string, as defined in LayoutTests/media/media-fragments/media-fragments.js: TC0078 : { start: 3, end: 7, valid: true, description: "NPT HH:MM:SS format", fragment: "t=00:00:03,00:00:07", comment: "The media is requested from a to b."}, If the fragment is changed to "t=0:00:03,00:00:07" (use only 1 digit for the hour), the test fails (based on my understanding "NPT H:MM:SS format" is valid and the test should pass). =================== Note: 1-digit hour string ("0:00:03") is rejected because of https://trac.webkit.org/browser/trunk/Source/WebCore/html/MediaFragmentURIParser.cpp#L281 Please let me know if I'm missing something. thanks. 1214836 1 fvallee 2016-07-27 00:50:55 -0700 FYI media/media-fragments/TC0078.html can PASS using Fragment: 't=00000:00:03,00:00:07' Hours using more than 2 digits are accepted by the parser, only 1 digit hours is rejected. 2036202 2 ews-feeder 2024-05-18 02:46:37 -0700 Committed 278951@main (1b08c7ea9a82): <https://commits.webkit.org/278951@main> Reviewed commits have been landed. Closing PR #28748 and removing active labels. 2036203 3 webkit-bug-importer 2024-05-18 02:47:16 -0700 <rdar://problem/128318772>