160196 2016-07-26 06:06:05 -0700 Typo in StyleSharingResolver.cpp 2017-07-05 12:58:53 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 emilio ecobos cdumez commit-queue darin ecobos jer.noble kling koivisto oldest_to_newest 1214520 0 emilio 2016-07-26 06:06:05 -0700 Not a huge deal, just noticed it. Not sure how to test it though. 1214522 1 284587 emilio 2016-07-26 06:17:28 -0700 Created attachment 284587 Patch 1214728 2 284587 darin 2016-07-26 16:00:31 -0700 Comment on attachment 284587 Patch Clearly a correct change and likely valuable. Antti, Jer, any insight into what the symptom will be here? 1215162 3 koivisto 2016-07-28 00:40:49 -0700 > Clearly a correct change and likely valuable. Antti, Jer, any insight into > what the symptom will be here? It could cause inappropriate style sharing (and so wrong style being applied) from the full screen element to some other element. Good find. 1215235 4 darin 2016-07-28 08:54:47 -0700 (In reply to comment #3) > > Clearly a correct change and likely valuable. Antti, Jer, any insight into > > what the symptom will be here? > > It could cause inappropriate style sharing (and so wrong style being > applied) from the full screen element to some other element. Good find. Sorry, what I meant to say was, can we figure out how to use this information to help us construct a test case? 1215255 5 koivisto 2016-07-28 10:36:06 -0700 > Sorry, what I meant to say was, can we figure out how to use this > information to help us construct a test case? It would involve inserting an element that is otherwise identical to the full screen element (in full screen mode) so the style gets copied. This is likely to be somewhat tricky. I assume there is some sort of non-CSS styling in full screen elements that would result in observable differences (since these tests exist). 1325533 6 ecobos 2017-07-04 22:10:40 -0700 *** Bug 174147 has been marked as a duplicate of this bug. *** 1325534 7 284587 ecobos 2017-07-04 22:12:46 -0700 Comment on attachment 284587 Patch Antti, do you think this is worth landing? I think it is, and I remember spending a fair amount of time trying to test this without success (though I could try again I guess). The ChangeLog entry is suboptimal (heh, was my very first try). I can probably send a new patch if you want. 1325542 8 284587 commit-queue 2017-07-05 01:50:03 -0700 Comment on attachment 284587 Patch Rejecting attachment 284587 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 284587, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/4055293 1325543 9 koivisto 2017-07-05 01:51:03 -0700 Sure, please land it. ChangeLog needs some fixes to get through the commit queue. 1325684 10 314631 ecobos 2017-07-05 11:58:28 -0700 Created attachment 314631 Patch 1325685 11 314632 ecobos 2017-07-05 11:59:39 -0700 Created attachment 314632 Patch 1325718 12 314632 commit-queue 2017-07-05 12:58:52 -0700 Comment on attachment 314632 Patch Clearing flags on attachment: 314632 Committed r219147: <http://trac.webkit.org/changeset/219147> 1325719 13 commit-queue 2017-07-05 12:58:53 -0700 All reviewed patches have been landed. Closing bug. 284587 2016-07-26 06:17:28 -0700 2017-07-05 11:58:07 -0700 Patch bug-160196-20160726061619.patch text/plain 1697 emilio U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzNzEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjFkNTlmNWRiODM5NmMw Y2JmNDkwY2JhNmJkMjFkMjQ5Yjc3OTRmZi4uNzRjYTYzY2QwMzIxZDBkNDA2ZjlhNWY4ODkyYWQx YmE0MzAwOTNhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTA3LTI2ICBFbWls aW8gQ29ib3Mgw4FsdmFyZXogIDxlY29hbDk1QGdtYWlsLmNvbT4KKworICAgICAgICBCdWcgMTYw MTk2OiBGaXggdHlwbyBpbiBTdHlsZVNoYXJpbmdSZXNvbHZlciwgd2hlcmUgdGhlIHNhbWUgY2hl Y2sgd2FzIGJlaW5nIG1hZGUgdHdvIHRpbWVzLgorCisgICAgICAgIFRoZSBwcmV2aW91cyBjb2Rl IGRpZG4ndCBjaGVjayB0aGUgYWN0dWFsIHN0eWxlIHNoYXJpbmcgY2FuZGlkYXRlLgorCisgICAg ICAgIFR5cG8gaW4gU3R5bGVTaGFyaW5nUmVzb2x2ZXIuY3BwCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjAxOTYKKworICAgICAgICBObyByZXZpZXcg KHlldCkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBub3QgcmVhbGx5IHN1cmUgaG93IHRvIHRl c3QgdGhpcyByZWxpYWJseS4KKworICAgICAgICAqIHN0eWxlL1N0eWxlU2hhcmluZ1Jlc29sdmVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlOjpTaGFyaW5nUmVzb2x2ZXI6OmNhblNoYXJl U3R5bGVXaXRoRWxlbWVudCk6CisKIDIwMTYtMDctMjUgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFw cGxlLmNvbT4KIAogICAgICAgICBET01Ub2tlbkxpc3QucHJvdG90eXBlLnRvU3RyaW5nIHNob3Vs ZCBiZSBlbnVtZXJhYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZVNo YXJpbmdSZXNvbHZlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZVNoYXJpbmdSZXNv bHZlci5jcHAKaW5kZXggNTExMWEzMDk3MmI2Y2VhYWMyOTliOThmYjlmNjAwZjg2YWU1YTI3My4u ZmJiMWRhNzMxOTdlMzRhOGI4ZTk3ZDJiMmIxYjczZmQxODVlOTZkZCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVTaGFyaW5nUmVzb2x2ZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3N0eWxlL1N0eWxlU2hhcmluZ1Jlc29sdmVyLmNwcApAQCAtMjkwLDcgKzI5MCw3IEBA IGJvb2wgU2hhcmluZ1Jlc29sdmVyOjpjYW5TaGFyZVN0eWxlV2l0aEVsZW1lbnQoY29uc3QgQ29u dGV4dCYgY29udGV4dCwgY29uc3QgU3R5CiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogI2lmIEVO QUJMRShGVUxMU0NSRUVOX0FQSSkKLSAgICBpZiAoJmVsZW1lbnQgPT0gbV9kb2N1bWVudC53ZWJr aXRDdXJyZW50RnVsbFNjcmVlbkVsZW1lbnQoKSB8fCAmZWxlbWVudCA9PSBtX2RvY3VtZW50Lndl YmtpdEN1cnJlbnRGdWxsU2NyZWVuRWxlbWVudCgpKQorICAgIGlmICgmZWxlbWVudCA9PSBtX2Rv Y3VtZW50LndlYmtpdEN1cnJlbnRGdWxsU2NyZWVuRWxlbWVudCgpIHx8ICZjYW5kaWRhdGVFbGVt ZW50ID09IG1fZG9jdW1lbnQud2Via2l0Q3VycmVudEZ1bGxTY3JlZW5FbGVtZW50KCkpCiAgICAg ICAgIHJldHVybiBmYWxzZTsKICNlbmRpZgogICAgIHJldHVybiB0cnVlOwo= 314631 2017-07-05 11:58:28 -0700 2017-07-05 11:59:34 -0700 Patch bug-160196-20170705205826.patch text/plain 1635 ecobos U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5MTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWFkZTI0YzJkNzFjODMz OTNhOTMwMzNmNWUxYzkwMzlmODE1Yjg4Ny4uZTc0ZDk0NDVjNGMxMGRhNTg2MjQ5OWUwOWU2ZGUy NWNjN2Y0MDFhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE3LTA3LTA0ICBFbWls aW8gQ29ib3Mgw4FsdmFyZXogIDxlY29ib3NAaWdhbGlhLmNvbT4KIAorICAgICAgICBTdHlsZSBz aGFyaW5nIGNoZWNrIGZvciBmdWxsc2NyZWVuIGVsZW1lbnQgc2VlbXMgYm9ndXMuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjAxOTYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgQW50dGkgS29pdmlzdG8uCisKKyAgICAgICAgTm8gbmV3IHRl c3RzIChubyBlYXN5IHdheSB0byB0ZXN0IHRoaXMgcmVsaWFibHkpLgorCisgICAgICAgICogc3R5 bGUvU3R5bGVTaGFyaW5nUmVzb2x2ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGU6OlNo YXJpbmdSZXNvbHZlcjo6Y2FuU2hhcmVTdHlsZVdpdGhFbGVtZW50KToKKworMjAxNy0wNy0wNCAg RW1pbGlvIENvYm9zIMOBbHZhcmV6ICA8ZWNvYm9zQGlnYWxpYS5jb20+CisKICAgICAgICAgUHJv Y2Vzc2luZ0luc3RydWN0aW9uOjpjbGVhckV4aXN0aW5nQ2FjaGVkU2hlZXQgZG9lc24ndCByZWFs bHkgZXhpc3QuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzQxNDYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVTaGFyaW5n UmVzb2x2ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVTaGFyaW5nUmVzb2x2ZXIu Y3BwCmluZGV4IGI3YTI4NDk2YWU1MmM4Njk1MjJiMTgwMjlkNzEwYmI3NTNlZTEyMDMuLjQ4MGY0 ZGM3MzJhZTdmMzRiMjdlYThkZThlZjQ1NmJkMGM3ODNhNjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3N0eWxlL1N0eWxlU2hhcmluZ1Jlc29sdmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9zdHlsZS9TdHlsZVNoYXJpbmdSZXNvbHZlci5jcHAKQEAgLTI5Miw3ICsyOTIsNyBAQCBib29s IFNoYXJpbmdSZXNvbHZlcjo6Y2FuU2hhcmVTdHlsZVdpdGhFbGVtZW50KGNvbnN0IENvbnRleHQm IGNvbnRleHQsIGNvbnN0IFN0eQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICNpZiBFTkFCTEUo RlVMTFNDUkVFTl9BUEkpCi0gICAgaWYgKCZlbGVtZW50ID09IG1fZG9jdW1lbnQud2Via2l0Q3Vy cmVudEZ1bGxTY3JlZW5FbGVtZW50KCkgfHwgJmVsZW1lbnQgPT0gbV9kb2N1bWVudC53ZWJraXRD dXJyZW50RnVsbFNjcmVlbkVsZW1lbnQoKSkKKyAgICBpZiAoJmNhbmRpZGF0ZUVsZW1lbnQgPT0g bV9kb2N1bWVudC53ZWJraXRDdXJyZW50RnVsbFNjcmVlbkVsZW1lbnQoKSB8fCAmZWxlbWVudCA9 PSBtX2RvY3VtZW50LndlYmtpdEN1cnJlbnRGdWxsU2NyZWVuRWxlbWVudCgpKQogICAgICAgICBy ZXR1cm4gZmFsc2U7CiAjZW5kaWYKICAgICByZXR1cm4gdHJ1ZTsK 314632 2017-07-05 11:59:39 -0700 2017-07-05 12:58:52 -0700 Patch bug-160196-20170705205937.patch text/plain 1628 ecobos U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5MTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWFkZTI0YzJkNzFjODMz OTNhOTMwMzNmNWUxYzkwMzlmODE1Yjg4Ny4uZjRkMjg3Njk3YjdlNGViZDY2MTcxYzViZDI4ZDIy OTE1OWEyMmRkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE3LTA3LTA0ICBFbWls aW8gQ29ib3Mgw4FsdmFyZXogIDxlY29ib3NAaWdhbGlhLmNvbT4KIAorICAgICAgICBTdHlsZSBz aGFyaW5nIGNoZWNrIGZvciBmdWxsc2NyZWVuIGVsZW1lbnQgc2VlbXMgYm9ndXMuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjAxOTYKKworICAgICAg ICBSZXZpZXdlZCBieSBBbnR0aSBLb2l2aXN0by4KKworICAgICAgICBObyBuZXcgdGVzdHMgKG5v IGVhc3kgd2F5IHRvIHRlc3QgdGhpcyByZWxpYWJseSkuCisKKyAgICAgICAgKiBzdHlsZS9TdHls ZVNoYXJpbmdSZXNvbHZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZTo6U2hhcmluZ1Jl c29sdmVyOjpjYW5TaGFyZVN0eWxlV2l0aEVsZW1lbnQpOgorCisyMDE3LTA3LTA0ICBFbWlsaW8g Q29ib3Mgw4FsdmFyZXogIDxlY29ib3NAaWdhbGlhLmNvbT4KKwogICAgICAgICBQcm9jZXNzaW5n SW5zdHJ1Y3Rpb246OmNsZWFyRXhpc3RpbmdDYWNoZWRTaGVldCBkb2Vzbid0IHJlYWxseSBleGlz dC4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NDE0 NgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZVNoYXJpbmdSZXNvbHZl ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZVNoYXJpbmdSZXNvbHZlci5jcHAKaW5k ZXggYjdhMjg0OTZhZTUyYzg2OTUyMmIxODAyOWQ3MTBiYjc1M2VlMTIwMy4uNDgwZjRkYzczMmFl N2YzNGIyN2VhOGRlOGVmNDU2YmQwYzc4M2E2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv c3R5bGUvU3R5bGVTaGFyaW5nUmVzb2x2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N0eWxl L1N0eWxlU2hhcmluZ1Jlc29sdmVyLmNwcApAQCAtMjkyLDcgKzI5Miw3IEBAIGJvb2wgU2hhcmlu Z1Jlc29sdmVyOjpjYW5TaGFyZVN0eWxlV2l0aEVsZW1lbnQoY29uc3QgQ29udGV4dCYgY29udGV4 dCwgY29uc3QgU3R5CiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogI2lmIEVOQUJMRShGVUxMU0NS RUVOX0FQSSkKLSAgICBpZiAoJmVsZW1lbnQgPT0gbV9kb2N1bWVudC53ZWJraXRDdXJyZW50RnVs bFNjcmVlbkVsZW1lbnQoKSB8fCAmZWxlbWVudCA9PSBtX2RvY3VtZW50LndlYmtpdEN1cnJlbnRG dWxsU2NyZWVuRWxlbWVudCgpKQorICAgIGlmICgmY2FuZGlkYXRlRWxlbWVudCA9PSBtX2RvY3Vt ZW50LndlYmtpdEN1cnJlbnRGdWxsU2NyZWVuRWxlbWVudCgpIHx8ICZlbGVtZW50ID09IG1fZG9j dW1lbnQud2Via2l0Q3VycmVudEZ1bGxTY3JlZW5FbGVtZW50KCkpCiAgICAgICAgIHJldHVybiBm YWxzZTsKICNlbmRpZgogICAgIHJldHVybiB0cnVlOwo=