160195 2016-07-26 05:52:35 -0700 check-for-exit-time-destructors should be usable outside Xcode 2016-07-28 12:56:28 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=22061 https://bugs.webkit.org/show_bug.cgi?id=160302 P2 Normal --- 1 ddkilzer ddkilzer commit-queue darin dbates lforschler oldest_to_newest 1214516 0 284583 ddkilzer 2016-07-26 05:52:35 -0700 Created attachment 284583 WIP Patch It would be nice if check-for-exit-time-destructors was generally usable outside an Xcode build phase script. 1214549 1 284597 ddkilzer 2016-07-26 09:25:17 -0700 Created attachment 284597 Patch v1 1214550 2 ddkilzer 2016-07-26 09:25:52 -0700 (In reply to comment #1) > Created attachment 284597 [details] > Patch v1 Same as "WIP Patch", but with ChangeLog. 1214559 3 ddkilzer 2016-07-26 09:35:06 -0700 (In reply to comment #2) > (In reply to comment #1) > > Created attachment 284597 [details] > > Patch v1 > > Same as "WIP Patch", but with ChangeLog. https://bugs.webkit.org/attachment.cgi?oldid=284583&action=interdiff&newid=284597&headers=1 1214684 4 284597 darin 2016-07-26 14:58:13 -0700 Comment on attachment 284597 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=284597&action=review > Tools/ChangeLog:13 > + * Scripts/check-for-exit-time-destructors: Update to parse > + -h|--help switch, or to take one argument to a binary to check > + for exit time destructors on the command-line. The clang > + compiler will find these at compile-time with the > + -Wexit-time-destructors switch, but this script will check for > + them after-the-fact. Given that -Wexit-time-destructors now exists, do we even need this script at all any more? > Tools/Scripts/check-for-exit-time-destructors:65 > + # Running from Xcode build phase script with no arguments. Maybe this behavior should be triggered by an explicit command line argument instead of by "no arguments". Also, when you try this and none of the environment variables are set, what ends up happening? 1214697 5 284597 commit-queue 2016-07-26 15:05:13 -0700 Comment on attachment 284597 Patch v1 Clearing flags on attachment: 284597 Committed r203742: <http://trac.webkit.org/changeset/203742> 1214698 6 commit-queue 2016-07-26 15:05:18 -0700 All reviewed patches have been landed. Closing bug. 1215102 7 284597 ddkilzer 2016-07-27 17:17:15 -0700 Comment on attachment 284597 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=284597&action=review >> Tools/ChangeLog:13 >> + them after-the-fact. > > Given that -Wexit-time-destructors now exists, do we even need this script at all any more? The script is not referenced in any Xcode project in WebKit anymore, but the script was very useful in checking for exit-time destructors in a compiled binary (see <rdar://problem/27528158>). Not sure if the WebKit project is the right place to host such a script, though. (The check-for-global-initializers script also has a clang warning now.) Thoughts? >> Tools/Scripts/check-for-exit-time-destructors:65 >> + # Running from Xcode build phase script with no arguments. > > Maybe this behavior should be triggered by an explicit command line argument instead of by "no arguments". > > Also, when you try this and none of the environment variables are set, what ends up happening? The script prints a bunch of error messages, then exits without doing anything useful. A command-line switch would make it not spew error messages, which would be a better user experience. 1215232 8 darin 2016-07-28 08:46:34 -0700 I personally think that this script, which is one that I wrote to track progress of the project to eliminate all exit-time destructors from WebKit specifically to help with an iOS-specific issue (see bug 22061), has outlived its usefulness and should be deleted. 1215236 9 darin 2016-07-28 08:56:41 -0700 Oh, and I now see how this script was useful internally at Apple, Dave. I agree, it should be moved somewhere else since it’s not important for building WebKit any more. 1215343 10 ddkilzer 2016-07-28 12:56:28 -0700 (In reply to comment #8) > I personally think that this script, which is one that I wrote to track > progress of the project to eliminate all exit-time destructors from WebKit > specifically to help with an iOS-specific issue (see bug 22061), has > outlived its usefulness and should be deleted. Filed Bug 160302 to track removing the scripts (and using -Wexit-time-destructors, -Wglobal-constructors consistently). In hindsight, maybe I should have separated these two steps, though. (In reply to comment #9) > Oh, and I now see how this script was useful internally at Apple, Dave. I > agree, it should be moved somewhere else since it’s not important for > building WebKit any more. I have an idea about next steps here. More radars forthcoming. :) 284583 2016-07-26 05:52:35 -0700 2016-07-26 09:25:10 -0700 WIP Patch fix-check-for-exit-time-destructors.diff text/plain 4720 ddkilzer ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvY2hlY2stZm9yLWV4aXQtdGltZS1kZXN0cnVjdG9y cyBiL1Rvb2xzL1NjcmlwdHMvY2hlY2stZm9yLWV4aXQtdGltZS1kZXN0cnVjdG9ycwppbmRleCA0 ZjdiZjNmLi5iOTVhZWMwIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL2NoZWNrLWZvci1leGl0 LXRpbWUtZGVzdHJ1Y3RvcnMKKysrIGIvVG9vbHMvU2NyaXB0cy9jaGVjay1mb3ItZXhpdC10aW1l LWRlc3RydWN0b3JzCkBAIC0xLDMwICsxLDI2IEBACiAjIS91c3IvYmluL3BlcmwKIAotIyBDb3B5 cmlnaHQgKEMpIDIwMDYsIDIwMDcsIDIwMDggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVk LgorIyBDb3B5cmlnaHQgKEMpIDIwMDYtMjAwOCwgMjAxNiBBcHBsZSBJbmMuIEFsbCByaWdodHMg cmVzZXJ2ZWQuCiAjCiAjIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5h cnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogIyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQg cHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKICMgYXJlIG1ldDoKLSMKICMg MS4gIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUg Y29weXJpZ2h0Ci0jICAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUg Zm9sbG93aW5nIGRpc2NsYWltZXIuIAorIyAgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0 aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgogIyAyLiAgUmVkaXN0cmlidXRpb25z IGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKICMgICAg IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xh aW1lciBpbiB0aGUKLSMgICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBw cm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uIAotIyAzLiAgTmVpdGhlciB0aGUgbmFtZSBv ZiBBcHBsZSBJbmMuICgiQXBwbGUiKSBub3IgdGhlIG5hbWVzIG9mCi0jICAgICBpdHMgY29udHJp YnV0b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ugb3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVk Ci0jICAgICBmcm9tIHRoaXMgc29mdHdhcmUgd2l0aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVu IHBlcm1pc3Npb24uIAorIyAgICAgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxz IHByb3ZpZGVkIHdpdGggdGhlIGRpc3RyaWJ1dGlvbi4KICMKLSMgVEhJUyBTT0ZUV0FSRSBJUyBQ Uk9WSURFRCBCWSBBUFBMRSBBTkQgSVRTIENPTlRSSUJVVE9SUyAiQVMgSVMiIEFORCBBTlkKKyMg VEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBJTkMuIEFORCBJVFMgQ09OVFJJQlVU T1JTIGBgQVMgSVMnJyBBTkQgQU5ZCiAjIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJ TkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgVEhFIElNUExJRUQKICMgV0FSUkFOVElFUyBP RiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFS RQotIyBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBPUiBJVFMgQ09OVFJJQlVU T1JTIEJFIExJQUJMRSBGT1IgQU5ZCisjIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIEFQ UExFIElOQy4gT1IgSVRTIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWQogIyBESVJFQ1Qs IElORElSRUNULCBJTkNJREVOVEFMLCBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJ QUwgREFNQUdFUwogIyAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFBST0NVUkVNRU5U IE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7Ci0jIExPU1MgT0YgVVNFLCBEQVRBLCBP UiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORAot IyBPTiBBTlkgVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNU IExJQUJJTElUWSwgT1IgVE9SVAotIyAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNF KSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UgT0YKLSMgVEhJUyBTT0ZUV0FSRSwg RVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKyMgTE9T UyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9X RVZFUiBDQVVTRUQgQU5EIE9OCisjIEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElO IENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisjIChJTkNMVURJTkcgTkVHTElH RU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRSBPRiBU SElTCisjIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNV Q0ggREFNQUdFLgogCiAjICJjaGVjay1mb3ItZXhpdC10aW1lLWRlc3RydWN0b3JzIiBzY3JpcHQg Zm9yIFdlYktpdCBPcGVuIFNvdXJjZSBQcm9qZWN0CiAKQEAgLTM1LDM0ICszMSw1NSBAQCB1c2Ug d2FybmluZ3M7CiB1c2Ugc3RyaWN0OwogCiB1c2UgRmlsZTo6QmFzZW5hbWU7Cit1c2UgRmlsZTo6 U3BlYzsKK3VzZSBHZXRvcHQ6Okxvbmc7CiAKIHN1YiB0b3VjaCgkKTsKIHN1YiBwcmludEZ1bmN0 aW9ucygkJCk7CiAKLW15ICRhcmNoID0gJEVOVnsnQ1VSUkVOVF9BUkNIJ307Ci1teSAkY29uZmln dXJhdGlvbiA9ICRFTlZ7J0NPTkZJR1VSQVRJT04nfTsKLW15ICR0YXJnZXQgPSAkRU5WeydUQVJH RVRfTkFNRSd9OwotbXkgJHZhcmlhbnQgPSAkRU5WeydDVVJSRU5UX1ZBUklBTlQnfTsKLW15ICRj b3ZlcmFnZUJ1aWxkID0gJEVOVnsnV0VCS0lUX0NPVkVSQUdFX0JVSUxEJ307Ci1teSAkZGVidWdS b290ID0gJEVOVnsnV0VCS0lUX0RFQlVHX1JPT1QnfTsKK215ICRjb3ZlcmFnZUJ1aWxkOworbXkg JGV4ZWN1dGFibGVQYXRoOworbXkgQGZpbGVzOworbXkgJHNob3dIZWxwOworbXkgJHRlbXBEaXI7 CisKK2lmIChAQVJHVikgeworICAgICMgUnVubmluZyBpbiBpbnRlcmFjdGl2ZSBtb2RlIHdpdGgg YXJndW1lbnRzLgorICAgIG15ICRyZXN1bHQgPSBHZXRPcHRpb25zKAorICAgICAgICAiaHxoZWxw IiA9PiBcJHNob3dIZWxwLAorICAgICk7CisgICAgJGV4ZWN1dGFibGVQYXRoID0gZ2xvYihzaGlm dCBAQVJHVik7CisKKyAgICBpZiAoISRyZXN1bHQgfHwgJHNob3dIZWxwIHx8IEBBUkdWID4gMCkg eworICAgICAgICBwcmludCBTVERFUlIgIkNoZWNrIGZvciBleGl0LXRpbWUgZGVzdHJ1Y3RvcnMu XG4iOworICAgICAgICBwcmludCBTVERFUlIgIlVzYWdlOiAiIC4gYmFzZW5hbWUoJDApIC4gIiBb b3B0aW9uc10gcGF0aC90by9leGVjdXRhYmxlXG4iOworICAgICAgICBwcmludCBTVERFUlIgPDxF TkQ7CisgIFstaHwtLWhlbHBdICAgICAgICAgICAgICAgICAgICBzaG93IHRoaXMgaGVscCBtZXNz YWdlCitFTkQKKyAgICAgICAgZXhpdCAxOworICAgIH0KIAotbXkgJGV4ZWN1dGFibGVQYXRoID0g IiRFTlZ7J1RBUkdFVF9CVUlMRF9ESVInfS8kRU5WeydFWEVDVVRBQkxFX1BBVEgnfSI7CisgICAg JHRlbXBEaXIgPSBGaWxlOjpTcGVjLT50bXBkaXIoKTsKKyAgICBAZmlsZXMgPSAoJGV4ZWN1dGFi bGVQYXRoKTsKK30gZWxzZSB7CisgICAgIyBSdW5uaW5nIGZyb20gWGNvZGUgYnVpbGQgcGhhc2Ug c2NyaXB0IHdpdGggbm8gYXJndW1lbnRzLgorICAgICRjb3ZlcmFnZUJ1aWxkID0gJEVOVnsnV0VC S0lUX0NPVkVSQUdFX0JVSUxEJ307CisgICAgJGV4ZWN1dGFibGVQYXRoID0gIiRFTlZ7J1RBUkdF VF9CVUlMRF9ESVInfS8kRU5WeydFWEVDVVRBQkxFX1BBVEgnfSI7CisgICAgJHRlbXBEaXIgPSAk RU5WeydUQVJHRVRfVEVNUF9ESVInfTsKKworICAgIG15ICRhcmNoID0gJEVOVnsnQ1VSUkVOVF9B UkNIJ307CisgICAgbXkgJHZhcmlhbnQgPSAkRU5WeydDVVJSRU5UX1ZBUklBTlQnfTsKKyAgICBt eSAkbGlzdCA9ICRFTlZ7IkxJTktfRklMRV9MSVNUXyR7dmFyaWFudH1fJHthcmNofSJ9OworICAg IG9wZW4gTElTVCwgJGxpc3QgfHwgZGllICJFUlJPUjogQ291bGQgbm90IG9wZW4gJGxpc3RcbiI7 CisgICAgQGZpbGVzID0gPExJU1Q+OworICAgIGNob21wIEBmaWxlczsKKyAgICBjbG9zZSBMSVNU OworfQogCi1teSAkYnVpbGRUaW1lc3RhbXBQYXRoID0gJEVOVnsnVEFSR0VUX1RFTVBfRElSJ30g LiAiLyIgLiBiYXNlbmFtZSgkMCkgLiAiLnRpbWVzdGFtcCI7CitteSAkYnVpbGRUaW1lc3RhbXBQ YXRoID0gRmlsZTo6U3BlYy0+Y2F0ZmlsZSgkdGVtcERpciwgYmFzZW5hbWUoJDApIC4gIi50aW1l c3RhbXAiKTsKIG15ICRidWlsZFRpbWVzdGFtcEFnZSA9IC1NICRidWlsZFRpbWVzdGFtcFBhdGg7 CiBteSAkc2NyaXB0QWdlID0gLU0gJDA7CiAKLW15ICRsaXN0ID0gJEVOVnsiTElOS19GSUxFX0xJ U1RfJHt2YXJpYW50fV8ke2FyY2h9In07Ci0KLWlmICghb3BlbiBMSVNULCAkbGlzdCkgewotICAg IHByaW50ICJFUlJPUjogQ291bGQgbm90IG9wZW4gJGxpc3RcbiI7Ci0gICAgZXhpdCAxOwotfQot Ci1teSBAZmlsZXMgPSA8TElTVD47Ci1jaG9tcCBAZmlsZXM7Ci1jbG9zZSBMSVNUOwotCiBteSAk c2F3RXJyb3IgPSAwOwogCiBmb3IgbXkgJGZpbGUgKHNvcnQgQGZpbGVzKSB7Cg== 284597 2016-07-26 09:25:17 -0700 2016-07-26 15:05:13 -0700 Patch v1 bug-160195-20160726092408.patch text/plain 5724 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzNzAxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTNjNzdlNmIyMWU1NTRmODFmZTEzOTk5OTY0ZGRjMDc2 YWQxOWM0My4uMDZhOTM5MTFiZWIzZDQ3MDNkNGU4OTM5YzYwM2U0MTVlMmFmMDg3OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE2LTA3LTI2ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgY2hlY2stZm9yLWV4aXQtdGltZS1kZXN0cnVjdG9ycyBzaG91bGQgYmUgdXNhYmxlIG91 dHNpZGUgWGNvZGUKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE2MDE5NT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvY2hl Y2stZm9yLWV4aXQtdGltZS1kZXN0cnVjdG9yczogVXBkYXRlIHRvIHBhcnNlCisgICAgICAgIC1o fC0taGVscCBzd2l0Y2gsIG9yIHRvIHRha2Ugb25lIGFyZ3VtZW50IHRvIGEgYmluYXJ5IHRvIGNo ZWNrCisgICAgICAgIGZvciBleGl0IHRpbWUgZGVzdHJ1Y3RvcnMgb24gdGhlIGNvbW1hbmQtbGlu ZS4gIFRoZSBjbGFuZworICAgICAgICBjb21waWxlciB3aWxsIGZpbmQgdGhlc2UgYXQgY29tcGls ZS10aW1lIHdpdGggdGhlCisgICAgICAgIC1XZXhpdC10aW1lLWRlc3RydWN0b3JzIHN3aXRjaCwg YnV0IHRoaXMgc2NyaXB0IHdpbGwgY2hlY2sgZm9yCisgICAgICAgIHRoZW0gYWZ0ZXItdGhlLWZh Y3QuCisKIDIwMTYtMDctMjUgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAg ICAgICAgIE1vZGVybiBJREI6IE1ha2Ugc3VyZSBJbmRleGVkREIgd29ya3MgZnJvbSBmaWxlOi8v IHVybCBkb2N1bWVudHMgYnkgZGVmYXVsdApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9jaGVj ay1mb3ItZXhpdC10aW1lLWRlc3RydWN0b3JzIGIvVG9vbHMvU2NyaXB0cy9jaGVjay1mb3ItZXhp dC10aW1lLWRlc3RydWN0b3JzCmluZGV4IDRmN2JmM2ZmYTBjMzliNzlhZjFmNjdlOWMyZWUxZmM4 NzIwZmFiMDYuLmI5NWFlYzAzNjRhZjhlNGEwMTNhMzA4ZDM2MzgwMjkxYjRiNzVlYmEgMTAwNzU1 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvY2hlY2stZm9yLWV4aXQtdGltZS1kZXN0cnVjdG9ycworKysg Yi9Ub29scy9TY3JpcHRzL2NoZWNrLWZvci1leGl0LXRpbWUtZGVzdHJ1Y3RvcnMKQEAgLTEsMzAg KzEsMjYgQEAKICMhL3Vzci9iaW4vcGVybAogCi0jIENvcHlyaWdodCAoQykgMjAwNiwgMjAwNywg MjAwOCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjIENvcHlyaWdodCAoQykgMjAw Ni0yMDA4LCAyMDE2IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMKICMgUmVkaXN0 cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRo b3V0CiAjIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xs b3dpbmcgY29uZGl0aW9ucwogIyBhcmUgbWV0OgotIwogIyAxLiAgUmVkaXN0cmlidXRpb25zIG9m IHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKLSMgICAgIG5vdGlj ZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4g CisjICAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5n IGRpc2NsYWltZXIuCiAjIDIuICBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCBy ZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAogIyAgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2Yg Y29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyIGluIHRoZQotIyAgICAgZG9j dW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlIGRpc3Ry aWJ1dGlvbi4gCi0jIDMuICBOZWl0aGVyIHRoZSBuYW1lIG9mIEFwcGxlIEluYy4gKCJBcHBsZSIp IG5vciB0aGUgbmFtZXMgb2YKLSMgICAgIGl0cyBjb250cmlidXRvcnMgbWF5IGJlIHVzZWQgdG8g ZW5kb3JzZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQKLSMgICAgIGZyb20gdGhpcyBzb2Z0 d2FyZSB3aXRob3V0IHNwZWNpZmljIHByaW9yIHdyaXR0ZW4gcGVybWlzc2lvbi4gCisjICAgICBk b2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlz dHJpYnV0aW9uLgogIwotIyBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIEFQUExFIEFORCBJ VFMgQ09OVFJJQlVUT1JTICJBUyBJUyIgQU5EIEFOWQorIyBUSElTIFNPRlRXQVJFIElTIFBST1ZJ REVEIEJZIEFQUExFIElOQy4gQU5EIElUUyBDT05UUklCVVRPUlMgYGBBUyBJUycnIEFORCBBTlkK ICMgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVCBMSU1J VEVEIFRPLCBUSEUgSU1QTElFRAogIyBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQg RklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFCi0jIERJU0NMQUlNRUQuIElOIE5P IEVWRU5UIFNIQUxMIEFQUExFIE9SIElUUyBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkK KyMgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgSU5DLiBPUiBJVFMgQ09OVFJJ QlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZCiAjIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUws IFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTCiAjIChJTkNMVURJ TkcsIEJVVCBOT1QgTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBP UiBTRVJWSUNFUzsKLSMgTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNT IElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5ECi0jIE9OIEFOWSBUSEVPUlkgT0YgTElB QklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCi0j IChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBP VVQgT0YgVEhFIFVTRSBPRgotIyBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhF IFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorIyBMT1NTIE9GIFVTRSwgREFUQSwgT1IgUFJP RklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04KKyMg QU5ZIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFC SUxJVFksIE9SIFRPUlQKKyMgKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJ U0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9GIFRISVMKKyMgU09GVFdBUkUsIEVWRU4g SUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAKICMgImNoZWNr LWZvci1leGl0LXRpbWUtZGVzdHJ1Y3RvcnMiIHNjcmlwdCBmb3IgV2ViS2l0IE9wZW4gU291cmNl IFByb2plY3QKIApAQCAtMzUsMzQgKzMxLDU1IEBAIHVzZSB3YXJuaW5nczsKIHVzZSBzdHJpY3Q7 CiAKIHVzZSBGaWxlOjpCYXNlbmFtZTsKK3VzZSBGaWxlOjpTcGVjOwordXNlIEdldG9wdDo6TG9u ZzsKIAogc3ViIHRvdWNoKCQpOwogc3ViIHByaW50RnVuY3Rpb25zKCQkKTsKIAotbXkgJGFyY2gg PSAkRU5WeydDVVJSRU5UX0FSQ0gnfTsKLW15ICRjb25maWd1cmF0aW9uID0gJEVOVnsnQ09ORklH VVJBVElPTid9OwotbXkgJHRhcmdldCA9ICRFTlZ7J1RBUkdFVF9OQU1FJ307Ci1teSAkdmFyaWFu dCA9ICRFTlZ7J0NVUlJFTlRfVkFSSUFOVCd9OwotbXkgJGNvdmVyYWdlQnVpbGQgPSAkRU5WeydX RUJLSVRfQ09WRVJBR0VfQlVJTEQnfTsKLW15ICRkZWJ1Z1Jvb3QgPSAkRU5WeydXRUJLSVRfREVC VUdfUk9PVCd9OworbXkgJGNvdmVyYWdlQnVpbGQ7CitteSAkZXhlY3V0YWJsZVBhdGg7CitteSBA ZmlsZXM7CitteSAkc2hvd0hlbHA7CitteSAkdGVtcERpcjsKKworaWYgKEBBUkdWKSB7CisgICAg IyBSdW5uaW5nIGluIGludGVyYWN0aXZlIG1vZGUgd2l0aCBhcmd1bWVudHMuCisgICAgbXkgJHJl c3VsdCA9IEdldE9wdGlvbnMoCisgICAgICAgICJofGhlbHAiID0+IFwkc2hvd0hlbHAsCisgICAg KTsKKyAgICAkZXhlY3V0YWJsZVBhdGggPSBnbG9iKHNoaWZ0IEBBUkdWKTsKKworICAgIGlmICgh JHJlc3VsdCB8fCAkc2hvd0hlbHAgfHwgQEFSR1YgPiAwKSB7CisgICAgICAgIHByaW50IFNUREVS UiAiQ2hlY2sgZm9yIGV4aXQtdGltZSBkZXN0cnVjdG9ycy5cbiI7CisgICAgICAgIHByaW50IFNU REVSUiAiVXNhZ2U6ICIgLiBiYXNlbmFtZSgkMCkgLiAiIFtvcHRpb25zXSBwYXRoL3RvL2V4ZWN1 dGFibGVcbiI7CisgICAgICAgIHByaW50IFNUREVSUiA8PEVORDsKKyAgWy1ofC0taGVscF0gICAg ICAgICAgICAgICAgICAgIHNob3cgdGhpcyBoZWxwIG1lc3NhZ2UKK0VORAorICAgICAgICBleGl0 IDE7CisgICAgfQogCi1teSAkZXhlY3V0YWJsZVBhdGggPSAiJEVOVnsnVEFSR0VUX0JVSUxEX0RJ Uid9LyRFTlZ7J0VYRUNVVEFCTEVfUEFUSCd9IjsKKyAgICAkdGVtcERpciA9IEZpbGU6OlNwZWMt PnRtcGRpcigpOworICAgIEBmaWxlcyA9ICgkZXhlY3V0YWJsZVBhdGgpOworfSBlbHNlIHsKKyAg ICAjIFJ1bm5pbmcgZnJvbSBYY29kZSBidWlsZCBwaGFzZSBzY3JpcHQgd2l0aCBubyBhcmd1bWVu dHMuCisgICAgJGNvdmVyYWdlQnVpbGQgPSAkRU5WeydXRUJLSVRfQ09WRVJBR0VfQlVJTEQnfTsK KyAgICAkZXhlY3V0YWJsZVBhdGggPSAiJEVOVnsnVEFSR0VUX0JVSUxEX0RJUid9LyRFTlZ7J0VY RUNVVEFCTEVfUEFUSCd9IjsKKyAgICAkdGVtcERpciA9ICRFTlZ7J1RBUkdFVF9URU1QX0RJUid9 OworCisgICAgbXkgJGFyY2ggPSAkRU5WeydDVVJSRU5UX0FSQ0gnfTsKKyAgICBteSAkdmFyaWFu dCA9ICRFTlZ7J0NVUlJFTlRfVkFSSUFOVCd9OworICAgIG15ICRsaXN0ID0gJEVOVnsiTElOS19G SUxFX0xJU1RfJHt2YXJpYW50fV8ke2FyY2h9In07CisgICAgb3BlbiBMSVNULCAkbGlzdCB8fCBk aWUgIkVSUk9SOiBDb3VsZCBub3Qgb3BlbiAkbGlzdFxuIjsKKyAgICBAZmlsZXMgPSA8TElTVD47 CisgICAgY2hvbXAgQGZpbGVzOworICAgIGNsb3NlIExJU1Q7Cit9CiAKLW15ICRidWlsZFRpbWVz dGFtcFBhdGggPSAkRU5WeydUQVJHRVRfVEVNUF9ESVInfSAuICIvIiAuIGJhc2VuYW1lKCQwKSAu ICIudGltZXN0YW1wIjsKK215ICRidWlsZFRpbWVzdGFtcFBhdGggPSBGaWxlOjpTcGVjLT5jYXRm aWxlKCR0ZW1wRGlyLCBiYXNlbmFtZSgkMCkgLiAiLnRpbWVzdGFtcCIpOwogbXkgJGJ1aWxkVGlt ZXN0YW1wQWdlID0gLU0gJGJ1aWxkVGltZXN0YW1wUGF0aDsKIG15ICRzY3JpcHRBZ2UgPSAtTSAk MDsKIAotbXkgJGxpc3QgPSAkRU5WeyJMSU5LX0ZJTEVfTElTVF8ke3ZhcmlhbnR9XyR7YXJjaH0i fTsKLQotaWYgKCFvcGVuIExJU1QsICRsaXN0KSB7Ci0gICAgcHJpbnQgIkVSUk9SOiBDb3VsZCBu b3Qgb3BlbiAkbGlzdFxuIjsKLSAgICBleGl0IDE7Ci19Ci0KLW15IEBmaWxlcyA9IDxMSVNUPjsK LWNob21wIEBmaWxlczsKLWNsb3NlIExJU1Q7Ci0KIG15ICRzYXdFcnJvciA9IDA7CiAKIGZvciBt eSAkZmlsZSAoc29ydCBAZmlsZXMpIHsK