160193 2016-07-26 05:05:36 -0700 ASSERTION FAILED: !m_frame->page()->defersLoading() || InspectorInstrumentation::isDebuggerPaused(m_frame) 2016-07-26 09:30:27 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 1 cgarcia webkit-unassigned achristensen beidson bugs-noreply cdumez commit-queue darin japhet oldest_to_newest 1214503 0 cgarcia 2016-07-26 05:05:36 -0700 This is happening in the GTK+ Debug bot when running test loader/load-defer.html (note that the assert is inside an !USE(CF) block). The test is creating an iframe with load deferred, then in a timeout it disables the deferred load and checks that the load actually happens. What happens is that the initial empty document is what calls DocumentLoader::finishedLoading() when load is still deferred. The onload handler is not called because load events are disabled for the initial empty document in SubframeLoader::loadSubframe(), but DocumentLoader::finishedLoading() is called unconditionally from maybeLoadEmpty(). I think it's fine to call DocumentLoader::finishedLoading() for the initial empty document even when load is deferred, so we can simply update the assert to handle that case. 1214504 1 cgarcia 2016-07-26 05:05:50 -0700 STDERR: ASSERTION FAILED: !m_frame->page()->defersLoading() || InspectorInstrumentation::isDebuggerPaused(m_frame) STDERR: ../../Source/WebCore/loader/DocumentLoader.cpp(401) : void WebCore::DocumentLoader::finishedLoading(double) STDERR: 1 0x7f73c3136c2f /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(WTFCrash+0x1e) [0x7f73c3136c2f] STDERR: 2 0x7f73ca8dd34d /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::DocumentLoader::finishedLoading(double)+0x79) [0x7f73ca8dd34d] STDERR: 3 0x7f73ca8e25d4 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::DocumentLoader::maybeLoadEmpty()+0x35a) [0x7f73ca8e25d4] STDERR: 4 0x7f73ca8e27aa /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::DocumentLoader::startLoadingMainResource()+0x100) [0x7f73ca8e27aa] STDERR: 5 0x7f73ca8ffed7 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::FrameLoader::init()+0x12d) [0x7f73ca8ffed7] STDERR: 6 0x7f73c9a56466 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::Frame::init()+0x1e) [0x7f73c9a56466] STDERR: 7 0x7f73c9a5348b /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebKit::WebFrame::createSubframe(WebKit::WebPage*, WTF::String const&, WebCore::HTMLFrameOwnerElement*)+0x1f7) [0x7f73c9a5348b] STDERR: 8 0x7f73c9a251e7 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebKit::WebFrameLoaderClient::createFrame(WebCore::URL const&, WTF::String const&, WebCore::HTMLFrameOwnerElement*, WTF::String const&, bool, int, int)+0x53) [0x7f73c9a251e7] STDERR: 9 0x7f73ca94aa20 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::SubframeLoader::loadSubframe(WebCore::HTMLFrameOwnerElement&, WebCore::URL const&, WTF::String const&, WTF::String const&)+0x1cc) [0x7f73ca94aa20] STDERR: 10 0x7f73ca94a77a /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::SubframeLoader::loadOrRedirectSubframe(WebCore::HTMLFrameOwnerElement&, WebCore::URL const&, WTF::AtomicString const&, WebCore::LockHistory, WebCore::LockBackForwardList)+0x18a) [0x7f73ca94a77a] STDERR: 11 0x7f73ca949312 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::SubframeLoader::requestFrame(WebCore::HTMLFrameOwnerElement&, WTF::String const&, WTF::AtomicString const&, WebCore::LockHistory, WebCore::LockBackForwardList)+0x194) [0x7f73ca949312] STDERR: 12 0x7f73ca66cd4d /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::HTMLFrameElementBase::openURL(WebCore::LockHistory, WebCore::LockBackForwardList)+0xf9) [0x7f73ca66cd4d] STDERR: 13 0x7f73ca66d106 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::HTMLFrameElementBase::setNameAndOpenURL()+0x7a) [0x7f73ca66d106] STDERR: 14 0x7f73ca66d1d3 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::HTMLFrameElementBase::finishedInsertingSubtree()+0x89) [0x7f73ca66d1d3] STDERR: 15 0x7f73ca3a2224 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::ContainerNode::notifyChildInserted(WebCore::Node&, WebCore::ContainerNode::ChildChangeSource)+0x17a) [0x7f73ca3a2224] STDERR: 16 0x7f73ca3a45c5 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::ContainerNode::updateTreeAfterInsertion(WebCore::Node&)+0x61) [0x7f73ca3a45c5] STDERR: 17 0x7f73ca3a375a /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::ContainerNode::appendChild(WebCore::Node&, int&)+0x29c) [0x7f73ca3a375a] STDERR: 18 0x7f73ca48d38e /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::Node::appendChild(WebCore::Node&, int&)+0x5a) [0x7f73ca48d38e] STDERR: 19 0x7f73ca0f1098 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::JSNode::appendChild(JSC::ExecState&)+0xa8) [0x7f73ca0f1098] STDERR: 20 0x7f73cb6ce227 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::jsNodePrototypeFunctionAppendChild(JSC::ExecState*)+0x141) [0x7f73cb6ce227] STDERR: 21 0x7f73721fe028 [0x7f73721fe028] 1214505 2 284578 cgarcia 2016-07-26 05:09:04 -0700 Created attachment 284578 Patch 1214554 3 cgarcia 2016-07-26 09:30:27 -0700 Committed r203723: <http://trac.webkit.org/changeset/203723> 284578 2016-07-26 05:09:04 -0700 2016-07-26 07:01:02 -0700 Patch wcore-load-defer-crash.diff text/plain 2418 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkN2Y0NTZjLi45Yzk1ZTQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTYtMDctMjYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIEFTU0VSVElPTiBGQUlMRUQ6ICFtX2ZyYW1lLT5wYWdlKCktPmRlZmVyc0xv YWRpbmcoKSB8fCBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OmlzRGVidWdnZXJQYXVzZWQobV9m cmFtZSkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2 MDE5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo aXMgaXMgaGFwcGVuaW5nIGluIHRoZSBHVEsrIERlYnVnIGJvdCB3aGVuIHJ1bm5pbmcgdGVzdCBs b2FkZXIvbG9hZC1kZWZlci5odG1sIChub3RlIHRoYXQgdGhlIGFzc2VydCBpcyBpbnNpZGUKKyAg ICAgICAgYSAhVVNFKENGKSBibG9jaykuCisgICAgICAgIFRoZSB0ZXN0IGlzIGNyZWF0aW5nIGFu IGlmcmFtZSB3aXRoIGxvYWQgZGVmZXJyZWQsIHRoZW4gaW4gYSB0aW1lb3V0IGl0IGRpc2FibGVz IHRoZSBkZWZlcnJlZCBsb2FkIGFuZCBjaGVja3MKKyAgICAgICAgdGhhdCB0aGUgbG9hZCBhY3R1 YWxseSBoYXBwZW5zLiBXaGF0IGhhcHBlbnMgaXMgdGhhdCB0aGUgaW5pdGlhbCBlbXB0eSBkb2N1 bWVudCBpcyB3aGF0IGNhbGxzCisgICAgICAgIERvY3VtZW50TG9hZGVyOjpmaW5pc2hlZExvYWRp bmcoKSB3aGVuIGxvYWQgaXMgc3RpbGwgZGVmZXJyZWQuIFRoZSBvbmxvYWQgaGFuZGxlciBpcyBu b3QgY2FsbGVkIGJlY2F1c2UgbG9hZAorICAgICAgICBldmVudHMgYXJlIGRpc2FibGVkIGZvciB0 aGUgaW5pdGlhbCBlbXB0eSBkb2N1bWVudCBpbiBTdWJmcmFtZUxvYWRlcjo6bG9hZFN1YmZyYW1l KCksIGJ1dAorICAgICAgICBEb2N1bWVudExvYWRlcjo6ZmluaXNoZWRMb2FkaW5nKCkgaXMgY2Fs bGVkIHVuY29uZGl0aW9uYWxseSBmcm9tIG1heWJlTG9hZEVtcHR5KCkuIEkgdGhpbmsgaXQncyBm aW5lIHRvIGNhbGwKKyAgICAgICAgRG9jdW1lbnRMb2FkZXI6OmZpbmlzaGVkTG9hZGluZygpIGZv ciB0aGUgaW5pdGlhbCBlbXB0eSBkb2N1bWVudCBldmVuIHdoZW4gbG9hZCBpcyBkZWZlcnJlZCwg c28gd2UgY2FuIHNpbXBseQorICAgICAgICB1cGRhdGUgdGhlIGFzc2VydCB0byBoYW5kbGUgdGhh dCBjYXNlLgorCisgICAgICAgICogbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkRvY3VtZW50TG9hZGVyOjpmaW5pc2hlZExvYWRpbmcpOiBEbyBub3QgYXNzZXJ0 IGlmIGNhbGxlZCBmb3IgdGhlIGluaXRpYWwgZW1wdHkgZG9jdW1lbnQgd2hlbiBsb2FkIGlzCisg ICAgICAgIGRlZmVycmVkLgorCiAyMDE2LTA3LTI1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBs ZS5jb20+CiAKICAgICAgICAgU2Vjb25kIHBhcmFtZXRlciB0byBSYW5nZS5zZXRTdGFydCgpIC8g c2V0RW5kKCkgc2hvdWxkIGJlIG1hbmRhdG9yeQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv bG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVu dExvYWRlci5jcHAKaW5kZXggODAxODE3Yi4uYzJiZDEwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvRG9jdW1lbnRMb2FkZXIuY3BwCkBAIC0zOTgsNyArMzk4LDcgQEAgdm9pZCBEb2N1bWVudExv YWRlcjo6ZmluaXNoZWRMb2FkaW5nKGRvdWJsZSBmaW5pc2hUaW1lKQogICAgIC8vIFRoZXJlIGlz IGEgYnVnIGluIENGTmV0d29yayB3aGVyZSBjYWxsYmFja3MgY2FuIGJlIGRpc3BhdGNoZWQgZXZl biB3aGVuIGxvYWRzIGFyZSBkZWZlcnJlZC4KICAgICAvLyBTZWUgPHJkYXI6Ly9wcm9ibGVtLzYz MDQ2MDA+IGZvciBtb3JlIGRldGFpbHMuCiAjaWYgIVVTRShDRikKLSAgICBBU1NFUlQoIW1fZnJh bWUtPnBhZ2UoKS0+ZGVmZXJzTG9hZGluZygpIHx8IEluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6 aXNEZWJ1Z2dlclBhdXNlZChtX2ZyYW1lKSk7CisgICAgQVNTRVJUKCFtX2ZyYW1lLT5wYWdlKCkt PmRlZmVyc0xvYWRpbmcoKSB8fCBmcmFtZUxvYWRlcigpLT5zdGF0ZU1hY2hpbmUoKS5jcmVhdGlu Z0luaXRpYWxFbXB0eURvY3VtZW50KCkgfHwgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjppc0Rl YnVnZ2VyUGF1c2VkKG1fZnJhbWUpKTsKICNlbmRpZgogCiAgICAgUmVmPERvY3VtZW50TG9hZGVy PiBwcm90ZWN0ZWRUaGlzKCp0aGlzKTsK