160188 2016-07-25 23:49:13 -0700 Database Process: ASSERTION FAILED: paths.size() == handles.size() with SANDBOX_EXTENSIONS disabled 2016-08-01 01:05:31 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=160398 LayoutTestFailure P2 Normal --- 1 cgarcia webkit-unassigned achristensen beidson cdumez oldest_to_newest 1214473 0 cgarcia 2016-07-25 23:49:13 -0700 This happens in ports with sandbox extensions disabled, and it's making several tests to crash in debug builds. The SandboxExtension implementation is empty in case of building with sandbox extensions disabled, so that we are actually allocating no extensions at all in NetworkProcessProxy::grantSandboxExtensionsToDatabaseProcessForBlobs(). When the message arrives to database process, we have a list of paths, but an empty list of hanldes which causes the assertion. We can just avoid that message entirely in case of building without sandbox extensions. 1214474 1 284567 cgarcia 2016-07-25 23:54:02 -0700 Created attachment 284567 Patch 1215216 2 beidson 2016-07-28 06:19:52 -0700 Yup looks good. 1215491 3 cgarcia 2016-07-28 22:17:27 -0700 Committed r203856: <http://trac.webkit.org/changeset/203856> 284567 2016-07-25 23:54:02 -0700 2016-07-28 01:50:47 -0700 Patch wk2-database-process-crash.diff text/plain 5612 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjNWE4NTJhLi5iMDg5YTIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjUg QEAKIDIwMTYtMDctMjUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIERhdGFiYXNlIFByb2Nlc3M6IEFTU0VSVElPTiBGQUlMRUQ6IHBhdGhzLnNp emUoKSA9PSBoYW5kbGVzLnNpemUoKSB3aXRoIFNBTkRCT1hfRVhURU5TSU9OUyBkaXNhYmxlZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwMTg4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBoYXBw ZW5zIGluIHBvcnRzIHdpdGggc2FuZGJveCBleHRlbnNpb25zIGRpc2FibGVkLCBhbmQgaXQncyBt YWtpbmcgc2V2ZXJhbCB0ZXN0cyB0byBjcmFzaCBpbiBkZWJ1ZworICAgICAgICBidWlsZHMuIFRo ZSBTYW5kYm94RXh0ZW5zaW9uIGltcGxlbWVudGF0aW9uIGlzIGVtcHR5IGluIGNhc2Ugb2YgYnVp bGRpbmcgd2l0aCBzYW5kYm94IGV4dGVuc2lvbnMgZGlzYWJsZWQsIHNvCisgICAgICAgIHRoYXQg d2UgYXJlIGFjdHVhbGx5IGFsbG9jYXRpbmcgbm8gZXh0ZW5zaW9ucyBhdCBhbGwgaW4KKyAgICAg ICAgTmV0d29ya1Byb2Nlc3NQcm94eTo6Z3JhbnRTYW5kYm94RXh0ZW5zaW9uc1RvRGF0YWJhc2VQ cm9jZXNzRm9yQmxvYnMoKS4gV2hlbiB0aGUgbWVzc2FnZSBhcnJpdmVzIHRvIGRhdGFiYXNlCisg ICAgICAgIHByb2Nlc3MsIHdlIGhhdmUgYSBsaXN0IG9mIHBhdGhzLCBidXQgYW4gZW1wdHkgbGlz dCBvZiBoYW5sZGVzIHdoaWNoIGNhdXNlcyB0aGUgYXNzZXJ0aW9uLiBXZSBjYW4ganVzdCBhdm9p ZAorICAgICAgICB0aGF0IG1lc3NhZ2UgZW50aXJlbHkgaW4gY2FzZSBvZiBidWlsZGluZyB3aXRo b3V0IHNhbmRib3ggZXh0ZW5zaW9ucy4KKworICAgICAgICAqIERhdGFiYXNlUHJvY2Vzcy9EYXRh YmFzZVByb2Nlc3MuY3BwOgorICAgICAgICAqIERhdGFiYXNlUHJvY2Vzcy9EYXRhYmFzZVByb2Nl c3MuaDoKKyAgICAgICAgKiBEYXRhYmFzZVByb2Nlc3MvRGF0YWJhc2VQcm9jZXNzLm1lc3NhZ2Vz LmluOgorICAgICAgICAqIFVJUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9jZXNzUHJveHkuY3Bw OgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUHJvY2Vzc1Byb3h5OjpncmFudFNhbmRib3hFeHRl bnNpb25zVG9EYXRhYmFzZVByb2Nlc3NGb3JCbG9icyk6CisKKzIwMTYtMDctMjUgIENhcmxvcyBH YXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtDb29yZGluYXRl ZCBHcmFwaGljc10gVGVzdCBmYXN0L2ZpeGVkLWxheW91dC9maXhlZC1sYXlvdXQuaHRtbCBjcmFz aGVzIGluIGRlYnVnCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNjAxMTcKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvRGF0YWJhc2VQcm9jZXNz L0RhdGFiYXNlUHJvY2Vzcy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9EYXRhYmFzZVByb2Nlc3MvRGF0 YWJhc2VQcm9jZXNzLmNwcAppbmRleCAwM2Q0YmMyLi45MWJjMjZiIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9EYXRhYmFzZVByb2Nlc3MvRGF0YWJhc2VQcm9jZXNzLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9EYXRhYmFzZVByb2Nlc3MvRGF0YWJhc2VQcm9jZXNzLmNwcApAQCAtMjM4LDYg KzIzOCw3IEBAIHZvaWQgRGF0YWJhc2VQcm9jZXNzOjpkZWxldGVXZWJzaXRlRGF0YUZvck9yaWdp bnMoV2ViQ29yZTo6U2Vzc2lvbklELCBPcHRpb25TZXQ8CiAjZW5kaWYKIH0KIAorI2lmIEVOQUJM RShTQU5EQk9YX0VYVEVOU0lPTlMpCiB2b2lkIERhdGFiYXNlUHJvY2Vzczo6Z3JhbnRTYW5kYm94 RXh0ZW5zaW9uc0ZvckJsb2JzKGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBwYXRocywgY29uc3QgU2Fu ZGJveEV4dGVuc2lvbjo6SGFuZGxlQXJyYXkmIGhhbmRsZXMpCiB7CiAgICAgQVNTRVJUKHBhdGhz LnNpemUoKSA9PSBoYW5kbGVzLnNpemUoKSk7CkBAIC0yNDcsNiArMjQ4LDcgQEAgdm9pZCBEYXRh YmFzZVByb2Nlc3M6OmdyYW50U2FuZGJveEV4dGVuc2lvbnNGb3JCbG9icyhjb25zdCBWZWN0b3I8 U3RyaW5nPiYgcGF0aHMKICAgICAgICAgQVNTRVJUX1VOVVNFRChyZXN1bHQsIHJlc3VsdC5pc05l d0VudHJ5KTsKICAgICB9CiB9CisjZW5kaWYKIAogI2lmIEVOQUJMRShJTkRFWEVEX0RBVEFCQVNF KQogdm9pZCBEYXRhYmFzZVByb2Nlc3M6OnByZXBhcmVGb3JBY2Nlc3NUb1RlbXBvcmFyeUZpbGUo Y29uc3QgU3RyaW5nJiBwYXRoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvRGF0YWJhc2VQ cm9jZXNzL0RhdGFiYXNlUHJvY2Vzcy5oIGIvU291cmNlL1dlYktpdDIvRGF0YWJhc2VQcm9jZXNz L0RhdGFiYXNlUHJvY2Vzcy5oCmluZGV4IGU4M2JjMzEuLjQ5ZDBjMWUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL0RhdGFiYXNlUHJvY2Vzcy9EYXRhYmFzZVByb2Nlc3MuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9EYXRhYmFzZVByb2Nlc3MvRGF0YWJhc2VQcm9jZXNzLmgKQEAgLTEwMyw3ICsx MDMsOSBAQCBwcml2YXRlOgogICAgIHZvaWQgZmV0Y2hXZWJzaXRlRGF0YShXZWJDb3JlOjpTZXNz aW9uSUQsIE9wdGlvblNldDxXZWJzaXRlRGF0YVR5cGU+IHdlYnNpdGVEYXRhVHlwZXMsIHVpbnQ2 NF90IGNhbGxiYWNrSUQpOwogICAgIHZvaWQgZGVsZXRlV2Vic2l0ZURhdGEoV2ViQ29yZTo6U2Vz c2lvbklELCBPcHRpb25TZXQ8V2Vic2l0ZURhdGFUeXBlPiB3ZWJzaXRlRGF0YVR5cGVzLCBzdGQ6 OmNocm9ubzo6c3lzdGVtX2Nsb2NrOjp0aW1lX3BvaW50IG1vZGlmaWVkU2luY2UsIHVpbnQ2NF90 IGNhbGxiYWNrSUQpOwogICAgIHZvaWQgZGVsZXRlV2Vic2l0ZURhdGFGb3JPcmlnaW5zKFdlYkNv cmU6OlNlc3Npb25JRCwgT3B0aW9uU2V0PFdlYnNpdGVEYXRhVHlwZT4gd2Vic2l0ZURhdGFUeXBl cywgY29uc3QgVmVjdG9yPFdlYkNvcmU6OlNlY3VyaXR5T3JpZ2luRGF0YT4mIG9yaWdpbnMsIHVp bnQ2NF90IGNhbGxiYWNrSUQpOworI2lmIEVOQUJMRShTQU5EQk9YX0VYVEVOU0lPTlMpCiAgICAg dm9pZCBncmFudFNhbmRib3hFeHRlbnNpb25zRm9yQmxvYnMoY29uc3QgVmVjdG9yPFN0cmluZz4m IHBhdGhzLCBjb25zdCBTYW5kYm94RXh0ZW5zaW9uOjpIYW5kbGVBcnJheSYpOworI2VuZGlmCiAK ICAgICB2b2lkIGRpZEdldFNhbmRib3hFeHRlbnNpb25zRm9yQmxvYkZpbGVzKHVpbnQ2NF90IHJl cXVlc3RJRCwgU2FuZGJveEV4dGVuc2lvbjo6SGFuZGxlQXJyYXkmJik7CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL0RhdGFiYXNlUHJvY2Vzcy9EYXRhYmFzZVByb2Nlc3MubWVzc2FnZXMu aW4gYi9Tb3VyY2UvV2ViS2l0Mi9EYXRhYmFzZVByb2Nlc3MvRGF0YWJhc2VQcm9jZXNzLm1lc3Nh Z2VzLmluCmluZGV4IDI3OGViZDIuLjk4NzA0ZjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L0RhdGFiYXNlUHJvY2Vzcy9EYXRhYmFzZVByb2Nlc3MubWVzc2FnZXMuaW4KKysrIGIvU291cmNl L1dlYktpdDIvRGF0YWJhc2VQcm9jZXNzL0RhdGFiYXNlUHJvY2Vzcy5tZXNzYWdlcy5pbgpAQCAt MzIsNyArMzIsOSBAQCBtZXNzYWdlcyAtPiBEYXRhYmFzZVByb2Nlc3MgTGVnYWN5UmVjZWl2ZXIg ewogICAgIEZldGNoV2Vic2l0ZURhdGEoV2ViQ29yZTo6U2Vzc2lvbklEIHNlc3Npb25JRCwgT3B0 aW9uU2V0PFdlYktpdDo6V2Vic2l0ZURhdGFUeXBlPiB3ZWJzaXRlRGF0YVR5cGVzLCB1aW50NjRf dCBjYWxsYmFja0lEKQogICAgIERlbGV0ZVdlYnNpdGVEYXRhKFdlYkNvcmU6OlNlc3Npb25JRCBz ZXNzaW9uSUQsIE9wdGlvblNldDxXZWJLaXQ6OldlYnNpdGVEYXRhVHlwZT4gd2Vic2l0ZURhdGFU eXBlcywgc3RkOjpjaHJvbm86OnN5c3RlbV9jbG9jazo6dGltZV9wb2ludCBtb2RpZmllZFNpbmNl LCB1aW50NjRfdCBjYWxsYmFja0lEKQogICAgIERlbGV0ZVdlYnNpdGVEYXRhRm9yT3JpZ2lucyhX ZWJDb3JlOjpTZXNzaW9uSUQgc2Vzc2lvbklELCBPcHRpb25TZXQ8V2ViS2l0OjpXZWJzaXRlRGF0 YVR5cGU+IHdlYnNpdGVEYXRhVHlwZXMsIFZlY3RvcjxXZWJDb3JlOjpTZWN1cml0eU9yaWdpbkRh dGE+IG9yaWdpbnMsIHVpbnQ2NF90IGNhbGxiYWNrSUQpCisjaWYgRU5BQkxFKFNBTkRCT1hfRVhU RU5TSU9OUykKICAgICBHcmFudFNhbmRib3hFeHRlbnNpb25zRm9yQmxvYnMoVmVjdG9yPFN0cmlu Zz4gcGF0aHMsIFdlYktpdDo6U2FuZGJveEV4dGVuc2lvbjo6SGFuZGxlQXJyYXkgZXh0ZW5zaW9u cykKKyNlbmRpZgogCiAgICAgRGlkR2V0U2FuZGJveEV4dGVuc2lvbnNGb3JCbG9iRmlsZXModWlu dDY0X3QgcmVxdWVzdElELCBXZWJLaXQ6OlNhbmRib3hFeHRlbnNpb246OkhhbmRsZUFycmF5IGV4 dGVuc2lvbnMpCiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTmV0d29y ay9OZXR3b3JrUHJvY2Vzc1Byb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9OZXR3 b3JrL05ldHdvcmtQcm9jZXNzUHJveHkuY3BwCmluZGV4IDc4NzhiOGQuLjAzYmNiNjEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9jZXNzUHJv eHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9j ZXNzUHJveHkuY3BwCkBAIC0yODAsNiArMjgwLDcgQEAgdm9pZCBOZXR3b3JrUHJvY2Vzc1Byb3h5 OjpkaWREZWxldGVXZWJzaXRlRGF0YUZvck9yaWdpbnModWludDY0X3QgY2FsbGJhY2tJRCkKIHZv aWQgTmV0d29ya1Byb2Nlc3NQcm94eTo6Z3JhbnRTYW5kYm94RXh0ZW5zaW9uc1RvRGF0YWJhc2VQ cm9jZXNzRm9yQmxvYnModWludDY0X3QgcmVxdWVzdElELCBjb25zdCBWZWN0b3I8U3RyaW5nPiYg cGF0aHMpCiB7CiAjaWYgRU5BQkxFKERBVEFCQVNFX1BST0NFU1MpCisjaWYgRU5BQkxFKFNBTkRC T1hfRVhURU5TSU9OUykKICAgICBTYW5kYm94RXh0ZW5zaW9uOjpIYW5kbGVBcnJheSBleHRlbnNp b25zOwogICAgIGV4dGVuc2lvbnMuYWxsb2NhdGUocGF0aHMuc2l6ZSgpKTsKICAgICBmb3IgKHNp emVfdCBpID0gMDsgaSA8IHBhdGhzLnNpemUoKTsgKytpKSB7CkBAIC0yODgsNiArMjg5LDcgQEAg dm9pZCBOZXR3b3JrUHJvY2Vzc1Byb3h5OjpncmFudFNhbmRib3hFeHRlbnNpb25zVG9EYXRhYmFz ZVByb2Nlc3NGb3JCbG9icyh1aW50NjQKICAgICB9CiAKICAgICBtX3Byb2Nlc3NQb29sLnNlbmRU b0RhdGFiYXNlUHJvY2Vzc1JlbGF1bmNoaW5nSWZOZWNlc3NhcnkoTWVzc2FnZXM6OkRhdGFiYXNl UHJvY2Vzczo6R3JhbnRTYW5kYm94RXh0ZW5zaW9uc0ZvckJsb2JzKHBhdGhzLCBleHRlbnNpb25z KSk7CisjZW5kaWYKICAgICBjb25uZWN0aW9uKCktPnNlbmQoTWVzc2FnZXM6Ok5ldHdvcmtQcm9j ZXNzOjpEaWRHcmFudFNhbmRib3hFeHRlbnNpb25zVG9EYXRhYmFzZVByb2Nlc3NGb3JCbG9icyhy ZXF1ZXN0SUQpLCAwKTsKICNlbmRpZgogfQo=