160187 2016-07-25 23:20:50 -0700 Regression(r203535): Uncaught Exception: TypeError: Not enough arguments at LayerTreeDataGridNode.js:47 2016-07-27 09:15:41 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED http://cookingaddict.net/ InRadar P2 Normal --- 160047 1 benjamin bburg bburg cdumez commit-queue eric.carlson joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1214465 0 benjamin 2016-07-25 23:20:50 -0700 ------- Inspected URL: http://cookingaddict.net/ Loading completed: true Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/603.1.1+ (KHTML, like Gecko) Uncaught Exceptions: - TypeError: Not enough arguments (at LayerTreeDataGridNode.js:47:131) createTextNode @ [native code] createCellContent @ LayerTreeDataGridNode.js:47:131 createCell @ DataGridNode.js:361:45 createCells @ DataGridNode.js:111:54 createCells @ LayerTreeDataGridNode.js:40:26 element @ DataGridNode.js:104:25 _updateVisibleRows @ DataGrid.js:1070:47 layout @ DataGrid.js:852:32 _layoutSubtree @ View.js:250:20 updateLayout @ View.js:147:28 updateLayoutIfNeeded @ View.js:155:26 _sortNodesCallback @ DataGrid.js:1344:38 _sortNodesCallback @ [native code] ------- * STEPS TO REPRODUCE 1. What were you doing? Include setup or other preparations to reproduce the exception. 2. Include explicit, accurate, and minimal steps taken. Do not include extraneous or irrelevant steps. * NOTES Document any additional information that might be useful in resolving the problem, such as screen shots or other included attachments. 1214466 1 webkit-bug-importer 2016-07-25 23:21:19 -0700 <rdar://problem/27540435> 1214467 2 benjamin 2016-07-25 23:23:19 -0700 To reproduce: -Open http://cookingaddict.net -Right click on the slider->Inspect -Click on the div with id="defilhor" 1214555 3 cdumez 2016-07-26 09:31:51 -0700 var cell = columnIdentifier === "name" ? this._makeNameCell() : this._makeOutlet(columnIdentifier, document.createTextNode()); Parameter to createTextNode() is mandatory after: http://trac.webkit.org/changeset/203535 document.createTextNode() was identical to calling document.createTextNode("undefined") :/ 1214567 4 bburg 2016-07-26 09:54:18 -0700 (In reply to comment #3) > var cell = columnIdentifier === "name" ? this._makeNameCell() : > this._makeOutlet(columnIdentifier, document.createTextNode()); > > Parameter to createTextNode() is mandatory after: > http://trac.webkit.org/changeset/203535 > > document.createTextNode() was identical to calling > document.createTextNode("undefined") :/ Oops! This is in view code so we didn't have any coverage for that change. 1214631 5 284619 bburg 2016-07-26 12:41:39 -0700 Created attachment 284619 Proposed Fix 1214634 6 284619 nvasilyev 2016-07-26 13:09:34 -0700 Comment on attachment 284619 Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=284619&action=review Looks good, but I'm not a reviewer to r+ it. > Source/WebInspectorUI/UserInterface/Views/LayerTreeDataGridNode.js:47 > + cell = columnIdentifier === "name" ? this._makeNameCell() : this._makeOutlet(columnIdentifier, document.createTextNode("–")); †is an em dash. Our bugzilla doesn't handle unicode that well, apparently. 1214906 7 nvasilyev 2016-07-27 08:33:17 -0700 *** Bug 160250 has been marked as a duplicate of this bug. *** 1214934 8 284619 commit-queue 2016-07-27 09:15:36 -0700 Comment on attachment 284619 Proposed Fix Clearing flags on attachment: 284619 Committed r203778: <http://trac.webkit.org/changeset/203778> 1214935 9 commit-queue 2016-07-27 09:15:41 -0700 All reviewed patches have been landed. Closing bug. 284619 2016-07-26 12:41:39 -0700 2016-07-27 09:15:36 -0700 Proposed Fix bug-160187-20160726124030.patch text/plain 1989 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzNzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA5 YTM4ZDkzNzM0MmY1NWU5NTQzYmEwNTc1MmU0NDVkYzZhOGNmOWQ4Li5lOTRkOTZkMjNmMTkxYzA3 NTU5NGFkNDRlMWMzZWNiOTdhNTBjY2QyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNi0wNy0yNiAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICBSZWdyZXNzaW9uKHIyMDM1MzUpOiBVbmNhdWdodCBFeGNlcHRpb246IFR5cGVFcnJv cjogTm90IGVub3VnaCBhcmd1bWVudHMgYXQgTGF5ZXJUcmVlRGF0YUdyaWROb2RlLmpzOjQ3Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjAxODcKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI3NTQwNDM1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFmdGVyIHIyMDM1MzUsIGRvY3VtZW50LmNyZWF0ZVRl eHROb2RlKCkgcmVxdWlyZXMgYW4gYXJndW1lbnQuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L1ZpZXdzL0xheWVyVHJlZURhdGFHcmlkTm9kZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5M YXllclRyZWVEYXRhR3JpZE5vZGUucHJvdG90eXBlLmNyZWF0ZUNlbGxDb250ZW50KToKKyAgICAg ICAgU2luY2UgdGhpcyB1c2Utc2l0ZSBpcyBmb3IgY3JlYXRpbmcgYSBjZWxsIGluIGFuIHVua25v d24gY29sdW1uLAorICAgICAgICBpbml0aWFsaXplIGl0IHRvICfigJMnLiBQcmV2aW91c2x5IGl0 IHdvdWxkIGhhdmUgYmVlbiB0aGUgc3RyaW5nCisgICAgICAgICJ1bmRlZmluZWQiIG9yIGVtcHR5 LgorCiAyMDE2LTA3LTI0ICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KIAogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBGaWx0ZXJpbmcgaXMgYnJva2VuIGluIHRoZSBPdmVydmlldyB0 aW1lbGluZSB2aWV3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9MYXllclRyZWVEYXRhR3JpZE5vZGUuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9MYXllclRyZWVEYXRhR3JpZE5vZGUuanMKaW5kZXggMDli ZjI0YzE0YTBkZGE0ZTg0MDYzNjIxZDVhZjkwYjRmYmI2ZmViNi4uODIzOWM4YWNiYzk1N2FhMDBl YzcwMTc0MDM3MTM0OThkMDIzMTUyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvTGF5ZXJUcmVlRGF0YUdyaWROb2RlLmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xheWVyVHJlZURhdGFHcmlkTm9k ZS5qcwpAQCAtNDQsNyArNDQsNyBAQCBXZWJJbnNwZWN0b3IuTGF5ZXJUcmVlRGF0YUdyaWROb2Rl ID0gY2xhc3MgTGF5ZXJUcmVlRGF0YUdyaWROb2RlIGV4dGVuZHMgV2ViSW5zcAogCiAgICAgY3Jl YXRlQ2VsbENvbnRlbnQoY29sdW1uSWRlbnRpZmllciwgY2VsbCkKICAgICB7Ci0gICAgICAgIHZh ciBjZWxsID0gY29sdW1uSWRlbnRpZmllciA9PT0gIm5hbWUiID8gdGhpcy5fbWFrZU5hbWVDZWxs KCkgOiB0aGlzLl9tYWtlT3V0bGV0KGNvbHVtbklkZW50aWZpZXIsIGRvY3VtZW50LmNyZWF0ZVRl eHROb2RlKCkpOworICAgICAgICBjZWxsID0gY29sdW1uSWRlbnRpZmllciA9PT0gIm5hbWUiID8g dGhpcy5fbWFrZU5hbWVDZWxsKCkgOiB0aGlzLl9tYWtlT3V0bGV0KGNvbHVtbklkZW50aWZpZXIs IGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKCLigJMiKSk7CiAgICAgICAgIHRoaXMuX3VwZGF0ZUNl bGwoY29sdW1uSWRlbnRpZmllcik7CiAgICAgICAgIHJldHVybiBjZWxsOwogICAgIH0K