16018 2007-11-16 14:03:00 -0800 build bustage when building on debian 4.0 2007-11-16 14:27:29 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 0 dougt webkit-unassigned oldest_to_newest 61413 0 dougt 2007-11-16 14:03:00 -0800 on a stock install of debian 4.0, my build is failing in: WebCore/platform/gtk/Language.cpp Apparently, pango_language_get_default() is not defined by the shipping version of pango. this function was introduced in Pango-1.15.2 or maybe 1.16. we can just replace the old pango_ call with the gtk_ one, or we can use a version check macro to choose one conditionally. patch coming up that replaces the pango call. 61414 1 17317 dougt 2007-11-16 14:04:37 -0800 Created attachment 17317 patch which uses gtk_get_default_language Note that I removed the static string as the docs say that the value of gtk_get_default_language can change over the lifetime of the application. I am worry about this being a perf hit, so we should watch carefully after this lands. 61417 2 17319 dougt 2007-11-16 14:17:38 -0800 Created attachment 17319 patch 2 w/ change log 61419 3 17319 alp 2007-11-16 14:23:25 -0800 Comment on attachment 17319 patch 2 w/ change log Looks great. ChangeLog entry could be slightly more descriptive, but I can fix that up before landing it. 61422 4 alp 2007-11-16 14:27:29 -0800 Landed in r27858. Thanks! 17317 2007-11-16 14:04:37 -0800 2007-11-16 14:17:38 -0800 patch which uses gtk_get_default_language patch text/plain 673 dougt SW5kZXg6IExhbmd1YWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYW5ndWFnZS5jcHAJKHJldmlzaW9u IDI3ODU2KQorKysgTGFuZ3VhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOSwxOCArMjksMTQg QEAKICNpbmNsdWRlICJDU3RyaW5nLmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1TdHJpbmcuaCIKIAor I2luY2x1ZGUgPGd0ay9ndGsuaD4KICNpbmNsdWRlIDxwYW5nby9wYW5nby5oPgogCiBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAKIFN0cmluZyBkZWZhdWx0TGFuZ3VhZ2UoKQogewotICAgIHN0YXRpYyBT dHJpbmcgZGVmYXVsdExhbmd1YWdlOwotCi0gICAgaWYgKCFkZWZhdWx0TGFuZ3VhZ2UuaXNFbXB0 eSgpKQotICAgICAgICByZXR1cm4gZGVmYXVsdExhbmd1YWdlOwotCi0gICAgUGFuZ29MYW5ndWFn ZSogcGFuZ29MYW5ndWFnZSA9IHBhbmdvX2xhbmd1YWdlX2dldF9kZWZhdWx0KCk7CisgICAgUGFu Z29MYW5ndWFnZSogcGFuZ29MYW5ndWFnZSA9IGd0a19nZXRfZGVmYXVsdF9sYW5ndWFnZSgpOwog ICAgIGRlZmF1bHRMYW5ndWFnZSA9IFN0cmluZyhwYW5nb19sYW5ndWFnZV90b19zdHJpbmcocGFu Z29MYW5ndWFnZSkpOwogCiAgICAgcmV0dXJuIGRlZmF1bHRMYW5ndWFnZTsKCg== 17319 2007-11-16 14:17:38 -0800 2007-11-16 14:23:25 -0800 patch 2 w/ change log patch text/plain 1255 dougt SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n ICAgKHJldmlzaW9uIDI3ODU3KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cgICAod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDEzIEBACisyMDA3LTExLTE2ICBkb3VndCAgPGRvdWd0QG1lZXIubmV0Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC1GaXggaHR0 cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwMTgKKyAgICAgICBGaXhlZCBi dWlsZCBidXN0YWdlIG9uIEdUSy4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9MYW5ndWFnZS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpkZWZhdWx0TGFuZ3VhZ2UpOgorCiAyMDA3LTExLTE2ICBC cmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KCiAgICAgICAgIEJ1aWxkIGZpeApJbmRl eDogV2ViQ29yZS9wbGF0Zm9ybS9ndGsvTGFuZ3VhZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvcGxhdGZvcm0vZ3RrL0xhbmd1YWdlLmNwcCAgIChyZXZpc2lvbiAyNzg1NikKKysrIFdlYkNv cmUvcGxhdGZvcm0vZ3RrL0xhbmd1YWdlLmNwcCAgICh3b3JraW5nIGNvcHkpCkBAIC0yOSwyMSAr MjksMTQgQEAKICNpbmNsdWRlICJDU3RyaW5nLmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1TdHJpbmcu aCIKCisjaW5jbHVkZSA8Z3RrL2d0ay5oPgogI2luY2x1ZGUgPHBhbmdvL3BhbmdvLmg+CgogbmFt ZXNwYWNlIFdlYkNvcmUgewoKIFN0cmluZyBkZWZhdWx0TGFuZ3VhZ2UoKQogewotICAgIHN0YXRp YyBTdHJpbmcgZGVmYXVsdExhbmd1YWdlOwotCi0gICAgaWYgKCFkZWZhdWx0TGFuZ3VhZ2UuaXNF bXB0eSgpKQotICAgICAgICByZXR1cm4gZGVmYXVsdExhbmd1YWdlOwotCi0gICAgUGFuZ29MYW5n dWFnZSogcGFuZ29MYW5ndWFnZSA9IHBhbmdvX2xhbmd1YWdlX2dldF9kZWZhdWx0KCk7Ci0gICAg ZGVmYXVsdExhbmd1YWdlID0gU3RyaW5nKHBhbmdvX2xhbmd1YWdlX3RvX3N0cmluZyhwYW5nb0xh bmd1YWdlKSk7Ci0KLSAgICByZXR1cm4gZGVmYXVsdExhbmd1YWdlOworICAgIHJldHVybiBwYW5n b19sYW5ndWFnZV90b19zdHJpbmcoZ3RrX2dldF9kZWZhdWx0X2xhbmd1YWdlKCkpOwogfQoKIH0K Cg==