160131 2016-07-23 15:25:05 -0700 [GTK] Layout test media/track/track-in-band-duplicate-tracks-when-source-changes.html flaky again 2021-06-04 19:40:44 -0700 1 1 1 Unclassified WebKit Media Other PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro fujii bugs-noreply calvaris commit-queue csaavedra darin eric.carlson fujii magomez mcatanzaro Ms2ger pnormand webkit-bug-importer oldest_to_newest 1213960 0 mcatanzaro 2016-07-23 15:25:05 -0700 Layout test media/track/track-in-band-duplicate-tracks-when-source-changes.html is sadly double-broken: * It has been flakily crashing for a very long time. * It has been flakily timing out since we enabled threaded compositor. Lots of other tests are timing out too, so it's probably best to restrict this bug to the crash, but if the crash is fixed before the timeout is fixed then we need to reassign the test expectation to some other bug before closing this one. 1213971 1 mcatanzaro 2016-07-23 15:58:51 -0700 Updating expectations accordingly. 1341064 2 Ms2ger 2017-08-22 08:52:21 -0700 It's crashing because mediaElement() is null in VideoTrack::setLanguage(). Not sure if this is something it should be expected to deal with, or if there's an underlying problem. (The billion-dollar mistake indeed.) 1378048 3 fujii 2017-12-04 18:42:47 -0800 GTK port, Debug build, trunk@225473 > Thread 1 (Thread 0x7f54e9eaca80 (LWP 123232)): > #0 0x00007f54e45000dc in WTF::RefPtr<WebCore::VideoTrackList>::operator! (this=0x6d0) at ../../Source/WTF/wtf/RefPtr.h:81 > #1 0x00007f54e4d32073 in (anonymous namespace)::HTMLMediaElement::videoTracks (this=0x0) at ../../Source/WebCore/html/HTMLMediaElement.cpp:4079 > #2 0x00007f54e5b5537c in (anonymous namespace)::VideoTrack::setLanguage (this=0x7f547436c7e0, language=...) at ../../Source/WebCore/html/track/VideoTrack.cpp:213 > #3 0x00007f54e5b551eb in (anonymous namespace)::VideoTrack::languageChanged (this=0x7f547436c7e0, language=...) at ../../Source/WebCore/html/track/VideoTrack.cpp:161 > #4 0x00007f54e5e67858 in (anonymous namespace)::TrackPrivateBaseGStreamer::notifyTrackOfTagsChanged (this=0x7f547432a110) at ../../Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:172 > #5 0x00007f54e5e6729f in (anonymous namespace)::TrackPrivateBaseGStreamer::<lambda()>::operator()(void) const (__closure=0x7f5474321038) at ../../Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:103 > #6 0x00007f54e5e6988a in WTF::Function<void()>::CallableWrapper<WebCore::TrackPrivateBaseGStreamer::tagsChanged()::<lambda()> >::call(void) (this=0x7f5474321030) at ../../Source/WTF/wtf/Function.h:101 > #7 0x00007f54e2f0b4e6 in WTF::Function<void()>::operator()(void) const (this=0x7f54743230c0) at ../../Source/WTF/wtf/Function.h:56 > #8 0x00007f54e5e67b5a in (anonymous namespace)::MainThreadNotifier<WebCore::TrackPrivateBaseGStreamer::MainThreadNotification>::<lambda()>::operator()(void) const (__closure=0x7f54743230a8) at ../../Source/WebCore/platform/graphics/gstreamer/MainThreadNotifier.h:55 > #9 0x00007f54e5e6986c in WTF::Function<void()>::CallableWrapper<WebCore::MainThreadNotifier<T>::notify(T, F&&) [with F = WebCore::TrackPrivateBaseGStreamer::tagsChanged()::<lambda()>; T = WebCore::TrackPrivateBaseGStreamer::MainThreadNotification]::<lambda()> >::call(void) (this=0x7f54743230a0) at ../../Source/WTF/wtf/Function.h:101 > #10 0x00007f54e2f0b4e6 in WTF::Function<void()>::operator()(void) const (this=0x7ffd69da9380) at ../../Source/WTF/wtf/Function.h:56 > #11 0x00007f54d8bbf3dd in WTF::RunLoop::performWork (this=0x7f54c75fc100) at ../../Source/WTF/wtf/RunLoop.cpp:106 > #12 0x00007f54d8c0f3b6 in WTF::RunLoop::<lambda(gpointer)>::operator()(gpointer) const (__closure=0x0, userData=0x7f54c75fc100) at ../../Source/WTF/wtf/glib/RunLoopGLib.cpp:68 > #13 0x00007f54d8c0f3da in WTF::RunLoop::<lambda(gpointer)>::_FUN(gpointer) () at ../../Source/WTF/wtf/glib/RunLoopGLib.cpp:70 > #14 0x00007f54d8c0f356 in WTF::<lambda(GSource*, GSourceFunc, gpointer)>::operator()(GSource *, GSourceFunc, gpointer) const (__closure=0x0, source=0x560fb0946af0, callback=0x7f54d8c0f3bd <WTF::RunLoop::<lambda(gpointer)>::_FUN(gpointer)>, userData=0x7f54c75fc100) at ../../Source/WTF/wtf/glib/RunLoopGLib.cpp:45 > #15 0x00007f54d8c0f385 in WTF::<lambda(GSource*, GSourceFunc, gpointer)>::_FUN(GSource *, GSourceFunc, gpointer) () at ../../Source/WTF/wtf/glib/RunLoopGLib.cpp:46 > #16 0x00007f54d9db6c35 in g_main_dispatch () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3148 > #17 g_main_context_dispatch () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3813 > #18 0x00007f54d9db7000 in g_main_context_iterate () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3886 > #19 0x00007f54d9db7312 in g_main_loop_run () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:4082 > #20 0x00007f54d8c0f8d5 in WTF::RunLoop::run () at ../../Source/WTF/wtf/glib/RunLoopGLib.cpp:96 > #21 0x00007f54e3820996 in (anonymous namespace)::ChildProcessMain<WebKit::WebProcess, WebKit::WebProcessMain> (argc=2, argv=0x7ffd69da9778) at ../../Source/WebKit/Shared/unix/ChildProcessMain.h:61 > #22 0x00007f54e3820839 in (anonymous namespace)::WebProcessMainUnix (argc=2, argv=0x7ffd69da9778) at ../../Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp:69 > #23 0x0000560faebe9a45 in main (argc=2, argv=0x7ffd69da9778) at ../../Source/WebKit/WebProcess/EntryPoint/unix/WebProcessMain.cpp:52 1378057 4 fujii 2017-12-04 19:11:24 -0800 This is the callstack when the m_mediaElement is cleared. > #0 (anonymous namespace)::VideoTrack::setMediaElement (this=0x7f6ec91ffaf0, element=0x0) at ../../Source/WebCore/html/track/VideoTrack.cpp:248 > #1 0x00007f6f4a26018f in (anonymous namespace)::TrackListBase::remove (this=0x7f6eca7343e0, track=..., scheduleEvent=true) > at ../../Source/WebCore/html/track/TrackListBase.cpp:79 > #2 0x00007f6f49447ae1 in (anonymous namespace)::HTMLMediaElement::removeVideoTrack (this=0x7f6eca766800, track=...) > at ../../Source/WebCore/html/HTMLMediaElement.cpp:4006 > #3 0x00007f6f49447cb4 in (anonymous namespace)::HTMLMediaElement::forgetResourceSpecificTracks (this=0x7f6eca766800) > at ../../Source/WebCore/html/HTMLMediaElement.cpp:4025 > #4 0x00007f6f4944f016 in (anonymous namespace)::HTMLMediaElement::createMediaPlayer (this=0x7f6eca766800) at ../../Source/WebCore/html/HTMLMediaElement.cpp:6410 > #5 0x00007f6f4943f388 in (anonymous namespace)::HTMLMediaElement::loadNextSourceChild (this=0x7f6eca766800) at ../../Source/WebCore/html/HTMLMediaElement.cpp:1527 > #6 0x00007f6f4943dd5f in (anonymous namespace)::HTMLMediaElement::<lambda()>::operator()(void) const (__closure=0x7f6ec91c58b8) > at ../../Source/WebCore/html/HTMLMediaElement.cpp:1054 > #7 0x00007f6f49458fd2 in WTF::Function<void()>::CallableWrapper<WebCore::HTMLMediaElement::scheduleNextSourceChild()::<lambda()> >::call(void) ( > this=0x7f6ec91c58b0) at ../../Source/WTF/wtf/Function.h:101 > #8 0x00007f6f476214e6 in WTF::Function<void()>::operator()(void) const (this=0x7f6ebf0dfef8) at ../../Source/WTF/wtf/Function.h:56 > #9 0x00007f6f48dc6591 in (anonymous namespace)::GenericTaskQueue<WebCore::Timer>::<lambda()>::operator()(void) const (__closure=0x7f6ebf0dfef0) > at ../../Source/WebCore/platform/GenericTaskQueue.h:96 > #10 0x00007f6f48dd0798 in WTF::Function<void()>::CallableWrapper<WebCore::GenericTaskQueue<T>::enqueueTask(WebCore::GenericTaskQueue<T>::TaskFunction&&) [with T = WebCore::Timer; WebCore::GenericTaskQueue<T>::TaskFunction = WTF::Function<void()>]::<lambda()> >::call(void) (this=0x7f6ebf0dfee8) > at ../../Source/WTF/wtf/Function.h:101 > #11 0x00007f6f476214e6 in WTF::Function<void()>::operator()(void) const (this=0x7ffca0b6a440) at ../../Source/WTF/wtf/Function.h:56 > #12 0x00007f6f4997277e in (anonymous namespace)::TaskDispatcher<WebCore::Timer>::dispatchOneTask (this=0x7f6eca766c10) > at ../../Source/WebCore/platform/GenericTaskQueue.cpp:80 > #13 0x00007f6f49972649 in (anonymous namespace)::TaskDispatcher<WebCore::Timer>::sharedTimerFired () at ../../Source/WebCore/platform/GenericTaskQueue.cpp:65 > #14 0x00007f6f499724a3 in (anonymous namespace)::TaskDispatcher<WebCore::Timer>::<lambda()>::operator()(void) const (__closure=0x7f6eca776958) > at ../../Source/WebCore/platform/GenericTaskQueue.cpp:49 > #15 0x00007f6f4997308e in WTF::Function<void()>::CallableWrapper<WebCore::TaskDispatcher<WebCore::Timer>::sharedTimer()::<lambda()> >::call(void) ( > this=0x7f6eca776950) at ../../Source/WTF/wtf/Function.h:101 > #16 0x00007f6f476214e6 in WTF::Function<void()>::operator()(void) const (this=0x7f6f4e3ef740 <WebCore::TaskDispatcher<WebCore::Timer>::sharedTimer()::timer+64>) > at ../../Source/WTF/wtf/Function.h:56 > #17 0x00007f6f4762d172 in (anonymous namespace)::Timer::fired (this=0x7f6f4e3ef700 <WebCore::TaskDispatcher<WebCore::Timer>::sharedTimer()::timer>) > at ../../Source/WebCore/platform/Timer.h:133 > #18 0x00007f6f4999c075 in (anonymous namespace)::ThreadTimers::sharedTimerFiredInternal (this=0x7f6f29efd1e0) at ../../Source/WebCore/platform/ThreadTimers.cpp:118 > #19 0x00007f6f4999bb4d in (anonymous namespace)::ThreadTimers::<lambda()>::operator()(void) const (__closure=0x7f6f29efa378) > at ../../Source/WebCore/platform/ThreadTimers.cpp:70 > #20 0x00007f6f4999e9c0 in WTF::Function<void()>::CallableWrapper<WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::<lambda()> >::call(void) ( > this=0x7f6f29efa370) at ../../Source/WTF/wtf/Function.h:101 > #21 0x00007f6f476214e6 in WTF::Function<void()>::operator()(void) const (this=0x7f6f4e3ef868 <WebCore::MainThreadSharedTimer::singleton()::instance+8>) > at ../../Source/WTF/wtf/Function.h:56 > #22 0x00007f6f499831e9 in (anonymous namespace)::MainThreadSharedTimer::fired (this=0x7f6f4e3ef860 <WebCore::MainThreadSharedTimer::singleton()::instance>) > at ../../Source/WebCore/platform/MainThreadSharedTimer.cpp:54 > #23 0x00007f6f499846a0 in WTF::RunLoop::Timer<WebCore::MainThreadSharedTimer>::fired ( > this=0x7f6f4e3ef870 <WebCore::MainThreadSharedTimer::singleton()::instance+16>) at ../../Source/WTF/wtf/RunLoop.h:152 > #24 0x00007f6f3d350c91 in WTF::RunLoop::TimerBase::<lambda(gpointer)>::operator()(gpointer) const (__closure=0x0, > userData=0x7f6f4e3ef870 <WebCore::MainThreadSharedTimer::singleton()::instance+16>) at ../../Source/WTF/wtf/glib/RunLoopGLib.cpp:166 > #25 0x00007f6f3d350ccd in WTF::RunLoop::TimerBase::<lambda(gpointer)>::_FUN(gpointer) () at ../../Source/WTF/wtf/glib/RunLoopGLib.cpp:170 > #26 0x00007f6f3d350356 in WTF::<lambda(GSource*, GSourceFunc, gpointer)>::operator()(GSource *, GSourceFunc, gpointer) const (__closure=0x0, > source=0x564f612caa30, callback=0x7f6f3d350cb0 <WTF::RunLoop::TimerBase::<lambda(gpointer)>::_FUN(gpointer)>, > userData=0x7f6f4e3ef870 <WebCore::MainThreadSharedTimer::singleton()::instance+16>) at ../../Source/WTF/wtf/glib/RunLoopGLib.cpp:45 > #27 0x00007f6f3d350385 in WTF::<lambda(GSource*, GSourceFunc, gpointer)>::_FUN(GSource *, GSourceFunc, gpointer) () at ../../Source/WTF/wtf/glib/RunLoopGLib.cpp:46 > #28 0x00007f6f3e4f7c35 in g_main_dispatch () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3148 > #29 g_main_context_dispatch () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3813 > #30 0x00007f6f3e4f8000 in g_main_context_iterate () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3886 > #31 0x00007f6f3e4f8312 in g_main_loop_run () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:4082 > #32 0x00007f6f3d3508d5 in WTF::RunLoop::run () at ../../Source/WTF/wtf/glib/RunLoopGLib.cpp:96 > #33 0x00007f6f47f36996 in (anonymous namespace)::ChildProcessMain<WebKit::WebProcess, WebKit::WebProcessMain> (argc=2, argv=0x7ffca0b6a9e8) > at ../../Source/WebKit/Shared/unix/ChildProcessMain.h:61 > #34 0x00007f6f47f36839 in (anonymous namespace)::WebProcessMainUnix (argc=2, argv=0x7ffca0b6a9e8) at ../../Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp:69 > #35 0x0000564f60461a45 in main (argc=2, argv=0x7ffca0b6a9e8) at ../../Source/WebKit/WebProcess/EntryPoint/unix/WebProcessMain.cpp:52 1378062 5 fujii 2017-12-04 19:34:00 -0800 VideoTrack::willRemove() already has a null check of m_mediaElement. This was added by Darin Adler in Bug 166635. InbandTextTrack::willRemove() also has the null check. This was added by Eric Carlson in Bug 117938. But, AudioTrack::willRemove() doesn't have the null check even though it also dereference the m_mediaElement. 1378069 6 328431 fujii 2017-12-04 20:13:15 -0800 Created attachment 328431 WIP patch * This patch doesn't solve the time-out issue. 1378518 7 fujii 2017-12-05 19:29:34 -0800 I can reproduce the timeout bug by repeatedly reloading the test case media/track/track-in-band-duplicate-tracks-when-source-changes.html in GTK MiniBrowser. This test case expects two canplaythrough events are dispatched. There are two types of timeout failure. 1. No canplaythrough event dispatched. 2. Only one canplaythrough event dispatched. Screenshots: https://photos.app.goo.gl/avRU9ubausB0pQrs2 1378523 8 328549 fujii 2017-12-05 20:19:02 -0800 Created attachment 328549 Patch * Fixing only the crash issue 1378528 9 328549 commit-queue 2017-12-05 21:25:19 -0800 Comment on attachment 328549 Patch Clearing flags on attachment: 328549 Committed r225567: <https://trac.webkit.org/changeset/225567> 1378529 10 commit-queue 2017-12-05 21:25:21 -0800 All reviewed patches have been landed. Closing bug. 1378530 11 fujii 2017-12-05 21:41:48 -0800 Reopened. The timeout issue still occurs. 1378531 12 webkit-bug-importer 2017-12-05 21:42:03 -0800 <rdar://problem/35873985> 1379524 13 fujii 2017-12-08 03:05:47 -0800 MediaPlayerPrivateGStreamer::loadingFailed was called in case of the timeout issues happened. 1400341 14 csaavedra 2018-02-19 05:42:21 -0800 This is now failing consistently after https://trac.webkit.org/changeset/228617: --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/media/track/track-in-band-duplicate-tracks-when-source-changes-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/media/track/track-in-band-duplicate-tracks-when-source-changes-actual.txt @@ -4,7 +4,7 @@ EVENT(canplaythrough) ** Storing number of tracks and reloading video -EXPECTED (video.textTracks.length > '0') OK +EXPECTED (video.textTracks.length > '0'), OBSERVED '0' FAIL RUN(numTracks = video.textTracks.length) EVENT(canplaythrough) 1400346 15 pnormand 2018-02-19 06:11:57 -0800 (In reply to Fujii Hironori from comment #13) > MediaPlayerPrivateGStreamer::loadingFailed was called in case of the timeout > issues happened. Seems a bit odd because that patch shouldn't have a functional impact unless playbin3 is enabled, which isn't the case... I'll try to debug it at some point if time allows... 1400754 16 334267 pnormand 2018-02-20 07:13:06 -0800 Created attachment 334267 Patch 1400796 17 334267 mcatanzaro 2018-02-20 09:53:06 -0800 Comment on attachment 334267 Patch Aren't there test expectations to update too? 1400839 18 pnormand 2018-02-20 10:54:04 -0800 It seems Claudio didn't update it? I haven't touched it because I assume the test will be flaky again, as before I broke it for real. 1401069 19 pnormand 2018-02-21 03:42:52 -0800 Committed r228868 but leaving bug open as the test might still be flaky. 1401399 20 csaavedra 2018-02-22 02:30:44 -0800 It's still flaky, it timed out a few times but it's passing most times now. Thanks Phil! 1767076 21 dpino 2021-06-04 19:40:40 -0700 This test, or group of tests, has been passing for the last 4000 revisions. Closing bug. Gardened in r278519. 328431 2017-12-04 20:13:15 -0800 2017-12-05 20:18:56 -0800 WIP patch wip.patch text/plain 1195 fujii ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svQXVkaW9UcmFjay5jcHAgYi9T b3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL0F1ZGlvVHJhY2suY3BwCmluZGV4IGFiZWU5MjMxM2Fl Li43ZTVhYmQzNGZkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9BdWRp b1RyYWNrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL0F1ZGlvVHJhY2suY3Bw CkBAIC0xNjAsNyArMTYwLDEwIEBAIHZvaWQgQXVkaW9UcmFjazo6bGFuZ3VhZ2VDaGFuZ2VkKGNv bnN0IEF0b21pY1N0cmluZyYgbGFuZ3VhZ2UpCiAKIHZvaWQgQXVkaW9UcmFjazo6d2lsbFJlbW92 ZSgpCiB7Ci0gICAgbWVkaWFFbGVtZW50KCktPnJlbW92ZUF1ZGlvVHJhY2soKnRoaXMpOworICAg IGF1dG8gZWxlbWVudCA9IG1ha2VSZWZQdHIobWVkaWFFbGVtZW50KCkpOworICAgIGlmICghZWxl bWVudCkKKyAgICAgICAgcmV0dXJuOworICAgIGVsZW1lbnQtPnJlbW92ZUF1ZGlvVHJhY2soKnRo aXMpOwogfQogCiB2b2lkIEF1ZGlvVHJhY2s6OnVwZGF0ZUtpbmRGcm9tUHJpdmF0ZSgpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL1ZpZGVvVHJhY2suY3BwIGIvU291cmNl L1dlYkNvcmUvaHRtbC90cmFjay9WaWRlb1RyYWNrLmNwcAppbmRleCAyODQxM2I5YjlmYy4uMWE0 YTI5MzFlM2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svVmlkZW9UcmFj ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9WaWRlb1RyYWNrLmNwcApAQCAt MjEwLDcgKzIxMCw4IEBAIHZvaWQgVmlkZW9UcmFjazo6c2V0TGFuZ3VhZ2UoY29uc3QgQXRvbWlj U3RyaW5nJiBsYW5ndWFnZSkKIAogICAgIC8vIDQuIFF1ZXVlIGEgdGFzayB0byBmaXJlIGEgc2lt cGxlIGV2ZW50IG5hbWVkIGNoYW5nZSBhdCB0aGUgVmlkZW9UcmFja0xpc3Qgb2JqZWN0IHJlZmVy ZW5jZWQgYnkKICAgICAvLyB0aGUgdmlkZW9UcmFja3MgYXR0cmlidXRlIG9uIHRoZSBIVE1MTWVk aWFFbGVtZW50LgotICAgIG1lZGlhRWxlbWVudCgpLT52aWRlb1RyYWNrcygpLnNjaGVkdWxlQ2hh bmdlRXZlbnQoKTsKKyAgICBpZiAobWVkaWFFbGVtZW50KCkpCisgICAgICAgIG1lZGlhRWxlbWVu dCgpLT52aWRlb1RyYWNrcygpLnNjaGVkdWxlQ2hhbmdlRXZlbnQoKTsKIH0KIAogI2VuZGlmCg== 328549 2017-12-05 20:19:02 -0800 2018-02-20 07:13:02 -0800 Patch bug-160131-20171205201645.patch text/plain 4606 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1NTIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTQ0ZGE0ZDIxNmMxZDgz NGIzNTViYzliYzY4ZGE3Y2U2YjgwMWNhYi4uNTM0NGYxODU2NTgxNTM1MmUzZjU2NjA2M2Y1ZWUz MjQ2ODk1ZmY3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE3LTEyLTA1ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtHVEtdIExh eW91dCB0ZXN0IG1lZGlhL3RyYWNrL3RyYWNrLWluLWJhbmQtZHVwbGljYXRlLXRyYWNrcy13aGVu LXNvdXJjZS1jaGFuZ2VzLmh0bWwgY3Jhc2hlcyBhbmQgdGltZXMgb3V0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjAxMzEKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOdWxsIGRlcmVmZXJlbmNlIGNhbiBi ZSBoYXBwZW4gaWYgVmlkZW9UcmFjayBhbmQgQXVkaW9UcmFjayBhcmUKKyAgICAgICAgZGlzY29u bmVjdGVkIGZyb20gaXRzIG1lZGlhIGVsZW1lbnQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBu byBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBodG1sL3RyYWNrL0F1ZGlvVHJhY2suY3Bw OgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9UcmFjazo6d2lsbFJlbW92ZSk6IE51bGwtY2hlY2sg bWVkaWFFbGVtZW50LgorICAgICAgICAqIGh0bWwvdHJhY2svVmlkZW9UcmFjay5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpWaWRlb1RyYWNrOjpzZXRMYW5ndWFnZSk6IERpdHRvLgorCiAyMDE3LTEy LTA1ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CiAKICAgICAgICAgPHZpZGVv PiBhbmQgc2NhbGUoKSB0cmFuc2Zvcm1zIHlpZWxkIHNocnVuayBzbWFsbCBvciBjbGlwcGVkIGNv bnRyb2xzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL0F1ZGlvVHJhY2su Y3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9BdWRpb1RyYWNrLmNwcAppbmRleCBhYmVl OTIzMTNhZWY2YmIxMzc2MjFmOTFmYjY5NzRkNDlmY2NiNWJjLi43ZTVhYmQzNGZkMGZhOGE1MGJl MmYwM2EwYTMxMmFjZTg3YmI4NjcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3Ry YWNrL0F1ZGlvVHJhY2suY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svQXVkaW9U cmFjay5jcHAKQEAgLTE2MCw3ICsxNjAsMTAgQEAgdm9pZCBBdWRpb1RyYWNrOjpsYW5ndWFnZUNo YW5nZWQoY29uc3QgQXRvbWljU3RyaW5nJiBsYW5ndWFnZSkKIAogdm9pZCBBdWRpb1RyYWNrOjp3 aWxsUmVtb3ZlKCkKIHsKLSAgICBtZWRpYUVsZW1lbnQoKS0+cmVtb3ZlQXVkaW9UcmFjaygqdGhp cyk7CisgICAgYXV0byBlbGVtZW50ID0gbWFrZVJlZlB0cihtZWRpYUVsZW1lbnQoKSk7CisgICAg aWYgKCFlbGVtZW50KQorICAgICAgICByZXR1cm47CisgICAgZWxlbWVudC0+cmVtb3ZlQXVkaW9U cmFjaygqdGhpcyk7CiB9CiAKIHZvaWQgQXVkaW9UcmFjazo6dXBkYXRlS2luZEZyb21Qcml2YXRl KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svVmlkZW9UcmFjay5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL1ZpZGVvVHJhY2suY3BwCmluZGV4IDI4NDEzYjli OWZjMDUzZTA0NDBjNjY4YTViNWM5NWU3MmM5NjZlZWIuLjFhNGEyOTMxZTNlMjA0MGQ5YzllZmZl ZjBiNWFiNDM4NmVmZDEyYTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2sv VmlkZW9UcmFjay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9WaWRlb1RyYWNr LmNwcApAQCAtMjEwLDcgKzIxMCw4IEBAIHZvaWQgVmlkZW9UcmFjazo6c2V0TGFuZ3VhZ2UoY29u c3QgQXRvbWljU3RyaW5nJiBsYW5ndWFnZSkKIAogICAgIC8vIDQuIFF1ZXVlIGEgdGFzayB0byBm aXJlIGEgc2ltcGxlIGV2ZW50IG5hbWVkIGNoYW5nZSBhdCB0aGUgVmlkZW9UcmFja0xpc3Qgb2Jq ZWN0IHJlZmVyZW5jZWQgYnkKICAgICAvLyB0aGUgdmlkZW9UcmFja3MgYXR0cmlidXRlIG9uIHRo ZSBIVE1MTWVkaWFFbGVtZW50LgotICAgIG1lZGlhRWxlbWVudCgpLT52aWRlb1RyYWNrcygpLnNj aGVkdWxlQ2hhbmdlRXZlbnQoKTsKKyAgICBpZiAobWVkaWFFbGVtZW50KCkpCisgICAgICAgIG1l ZGlhRWxlbWVudCgpLT52aWRlb1RyYWNrcygpLnNjaGVkdWxlQ2hhbmdlRXZlbnQoKTsKIH0KIAog I2VuZGlmCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKaW5kZXggN2M5ZjM3YjBlNjkyMmYyNDMyYzY5YmQyNDgyZmQzODIyYmVlMjA4ZC4u M2RlYTNiZTQ1ZDYxZDNhMjJiZDIxNzRhNzM3NDA1YjVhNmIxNGZhZSAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEyIEBACisyMDE3LTEyLTA1ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnku Y29tPgorCisgICAgICAgIFtHVEtdIExheW91dCB0ZXN0IG1lZGlhL3RyYWNrL3RyYWNrLWluLWJh bmQtZHVwbGljYXRlLXRyYWNrcy13aGVuLXNvdXJjZS1jaGFuZ2VzLmh0bWwgY3Jhc2hlcyBhbmQg dGltZXMgb3V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNjAxMzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHBsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDE3LTEyLTA1ICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIFdQRSBn YXJkZW5pbmcuIFJlYmFzZWxpbmUgYSBxdWludGV0IG9mIFNWRyB0ZXN0cy4KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggYTA5MTYxNjc4MzgzMGEzM2RkNGIy YWRlZGQ1YmZkZDEwZGQ2ZWU4ZC4uNTk0MDhiOTMwYjljZWE3NmIwOTRjNzVlMGY3MmJiYWRiYjIz Y2M5YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlv bnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTMw NTIsNyArMzA1Miw3IEBAIHdlYmtpdC5vcmcvYi8xNjMzODMgYWNjZXNzaWJpbGl0eS9yb2xlcy1j b21wdXRlZFJvbGVTdHJpbmcuaHRtbCBbIEZhaWx1cmUgXQogCiB3ZWJraXQub3JnL2IvMTYzNTEy IG1lZGlhL21lZGlhLWNvbnRyb2xzLWFjY2Vzc2liaWxpdHkuaHRtbCBbIEZhaWx1cmUgXQogd2Vi a2l0Lm9yZy9iLzE2MzUyMSBtZWRpYS90YWItZm9jdXMtaW5zaWRlLW1lZGlhLWVsZW1lbnRzLmh0 bWwgWyBGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8xNjM1MjMgbWVkaWEvdHJhY2svdHJhY2stbWFu dWFsLW1vZGUuaHRtbCBbIEZhaWx1cmUgQ3Jhc2ggXQord2Via2l0Lm9yZy9iLzE2MzUyMyBtZWRp YS90cmFjay90cmFjay1tYW51YWwtbW9kZS5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2Iv MTYzNTI0IG1lZGlhL3RyYWNrL3ZpZGVvLXRyYWNrLWFsdGVybmF0ZS1ncm91cHMuaHRtbCBbIEZh aWx1cmUgXQogd2Via2l0Lm9yZy9iLzE2MzUyNSBtZWRpYS92aWRlby1iYWNrZ3JvdW5kLXRhYi1w bGF5YmFjay5odG1sIFsgRmFpbHVyZSBQYXNzIENyYXNoIFRpbWVvdXQgXQogd2Via2l0Lm9yZy9i LzE2MzUyNiBtZWRpYS92aWRlby1jb250cm9scy1kcm9wLWFuZC1yZXN0b3JlLXRpbWVsaW5lLmh0 bWwgWyBGYWlsdXJlIF0KQEAgLTM1MDEsOSArMzUwMSw3IEBAIHdlYmtpdC5vcmcvYi8xNjAxMTkg aW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFudGljcy9lbWJlZGRlZC1j b250CiAKIHdlYmtpdC5vcmcvYi8xNjAxMTkgbWVkaWEvY2xpY2stdm9sdW1lLWJhci1ub3QtcGF1 c2luZy5odG1sIFsgVGltZW91dCBGYWlsdXJlIFBhc3MgXQogCi0jIFRoaXMgb25lIGhhcyBpdHMg b3duIGJ1ZyBiZWNhdXNlIHRoZSBjcmFzaGVzIHdlcmUgcHJlZXhpc3Rpbmc7IG9ubHkgdGhlCi0j IHRpbWVvdXQgaXMgY2F1c2VkIGJ5IHRoZSBzd2l0Y2ggdG8gdGhyZWFkZWQgY29tcG9zaXRvci4K LXdlYmtpdC5vcmcvYi8xNjAxMzEgbWVkaWEvdHJhY2svdHJhY2staW4tYmFuZC1kdXBsaWNhdGUt dHJhY2tzLXdoZW4tc291cmNlLWNoYW5nZXMuaHRtbCBbIENyYXNoIFRpbWVvdXQgUGFzcyBdCit3 ZWJraXQub3JnL2IvMTYwMTMxIG1lZGlhL3RyYWNrL3RyYWNrLWluLWJhbmQtZHVwbGljYXRlLXRy YWNrcy13aGVuLXNvdXJjZS1jaGFuZ2VzLmh0bWwgWyBUaW1lb3V0IFBhc3MgXQogCiB3ZWJraXQu b3JnL2IvMTYwMTMxIHBsdWdpbnMvcmV0dXJuLWVycm9yLWZyb20tbmV3LXN0cmVhbS1kb2VzbnQt aW52b2tlLWRlc3Ryb3ktc3RyZWFtLmh0bWwgWyBUaW1lb3V0IFBhc3MgXQogCg== 334267 2018-02-20 07:13:06 -0800 2018-02-21 03:43:07 -0800 Patch bug-160131-20180220151305.patch text/plain 2808 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4ODE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjA0OGUwZWY2ODZjZDg2 YWUzYmJiZmFhZmFjZTE0MWVlZWRiNDUzMC4uNDEyZGE5NDA2MzQwMWMyNjNlYjllZWVhOGUxZTZk NzE2OTlmZDJlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTAyLTIwICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBMYXlv dXQgdGVzdCBtZWRpYS90cmFjay90cmFjay1pbi1iYW5kLWR1cGxpY2F0ZS10cmFja3Mtd2hlbi1z b3VyY2UtY2hhbmdlcy5odG1sIGZhaWxpbmcgc2luY2UgcjIyODYxNworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwMTMxCisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS8zNTg3Mzk4NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZh dGVHU3RyZWFtZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyOjpub3RpZnlQbGF5ZXJPZlRleHQpOiBXZQorICAgICAgICBjYW4ndCBhc3N1bWUgdGhl IHBhZCBoYXMgYSBzdGlja3kgZXZlbnQgaGVyZSBsaWtlIGltcGxlbWVudGVkIGluCisgICAgICAg IEluYmFuZFRleHRUcmFja1ByaXZhdGVHU3RyZWFtZXIgYmVjYXVzZSBpdCBtaWdodCBiZSBlbWl0 dGVkIGFmdGVyCisgICAgICAgIHRoZSB0cmFjayB3YXMgY3JlYXRlZC4gU28gZmFsbGJhY2sgdG8g YSBkdW1teSBzdHJlYW0gSUQgbGlrZSBpbgorICAgICAgICB0aGUgQXVkaW8gYW5kIFZpZGVvIHRy YWNrcy4KKwogMjAxOC0wMi0yMCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5j b20+CiAKICAgICAgICAgW0dTdHJlYW1lcl1bTWluaUJyb3dzZXJdIEhvbm9yIEdTdHJlYW1lciBj b21tYW5kIGxpbmUgcGFyYW1ldGVycyBpbiBNaW5pQnJvd3NlcgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIv TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAppbmRleCAxZTJmNWYwYWVkNTc3MzM5M2M2 YjE3YmVmNTQ0ZTcwZjVlZDZiODQwLi4yZGI2ZjZlNTg3YzYyNDU5ZDRhM2E1Nzk4NzY1ZjAzNTQ5 NDUwMDYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3Ry ZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy LmNwcApAQCAtOTI0LDYgKzkyNCw4IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy Ojpub3RpZnlQbGF5ZXJPZlRleHQoKQogICAgIEdzdEVsZW1lbnQqIGVsZW1lbnQgPSB1c2VNZWRp YVNvdXJjZSA/IG1fc291cmNlLmdldCgpIDogbV9waXBlbGluZS5nZXQoKTsKICAgICBnX29iamVj dF9nZXQoZWxlbWVudCwgIm4tdGV4dCIsICZudW1UcmFja3MsIG51bGxwdHIpOwogCisgICAgR1NU X0lORk8oIk1lZGlhIGhhcyAlZCB0ZXh0IHRyYWNrcyIsIG51bVRyYWNrcyk7CisKICAgICBpZiAo dXNlTWVkaWFTb3VyY2UpIHsKICAgICAgICAgR1NUX0RFQlVHKCJUcmFja3MgbWFuYWdlZCBieSBz b3VyY2UgZWxlbWVudC4gQmFpbGluZyBvdXQgbm93LiIpOwogICAgICAgICByZXR1cm47CkBAIC05 MzUsMTIgKzkzNywxMSBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6bm90aWZ5 UGxheWVyT2ZUZXh0KCkKICAgICAgICAgZ19zaWduYWxfZW1pdF9ieV9uYW1lKG1fcGlwZWxpbmUu Z2V0KCksICJnZXQtdGV4dC1wYWQiLCBpLCAmcGFkLm91dFB0cigpLCBudWxscHRyKTsKICAgICAg ICAgQVNTRVJUKHBhZCk7CiAKLSAgICAgICAgR1JlZlB0cjxHc3RFdmVudD4gZXZlbnQgPSBhZG9w dEdSZWYoZ3N0X3BhZF9nZXRfc3RpY2t5X2V2ZW50KHBhZC5nZXQoKSwgR1NUX0VWRU5UX1NUUkVB TV9TVEFSVCwgMCkpOwotICAgICAgICBpZiAoIWV2ZW50KQotICAgICAgICAgICAgY29udGludWU7 Ci0KLSAgICAgICAgY29uc3QgY2hhciogc3RyZWFtSWQ7Ci0gICAgICAgIGdzdF9ldmVudF9wYXJz ZV9zdHJlYW1fc3RhcnQoZXZlbnQuZ2V0KCksICZzdHJlYW1JZCk7CisgICAgICAgIC8vIFdlIGNh bid0IGFzc3VtZSB0aGUgcGFkIGhhcyBhIHN0aWNreSBldmVudCBoZXJlIGxpa2UgaW1wbGVtZW50 ZWQgaW4KKyAgICAgICAgLy8gSW5iYW5kVGV4dFRyYWNrUHJpdmF0ZUdTdHJlYW1lciBiZWNhdXNl IGl0IG1pZ2h0IGJlIGVtaXR0ZWQgYWZ0ZXIgdGhlCisgICAgICAgIC8vIHRyYWNrIHdhcyBjcmVh dGVkLiBTbyBmYWxsYmFjayB0byBhIGR1bW15IHN0cmVhbSBJRCBsaWtlIGluIHRoZSBBdWRpbwor ICAgICAgICAvLyBhbmQgVmlkZW8gdHJhY2tzLgorICAgICAgICBTdHJpbmcgc3RyZWFtSWQgPSAi VCIgKyBTdHJpbmc6Om51bWJlcihpKTsKIAogICAgICAgICB2YWxpZFRleHRTdHJlYW1zLmFwcGVu ZChzdHJlYW1JZCk7CiAgICAgICAgIGlmIChpIDwgc3RhdGljX2Nhc3Q8Z2ludD4obV90ZXh0VHJh Y2tzLnNpemUoKSkpIHsK