160118 2016-07-23 07:09:42 -0700 [Coordinated Graphics] Lots of flaky tests 2016-07-23 15:37:50 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 154066 1 cgarcia webkit-unassigned bugs-noreply commit-queue mcatanzaro oldest_to_newest 1213909 0 cgarcia 2016-07-23 07:09:42 -0700 Since the GTK+ ported to threaded compositor (coordinated graphics) there are a lot of flaky tests in the bots. In manu of the cases the diff shows a different size in the FrameView layer: -layer at (0,0) size 800x600 - RenderView at (0,0) size 800x600 -layer at (0,0) size 800x600 - RenderBlock {HTML} at (0,0) size 800x600 - RenderBody {BODY} at (8,8) size 784x584 - RenderBlock {H1} at (0,0) size 784x36 +layer at (0,0) size 400x474 + RenderView at (0,0) size 400x400 +layer at (0,0) size 400x474 + RenderBlock {HTML} at (0,0) size 400x475 + RenderBody {BODY} at (8,8) size 384x459 + RenderBlock {H1} at (0,0) size 384x36 This happens for tests run in the same WTR after fast/fixed-layout/fixed-layout.html. This is what happens: 1.- Test fast/fixed-layout/fixed-layout.html runs and sets fixed layout to true and fixed layout size to 400x400 2.- When it finishes TestController::resetStateToConsistentValues() is called. 3.- Blank URL is loaded after state has been updated 4.- Then Reset message is handled in the web process and Internals::resetToConsistentState() resets the fixed layout state and size. 5.- onresize happens and the handler set in fast/fixed-layout/fixed-layout.html is invoked setting the fixed layout to true and size to 400x400 again. 6.- about_blank is then loaded with the fixed layout enabled, as well as other tests after this one. In addition to this, coordinated graphics uses a fixedVisibleContentRect in ScrollView that is never reset. 1213910 1 284417 cgarcia 2016-07-23 07:14:55 -0700 Created attachment 284417 Patch 1213911 2 284417 mcatanzaro 2016-07-23 07:50:19 -0700 Comment on attachment 284417 Patch I think the iOS and macOS failures are unrelated to your change, r=me. 1213917 3 284417 commit-queue 2016-07-23 08:26:44 -0700 Comment on attachment 284417 Patch Clearing flags on attachment: 284417 Committed r203644: <http://trac.webkit.org/changeset/203644> 1213918 4 commit-queue 2016-07-23 08:26:48 -0700 All reviewed patches have been landed. Closing bug. 1213962 5 mcatanzaro 2016-07-23 15:37:50 -0700 I think this change itself broke several tests.I'm going to choose to mark these against bug #160119 rather than this one to keep things simple, but the ones I think it broke are: fast/forms/select/select-painting.html fast/images/animated-png.html fast/images/background-position.html fast/forms/select/listbox-disabled-no-autoscroll.html 284417 2016-07-23 07:14:55 -0700 2016-07-23 08:26:44 -0700 Patch wk2-coordinated-graphics-flaky.diff text/plain 5293 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3ZjY1MGFjLi5kY2M1Yzk1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTYtMDct MjMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAg IFtDb29yZGluYXRlZCBHcmFwaGljc10gTG90cyBvZiBmbGFreSB0ZXN0cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwMTE4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2ZpeGVkLWxheW91dC9m aXhlZC1sYXlvdXQuaHRtbDogUmVtb3ZlIHRoZSBvbnJlc2l6ZSBoYW5kbGVyIHdoZW4gdGhlIHRl c3QgZmluaXNoZXMgdG8gZW5zdXJlIGl0IGNhbid0IGJlCisgICAgICAgIGNhbGxlZCBsYXRlciBh ZmZlY3Rpbmcgb3RoZXIgdGVzdHMuCisKIDIwMTYtMDctMjEgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIHBhcmFtZXRlcnMgdG8gRWxlbWVudC5nZXRFbGVt ZW50c0J5KigpIG9wZXJhdGlvbnMgbWFuZGF0b3J5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L2ZpeGVkLWxheW91dC9maXhlZC1sYXlvdXQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZml4 ZWQtbGF5b3V0L2ZpeGVkLWxheW91dC5odG1sCmluZGV4IDM4NTk3NzUuLmZkOGMzYjQgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZml4ZWQtbGF5b3V0L2ZpeGVkLWxheW91dC5odG1sCisr KyBiL0xheW91dFRlc3RzL2Zhc3QvZml4ZWQtbGF5b3V0L2ZpeGVkLWxheW91dC5odG1sCkBAIC0y MSw2ICsyMSw3IEBAIHdpbmRvdy5vbnJlc2l6ZSA9IGZ1bmN0aW9uICgpIHsKICAgICBpbnRlcm5h bHMuc2V0Rml4ZWRMYXlvdXRTaXplKDQwMCwgNDAwKTsKIAogICAgIHRlc3RSdW5uZXIubm90aWZ5 RG9uZSgpOworICAgIHdpbmRvdy5vbnJlc2l6ZSA9IG51bGw7CiB9CiA8L3NjcmlwdD4KIDwvaGVh ZD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCBlMTYzNTdkLi5jNWVjMzQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEs MzYgQEAKIDIwMTYtMDctMjMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEu Y29tPgogCisgICAgICAgIFtDb29yZGluYXRlZCBHcmFwaGljc10gTG90cyBvZiBmbGFreSB0ZXN0 cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwMTE4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2Ug dGhlIEdUSysgcG9ydGVkIHRvIHRocmVhZGVkIGNvbXBvc2l0b3IgKGNvb3JkaW5hdGVkIGdyYXBo aWNzKSB0aGVyZSBhcmUgYSBsb3Qgb2YgZmxha3kgdGVzdHMgaW4gdGhlCisgICAgICAgIGJvdHMu IEluIG1hbnUgb2YgdGhlIGNhc2VzIHRoZSBkaWZmIHNob3dzIGEgZGlmZmVyZW50IHNpemUgaW4g dGhlIEZyYW1lVmlldyBsYXllci4KKworICAgICAgICBUaGlzIGhhcHBlbnMgZm9yIHRlc3RzIHJ1 biBpbiB0aGUgc2FtZSBXVFIgYWZ0ZXIgZmFzdC9maXhlZC1sYXlvdXQvZml4ZWQtbGF5b3V0Lmh0 bWwuIFRoaXMgaXMgd2hhdCBoYXBwZW5zOgorCisgICAgICAgICAxLi0gVGVzdCBmYXN0L2ZpeGVk LWxheW91dC9maXhlZC1sYXlvdXQuaHRtbCBydW5zIGFuZCBzZXRzIGZpeGVkIGxheW91dCB0byB0 cnVlIGFuZCBmaXhlZCBsYXlvdXQgc2l6ZSB0byA0MDB4NDAwCisgICAgICAgICAyLi0gV2hlbiBp dCBmaW5pc2hlcyBUZXN0Q29udHJvbGxlcjo6cmVzZXRTdGF0ZVRvQ29uc2lzdGVudFZhbHVlcygp IGlzIGNhbGxlZC4KKyAgICAgICAgIDMuLSBCbGFuayBVUkwgaXMgbG9hZGVkIGFmdGVyIHN0YXRl IGhhcyBiZWVuIHVwZGF0ZWQKKyAgICAgICAgIDQuLSBUaGVuIFJlc2V0IG1lc3NhZ2UgaXMgaGFu ZGxlZCBpbiB0aGUgd2ViIHByb2Nlc3MgYW5kIEludGVybmFsczo6cmVzZXRUb0NvbnNpc3RlbnRT dGF0ZSgpIHJlc2V0cyB0aGUgZml4ZWQKKyAgICAgICAgICAgICBsYXlvdXQgc3RhdGUgYW5kIHNp emUuCisgICAgICAgICA1Li0gb25yZXNpemUgaGFwcGVucyBhbmQgdGhlIGhhbmRsZXIgc2V0IGlu IGZhc3QvZml4ZWQtbGF5b3V0L2ZpeGVkLWxheW91dC5odG1sIGlzIGludm9rZWQgc2V0dGluZyB0 aGUgZml4ZWQKKyAgICAgICAgICAgICBsYXlvdXQgdG8gdHJ1ZSBhbmQgc2l6ZSB0byA0MDB4NDAw IGFnYWluLgorICAgICAgICAgNi4tIGFib3V0X2JsYW5rIGlzIHRoZW4gbG9hZGVkIHdpdGggdGhl IGZpeGVkIGxheW91dCBlbmFibGVkLCBhcyB3ZWxsIGFzIG90aGVyIHRlc3RzIGFmdGVyIHRoaXMg b25lLgorCisgICAgICAgIEluIGFkZGl0aW9uIHRvIHRoaXMsIGNvb3JkaW5hdGVkIGdyYXBoaWNz IHVzZXMgYSBmaXhlZFZpc2libGVDb250ZW50UmVjdCBpbiBTY3JvbGxWaWV3IHRoYXQgaXMgbmV2 ZXIgcmVzZXQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlNjcm9sbFZpZXc6OnVuc2NhbGVkVmlzaWJsZUNvbnRlbnRTaXplSW5jbHVkaW5n T2JzY3VyZWRBcmVhKTogT25seSB1c2UgbV9maXhlZFZpc2libGVDb250ZW50UmVjdCB3aGVuCisg ICAgICAgIGZpeGVkIGxheW91dCBpcyBlbmFibGVkLgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xs Vmlldzo6dW5zY2FsZWRVbm9ic2N1cmVkVmlzaWJsZUNvbnRlbnRTaXplKTogRGl0dG8uCisgICAg ICAgIChXZWJDb3JlOjpTY3JvbGxWaWV3Ojp2aXNpYmxlQ29udGVudFJlY3RJbnRlcm5hbCk6IERp dHRvLgorICAgICAgICAqIHRlc3RpbmcvSW50ZXJuYWxzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkludGVybmFsczo6cmVzZXRUb0NvbnNpc3RlbnRTdGF0ZSk6IFJlc2V0IGFsc28gdGhlIG1fZml4 ZWRWaXNpYmxlQ29udGVudFJlY3QuCisKKzIwMTYtMDctMjMgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtDb29yZGluYXRlZCBHcmFwaGljc10g VGVzdCBmYXN0L2ZpeGVkLWxheW91dC9maXhlZC1sYXlvdXQuaHRtbCBjcmFzaGVzIGluIGRlYnVn CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjAxMTcK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcAppbmRleCA5M2QyNDg1Li5jMWFi MmNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcApAQCAtMjU4LDcgKzI1 OCw3IEBAIEludFNpemUgU2Nyb2xsVmlldzo6dW5zY2FsZWRWaXNpYmxlQ29udGVudFNpemVJbmNs dWRpbmdPYnNjdXJlZEFyZWEoVmlzaWJsZUNvbnRlCiAgICAgICAgIHJldHVybiBwbGF0Zm9ybVZp c2libGVDb250ZW50U2l6ZUluY2x1ZGluZ09ic2N1cmVkQXJlYShzY3JvbGxiYXJJbmNsdXNpb24g PT0gSW5jbHVkZVNjcm9sbGJhcnMpOwogCiAjaWYgVVNFKENPT1JESU5BVEVEX0dSQVBISUNTKQot ICAgIGlmICghbV9maXhlZFZpc2libGVDb250ZW50UmVjdC5pc0VtcHR5KCkpCisgICAgaWYgKG1f dXNlRml4ZWRMYXlvdXQgJiYgIW1fZml4ZWRWaXNpYmxlQ29udGVudFJlY3QuaXNFbXB0eSgpKQog ICAgICAgICByZXR1cm4gbV9maXhlZFZpc2libGVDb250ZW50UmVjdC5zaXplKCk7CiAjZW5kaWYK IApAQCAtMjc3LDcgKzI3Nyw3IEBAIEludFNpemUgU2Nyb2xsVmlldzo6dW5zY2FsZWRVbm9ic2N1 cmVkVmlzaWJsZUNvbnRlbnRTaXplKFZpc2libGVDb250ZW50UmVjdEluY2x1CiAgICAgICAgIHJl dHVybiBwbGF0Zm9ybVZpc2libGVDb250ZW50U2l6ZShzY3JvbGxiYXJJbmNsdXNpb24gPT0gSW5j bHVkZVNjcm9sbGJhcnMpOwogCiAjaWYgVVNFKENPT1JESU5BVEVEX0dSQVBISUNTKQotICAgIGlm ICghbV9maXhlZFZpc2libGVDb250ZW50UmVjdC5pc0VtcHR5KCkpCisgICAgaWYgKG1fdXNlRml4 ZWRMYXlvdXQgJiYgIW1fZml4ZWRWaXNpYmxlQ29udGVudFJlY3QuaXNFbXB0eSgpKQogICAgICAg ICByZXR1cm4gdmlzaWJsZUNvbnRlbnRTaXplOwogI2VuZGlmCiAKQEAgLTMwMyw3ICszMDMsNyBA QCBJbnRSZWN0IFNjcm9sbFZpZXc6OnZpc2libGVDb250ZW50UmVjdEludGVybmFsKFZpc2libGVD b250ZW50UmVjdEluY2x1ZGVzU2Nyb2xsYgogICAgICAgICByZXR1cm4gcGxhdGZvcm1WaXNpYmxl Q29udGVudFJlY3Qoc2Nyb2xsYmFySW5jbHVzaW9uID09IEluY2x1ZGVTY3JvbGxiYXJzKTsKIAog I2lmIFVTRShDT09SRElOQVRFRF9HUkFQSElDUykKLSAgICBpZiAoIW1fZml4ZWRWaXNpYmxlQ29u dGVudFJlY3QuaXNFbXB0eSgpKQorICAgIGlmIChtX3VzZUZpeGVkTGF5b3V0ICYmICFtX2ZpeGVk VmlzaWJsZUNvbnRlbnRSZWN0LmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuIG1fZml4ZWRWaXNp YmxlQ29udGVudFJlY3Q7CiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvdGVz dGluZy9JbnRlcm5hbHMuY3BwIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3Bw CmluZGV4IGNmMTllYTYuLmZhMjg4MGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Rlc3Rp bmcvSW50ZXJuYWxzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5j cHAKQEAgLTM3NSw2ICszNzUsOSBAQCB2b2lkIEludGVybmFsczo6cmVzZXRUb0NvbnNpc3RlbnRT dGF0ZShQYWdlJiBwYWdlKQogICAgICAgICBwYWdlLnNldFRvcENvbnRlbnRJbnNldCgwKTsKICAg ICAgICAgbWFpbkZyYW1lVmlldy0+c2V0VXNlRml4ZWRMYXlvdXQoZmFsc2UpOwogICAgICAgICBt YWluRnJhbWVWaWV3LT5zZXRGaXhlZExheW91dFNpemUoSW50U2l6ZSgpKTsKKyNpZiBVU0UoQ09P UkRJTkFURURfR1JBUEhJQ1MpCisgICAgICAgIG1haW5GcmFtZVZpZXctPnNldEZpeGVkVmlzaWJs ZUNvbnRlbnRSZWN0KEludFJlY3QoKSk7CisjZW5kaWYKICAgICB9CiAKICAgICBXZWJDb3JlOjpv dmVycmlkZVVzZXJQcmVmZXJyZWRMYW5ndWFnZXMoVmVjdG9yPFN0cmluZz4oKSk7Cg==