<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>160115</bug_id>
          
          <creation_ts>2016-07-22 23:46:28 -0700</creation_ts>
          <short_desc>Adding a new WebCore JavaScript built-in source file does not trigger rebuild of WebCoreJSBuiltins*</short_desc>
          <delta_ts>2016-07-25 13:27:15 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Bindings</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Darin Adler">darin</reporter>
          <assigned_to name="Darin Adler">darin</assigned_to>
          <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>mitz</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>sam</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1213864</commentid>
    <comment_count>0</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2016-07-22 23:46:28 -0700</bug_when>
    <thetext>Addng a new WebCore JavaScript built-in source file does not trigger rebuild of WebCoreJSBuiltins*</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1213865</commentid>
    <comment_count>1</comment_count>
      <attachid>284405</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2016-07-22 23:49:49 -0700</bug_when>
    <thetext>Created attachment 284405
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1213866</commentid>
    <comment_count>2</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2016-07-22 23:51:15 -0700</bug_when>
    <thetext>I ran into this when I checked out the latest sources but they failed to link because XMLHttpRequest was not included in WebCoreJSBuiltins.cpp.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1213867</commentid>
    <comment_count>3</comment_count>
      <attachid>284405</attachid>
    <who name="youenn fablet">youennf</who>
    <bug_when>2016-07-23 00:17:03 -0700</bug_when>
    <thetext>Comment on attachment 284405
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284405&amp;action=review

Thanks!

&gt; Source/WebCore/DerivedSources.make:1334
&gt; +	$(PYTHON) $(JavaScriptCore_SCRIPTS_DIR)/UpdateContents.py &apos;$(WebCore_BUILTINS_SOURCES)&apos; $@

Why is this needed?

&gt; Source/WebCore/DerivedSources.make:1339
&gt; +$(firstword $(WebCore_BUILTINS_WRAPPERS)): WebCore_BUILTINS_SOURCES_LIST $(BUILTINS_GENERATOR_SCRIPTS) WebCore_BUILTINS_DEPENDENCIES_LIST

Cannot we just use $(WebCore_BUILTINS_SOURCES) here?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1214033</commentid>
    <comment_count>4</comment_count>
      <attachid>284444</attachid>
    <who name="youenn fablet">youennf</who>
    <bug_when>2016-07-24 03:24:02 -0700</bug_when>
    <thetext>Created attachment 284444
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1214034</commentid>
    <comment_count>5</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2016-07-24 03:24:29 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; Created attachment 284444 [details]
&gt; Patch for landing

Updated bug title in log.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1214035</commentid>
    <comment_count>6</comment_count>
      <attachid>284444</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-07-24 04:11:05 -0700</bug_when>
    <thetext>Comment on attachment 284444
Patch for landing

Clearing flags on attachment: 284444

Committed r203661: &lt;http://trac.webkit.org/changeset/203661&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1214036</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-07-24 04:11:10 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1214053</commentid>
    <comment_count>8</comment_count>
      <attachid>284405</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2016-07-24 10:27:22 -0700</bug_when>
    <thetext>Comment on attachment 284405
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284405&amp;action=review

&gt;&gt; Source/WebCore/DerivedSources.make:1334
&gt;&gt; +	$(PYTHON) $(JavaScriptCore_SCRIPTS_DIR)/UpdateContents.py &apos;$(WebCore_BUILTINS_SOURCES)&apos; $@
&gt; 
&gt; Why is this needed?

Because generating the wrappers depends on the *list* of JS files, not on the contents of those files, and further it needs to depend on removals as well as additions to that list. This technique gives us a file that changes when the filenames in the list change.

&gt;&gt; Source/WebCore/DerivedSources.make:1339
&gt;&gt; +$(firstword $(WebCore_BUILTINS_WRAPPERS)): WebCore_BUILTINS_SOURCES_LIST $(BUILTINS_GENERATOR_SCRIPTS) WebCore_BUILTINS_DEPENDENCIES_LIST
&gt; 
&gt; Cannot we just use $(WebCore_BUILTINS_SOURCES) here?

No. Doing that would rebuild:

1) Too often. Any time we changed the contents of one of the sources.
2) Not often enough. Would not trigger a rebuild if we removed a file from the list.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1214323</commentid>
    <comment_count>9</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2016-07-25 13:27:15 -0700</bug_when>
    <thetext>(In reply to comment #8)
&gt; Comment on attachment 284405 [details]
&gt; Patch
&gt; 
&gt; &gt;&gt; Source/WebCore/DerivedSources.make:1339
&gt; &gt;&gt; +$(firstword $(WebCore_BUILTINS_WRAPPERS)): WebCore_BUILTINS_SOURCES_LIST $(BUILTINS_GENERATOR_SCRIPTS) WebCore_BUILTINS_DEPENDENCIES_LIST
&gt; &gt; 
&gt; &gt; Cannot we just use $(WebCore_BUILTINS_SOURCES) here?
&gt; 
&gt; No. Doing that would rebuild:
&gt; 
&gt; 1) Too often. Any time we changed the contents of one of the sources.

I see the point.
That said, even if sources are changed, like adding a function, the header/source files will remain totally unchanged (lazy writer). So the perf loss is only the time spent to run the python generator. It does not trigger any compilation.

In the future, if we remove the use of macros, we might want to update wrapper cpp files according source file content. We can revisit this if we ever go down that path

Also, it might be good to think of the best way to limit the recompilation of cpp files in case of adding/removing a function.

&gt; 2) Not often enough. Would not trigger a rebuild if we removed a file from
&gt; the list.

OK</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>284405</attachid>
            <date>2016-07-22 23:49:49 -0700</date>
            <delta_ts>2016-07-24 03:23:43 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-160115-20160722234847.patch</filename>
            <type>text/plain</type>
            <size>4315</size>
            <attacher name="Darin Adler">darin</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzNjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk
YmVkNGJmNDdiMTlkNWNmNDFiMzVmZGUzZWUxNDJjNzM0ZDdmNzJiLi5iNjYxN2Q2NjdiZmY4NDc1
YmU2M2U5ODJiNjNjNjhkNjA1ODY2OTJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxMiBAQAorMjAxNi0wNy0yMiAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CisK
KyAgICAgICAgQWRkbmcgYSBuZXcgV2ViQ29yZSBKYXZhU2NyaXB0IGJ1aWx0LWluIHNvdXJjZSBm
aWxlIGRvZXMgbm90IHRyaWdnZXIgcmVidWlsZCBvZiBXZWJDb3JlSlNCdWlsdGlucyoKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDExNQorCisgICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbWFrZS1nZW5lcmF0
ZWQtc291cmNlcy5zaDogUmVtb3ZlZC4gV2FzIHVudXNlZC4KKwogMjAxNi0wNy0yMSAgRmlsaXAg
UGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFRlYWNoIE1hcmtlZFNwYWNlIGhv
dyB0byBhbGxvY2F0ZSBhdXhpbGlhcnkgc3RvcmFnZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv
cmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGQxYjRiNTNkMGQ5
MjZiYzAxYTE4MWVhMDM1MTdkNWU0MDcwYzRjMzEuLjc1ZGY3MWI5MjY5YTg4ZjIwN2EzZDBlOWJm
NmVkYmU4OTE4OTViNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysg
Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNi0wNy0yMiAg
RGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkbmcgYSBuZXcgV2Vi
Q29yZSBKYXZhU2NyaXB0IGJ1aWx0LWluIHNvdXJjZSBmaWxlIGRvZXMgbm90IHRyaWdnZXIgcmVi
dWlsZCBvZiBXZWJDb3JlSlNCdWlsdGlucyoKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTE2MDExNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgICogRGVyaXZlZFNvdXJjZXMubWFrZTogQWRkZWQgYSBtaXNzaW5n
IGRlcGVuZGVuY3kgc28gdGhlIHJ1bGUgdGhhdCBidWlsZHMgV2ViQ29yZV9CVUlMVElOU19XUkFQ
UEVSUworICAgICAgICBraWNrcyBpbiB3aGVuIHRoZSBsaXN0IG9mIFdlYkNvcmVfQlVJTFRJTlNf
U09VUkNFUyBpcyBtb2RpZmllZC4gQWxzbyBhZGRlZCBhbm90aGVyIG1pc3NpbmcgZGVwZW5kZW5j
eQorICAgICAgICBzbyB0aGF0IGNoYW5nZXMgdG8gdGhlIEphdmFTY3JpcHQgYnVpbHQtaW5zIFB5
dGhvbiBzY3JpcHRzIHdpbGwgYWxzbyB0cmlnZ2VyIFdlYkNvcmVfQlVJTFRJTlNfV1JBUFBFUlMu
CisKKyAgICAgICAgKiBtYWtlLWdlbmVyYXRlZC1zb3VyY2VzLnNoOiBSZW1vdmVkLiBXYXMgdW51
c2VkLgorCiAyMDE2LTA3LTIyICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAg
ICAgICAgSGFuZGxlIGNhc2VzIHdoZW4gSU9TdXJmYWNlIGluaXRpYWxpemF0aW9uIGZhaWxzLgpk
aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL21ha2UtZ2VuZXJhdGVkLXNvdXJjZXMu
c2ggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbWFrZS1nZW5lcmF0ZWQtc291cmNlcy5zaApkZWxl
dGVkIGZpbGUgbW9kZSAxMDA3NTUKaW5kZXggY2NmZWVkZDYxNDJiZTYzZDVjZDRkZjQxZTI5MDUx
NmE5YmQxMjE4YS4uMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMAotLS0g
YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbWFrZS1nZW5lcmF0ZWQtc291cmNlcy5zaAorKysgL2Rl
di9udWxsCkBAIC0xLDEyICswLDAgQEAKLSMhL2Jpbi9zaAotCi1leHBvcnQgU1JDUk9PVD0kUFdE
Ci1leHBvcnQgQ1JFQVRFX0hBU0hfVEFCTEU9IiRTUkNST09UL2NyZWF0ZV9oYXNoX3RhYmxlIgot
ZXhwb3J0IENSRUFURV9SRUdFWFBfVEFCTEVTPSIkU1JDUk9PVC9jcmVhdGVfcmVnZXhfdGFibGVz
IgotZXhwb3J0IENSRUFURV9LRVlXT1JEX0xPT0tVUD0iJFNSQ1JPT1QvS2V5d29yZExvb2t1cEdl
bmVyYXRvci5weSIKLQotbWtkaXIgLXAgRGVyaXZlZFNvdXJjZXMvSmF2YVNjcmlwdENvcmUKLWNk
IERlcml2ZWRTb3VyY2VzL0phdmFTY3JpcHRDb3JlCi0KLW1ha2UgLWYgLi4vLi4vRGVyaXZlZFNv
dXJjZXMubWFrZSBKYXZhU2NyaXB0Q29yZT0uLi8uLiBCVUlMVF9QUk9EVUNUU19ESVI9Li4vLi4K
LWNkIC4uLy4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9EZXJpdmVkU291cmNlcy5tYWtl
IGIvU291cmNlL1dlYkNvcmUvRGVyaXZlZFNvdXJjZXMubWFrZQppbmRleCA0MjIzNWViMTM0NzA3
NjZmZmI3NjgzODBlYWY0YTM3Y2RlNmVjZGFjLi4wZTcyYjg2NTYyNGNjMTZhNWY4Y2U2ZTIwY2U5
YTgyYjNmYjUxNTg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9EZXJpdmVkU291cmNlcy5t
YWtlCisrKyBiL1NvdXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3VyY2VzLm1ha2UKQEAgLTEzMjksMTAg
KzEzMjksMTQgQEAgV2ViQ29yZV9CVUlMVElOU19XUkFQUEVSUyA9IFwKICMgZ2VuZXJhdGVkIHNo
b3VsZCBub3QgYWZmZWN0IG90aGVyIGJ1aWx0aW5zIHdoZW4gbm90IHBhc3NpbmcgJy0tY29tYmlu
ZWQnIHRvIHRoZSBnZW5lcmF0b3IuCiAKIC5QSE9OWTogZm9yY2UKKworV2ViQ29yZV9CVUlMVElO
U19TT1VSQ0VTX0xJU1QgOiAkKEphdmFTY3JpcHRDb3JlX1NDUklQVFNfRElSKS9VcGRhdGVDb250
ZW50cy5weSBmb3JjZQorCSQoUFlUSE9OKSAkKEphdmFTY3JpcHRDb3JlX1NDUklQVFNfRElSKS9V
cGRhdGVDb250ZW50cy5weSAnJChXZWJDb3JlX0JVSUxUSU5TX1NPVVJDRVMpJyAkQAorCiBXZWJD
b3JlX0JVSUxUSU5TX0RFUEVOREVOQ0lFU19MSVNUIDogJChKYXZhU2NyaXB0Q29yZV9TQ1JJUFRT
X0RJUikvVXBkYXRlQ29udGVudHMucHkgZm9yY2UKIAkkKFBZVEhPTikgJChKYXZhU2NyaXB0Q29y
ZV9TQ1JJUFRTX0RJUikvVXBkYXRlQ29udGVudHMucHkgJyQoQlVJTFRJTlNfR0VORVJBVE9SX1ND
UklQVFMpJyAkQAogCi0kKGZpcnN0d29yZCAkKFdlYkNvcmVfQlVJTFRJTlNfV1JBUFBFUlMpKTog
V2ViQ29yZV9CVUlMVElOU19ERVBFTkRFTkNJRVNfTElTVAorJChmaXJzdHdvcmQgJChXZWJDb3Jl
X0JVSUxUSU5TX1dSQVBQRVJTKSk6IFdlYkNvcmVfQlVJTFRJTlNfU09VUkNFU19MSVNUICQoQlVJ
TFRJTlNfR0VORVJBVE9SX1NDUklQVFMpIFdlYkNvcmVfQlVJTFRJTlNfREVQRU5ERU5DSUVTX0xJ
U1QKIAkkKFBZVEhPTikgJChKYXZhU2NyaXB0Q29yZV9TQ1JJUFRTX0RJUikvZ2VuZXJhdGUtanMt
YnVpbHRpbnMucHkgLS13cmFwcGVycy1vbmx5IC0tb3V0cHV0LWRpcmVjdG9yeSAuIC0tZnJhbWV3
b3JrIFdlYkNvcmUgJChXZWJDb3JlX0JVSUxUSU5TX1NPVVJDRVMpCiAKICVCdWlsdGlucy5oOiAl
LmpzICQoQlVJTFRJTlNfR0VORVJBVE9SX1NDUklQVFMpIFdlYkNvcmVfQlVJTFRJTlNfREVQRU5E
RU5DSUVTX0xJU1QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL21ha2UtZ2VuZXJhdGVkLXNv
dXJjZXMuc2ggYi9Tb3VyY2UvV2ViQ29yZS9tYWtlLWdlbmVyYXRlZC1zb3VyY2VzLnNoCmRlbGV0
ZWQgZmlsZSBtb2RlIDEwMDc1NQppbmRleCBkYmVlNzE1ZTQ2ODZiOTFkYjc2NjRmNzQ0MjBjNTI1
Njg1ODQ0ZGM1Li4wMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwCi0tLSBh
L1NvdXJjZS9XZWJDb3JlL21ha2UtZ2VuZXJhdGVkLXNvdXJjZXMuc2gKKysrIC9kZXYvbnVsbApA
QCAtMSwxMCArMCwwIEBACi0jIS9iaW4vc2gKLWV4cG9ydCBTT1VSQ0VfUk9PVD0kUFdECi1leHBv
cnQgU1JDUk9PVD0kUFdECi1leHBvcnQgV2ViQ29yZT0kUFdECi1leHBvcnQgSW5zcGVjdG9yU2Ny
aXB0cz0kUFdELy4uL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzCi1leHBvcnQgV2Vi
UmVwbGF5U2NyaXB0cz0kUFdELy4uL0phdmFTY3JpcHRDb3JlL3JlcGxheS9zY3JpcHRzCi1leHBv
cnQgR2VuZXJhdGVKU0J1aWx0aW5zU2NyaXB0cz0kUFdELy4uL0phdmFTY3JpcHRDb3JlCi0KLW1r
ZGlyIC1wIERlcml2ZWRTb3VyY2VzL1dlYkNvcmUgJiYKLW1ha2UgLUMgRGVyaXZlZFNvdXJjZXMv
V2ViQ29yZSAtZiAuLi8uLi9EZXJpdmVkU291cmNlcy5tYWtlICRACg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>284444</attachid>
            <date>2016-07-24 03:24:02 -0700</date>
            <delta_ts>2016-07-24 04:11:05 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-160115-20160724122254.patch</filename>
            <type>text/plain</type>
            <size>4294</size>
            <attacher name="youenn fablet">youennf</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzNjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5
Mjg3MGUwNDllMDdiNTA5ZTNmYmU0OGRkOTljMzMyYzc4NGMzYjJlLi42MjVlNDczNTA5OWZkNTY3
ZDhjNDIwODJkMzIzYTI2NjY1NDJjZjJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxMiBAQAorMjAxNi0wNy0yNCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CisK
KyAgICAgICAgQWRkaW5nIGEgbmV3IFdlYkNvcmUgSmF2YVNjcmlwdCBidWlsdC1pbiBzb3VyY2Ug
ZmlsZSBkb2VzIG5vdCB0cmlnZ2VyIHJlYnVpbGQgb2YgV2ViQ29yZUpTQnVpbHRpbnMqCisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjAxMTUKKworICAg
ICAgICBSZXZpZXdlZCBieSBZb3Vlbm4gRmFibGV0LgorCisgICAgICAgICogbWFrZS1nZW5lcmF0
ZWQtc291cmNlcy5zaDogUmVtb3ZlZC4gV2FzIHVudXNlZC4KKwogMjAxNi0wNy0yMyAgQ29tbWl0
IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwg
cm9sbGluZyBvdXQgcjIwMzY0MS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv
ZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0MTA2NjkzNmM4ZDA2ZjE0NjJmMzY3
MjY5MzZmYjE2ZDMyNTdlZDY0Li4xNWVjZGU2YWI0YmIzZjhlMjNjNjRmNjE5MWY2NTJmN2FhYjNh
YTY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl
YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTYtMDctMjQgIERhcmluIEFkbGVy
ICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIEFkZGluZyBhIG5ldyBXZWJDb3JlIEphdmFT
Y3JpcHQgYnVpbHQtaW4gc291cmNlIGZpbGUgZG9lcyBub3QgdHJpZ2dlciByZWJ1aWxkIG9mIFdl
YkNvcmVKU0J1aWx0aW5zKgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MTYwMTE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgWW91ZW5uIEZhYmxldC4KKwor
ICAgICAgICAqIERlcml2ZWRTb3VyY2VzLm1ha2U6IEFkZGVkIGEgbWlzc2luZyBkZXBlbmRlbmN5
IHNvIHRoZSBydWxlIHRoYXQgYnVpbGRzIFdlYkNvcmVfQlVJTFRJTlNfV1JBUFBFUlMKKyAgICAg
ICAga2lja3MgaW4gd2hlbiB0aGUgbGlzdCBvZiBXZWJDb3JlX0JVSUxUSU5TX1NPVVJDRVMgaXMg
bW9kaWZpZWQuIEFsc28gYWRkZWQgYW5vdGhlciBtaXNzaW5nIGRlcGVuZGVuY3kKKyAgICAgICAg
c28gdGhhdCBjaGFuZ2VzIHRvIHRoZSBKYXZhU2NyaXB0IGJ1aWx0LWlucyBQeXRob24gc2NyaXB0
cyB3aWxsIGFsc28gdHJpZ2dlciBXZWJDb3JlX0JVSUxUSU5TX1dSQVBQRVJTLgorCisgICAgICAg
ICogbWFrZS1nZW5lcmF0ZWQtc291cmNlcy5zaDogUmVtb3ZlZC4gV2FzIHVudXNlZC4KKwogMjAx
Ni0wNy0yMyAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFN0b3Ag
aXNFbXB0eSgpIGZyb20gbGVha2luZyBvdXQgb2YgU1ZHLgpkaWZmIC0tZ2l0IGEvU291cmNlL0ph
dmFTY3JpcHRDb3JlL21ha2UtZ2VuZXJhdGVkLXNvdXJjZXMuc2ggYi9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvbWFrZS1nZW5lcmF0ZWQtc291cmNlcy5zaApkZWxldGVkIGZpbGUgbW9kZSAxMDA3NTUK
aW5kZXggY2NmZWVkZDYxNDJiZTYzZDVjZDRkZjQxZTI5MDUxNmE5YmQxMjE4YS4uMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvbWFrZS1nZW5lcmF0ZWQtc291cmNlcy5zaAorKysgL2Rldi9udWxsCkBAIC0xLDEyICswLDAg
QEAKLSMhL2Jpbi9zaAotCi1leHBvcnQgU1JDUk9PVD0kUFdECi1leHBvcnQgQ1JFQVRFX0hBU0hf
VEFCTEU9IiRTUkNST09UL2NyZWF0ZV9oYXNoX3RhYmxlIgotZXhwb3J0IENSRUFURV9SRUdFWFBf
VEFCTEVTPSIkU1JDUk9PVC9jcmVhdGVfcmVnZXhfdGFibGVzIgotZXhwb3J0IENSRUFURV9LRVlX
T1JEX0xPT0tVUD0iJFNSQ1JPT1QvS2V5d29yZExvb2t1cEdlbmVyYXRvci5weSIKLQotbWtkaXIg
LXAgRGVyaXZlZFNvdXJjZXMvSmF2YVNjcmlwdENvcmUKLWNkIERlcml2ZWRTb3VyY2VzL0phdmFT
Y3JpcHRDb3JlCi0KLW1ha2UgLWYgLi4vLi4vRGVyaXZlZFNvdXJjZXMubWFrZSBKYXZhU2NyaXB0
Q29yZT0uLi8uLiBCVUlMVF9QUk9EVUNUU19ESVI9Li4vLi4KLWNkIC4uLy4uCmRpZmYgLS1naXQg
YS9Tb3VyY2UvV2ViQ29yZS9EZXJpdmVkU291cmNlcy5tYWtlIGIvU291cmNlL1dlYkNvcmUvRGVy
aXZlZFNvdXJjZXMubWFrZQppbmRleCA0MjIzNWViMTM0NzA3NjZmZmI3NjgzODBlYWY0YTM3Y2Rl
NmVjZGFjLi4wZTcyYjg2NTYyNGNjMTZhNWY4Y2U2ZTIwY2U5YTgyYjNmYjUxNTg5IDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViQ29yZS9EZXJpdmVkU291cmNlcy5tYWtlCisrKyBiL1NvdXJjZS9XZWJD
b3JlL0Rlcml2ZWRTb3VyY2VzLm1ha2UKQEAgLTEzMjksMTAgKzEzMjksMTQgQEAgV2ViQ29yZV9C
VUlMVElOU19XUkFQUEVSUyA9IFwKICMgZ2VuZXJhdGVkIHNob3VsZCBub3QgYWZmZWN0IG90aGVy
IGJ1aWx0aW5zIHdoZW4gbm90IHBhc3NpbmcgJy0tY29tYmluZWQnIHRvIHRoZSBnZW5lcmF0b3Iu
CiAKIC5QSE9OWTogZm9yY2UKKworV2ViQ29yZV9CVUlMVElOU19TT1VSQ0VTX0xJU1QgOiAkKEph
dmFTY3JpcHRDb3JlX1NDUklQVFNfRElSKS9VcGRhdGVDb250ZW50cy5weSBmb3JjZQorCSQoUFlU
SE9OKSAkKEphdmFTY3JpcHRDb3JlX1NDUklQVFNfRElSKS9VcGRhdGVDb250ZW50cy5weSAnJChX
ZWJDb3JlX0JVSUxUSU5TX1NPVVJDRVMpJyAkQAorCiBXZWJDb3JlX0JVSUxUSU5TX0RFUEVOREVO
Q0lFU19MSVNUIDogJChKYXZhU2NyaXB0Q29yZV9TQ1JJUFRTX0RJUikvVXBkYXRlQ29udGVudHMu
cHkgZm9yY2UKIAkkKFBZVEhPTikgJChKYXZhU2NyaXB0Q29yZV9TQ1JJUFRTX0RJUikvVXBkYXRl
Q29udGVudHMucHkgJyQoQlVJTFRJTlNfR0VORVJBVE9SX1NDUklQVFMpJyAkQAogCi0kKGZpcnN0
d29yZCAkKFdlYkNvcmVfQlVJTFRJTlNfV1JBUFBFUlMpKTogV2ViQ29yZV9CVUlMVElOU19ERVBF
TkRFTkNJRVNfTElTVAorJChmaXJzdHdvcmQgJChXZWJDb3JlX0JVSUxUSU5TX1dSQVBQRVJTKSk6
IFdlYkNvcmVfQlVJTFRJTlNfU09VUkNFU19MSVNUICQoQlVJTFRJTlNfR0VORVJBVE9SX1NDUklQ
VFMpIFdlYkNvcmVfQlVJTFRJTlNfREVQRU5ERU5DSUVTX0xJU1QKIAkkKFBZVEhPTikgJChKYXZh
U2NyaXB0Q29yZV9TQ1JJUFRTX0RJUikvZ2VuZXJhdGUtanMtYnVpbHRpbnMucHkgLS13cmFwcGVy
cy1vbmx5IC0tb3V0cHV0LWRpcmVjdG9yeSAuIC0tZnJhbWV3b3JrIFdlYkNvcmUgJChXZWJDb3Jl
X0JVSUxUSU5TX1NPVVJDRVMpCiAKICVCdWlsdGlucy5oOiAlLmpzICQoQlVJTFRJTlNfR0VORVJB
VE9SX1NDUklQVFMpIFdlYkNvcmVfQlVJTFRJTlNfREVQRU5ERU5DSUVTX0xJU1QKZGlmZiAtLWdp
dCBhL1NvdXJjZS9XZWJDb3JlL21ha2UtZ2VuZXJhdGVkLXNvdXJjZXMuc2ggYi9Tb3VyY2UvV2Vi
Q29yZS9tYWtlLWdlbmVyYXRlZC1zb3VyY2VzLnNoCmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDc1NQpp
bmRleCBkYmVlNzE1ZTQ2ODZiOTFkYjc2NjRmNzQ0MjBjNTI1Njg1ODQ0ZGM1Li4wMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwCi0tLSBhL1NvdXJjZS9XZWJDb3JlL21ha2Ut
Z2VuZXJhdGVkLXNvdXJjZXMuc2gKKysrIC9kZXYvbnVsbApAQCAtMSwxMCArMCwwIEBACi0jIS9i
aW4vc2gKLWV4cG9ydCBTT1VSQ0VfUk9PVD0kUFdECi1leHBvcnQgU1JDUk9PVD0kUFdECi1leHBv
cnQgV2ViQ29yZT0kUFdECi1leHBvcnQgSW5zcGVjdG9yU2NyaXB0cz0kUFdELy4uL0phdmFTY3Jp
cHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzCi1leHBvcnQgV2ViUmVwbGF5U2NyaXB0cz0kUFdELy4u
L0phdmFTY3JpcHRDb3JlL3JlcGxheS9zY3JpcHRzCi1leHBvcnQgR2VuZXJhdGVKU0J1aWx0aW5z
U2NyaXB0cz0kUFdELy4uL0phdmFTY3JpcHRDb3JlCi0KLW1rZGlyIC1wIERlcml2ZWRTb3VyY2Vz
L1dlYkNvcmUgJiYKLW1ha2UgLUMgRGVyaXZlZFNvdXJjZXMvV2ViQ29yZSAtZiAuLi8uLi9EZXJp
dmVkU291cmNlcy5tYWtlICRACg==
</data>

          </attachment>
      

    </bug>

</bugzilla>