160109 2016-07-22 17:01:21 -0700 [iOS] Clients should be able to decide if they want secure text entry in a form field 2016-07-22 18:20:54 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cpugh webkit-unassigned commit-queue cpugh enrica mitz sam oldest_to_newest 1213796 0 cpugh 2016-07-22 17:01:21 -0700 Clients should be able to decide if they want secure text entry in a form field. Patch soon. 1213797 1 284389 cpugh 2016-07-22 17:18:21 -0700 Created attachment 284389 Patch for [iOS] Clients should be able to decide if they want secure text entry in a form field 1213799 2 284389 mitz 2016-07-22 17:39:51 -0700 Comment on attachment 284389 Patch for [iOS] Clients should be able to decide if they want secure text entry in a form field View in context: https://bugs.webkit.org/attachment.cgi?id=284389&action=review > Source/WebKit2/UIProcess/API/Cocoa/_WKFormInputSession.h:47 > +@property (nonatomic) BOOL shouldUseSecureTextEntry WK_API_AVAILABLE(ios(WK_IOS_TBA)); The name implies that setting the property to NO means that secure text entry won’t be used, but that’s not the case. The property only works in one direction, forcing secure text entry to be used where otherwise it wouldn’t. Maybe a name like “forceSecureTextEntry” would express this better? 1213800 3 cpugh 2016-07-22 17:47:36 -0700 (In reply to comment #2) > Comment on attachment 284389 [details] > Patch for [iOS] Clients should be able to decide if they want secure text > entry in a form field > > View in context: > https://bugs.webkit.org/attachment.cgi?id=284389&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/_WKFormInputSession.h:47 > > +@property (nonatomic) BOOL shouldUseSecureTextEntry WK_API_AVAILABLE(ios(WK_IOS_TBA)); > > The name implies that setting the property to NO means that secure text > entry won’t be used, but that’s not the case. The property only works in one > direction, forcing secure text entry to be used where otherwise it wouldn’t. > Maybe a name like “forceSecureTextEntry” would express this better? Yeah, I think that's a better name. 1213801 4 284390 cpugh 2016-07-22 17:48:14 -0700 Created attachment 284390 v2 patch for [iOS] Clients should be able to decide if they want secure text entry in a form field 1213805 5 284390 commit-queue 2016-07-22 18:20:51 -0700 Comment on attachment 284390 v2 patch for [iOS] Clients should be able to decide if they want secure text entry in a form field Clearing flags on attachment: 284390 Committed r203630: <http://trac.webkit.org/changeset/203630> 1213806 6 commit-queue 2016-07-22 18:20:54 -0700 All reviewed patches have been landed. Closing bug. 284389 2016-07-22 17:18:21 -0700 2016-07-22 17:48:14 -0700 Patch for [iOS] Clients should be able to decide if they want secure text entry in a form field [iOS] Clients should be able to decide if they want secure text entry in a form field.txt text/plain 3377 cpugh SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMzYyOCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA3LTIyICBDaGVsc2Vh IFB1Z2ggIDxjcHVnaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gQ2xpZW50cyBzaG91bGQg YmUgYWJsZSB0byBkZWNpZGUgaWYgdGhleSB3YW50IHNlY3VyZSB0ZXh0IGVudHJ5IGluIGEgZm9y bSBmaWVsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTYwMTA5CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzI3NTA0OTU4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL19X S0Zvcm1JbnB1dFNlc3Npb24uaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZp ZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tGb3JtSW5wdXRTZXNzaW9uIHNob3VsZFVz ZVNlY3VyZVRleHRFbnRyeV0pOiBTZXR0ZXIuCisgICAgICAgICgtW1dLRm9ybUlucHV0U2Vzc2lv biBzZXRTaG91bGRVc2VTZWN1cmVUZXh0RW50cnk6XSk6IEdldHRlci4KKyAgICAgICAgKC1bV0tD b250ZW50VmlldyB0ZXh0SW5wdXRUcmFpdHNdKTogSWYgdGhlIGZvcm0gaW5wdXQgc2Vzc2lvbiBo YXMgc3BlY2lmaWVkIHRoYXQgc2VjdXJlIHRleHQKKyAgICAgICAgZW50cnkgaXMgZGVzaXJlZCwg d2Ugc2hvdWxkIHVzZSBzZWN1cmUgdGV4dCBlbnRyeS4KKwogMjAxNi0wNy0yMiAgQW5kZXJzIENh cmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEdldCByaWQgb2YgYW4gdW51 c2VkIEFQSSB0eXBlZGVmCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29h L19XS0Zvcm1JbnB1dFNlc3Npb24uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL0NvY29hL19XS0Zvcm1JbnB1dFNlc3Npb24uaAkocmV2aXNpb24gMjAzNTMzKQor KysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tGb3JtSW5wdXRTZXNzaW9u LmgJKHdvcmtpbmcgY29weSkKQEAgLTQ0LDYgKzQ0LDcgQEAKIEBwcm9wZXJ0eSAobm9uYXRvbWlj LCBjb3B5KSBOU0FycmF5PFVJVGV4dFN1Z2dlc3Rpb24gKj4gKnN1Z2dlc3Rpb25zIFdLX0FQSV9B VkFJTEFCTEUoaW9zKFdLX0lPU19UQkEpKTsKIEBwcm9wZXJ0eSAobm9uYXRvbWljKSBCT09MIGFj Y2Vzc29yeVZpZXdTaG91bGROb3RTaG93IFdLX0FQSV9BVkFJTEFCTEUoaW9zKFdLX0lPU19UQkEp KTsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBjb3B5KSBOU1N0cmluZyAqdGV4dENvbnRlbnRUeXBl IFdLX0FQSV9BVkFJTEFCTEUoaW9zKFdLX0lPU19UQkEpKTsKK0Bwcm9wZXJ0eSAobm9uYXRvbWlj KSBCT09MIHNob3VsZFVzZVNlY3VyZVRleHRFbnRyeSBXS19BUElfQVZBSUxBQkxFKGlvcyhXS19J T1NfVEJBKSk7CiAjZW5kaWYKIAogQGVuZApJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0JKHJldmlzaW9u IDIwMzUzMykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0lu dGVyYWN0aW9uLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yNjYsNiArMjY2LDcgQEAKICAgICBSZXRh aW5QdHI8TlNBcnJheTxVSVRleHRTdWdnZXN0aW9uICo+PiBfc3VnZ2VzdGlvbnM7CiAgICAgUmV0 YWluUHRyPE5TU3RyaW5nPiBfdGV4dENvbnRlbnRUeXBlOwogICAgIEJPT0wgX2FjY2Vzc29yeVZp ZXdTaG91bGROb3RTaG93OworICAgIEJPT0wgX3Nob3VsZFVzZVNlY3VyZVRleHRFbnRyeTsKIH0K IAogLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRoQ29udGVudFZpZXc6KFdLQ29udGVudFZpZXcgKil2 aWV3IGZvY3VzZWRFbGVtZW50SW5mbzooV0tGb2N1c2VkRWxlbWVudEluZm8gKillbGVtZW50SW5m byB1c2VyT2JqZWN0OihOU09iamVjdCA8TlNTZWN1cmVDb2Rpbmc+ICopdXNlck9iamVjdApAQCAt MzI0LDYgKzMyNSwyMCBAQAogICAgIFtfY29udGVudFZpZXcgcmVsb2FkSW5wdXRWaWV3c107CiB9 CiAKKy0gKEJPT0wpc2hvdWxkVXNlU2VjdXJlVGV4dEVudHJ5Cit7CisgICAgcmV0dXJuIF9zaG91 bGRVc2VTZWN1cmVUZXh0RW50cnk7Cit9CisKKy0gKHZvaWQpc2V0U2hvdWxkVXNlU2VjdXJlVGV4 dEVudHJ5OihCT09MKXNob3VsZFVzZVNlY3VyZVRleHRFbnRyeQoreworICAgIGlmIChfc2hvdWxk VXNlU2VjdXJlVGV4dEVudHJ5ID09IHNob3VsZFVzZVNlY3VyZVRleHRFbnRyeSkKKyAgICAgICAg cmV0dXJuOworCisgICAgX3Nob3VsZFVzZVNlY3VyZVRleHRFbnRyeSA9IHNob3VsZFVzZVNlY3Vy ZVRleHRFbnRyeTsKKyAgICBbX2NvbnRlbnRWaWV3IHJlbG9hZElucHV0Vmlld3NdOworfQorCiAt IChVSVZpZXcgKiljdXN0b21JbnB1dFZpZXcKIHsKICAgICByZXR1cm4gX2N1c3RvbUlucHV0Vmll dy5nZXQoKTsKQEAgLTI5NzQsNyArMjk4OSw3IEBACiAgICAgaWYgKCFfdHJhaXRzKQogICAgICAg ICBfdHJhaXRzID0gYWRvcHROUyhbW1VJVGV4dElucHV0VHJhaXRzIGFsbG9jXSBpbml0XSk7CiAK LSAgICBbX3RyYWl0cyBzZXRTZWN1cmVUZXh0RW50cnk6X2Fzc2lzdGVkTm9kZUluZm9ybWF0aW9u LmVsZW1lbnRUeXBlID09IElucHV0VHlwZTo6UGFzc3dvcmRdOworICAgIFtfdHJhaXRzIHNldFNl Y3VyZVRleHRFbnRyeTpfYXNzaXN0ZWROb2RlSW5mb3JtYXRpb24uZWxlbWVudFR5cGUgPT0gSW5w dXRUeXBlOjpQYXNzd29yZCB8fCBbX2Zvcm1JbnB1dFNlc3Npb24gc2hvdWxkVXNlU2VjdXJlVGV4 dEVudHJ5XV07CiAgICAgW190cmFpdHMgc2V0U2hvcnRjdXRDb252ZXJzaW9uVHlwZTpfYXNzaXN0 ZWROb2RlSW5mb3JtYXRpb24uZWxlbWVudFR5cGUgPT0gSW5wdXRUeXBlOjpQYXNzd29yZCA/IFVJ VGV4dFNob3J0Y3V0Q29udmVyc2lvblR5cGVObyA6IFVJVGV4dFNob3J0Y3V0Q29udmVyc2lvblR5 cGVEZWZhdWx0XTsKIAogICAgIGlmICghX2Fzc2lzdGVkTm9kZUluZm9ybWF0aW9uLmZvcm1BY3Rp b24uaXNFbXB0eSgpKQo= 284390 2016-07-22 17:48:14 -0700 2016-07-22 18:20:51 -0700 v2 patch for [iOS] Clients should be able to decide if they want secure text entry in a form field [iOS] Clients should be able to decide if they want secure text entry in a form field.txt text/plain 3325 cpugh SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMzYyOCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA3LTIyICBDaGVsc2Vh IFB1Z2ggIDxjcHVnaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gQ2xpZW50cyBzaG91bGQg YmUgYWJsZSB0byBkZWNpZGUgaWYgdGhleSB3YW50IHNlY3VyZSB0ZXh0IGVudHJ5IGluIGEgZm9y bSBmaWVsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTYwMTA5CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzI3NTA0OTU4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL19X S0Zvcm1JbnB1dFNlc3Npb24uaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZp ZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tGb3JtSW5wdXRTZXNzaW9uIGZvcmNlU2Vj dXJlVGV4dEVudHJ5XSk6IEdldHRlci4KKyAgICAgICAgKC1bV0tGb3JtSW5wdXRTZXNzaW9uIHNl dEZvcmNlU2VjdXJlVGV4dEVudHJ5Ol0pOiBTZXR0ZXIuCisgICAgICAgICgtW1dLQ29udGVudFZp ZXcgdGV4dElucHV0VHJhaXRzXSk6IElmIHRoZSBmb3JtIGlucHV0IHNlc3Npb24gaGFzIHNwZWNp ZmllZCB0aGF0IHNlY3VyZSB0ZXh0CisgICAgICAgIGVudHJ5IGlzIGRlc2lyZWQsIHdlIHNob3Vs ZCB1c2Ugc2VjdXJlIHRleHQgZW50cnkuCisKIDIwMTYtMDctMjIgIEFuZGVycyBDYXJsc3NvbiAg PGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBHZXQgcmlkIG9mIGFuIHVudXNlZCBBUEkg dHlwZWRlZgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tGb3Jt SW5wdXRTZXNzaW9uLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9Db2NvYS9fV0tGb3JtSW5wdXRTZXNzaW9uLmgJKHJldmlzaW9uIDIwMzUzMykKKysrIFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLRm9ybUlucHV0U2Vzc2lvbi5oCSh3b3Jr aW5nIGNvcHkpCkBAIC00NCw2ICs0NCw3IEBACiBAcHJvcGVydHkgKG5vbmF0b21pYywgY29weSkg TlNBcnJheTxVSVRleHRTdWdnZXN0aW9uICo+ICpzdWdnZXN0aW9ucyBXS19BUElfQVZBSUxBQkxF KGlvcyhXS19JT1NfVEJBKSk7CiBAcHJvcGVydHkgKG5vbmF0b21pYykgQk9PTCBhY2Nlc3NvcnlW aWV3U2hvdWxkTm90U2hvdyBXS19BUElfQVZBSUxBQkxFKGlvcyhXS19JT1NfVEJBKSk7CiBAcHJv cGVydHkgKG5vbmF0b21pYywgY29weSkgTlNTdHJpbmcgKnRleHRDb250ZW50VHlwZSBXS19BUElf QVZBSUxBQkxFKGlvcyhXS19JT1NfVEJBKSk7CitAcHJvcGVydHkgKG5vbmF0b21pYykgQk9PTCBm b3JjZVNlY3VyZVRleHRFbnRyeSBXS19BUElfQVZBSUxBQkxFKGlvcyhXS19JT1NfVEJBKSk7CiAj ZW5kaWYKIAogQGVuZApJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRl bnRWaWV3SW50ZXJhY3Rpb24ubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0JKHJldmlzaW9uIDIwMzUzMykKKysr IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1t CSh3b3JraW5nIGNvcHkpCkBAIC0yNjYsNiArMjY2LDcgQEAKICAgICBSZXRhaW5QdHI8TlNBcnJh eTxVSVRleHRTdWdnZXN0aW9uICo+PiBfc3VnZ2VzdGlvbnM7CiAgICAgUmV0YWluUHRyPE5TU3Ry aW5nPiBfdGV4dENvbnRlbnRUeXBlOwogICAgIEJPT0wgX2FjY2Vzc29yeVZpZXdTaG91bGROb3RT aG93OworICAgIEJPT0wgX2ZvcmNlU2VjdXJlVGV4dEVudHJ5OwogfQogCiAtIChpbnN0YW5jZXR5 cGUpaW5pdFdpdGhDb250ZW50VmlldzooV0tDb250ZW50VmlldyAqKXZpZXcgZm9jdXNlZEVsZW1l bnRJbmZvOihXS0ZvY3VzZWRFbGVtZW50SW5mbyAqKWVsZW1lbnRJbmZvIHVzZXJPYmplY3Q6KE5T T2JqZWN0IDxOU1NlY3VyZUNvZGluZz4gKil1c2VyT2JqZWN0CkBAIC0zMjQsNiArMzI1LDIwIEBA CiAgICAgW19jb250ZW50VmlldyByZWxvYWRJbnB1dFZpZXdzXTsKIH0KIAorLSAoQk9PTClmb3Jj ZVNlY3VyZVRleHRFbnRyeQoreworICAgIHJldHVybiBfZm9yY2VTZWN1cmVUZXh0RW50cnk7Cit9 CisKKy0gKHZvaWQpc2V0Rm9yY2VTZWN1cmVUZXh0RW50cnk6KEJPT0wpZm9yY2VTZWN1cmVUZXh0 RW50cnkKK3sKKyAgICBpZiAoX2ZvcmNlU2VjdXJlVGV4dEVudHJ5ID09IGZvcmNlU2VjdXJlVGV4 dEVudHJ5KQorICAgICAgICByZXR1cm47CisKKyAgICBfZm9yY2VTZWN1cmVUZXh0RW50cnkgPSBm b3JjZVNlY3VyZVRleHRFbnRyeTsKKyAgICBbX2NvbnRlbnRWaWV3IHJlbG9hZElucHV0Vmlld3Nd OworfQorCiAtIChVSVZpZXcgKiljdXN0b21JbnB1dFZpZXcKIHsKICAgICByZXR1cm4gX2N1c3Rv bUlucHV0Vmlldy5nZXQoKTsKQEAgLTI5NzQsNyArMjk4OSw3IEBACiAgICAgaWYgKCFfdHJhaXRz KQogICAgICAgICBfdHJhaXRzID0gYWRvcHROUyhbW1VJVGV4dElucHV0VHJhaXRzIGFsbG9jXSBp bml0XSk7CiAKLSAgICBbX3RyYWl0cyBzZXRTZWN1cmVUZXh0RW50cnk6X2Fzc2lzdGVkTm9kZUlu Zm9ybWF0aW9uLmVsZW1lbnRUeXBlID09IElucHV0VHlwZTo6UGFzc3dvcmRdOworICAgIFtfdHJh aXRzIHNldFNlY3VyZVRleHRFbnRyeTpfYXNzaXN0ZWROb2RlSW5mb3JtYXRpb24uZWxlbWVudFR5 cGUgPT0gSW5wdXRUeXBlOjpQYXNzd29yZCB8fCBbX2Zvcm1JbnB1dFNlc3Npb24gZm9yY2VTZWN1 cmVUZXh0RW50cnldXTsKICAgICBbX3RyYWl0cyBzZXRTaG9ydGN1dENvbnZlcnNpb25UeXBlOl9h c3Npc3RlZE5vZGVJbmZvcm1hdGlvbi5lbGVtZW50VHlwZSA9PSBJbnB1dFR5cGU6OlBhc3N3b3Jk ID8gVUlUZXh0U2hvcnRjdXRDb252ZXJzaW9uVHlwZU5vIDogVUlUZXh0U2hvcnRjdXRDb252ZXJz aW9uVHlwZURlZmF1bHRdOwogCiAgICAgaWYgKCFfYXNzaXN0ZWROb2RlSW5mb3JtYXRpb24uZm9y bUFjdGlvbi5pc0VtcHR5KCkpCg==