160106 2016-07-22 15:39:31 -0700 REGRESSION(r203035): Marking points as an outlier no longer updates charts 2016-07-22 23:12:38 -0700 1 1 1 Unclassified WebKit Perf Dashboard WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa cdumez commit-queue dewei_zhu rniwa slewis oldest_to_newest 1213776 0 rniwa 2016-07-22 15:39:31 -0700 After https://trac.webkit.org/changeset/203035, charts don't update when marking points as outliers. 1213777 1 284382 rniwa 2016-07-22 15:48:36 -0700 Created attachment 284382 Fixes the bug 1213842 2 284382 darin 2016-07-22 22:15:11 -0700 Comment on attachment 284382 Fixes the bug rs=me 1213857 3 284382 commit-queue 2016-07-22 23:12:33 -0700 Comment on attachment 284382 Fixes the bug Clearing flags on attachment: 284382 Committed r203633: <http://trac.webkit.org/changeset/203633> 1213858 4 commit-queue 2016-07-22 23:12:38 -0700 All reviewed patches have been landed. Closing bug. 284382 2016-07-22 15:48:36 -0700 2016-07-22 23:12:33 -0700 Fixes the bug bug-160106-20160722154734.patch text/plain 7719 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMjAzNjIyKQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDM0IEBACisyMDE2LTA3LTIyICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIFJFR1JFU1NJT04ocjIwMzAzNSk6IE1hcmtpbmcgcG9pbnRzIGFzIGFuIG91dGxp ZXIgbm8gbG9uZ2VyIHVwZGF0ZXMgY2hhcnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNjAxMDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGUgYnVnIHdhcyBjYXVzZWQgYnkgTWVhc3VyZW1lbnRTZXQn cyBmZXRjaEJldHdlZW4gY2xlYXJpbmcgcHJldmlvdXNseSByZWdpc3RlcmVkIGNhbGxiYWNrcyB3 aGVuIG5vQ2FjaGUKKyAgICAgICAgb3B0aW9uIGlzIHNwZWNpZmllZC4KKworICAgICAgICAqIHB1 YmxpYy92My9jb21wb25lbnRzL3RpbWUtc2VyaWVzLWNoYXJ0LmpzOgorICAgICAgICAoVGltZVNl cmllc0NoYXJ0LnByb3RvdHlwZS5zZXRTb3VyY2VMaXN0KTogQ2xlYXIgdGhpcy5fZmV0Y2hlZFRp bWVTZXJpZXMgd2hlbiBjaGFuZ2luZyBjaGFydCBvcHRpb25zLgorICAgICAgICBlLmcuIG5lZWQg dG8gc3RhcnQgaW5jbHVkaW5nIG9yIGV4Y2x1ZGluZyBvdXRsaWVycy4KKyAgICAgICAgKFRpbWVT ZXJpZXNDaGFydC5wcm90b3R5cGUuZmV0Y2hNZWFzdXJlbWVudFNldHMpOiBEb24ndCBza2lwIHRo ZSBmZXRjaGluZyB3aGVuIG5vQ2FjaGUgaXMgdHJ1ZS4KKworICAgICAgICAqIHB1YmxpYy92My9t b2RlbHMvbWVhc3VyZW1lbnQtc2V0LmpzOgorICAgICAgICAoTWVhc3VyZW1lbnRTZXQpOiBBZGRl ZCB0aGlzLl9jYWxsYmFja01hcCBhcyBhbiBpbnN0YW5jZSB2YXJpYWJsZSB0byBrZWVwIHRyYWNr IG9mIGFsbCBjYWxsYmFja3Mgb24gZXZlcnkKKyAgICAgICAgY2x1c3RlciBzaW5jZSB3ZSBtYXkg bmVlZCB0byBjYWxsIGVhY2ggY2FsbGJhY2sgbXVsdGlwbGUgdGltZXMgcGVyIGNsdXN0ZXIgd2hl biBub0NhY2hlIG9wdGlvbiBpcyB1c2VkLgorICAgICAgICAoTWVhc3VyZW1lbnRTZXQucHJvdG90 eXBlLmZldGNoQmV0d2Vlbik6IE1vdmVkIHRoZSBjb2RlIHRvIGFkZCBfcHJpbWFyeUNsdXN0ZXJQ cm9taXNlIHRvIF9hbGxGZXRjaGVzIGhlcmUKKyAgICAgICAgc28gdGhhdCBub3cgdGhpcyBmdW5j dGlvbiBhbmQgX2Vuc3VyZUNsdXN0ZXJQcm9taXNlIGFyZSBvbmx5IGZ1bmN0aW9ucyB0aGF0IHRv dWNoIF9hbGxGZXRjaGVzLgorICAgICAgICAoTWVhc3VyZW1lbnRTZXQucHJvdG90eXBlLl9lbnN1 cmVDbHVzdGVyUHJvbWlzZSk6IEV4dHJhY3RlZCBvdXQgb2YgZmV0Y2hCZXR3ZWVuLiBRdWV1ZSB1 cCBhbGwgY2FsbGJhY2tzCisgICAgICAgIGZvciBlYWNoIGNsdXN0ZXIgd2hlbiBjcmVhdGluZyBh IG5ldyBwcm9taXNlLgorICAgICAgICAoTWVhc3VyZW1lbnRTZXQucHJvdG90eXBlLl9mZXRjaFBy aW1hcnlDbHVzdGVyKTogUmVtb3ZlZCB0aGUgY29kZSB0byBhZGQgX3ByaW1hcnlDbHVzdGVyUHJv bWlzZSBub3cgdGhhdAorICAgICAgICBpdCdzIGRvbmUgaW4gZmV0Y2hCZXR3ZWVuLgorCisgICAg ICAgICogcHVibGljL3YzL3JlbW90ZS5qczoKKyAgICAgICAgKFJlbW90ZUFQSS5wb3N0SlNPTldp dGhTdGF0dXMpOiBSZW1vdmVkIHN1cGVyZmx1b3VzIGNhbGwgdG8gY29uc29sZS5sb2cuCisKKyAg ICAgICAgKiB1bml0LXRlc3RzL21lYXN1cmVtZW50LXNldC10ZXN0cy5qczogVXBkYXRlZCB0aGUg dGVzdCBjYXNlIGZvciBub0NhY2hlLiBUaGUgY2FsbGJhY2sgcmVnaXN0ZXJlZCBiZWZvcmUKKyAg ICAgICAgZmV0Y2hCZXR3ZWVuIGlzIGNhbGxlZCB3aXRoIG5vQ2FjaGU9dHJ1ZSBpcyBub3cgaW52 b2tlZCBzbyBjYWxsQ291bnQgbXVzdCBiZSAzIGluc3RlYWQgb2YgMi4KKwogMjAxNi0wNy0xOSAg Unlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBQZXJmIGRhc2hib2Fy ZCBhbHdheXMgcmUtZ2VuZXJhdGUgbWVhc3VyZW1lbnQgc2V0IEpTT04KSW5kZXg6IFdlYnNpdGVz L3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvcmVtb3RlLmpzCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNp dGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvcmVtb3RlLmpzCShyZXZpc2lvbiAyMDM2MjEp CisrKyBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YzL3JlbW90ZS5qcwkod29ya2lu ZyBjb3B5KQpAQCAtOSw3ICs5LDYgQEAgUmVtb3RlQVBJLnBvc3RKU09OID0gZnVuY3Rpb24gKHBh dGgsIGRhdAogCiBSZW1vdGVBUEkucG9zdEpTT05XaXRoU3RhdHVzID0gZnVuY3Rpb24gKHBhdGgs IGRhdGEpCiB7Ci0gICAgY29uc29sZS5sb2coZG9jdW1lbnQuY29va2llKTsKICAgICByZXR1cm4g dGhpcy5nZXRKU09OV2l0aFN0YXR1cyhwYXRoLCBkYXRhIHx8IHt9KTsKIH0KIApJbmRleDogV2Vi c2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92My9jb21wb25lbnRzL3RpbWUtc2VyaWVzLWNo YXJ0LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMv Y29tcG9uZW50cy90aW1lLXNlcmllcy1jaGFydC5qcwkocmV2aXNpb24gMjAzNjIxKQorKysgV2Vi c2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92My9jb21wb25lbnRzL3RpbWUtc2VyaWVzLWNo YXJ0LmpzCSh3b3JraW5nIGNvcHkpCkBAIC04Myw2ICs4Myw3IEBAIGNsYXNzIFRpbWVTZXJpZXND aGFydCBleHRlbmRzIENvbXBvbmVudEIKICAgICB7CiAgICAgICAgIHRoaXMuX3NvdXJjZUxpc3Qg PSBzb3VyY2VMaXN0OwogICAgICAgICB0aGlzLmZldGNoTWVhc3VyZW1lbnRTZXRzKGZhbHNlKTsK KyAgICAgICAgdGhpcy5fZmV0Y2hlZFRpbWVTZXJpZXMgPSBudWxsOwogICAgIH0KIAogICAgIGZl dGNoTWVhc3VyZW1lbnRTZXRzKG5vQ2FjaGUpCkBAIC05MCw3ICs5MSw3IEBAIGNsYXNzIFRpbWVT ZXJpZXNDaGFydCBleHRlbmRzIENvbXBvbmVudEIKICAgICAgICAgdmFyIGZldGNoaW5nID0gZmFs c2U7CiAgICAgICAgIGZvciAodmFyIHNvdXJjZSBvZiB0aGlzLl9zb3VyY2VMaXN0KSB7CiAgICAg ICAgICAgICBpZiAoc291cmNlLm1lYXN1cmVtZW50U2V0KSB7Ci0gICAgICAgICAgICAgICAgaWYg KHNvdXJjZS5tZWFzdXJlbWVudFNldC5oYXNGZXRjaGVkUmFuZ2UodGhpcy5fc3RhcnRUaW1lLCB0 aGlzLl9lbmRUaW1lKSkKKyAgICAgICAgICAgICAgICBpZiAoIW5vQ2FjaGUgJiYgc291cmNlLm1l YXN1cmVtZW50U2V0Lmhhc0ZldGNoZWRSYW5nZSh0aGlzLl9zdGFydFRpbWUsIHRoaXMuX2VuZFRp bWUpKQogICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgICAgICAgICBzb3Vy Y2UubWVhc3VyZW1lbnRTZXQuZmV0Y2hCZXR3ZWVuKHRoaXMuX3N0YXJ0VGltZSwgdGhpcy5fZW5k VGltZSwgdGhpcy5fZGlkRmV0Y2hNZWFzdXJlbWVudFNldC5iaW5kKHRoaXMsIHNvdXJjZS5tZWFz dXJlbWVudFNldCksIG5vQ2FjaGUpOwogICAgICAgICAgICAgICAgIGZldGNoaW5nID0gdHJ1ZTsK SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvbW9kZWxzL21lYXN1cmVt ZW50LXNldC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGlj L3YzL21vZGVscy9tZWFzdXJlbWVudC1zZXQuanMJKHJldmlzaW9uIDIwMzYyMSkKKysrIFdlYnNp dGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvbW9kZWxzL21lYXN1cmVtZW50LXNldC5qcwko d29ya2luZyBjb3B5KQpAQCAtMTYsNiArMTYsNyBAQCBjbGFzcyBNZWFzdXJlbWVudFNldCB7CiAg ICAgICAgIHRoaXMuX2NsdXN0ZXJTdGFydCA9IG51bGw7CiAgICAgICAgIHRoaXMuX2NsdXN0ZXJT aXplID0gbnVsbDsKICAgICAgICAgdGhpcy5fYWxsRmV0Y2hlcyA9IHt9OworICAgICAgICB0aGlz Ll9jYWxsYmFja01hcCA9IG5ldyBNYXA7CiAgICAgICAgIHRoaXMuX3ByaW1hcnlDbHVzdGVyUHJv bWlzZSA9IG51bGw7CiAgICAgfQogCkBAIC02MSwyMiArNjIsMzggQEAgY2xhc3MgTWVhc3VyZW1l bnRTZXQgewogICAgICAgICAgICAgdGhpcy5fcHJpbWFyeUNsdXN0ZXJQcm9taXNlID0gbnVsbDsK ICAgICAgICAgICAgIHRoaXMuX2FsbEZldGNoZXMgPSB7fTsKICAgICAgICAgfQotICAgICAgICBp ZiAoIXRoaXMuX3ByaW1hcnlDbHVzdGVyUHJvbWlzZSB8fCBub0NhY2hlKQorICAgICAgICBpZiAo IXRoaXMuX3ByaW1hcnlDbHVzdGVyUHJvbWlzZSkKICAgICAgICAgICAgIHRoaXMuX3ByaW1hcnlD bHVzdGVyUHJvbWlzZSA9IHRoaXMuX2ZldGNoUHJpbWFyeUNsdXN0ZXIobm9DYWNoZSk7CiAgICAg ICAgIHZhciBzZWxmID0gdGhpczsKICAgICAgICAgdGhpcy5fcHJpbWFyeUNsdXN0ZXJQcm9taXNl LmNhdGNoKGNhbGxiYWNrKTsKICAgICAgICAgcmV0dXJuIHRoaXMuX3ByaW1hcnlDbHVzdGVyUHJv bWlzZS50aGVuKGZ1bmN0aW9uICgpIHsKLSAgICAgICAgICAgIHZhciBwcm9taXNlTGlzdCA9IFtd OwotICAgICAgICAgICAgc2VsZi5maW5kQ2x1c3RlcnMoc3RhcnRUaW1lLCBlbmRUaW1lKS5tYXAo ZnVuY3Rpb24gKGNsdXN0ZXJFbmRUaW1lKSB7Ci0gICAgICAgICAgICAgICAgaWYoIXNlbGYuX2Fs bEZldGNoZXNbY2x1c3RlckVuZFRpbWVdKQotICAgICAgICAgICAgICAgICAgICBzZWxmLl9hbGxG ZXRjaGVzW2NsdXN0ZXJFbmRUaW1lXSA9IHNlbGYuX2ZldGNoU2Vjb25kYXJ5Q2x1c3RlcihjbHVz dGVyRW5kVGltZSk7Ci0gICAgICAgICAgICAgICAgc2VsZi5fYWxsRmV0Y2hlc1tjbHVzdGVyRW5k VGltZV0udGhlbihjYWxsYmFjaywgY2FsbGJhY2spOwotICAgICAgICAgICAgICAgIHByb21pc2VM aXN0LnB1c2goc2VsZi5fYWxsRmV0Y2hlc1tjbHVzdGVyRW5kVGltZV0pOwotICAgICAgICAgICAg fSk7Ci0gICAgICAgICAgICByZXR1cm4gUHJvbWlzZS5hbGwocHJvbWlzZUxpc3QpOworICAgICAg ICAgICAgc2VsZi5fYWxsRmV0Y2hlc1tzZWxmLl9wcmltYXJ5Q2x1c3RlckVuZFRpbWVdID0gc2Vs Zi5fcHJpbWFyeUNsdXN0ZXJQcm9taXNlOworICAgICAgICAgICAgcmV0dXJuIFByb21pc2UuYWxs KHNlbGYuZmluZENsdXN0ZXJzKHN0YXJ0VGltZSwgZW5kVGltZSkubWFwKGZ1bmN0aW9uIChjbHVz dGVyRW5kVGltZSkgeworICAgICAgICAgICAgICAgIHJldHVybiBzZWxmLl9lbnN1cmVDbHVzdGVy UHJvbWlzZShjbHVzdGVyRW5kVGltZSwgY2FsbGJhY2spOworICAgICAgICAgICAgfSkpOwogICAg ICAgICB9KTsKICAgICB9CiAKKyAgICBfZW5zdXJlQ2x1c3RlclByb21pc2UoY2x1c3RlckVuZFRp bWUsIGNhbGxiYWNrKQorICAgIHsKKyAgICAgICAgaWYgKCF0aGlzLl9jYWxsYmFja01hcC5oYXMo Y2x1c3RlckVuZFRpbWUpKQorICAgICAgICAgICAgdGhpcy5fY2FsbGJhY2tNYXAuc2V0KGNsdXN0 ZXJFbmRUaW1lLCBuZXcgU2V0KTsKKyAgICAgICAgdmFyIGNhbGxiYWNrU2V0ID0gdGhpcy5fY2Fs bGJhY2tNYXAuZ2V0KGNsdXN0ZXJFbmRUaW1lKTsKKyAgICAgICAgY2FsbGJhY2tTZXQuYWRkKGNh bGxiYWNrKTsKKworICAgICAgICB2YXIgcHJvbWlzZSA9IHRoaXMuX2FsbEZldGNoZXNbY2x1c3Rl ckVuZFRpbWVdOworICAgICAgICBpZiAocHJvbWlzZSkKKyAgICAgICAgICAgIHByb21pc2UudGhl bihjYWxsYmFjaywgY2FsbGJhY2spOworICAgICAgICBlbHNlIHsKKyAgICAgICAgICAgIHByb21p c2UgPSB0aGlzLl9mZXRjaFNlY29uZGFyeUNsdXN0ZXIoY2x1c3RlckVuZFRpbWUpOworICAgICAg ICAgICAgZm9yICh2YXIgZXhpc3RpbmdDYWxsYmFjayBvZiBjYWxsYmFja1NldCkKKyAgICAgICAg ICAgICAgICBwcm9taXNlLnRoZW4oZXhpc3RpbmdDYWxsYmFjaywgZXhpc3RpbmdDYWxsYmFjayk7 CisgICAgICAgICAgICB0aGlzLl9hbGxGZXRjaGVzW2NsdXN0ZXJFbmRUaW1lXSA9IHByb21pc2U7 CisgICAgICAgIH0KKworICAgICAgICByZXR1cm4gcHJvbWlzZTsKKyAgICB9CisKICAgICBfY29u c3RydWN0VXJsKHVzZUNhY2hlLCBjbHVzdGVyRW5kVGltZSkKICAgICB7CiAgICAgICAgIGlmICgh dXNlQ2FjaGUpIHsKQEAgLTk2LDcgKzExMyw2IEBAIGNsYXNzIE1lYXN1cmVtZW50U2V0IHsKICAg ICAgICAgaWYgKG5vQ2FjaGUpIHsKICAgICAgICAgICAgIHJldHVybiBSZW1vdGVBUEkuZ2V0SlNP TldpdGhTdGF0dXMoc2VsZi5fY29uc3RydWN0VXJsKGZhbHNlLCBudWxsKSkudGhlbihmdW5jdGlv biAoZGF0YSkgewogICAgICAgICAgICAgICAgIHNlbGYuX2RpZEZldGNoSlNPTih0cnVlLCBkYXRh KTsKLSAgICAgICAgICAgICAgICBzZWxmLl9hbGxGZXRjaGVzW3NlbGYuX3ByaW1hcnlDbHVzdGVy RW5kVGltZV0gPSBzZWxmLl9wcmltYXJ5Q2x1c3RlclByb21pc2U7CiAgICAgICAgICAgICB9KTsK ICAgICAgICAgfQogCkBAIC0xMTAsNyArMTI2LDYgQEAgY2xhc3MgTWVhc3VyZW1lbnRTZXQgewog ICAgICAgICAgICAgcmV0dXJuIFByb21pc2UucmVqZWN0KGVycm9yKTsKICAgICAgICAgfSkudGhl bihmdW5jdGlvbiAoZGF0YSkgewogICAgICAgICAgICAgc2VsZi5fZGlkRmV0Y2hKU09OKHRydWUs IGRhdGEpOwotICAgICAgICAgICAgc2VsZi5fYWxsRmV0Y2hlc1tzZWxmLl9wcmltYXJ5Q2x1c3Rl ckVuZFRpbWVdID0gc2VsZi5fcHJpbWFyeUNsdXN0ZXJQcm9taXNlOwogICAgICAgICB9KTsKICAg ICB9CiAKSW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy91bml0LXRlc3RzL21lYXN1cmVt ZW50LXNldC10ZXN0cy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcv dW5pdC10ZXN0cy9tZWFzdXJlbWVudC1zZXQtdGVzdHMuanMJKHJldmlzaW9uIDIwMzYyMSkKKysr IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy91bml0LXRlc3RzL21lYXN1cmVtZW50LXNldC10ZXN0 cy5qcwkod29ya2luZyBjb3B5KQpAQCAtMzczLDcgKzM3Myw3IEBAIGRlc2NyaWJlKCdNZWFzdXJl bWVudFNldCcsIGZ1bmN0aW9uICgpIHsKIAogICAgICAgICAgICAgICAgIHJldHVybiB3YWl0Rm9y TWVhc3VyZW1lbnRTZXQoKTsKICAgICAgICAgICAgIH0pLnRoZW4oZnVuY3Rpb24gKCkgewotICAg ICAgICAgICAgICAgIGFzc2VydC5lcXVhbChjYWxsQ291bnQsIDIpOworICAgICAgICAgICAgICAg IGFzc2VydC5lcXVhbChjYWxsQ291bnQsIDMpOwogICAgICAgICAgICAgICAgIGFzc2VydC5lcXVh bChub0NhY2hlRmV0Y2hDb3VudCwgMik7CiAgICAgICAgICAgICAgICAgYXNzZXJ0LmVxdWFsKHNl dC5fc29ydGVkQ2x1c3RlcnMubGVuZ3RoLCAyKTsKICAgICAgICAgICAgICAgICBhc3NlcnQuZXF1 YWwocmVxdWVzdHMubGVuZ3RoLCA0KTsK