160104 2016-07-22 15:13:36 -0700 Media controls should be displayed for media in media documents 2016-07-22 17:48:35 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh commit-queue jeremyj-wk jer.noble oldest_to_newest 1213760 0 wenson_hsieh 2016-07-22 15:13:36 -0700 Media controls should be displayed for media in media documents 1213762 1 wenson_hsieh 2016-07-22 15:14:25 -0700 <rdar://problem/27438936> 1213769 2 284380 wenson_hsieh 2016-07-22 15:29:21 -0700 Created attachment 284380 Patch 1213802 3 284380 commit-queue 2016-07-22 17:48:32 -0700 Comment on attachment 284380 Patch Clearing flags on attachment: 284380 Committed r203629: <http://trac.webkit.org/changeset/203629> 1213803 4 commit-queue 2016-07-22 17:48:35 -0700 All reviewed patches have been landed. Closing bug. 284380 2016-07-22 15:29:21 -0700 2016-07-22 17:48:32 -0700 Patch bug-160104-20160722152819.patch text/plain 5098 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzNDczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2UwZmFkYTA0Y2I3Yjc1 ZmU2MTkwYmQ1ZTcyNGIyNTBkZTRiZGFkOC4uZDkwN2E0ZWI0ZmJiN2Q0ZWY4M2ZmOGZkMjE1OTQ4 MzNjZjQzZDQ1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTA3LTIyICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIE1lZGlhIGNvbnRy b2xzIHNob3VsZCBiZSBkaXNwbGF5ZWQgZm9yIG1lZGlhIGluIG1lZGlhIGRvY3VtZW50cworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwMTA0CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8yNzQzODkzNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHZpZGVvcyB0aGF0IHdvdWxkIG90aGVyd2lzZSBu b3QgaGF2ZSBiZWVuIGxhcmdlIGVub3VnaCBvciBoYXZlIHRoZSByaWdodAorICAgICAgICBhc3Bl Y3QgcmF0aW8gY2F1c2UgbWVkaWEgY29udHJvbHMgdG8gYXBwZWFyLiBUaGlzIGlzIGJlY2F1c2Ug bWVkaWEgZWxlbWVudHMgaW4KKyAgICAgICAgYSBtZWRpYSBkb2N1bWVudCBhcmUgaW1wbGllZCB0 byBiZSBtYWluIGNvbnRlbnQuCisKKyAgICAgICAgQWRkZWQgYSBuZXcgQVBJIHRlc3QuCisKKyAg ICAgICAgKiBodG1sL01lZGlhRWxlbWVudFNlc3Npb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6 TWVkaWFFbGVtZW50U2Vzc2lvbjo6Y2FuQ29udHJvbENvbnRyb2xzTWFuYWdlcik6CisKIDIwMTYt MDctMjAgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAg UGF1c2luZyBhdXRvcGxheWVkIG1lZGlhIHNob3VsZCBub3QgcmVtb3ZlIGFsbCByZXN0cmljdGlv bnMgZm9yIHRoYXQgbWVkaWEgZWxlbWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRt bC9NZWRpYUVsZW1lbnRTZXNzaW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvTWVkaWFFbGVt ZW50U2Vzc2lvbi5jcHAKaW5kZXggODMyYWI2ZDk5MDYwYTA4M2U2N2ZmMWRkOGM1MjUyZmRmODVj M2Q5YS4uZmExZGUzMWUwNmM5MmE3NTY1ZTQ4NmI3ZTc2YjYyOTlkNmIzOTNmYyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaHRtbC9NZWRpYUVsZW1lbnRTZXNzaW9uLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL01lZGlhRWxlbWVudFNlc3Npb24uY3BwCkBAIC0yNTQsNiArMjU0LDEx IEBAIGJvb2wgTWVkaWFFbGVtZW50U2Vzc2lvbjo6Y2FuQ29udHJvbENvbnRyb2xzTWFuYWdlcigp IGNvbnN0CiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgIH0KIAorICAgICAgICBp ZiAobV9lbGVtZW50LmRvY3VtZW50KCkuaXNNZWRpYURvY3VtZW50KCkpIHsKKyAgICAgICAgICAg IExPRyhNZWRpYSwgIk1lZGlhRWxlbWVudFNlc3Npb246OmNhbkNvbnRyb2xDb250cm9sc01hbmFn ZXIgLSByZXR1cm5pbmcgVFJVRTogSXMgbWVkaWEgZG9jdW1lbnQiKTsKKyAgICAgICAgICAgIHJl dHVybiB0cnVlOworICAgICAgICB9CisKICAgICAgICAgaWYgKCFtX2VsZW1lbnQuaGFzVmlkZW8o KSkgewogICAgICAgICAgICAgTE9HKE1lZGlhLCAiTWVkaWFFbGVtZW50U2Vzc2lvbjo6Y2FuQ29u dHJvbENvbnRyb2xzTWFuYWdlciAtIHJldHVybmluZyBGQUxTRTogTm8gdmlkZW8iKTsKICAgICAg ICAgICAgIHJldHVybiBmYWxzZTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xz L0NoYW5nZUxvZwppbmRleCAzNzJjMDhkNWIwY2U2ZDQ3ZDNlMGU5NmQzMGJlNDM1ZmUxNDEzZjJm Li45OGQ1YWQyOTVlYzFiZTdmNWRiM2Q1MmE0ZWU0MTQ2ZTA5YjkwYWRkIDEwMDY0NAotLS0gYS9U b29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIw MTYtMDctMjIgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAg ICAgTWVkaWEgY29udHJvbHMgc2hvdWxkIGJlIGRpc3BsYXllZCBmb3IgbWVkaWEgaW4gbWVkaWEg ZG9jdW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNjAxMDQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI3NDM4OTM2PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFZlcmlmaWVzIHRoYXQgZXZlbiBh IHNtYWxsIHZpZGVvIHdpdGggYXVkaW8gaW4gYSBtZWRpYSBkb2N1bWVudCBnZXRzIG1lZGlhIGNv bnRyb2xzLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvVmlk ZW9Db250cm9sc01hbmFnZXIubW06CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToKKwog MjAxNi0wNy0yMCAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAg ICAgICBVbnJldmlld2VkIGlPUyBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL1dlYktpdDJDb2NvYS9WaWRlb0NvbnRyb2xzTWFuYWdlci5tbSBiL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL1ZpZGVvQ29udHJvbHNNYW5hZ2VyLm1t CmluZGV4IGZiZWZlYmFlYzFmZWIxNjhhZDcyNWMwMzFhZmIyNGI0NjI5ZWNhZGYuLmFhOTc5MTk0 N2IwN2IyNTZlMjYzNzQ2NDZhNmUwN2I1ODU1MDQyYmIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RX ZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL1ZpZGVvQ29udHJvbHNNYW5hZ2VyLm1tCisrKyBi L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL1ZpZGVvQ29udHJvbHNNYW5h Z2VyLm1tCkBAIC0yMzUsNiArMjM1LDM2IEBAIFRFU1QoVmlkZW9Db250cm9sc01hbmFnZXIsIFZp ZGVvQ29udHJvbHNNYW5hZ2VyQXVkaW9FbGVtZW50U3RhcnRlZFdpdGhTY3JpcHQpCiAgICAgVGVz dFdlYktpdEFQSTo6VXRpbDo6cnVuKCZyZWNlaXZlZFNjcmlwdE1lc3NhZ2UpOwogfQogCitURVNU KFZpZGVvQ29udHJvbHNNYW5hZ2VyLCBWaWRlb0NvbnRyb2xzTWFuYWdlclNtYWxsVmlkZW9Jbk1l ZGlhRG9jdW1lbnQpCit7CisgICAgUmV0YWluUHRyPFdLV2ViVmlld0NvbmZpZ3VyYXRpb24+IGNv bmZpZ3VyYXRpb24gPSBhZG9wdE5TKFtbV0tXZWJWaWV3Q29uZmlndXJhdGlvbiBhbGxvY10gaW5p dF0pOworICAgIGNvbmZpZ3VyYXRpb24uZ2V0KCkubWVkaWFUeXBlc1JlcXVpcmluZ1VzZXJBY3Rp b25Gb3JQbGF5YmFjayA9IFdLQXVkaW92aXN1YWxNZWRpYVR5cGVOb25lOworICAgIFJldGFpblB0 cjxXS1dlYlZpZXc+IHdlYlZpZXcgPSBhZG9wdE5TKFtbV0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0 aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwgMTAwLCAxMDApIGNvbmZpZ3VyYXRpb246Y29uZmlndXJh dGlvbi5nZXQoKV0pOworICAgIAorICAgIFJldGFpblB0cjxOU1dpbmRvdz4gd2luZG93ID0gYWRv cHROUyhbW05TV2luZG93IGFsbG9jXSBpbml0V2l0aENvbnRlbnRSZWN0Olt3ZWJWaWV3IGZyYW1l XSBzdHlsZU1hc2s6TlNCb3JkZXJsZXNzV2luZG93TWFzayBiYWNraW5nOk5TQmFja2luZ1N0b3Jl QnVmZmVyZWQgZGVmZXI6Tk9dKTsKKyAgICBbW3dpbmRvdyBjb250ZW50Vmlld10gYWRkU3Vidmll dzp3ZWJWaWV3LmdldCgpXTsKKyAgICAKKyAgICBfX2Jsb2NrIGJvb2wgZmluaXNoZWRMb2FkID0g ZmFsc2U7CisgICAgZGlzcGF0Y2hfYmxvY2tfdCBoYW5kbGVGaW5pc2hlZExvYWQgPSBeKCkKKyAg ICB7CisgICAgICAgIGZpbmlzaGVkTG9hZCA9IHRydWU7CisgICAgfTsKKyAgICBPbkxvYWRNZXNz YWdlSGFuZGxlciAqaGFuZGxlciA9IFtbT25Mb2FkTWVzc2FnZUhhbmRsZXIgYWxsb2NdIGluaXRX aXRoV0tXZWJWaWV3OndlYlZpZXcuZ2V0KCkgaGFuZGxlcjpoYW5kbGVGaW5pc2hlZExvYWRdOwor ICAgIAorICAgIE5TU3RyaW5nICpvbmxvYWRTY3JpcHQgPSBAIndpbmRvdy5vbmxvYWQgPSBmdW5j dGlvbigpIHsgd2luZG93LndlYmtpdC5tZXNzYWdlSGFuZGxlcnMub25sb2FkSGFuZGxlci5wb3N0 TWVzc2FnZSgnbG9hZGVkJyk7IH0iOworICAgIFdLVXNlclNjcmlwdCAqc2NyaXB0ID0gW1tXS1Vz ZXJTY3JpcHQgYWxsb2NdIGluaXRXaXRoU291cmNlOm9ubG9hZFNjcmlwdCBpbmplY3Rpb25UaW1l OldLVXNlclNjcmlwdEluamVjdGlvblRpbWVBdERvY3VtZW50U3RhcnQgZm9yTWFpbkZyYW1lT25s eTpOT107CisgICAgW1tjb25maWd1cmF0aW9uIHVzZXJDb250ZW50Q29udHJvbGxlcl0gYWRkVXNl clNjcmlwdDpzY3JpcHRdOworICAgIFtbY29uZmlndXJhdGlvbiB1c2VyQ29udGVudENvbnRyb2xs ZXJdIGFkZFNjcmlwdE1lc3NhZ2VIYW5kbGVyOmhhbmRsZXIgbmFtZTpAIm9ubG9hZEhhbmRsZXIi XTsKKyAgICAKKyAgICBOU1VSTCAqdXJsT2ZWaWRlbyA9IFtbTlNCdW5kbGUgbWFpbkJ1bmRsZV0g VVJMRm9yUmVzb3VyY2U6QCJ2aWRlby13aXRoLWF1ZGlvIiB3aXRoRXh0ZW5zaW9uOkAibXA0IiBz dWJkaXJlY3Rvcnk6QCJUZXN0V2ViS2l0QVBJLnJlc291cmNlcyJdOworICAgIFt3ZWJWaWV3IGxv YWRGaWxlVVJMOnVybE9mVmlkZW8gYWxsb3dpbmdSZWFkQWNjZXNzVG9VUkw6W3VybE9mVmlkZW8g VVJMQnlEZWxldGluZ0xhc3RQYXRoQ29tcG9uZW50XV07CisgICAgCisgICAgVGVzdFdlYktpdEFQ STo6VXRpbDo6cnVuKCZmaW5pc2hlZExvYWQpOworICAgIAorICAgIC8vIFdlIGV4cGVjdCB0aGUg bWVkaWEgY29udHJvbGxlciB0byBiZSBwcmVzZW50IGJlY2F1c2UgdGhpcyBpcyBhIG1lZGlhIGRv Y3VtZW50LgorICAgIEVYUEVDVF9UUlVFKFt3ZWJWaWV3IF9oYXNBY3RpdmVWaWRlb0ZvckNvbnRy b2xzTWFuYWdlcl0pOworfQorCiB9IC8vIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJCiAKICNlbmRp ZiAvLyBXS19BUElfRU5BQkxFRCAmJiBQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lP Tl9NSU5fUkVRVUlSRUQgPj0gMTAxMjAwCg==