160100 2016-07-22 14:23:17 -0700 REGRESSION(203616): no FTL testing was inadvertently removed 2016-07-22 16:18:13 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 160033 1 msaboff msaboff oldest_to_newest 1213740 0 msaboff 2016-07-22 14:23:17 -0700 The runXXNoFTL tests should not have been removed in change set <http://trac.webkit.org/changeset/203616>. 1213744 1 284373 msaboff 2016-07-22 14:35:41 -0700 Created attachment 284373 Patch for Landing 1213750 2 284373 mark.lam 2016-07-22 14:57:16 -0700 Comment on attachment 284373 Patch for Landing View in context: https://bugs.webkit.org/attachment.cgi?id=284373&action=review > Tools/Scripts/run-jsc-stress-tests:942 > + runNoFTL if $isFTLPlatform > runFTLNoCJITValidate if $isFTLPlatform Since you have more than 1 thing to run if $isFTLPlatform, why not apply the same idiom of returning early if !$isFTLPlatform as is done in other run configurations? > Tools/Scripts/run-jsc-stress-tests:1201 > + runLayoutTestNoFTL Do we already disable the FTL by default? If not, you should explicitly disable the FTL in the definition of runLayoutTestNoFTL. > Tools/Scripts/run-jsc-stress-tests:1205 > + noFTLRunLayoutTest Is noFTLRunLayoutTest different than runLayoutTestNoFTL? If they are the same, we should get rid of one. If they are different, don't we want to run runLayoutTestNoFTL as well if $isFTLPlatform (because we want that coverage)? > Tools/Scripts/run-jsc-stress-tests:1364 > + runNoisyTest("no-ftl") Ditto. Is the FTL already disabled by default? If not, we should explicitly disable it. 1213759 3 msaboff 2016-07-22 15:10:58 -0700 (In reply to comment #2) > Comment on attachment 284373 [details] > Patch for Landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=284373&action=review > > > Tools/Scripts/run-jsc-stress-tests:942 > > + runNoFTL if $isFTLPlatform > > runFTLNoCJITValidate if $isFTLPlatform > > Since you have more than 1 thing to run if $isFTLPlatform, why not apply the > same idiom of returning early if !$isFTLPlatform as is done in other run > configurations? Done. > > Tools/Scripts/run-jsc-stress-tests:1201 > > + runLayoutTestNoFTL > > Do we already disable the FTL by default? If not, you should explicitly > disable the FTL in the definition of runLayoutTestNoFTL. FTL is disabled by default. > > Tools/Scripts/run-jsc-stress-tests:1205 > > + noFTLRunLayoutTest > > Is noFTLRunLayoutTest different than runLayoutTestNoFTL? If they are the > same, we should get rid of one. If they are different, don't we want to run > runLayoutTestNoFTL as well if $isFTLPlatform (because we want that coverage)? They are different. noFTLRunLayoutTest is the DFG only equivalent of the three test variants we run if FTL is enabled. Since this is a "quick" test only one flavor is needed. > > Tools/Scripts/run-jsc-stress-tests:1364 > > + runNoisyTest("no-ftl") > > Ditto. Is the FTL already disabled by default? If not, we should > explicitly disable it. See above. 1213785 4 msaboff 2016-07-22 16:18:13 -0700 Committed r203625: <http://trac.webkit.org/changeset/203625> 284373 2016-07-22 14:35:41 -0700 2016-07-22 14:35:41 -0700 Patch for Landing 160100.patch text/plain 4471 msaboff SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwMzYxNikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE2LTA3LTIyICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04oMjAzNjE2KTogbm8gRlRMIHRlc3Rpbmcgd2FzIGluYWR2 ZXJ0ZW50bHkgcmVtb3ZlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTYwMTAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWRkZWQgcnVuTm9GVEwgYmFjayBpbnRvIHRoZSBzZXQgb2YgdGVzdHMgd2UgcnVu IG9uIEZUTCBlbmFibGVkIHBsYXRmb3Jtcy4KKyAgICAgICAgUmVuYW1lZCBydW5MYXlvdXRUZXN0 Tm9GVEwgdG8gcnVuTGF5b3V0VGVzdERlZmF1bHQuICBSZXN0cnVjdHVyZWQgdGhlIHRlc3QKKyAg ICAgICAgbG9naWMgZm9yIHRoZSBydW5MYXlvdXQgYW5kIHJ1bk5vaXN5IHZhcmlhbnRzIHRvIG1h dGNoIHRoZSBydW4gdGVzdCBsb2dpYywKKyAgICAgICAgdGhhdCBpcyB3ZSBhbHdheXMgaW52b2tl IHJ1blhYWERlZmF1bHQgYW5kIGludm9rZSBydW5YWFhOb0ZUTCBmb3IgRlRMCisgICAgICAgIGVu YWJsZWQgcGxhdGZvcm1zLgorCisgICAgICAgICogU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0 czoKKwogMjAxNi0wNy0yMiAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAog ICAgICAgICBEb24ndCBydW4gRlRMIHJlbGF0ZWQgSlNDIHN0cmVzcyB0ZXN0cyBvbiBub24tRlRM IHBsYXRmb3JtcwpJbmRleDogVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCShyZXZpc2lvbiAy MDM2MTYpCisrKyBUb29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCSh3b3JraW5nIGNv cHkpCkBAIC04OTgsNiArODk4LDcgQEAgZGVmIGRlZmF1bHRSdW4KIAogICAgICAgICAgICAgcmV0 dXJuIGlmICEkaXNGVExQbGF0Zm9ybQogCisgICAgICAgICAgICBydW5Ob0ZUTAogICAgICAgICAg ICAgcnVuRlRMTm9DSklUVmFsaWRhdGUKICAgICAgICAgICAgIHJ1bkZUTE5vQ0pJVE5vUHV0U3Rh Y2tWYWxpZGF0ZQogICAgICAgICAgICAgcnVuRlRMTm9DSklUTm9JbmxpbmVWYWxpZGF0ZQpAQCAt OTIyLDYgKzkyMyw3IEBAIGRlZiBkZWZhdWx0Tm9Ob0xMSW50UnVuCiAKICAgICAgICAgICAgIHJl dHVybiBpZiAhJGlzRlRMUGxhdGZvcm0KIAorICAgICAgICAgICAgcnVuTm9GVEwKICAgICAgICAg ICAgIHJ1bkZUTE5vQ0pJVFZhbGlkYXRlCiAgICAgICAgICAgICBydW5GVExOb0NKSVROb1B1dFN0 YWNrVmFsaWRhdGUKICAgICAgICAgICAgIHJ1bkZUTE5vQ0pJVE5vSW5saW5lVmFsaWRhdGUKQEAg LTkzNiw2ICs5MzgsNyBAQCBkZWYgZGVmYXVsdFF1aWNrUnVuCiAgICAgcnVuRGVmYXVsdAogICAg IGlmICRqaXRUZXN0cwogICAgICAgICBydW5Ob0NKSVRWYWxpZGF0ZQorICAgICAgICBydW5Ob0ZU TCBpZiAkaXNGVExQbGF0Zm9ybQogICAgICAgICBydW5GVExOb0NKSVRWYWxpZGF0ZSBpZiAkaXNG VExQbGF0Zm9ybQogICAgIGVuZAogZW5kCkBAIC05NjcsNiArOTcwLDcgQEAgZGVmIGRlZmF1bHRO b0VhZ2VyUnVuCiAKICAgICAgICAgcmV0dXJuIGlmICEkaXNGVExQbGF0Zm9ybQogCisgICAgICAg IHJ1bk5vRlRMCiAgICAgICAgIHJ1bkZUTE5vQ0pJVFZhbGlkYXRlCiAgICAgICAgIHJ1bkZUTE5v Q0pJVE5vSW5saW5lVmFsaWRhdGUKICAgICBlbmQKQEAgLTk4NCw2ICs5ODgsNyBAQCBkZWYgZGVm YXVsdE5vU2FtcGxpbmdQcm9maWxlclJ1bgogCiAgICAgICAgIHJldHVybiBpZiAhJGlzRlRMUGxh dGZvcm0KIAorICAgICAgICBydW5Ob0ZUTAogICAgICAgICBydW5GVExOb0NKSVROb1B1dFN0YWNr VmFsaWRhdGUKICAgICAgICAgcnVuRlRMTm9DSklUTm9JbmxpbmVWYWxpZGF0ZQogICAgICAgICBy dW5GVExFYWdlcgpAQCAtMTE2Nyw3ICsxMTcyLDcgQEAgZGVmIHJ1bkxheW91dFRlc3RERkdFYWdl ck5vQ0pJVAogICAgIHJ1bkxheW91dFRlc3QoImRmZy1lYWdlci1uby1jaml0IiwgKihOT19DSklU X09QVElPTlMgKyBFQUdFUl9PUFRJT05TKSkKIGVuZAogCi1kZWYgcnVuTGF5b3V0VGVzdEZUTAor ZGVmIHJ1bkxheW91dFRlc3REZWZhdWx0CiAgICAgcnVuTGF5b3V0VGVzdChuaWwsICItLXRlc3RU aGVGVEw9dHJ1ZSIsICpGVExfT1BUSU9OUykKIGVuZAogCkBAIC0xMTkwLDEwICsxMTk1LDE1IEBA IGRlZiBub0ZUTFJ1bkxheW91dFRlc3QKIGVuZAogCiBkZWYgZGVmYXVsdFF1aWNrUnVuTGF5b3V0 VGVzdAotICAgIHJ1bkxheW91dFRlc3ROb0ZUTAorICAgIHJ1bkxheW91dFRlc3REZWZhdWx0CiAg ICAgaWYgJGppdFRlc3RzCi0gICAgICAgIHJ1bkxheW91dFRlc3RGVExOb0NKSVQKLSAgICAgICAg cnVuTGF5b3V0VGVzdEZUTEVhZ2VyTm9DSklUCisgICAgICAgIGlmICRpc0ZUTFBsYXRmb3JtCisg ICAgICAgICAgICBydW5MYXlvdXRUZXN0Tm9GVEwKKyAgICAgICAgICAgIHJ1bkxheW91dFRlc3RG VExOb0NKSVQKKyAgICAgICAgICAgIHJ1bkxheW91dFRlc3RGVExFYWdlck5vQ0pJVAorICAgICAg ICBlbHNlCisgICAgICAgICAgICBub0ZUTFJ1bkxheW91dFRlc3QKKyAgICAgICAgZW5kCiAgICAg ZW5kCiBlbmQKIApAQCAtMTIwMSwxMyArMTIxMSwxMyBAQCBkZWYgZGVmYXVsdFJ1bkxheW91dFRl c3QKICAgICBpZiAkcXVpY2tNb2RlCiAgICAgICAgIGRlZmF1bHRRdWlja1J1bkxheW91dFRlc3QK ICAgICBlbHNlCi0gICAgICAgIHJ1bkxheW91dFRlc3ROb0ZUTAorICAgICAgICBydW5MYXlvdXRU ZXN0RGVmYXVsdAogICAgICAgICBpZiAkaml0VGVzdHMKICAgICAgICAgICAgIG5vRlRMUnVuTGF5 b3V0VGVzdAogCiAgICAgICAgICAgICByZXR1cm4gaWYgISRpc0ZUTFBsYXRmb3JtCiAKLSAgICAg ICAgICAgIHJ1bkxheW91dFRlc3RGVEwKKyAgICAgICAgICAgIHJ1bkxheW91dFRlc3ROb0ZUTAog ICAgICAgICAgICAgcnVuTGF5b3V0VGVzdEZUTE5vQ0pJVAogICAgICAgICAgICAgcnVuTGF5b3V0 VGVzdEZUTEVhZ2VyTm9DSklUCiAgICAgICAgIGVuZApAQCAtMTIxNSwyNiArMTIyNSwyNiBAQCBk ZWYgZGVmYXVsdFJ1bkxheW91dFRlc3QKIGVuZAogCiBkZWYgbm9FYWdlck5vTm9MTEludFRlc3Rz UnVuTGF5b3V0VGVzdAotICAgIHJ1bkxheW91dFRlc3ROb0ZUTAorICAgIHJ1bkxheW91dFRlc3RE ZWZhdWx0CiAgICAgaWYgJGppdFRlc3RzCiAgICAgICAgIHJ1bkxheW91dFRlc3ROb0NKSVQKIAog ICAgICAgICByZXR1cm4gaWYgISRpc0ZUTFBsYXRmb3JtCiAKLSAgICAgICAgcnVuTGF5b3V0VGVz dEZUTAorICAgICAgICBydW5MYXlvdXRUZXN0Tm9GVEwKICAgICAgICAgcnVuTGF5b3V0VGVzdEZU TE5vQ0pJVAogICAgIGVuZAogZW5kCiAKIGRlZiBub05vTExJbnRSdW5MYXlvdXRUZXN0Ci0gICAg cnVuTGF5b3V0VGVzdE5vRlRMCisgICAgcnVuTGF5b3V0VGVzdERlZmF1bHQKICAgICBpZiAkaml0 VGVzdHMKICAgICAgICAgcnVuTGF5b3V0VGVzdE5vQ0pJVAogICAgICAgICBydW5MYXlvdXRUZXN0 REZHRWFnZXJOb0NKSVQKIAogICAgICAgICByZXR1cm4gaWYgISRpc0ZUTFBsYXRmb3JtCiAKLSAg ICAgICAgcnVuTGF5b3V0VGVzdEZUTAorICAgICAgICBydW5MYXlvdXRUZXN0Tm9GVEwKICAgICAg ICAgcnVuTGF5b3V0VGVzdEZUTE5vQ0pJVAogICAgICAgICBydW5MYXlvdXRUZXN0RlRMRWFnZXJO b0NKSVQKICAgICBlbmQKQEAgLTEzNTAsNiArMTM2MCwxMCBAQCBkZWYgcnVuTm9pc3lUZXN0RGVm YXVsdAogICAgIHJ1bk5vaXN5VGVzdCgiZGVmYXVsdCIsICpGVExfT1BUSU9OUykKIGVuZAogCitk ZWYgcnVuTm9pc3lUZXN0Tm9GVEwKKyAgICBydW5Ob2lzeVRlc3QoIm5vLWZ0bCIpCitlbmQKKwog ZGVmIHJ1bk5vaXN5VGVzdE5vQ0pJVAogICAgIHJ1bk5vaXN5VGVzdCgiZnRsLW5vLWNqaXQiLCAi LS12YWxpZGF0ZUJ5dGVjb2RlPXRydWUiLCAiLS12YWxpZGF0ZUdyYXBoQXRFYWNoUGhhc2U9dHJ1 ZSIsICooRlRMX09QVElPTlMgKyBOT19DSklUX09QVElPTlMpKQogZW5kCkBAIC0xMzYxLDYgKzEz NzUsNyBAQCBlbmQKIGRlZiBkZWZhdWx0UnVuTm9pc3lUZXN0CiAgICAgcnVuTm9pc3lUZXN0RGVm YXVsdAogICAgIGlmICRqaXRUZXN0cyBhbmQgJGlzRlRMUGxhdGZvcm0KKyAgICAgICAgcnVuTm9p c3lUZXN0Tm9GVEwKICAgICAgICAgcnVuTm9pc3lUZXN0Tm9DSklUCiAgICAgICAgIHJ1bk5vaXN5 VGVzdEVhZ2VyTm9DSklUCiAgICAgZW5kCg==