160093 2016-07-22 12:40:05 -0700 Web Inspector: Hiding a column which contains a TimelineRuler as the headerview, doesn't hide the headerView 2016-07-28 14:53:09 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 jj mattbaker bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1213691 0 jj 2016-07-22 12:40:05 -0700 Summary: Hiding a column (in a DataGrid) which contains a TimelineRuler as the headerview, doesn't hide the TimelineRuler when the column gets hidden. (This is the case for the patch in 160061) 1213692 1 webkit-bug-importer 2016-07-22 12:40:18 -0700 <rdar://problem/27499300> 1213695 2 mattbaker 2016-07-22 12:48:14 -0700 This doesn't affect any grids yet, but will become an issue once the Network waterfall column exists. The bug can still be reproduced, by making a small change to OverviewTimelineView: 1. Add the following to OverviewTimelineView's constructor: this._dataGrid.columnChooserEnabled = true; 2. Right click the grid header 3. Uncheck the "undefined" column => Graph column is hidden but ruler is still visible 1213698 3 284363 mattbaker 2016-07-22 12:56:04 -0700 Created attachment 284363 [Patch] Proposed Fix 1215373 4 284363 joepeck 2016-07-28 13:46:44 -0700 Comment on attachment 284363 [Patch] Proposed Fix r=me 1215403 5 284363 commit-queue 2016-07-28 14:53:05 -0700 Comment on attachment 284363 [Patch] Proposed Fix Clearing flags on attachment: 284363 Committed r203844: <http://trac.webkit.org/changeset/203844> 1215404 6 commit-queue 2016-07-28 14:53:09 -0700 All reviewed patches have been landed. Closing bug. 284363 2016-07-22 12:56:04 -0700 2016-07-28 14:53:05 -0700 [Patch] Proposed Fix bug-160093-20160722125502.patch text/plain 1831 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzNjA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA1 Mjk3YmM2YWUxODNlMWFjNWY1MDliMTJjODdjNGZiYTI0MzYwNjVhLi5jZDJkYmI4M2MxOTI3ODRl MjhmN2JjMDA1ZTA5MTFjZjMzNzM0ZGUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNi0wNy0yMiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogSGlkaW5nIGEgY29sdW1uIHdoaWNoIGNvbnRhaW5z IGEgVGltZWxpbmVSdWxlciBhcyB0aGUgaGVhZGVydmlldywgZG9lc24ndCBoaWRlIHRoZSBoZWFk ZXJWaWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NjAwOTMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI3NDk5MzAwPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9E YXRhR3JpZC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5EYXRhR3JpZC5wcm90b3R5cGUuX3Bv c2l0aW9uSGVhZGVyVmlld3MpOgorICAgICAgICBSZW1vdmUgZWFybHkgcmV0dXJuIHNvIHRoYXQg YSBoZWFkZXIgdmlldyBpbiBhIGhpZGRlbiBjb2x1bW4gd2lsbCBoYXZlCisgICAgICAgIGl0cyB3 aWR0aCByZXNpemVkIHRvIHplcm8sIG1hdGNoaW5nIHRoZSBjb2x1bW4uCisKIDIwMTYtMDctMjAg IEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5z cGVjdG9yOiBQYXVzaW5nIHdoZW4gRGVidWdnZXIgdGFiIGlzIGNsb3NlZCBvcGVucyB0YWIgaW4g d3Jvbmcgc3RhdGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL0RhdGFHcmlkLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvRGF0YUdyaWQuanMKaW5kZXggZTRlZjdiZjE1M2I4YTE4NGUwNzZhYWZjMzdkZGZl ZDYzMDJiYzg3Zi4uMDIwMWNjMjhhNGU0ODk3ZTkzMjg1NTY5ZjcxZDhiOGNmN2RkM2I5OCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdy aWQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0 YUdyaWQuanMKQEAgLTk4NCwxNyArOTg0LDYgQEAgV2ViSW5zcGVjdG9yLkRhdGFHcmlkID0gY2xh c3MgRGF0YUdyaWQgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuVmlldwogCiAgICAgX3Bvc2l0aW9uSGVh ZGVyVmlld3MoKQogICAgIHsKLSAgICAgICAgbGV0IHZpc2libGVIZWFkZXJWaWV3cyA9IGZhbHNl OwotICAgICAgICBmb3IgKGxldCBjb2x1bW4gb2YgdGhpcy5jb2x1bW5zLnZhbHVlcygpKSB7Ci0g ICAgICAgICAgICBpZiAoY29sdW1uWyJoZWFkZXJWaWV3Il0gJiYgIWNvbHVtblsiaGlkZGVuIl0p IHsKLSAgICAgICAgICAgICAgICB2aXNpYmxlSGVhZGVyVmlld3MgPSB0cnVlOwotICAgICAgICAg ICAgICAgIGJyZWFrOwotICAgICAgICAgICAgfQotICAgICAgICB9Ci0KLSAgICAgICAgaWYgKCF2 aXNpYmxlSGVhZGVyVmlld3MpCi0gICAgICAgICAgICByZXR1cm47Ci0KICAgICAgICAgbGV0IGxl ZnQgPSAwOwogICAgICAgICBsZXQgaGVhZGVyVmlld3MgPSBbXTsKICAgICAgICAgbGV0IGxlZnRz ID0gW107Cg==